71ce2bbd81881f19f797cfc8aec7e7ea2ea8347f: Bug 1571974: Simplify orientation handling in line decoration shaders. r=kvark
Jim Blandy <jimb@mozilla.com> - Fri, 24 Jan 2020 21:46:56 +0000 - rev 512413
Push 37087 by nbeleuzu@mozilla.com at Tue, 04 Feb 2020 04:04:16 +0000
Bug 1571974: Simplify orientation handling in line decoration shaders. r=kvark We want to use the same line decoration (dashed, dotted, wavy) shader code for both horizontal and vertical lines, so it makes sense for them to use a coordinate system that has been rotated (transposed, actually) so that .x always runs parallel to the line being decorated, and .y is always perpendicular. Before this patch, we passed the orientation enum as a vertex attribute, used a switch to swap coordinates in the vertex shader, and then swapped them again in the fragment shader. This patch trades the orientation for a f32 'axis select' vertex attribute, and uses `mix` to swap them in the vertex shader. Then no consideration is necessary in the fragment shader: the vLocalPos varying is already in the appropriate form. Since get_line_decoration_sizes is already thinking in terms of line-parallel coordinates, it might seem like a good idea for decoration jobs to simply use line-parallel coordinates throughout. However, this actually results in more swapping and opportunities for confusion: much of the CPU work is concerned with the rectangle the decoration's mask occupies in the texture cache, which is axis-aligned. Differential Revision: https://phabricator.services.mozilla.com/D60926
9f54a1daf2f205d25f8d1b12ec09ed29176f9f2d: Bug 1571974: Make prim_store::get_line_decoration_sizes return an oriented LayoutSize. r=kvark
Jim Blandy <jimb@mozilla.com> - Mon, 03 Feb 2020 09:31:22 +0000 - rev 512412
Push 37087 by nbeleuzu@mozilla.com at Tue, 04 Feb 2020 04:04:16 +0000
Bug 1571974: Make prim_store::get_line_decoration_sizes return an oriented LayoutSize. r=kvark Without this change, get_line_decoration_sizes returns an (inline_size, block_size) pair, where inline_size is parallel to the line being decorated, and block_size perpendicular. However, these values are generally used as the dimensions of an axis-aligned bounding box for the line, not as specific parameters to the rendering process, so it makes sense to arrange them into a LayoutSize value in this function, since it is already taking the orientation into account anyway. The caller, SceneBuilder::add_line, then doesn't need to swap the components, and the adjustment of the clipping rectangle to avoid partial dots looks a bit more natural: widths with widths, heights with heights. Differential Revision: https://phabricator.services.mozilla.com/D60925
bdc1fb2dfac2cb04d204fbcd0ae0695198d27644: Bug 1612326 - Update model keys pref used for v2 r=nanj
Scott <scott.downe@gmail.com> - Mon, 03 Feb 2020 20:15:22 +0000 - rev 512411
Push 37087 by nbeleuzu@mozilla.com at Tue, 04 Feb 2020 04:04:16 +0000
Bug 1612326 - Update model keys pref used for v2 r=nanj Differential Revision: https://phabricator.services.mozilla.com/D61308
659060314d6d9cf85b561c3342dd48c63fc4d625: Bug 1412856 part 6. Add more useful error messages for serviceworker exceptions. r=dom-workers-and-storage-reviewers,perry?
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 03 Feb 2020 20:09:15 +0000 - rev 512410
Push 37087 by nbeleuzu@mozilla.com at Tue, 04 Feb 2020 04:04:16 +0000
Bug 1412856 part 6. Add more useful error messages for serviceworker exceptions. r=dom-workers-and-storage-reviewers,perry? For some of these I had to take a guess due to lack of familiarity with this code, so careful review of the actual strings would be much appreciated. There's still a bunch of code in dom/serviceworkers that constructs a CopyableErrorResult from just an nsresult, but I don't understand that code well enough to write good error messages. Differential Revision: https://phabricator.services.mozilla.com/D61201
c9d48dee0b74a4fa3d480ebe223538abc4df22da: Bug 1412856 part 5. Remove use of NS_ERROR_DOM_TYPE_ERR from Clients.openWindow. r=dom-workers-and-storage-reviewers,perry?
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 30 Jan 2020 08:33:32 +0000 - rev 512409
Push 37087 by nbeleuzu@mozilla.com at Tue, 04 Feb 2020 04:04:16 +0000
Bug 1412856 part 5. Remove use of NS_ERROR_DOM_TYPE_ERR from Clients.openWindow. r=dom-workers-and-storage-reviewers,perry? Some of these error messages are not very informative; better ones would be appreciated. Differential Revision: https://phabricator.services.mozilla.com/D61200
8c749ce01fb97b8605ed17d5fd2f1de0a2ca99cc: Bug 1412856 part 4. Make SourcePromise have CopyableErrorResult as its rejection type. r=dom-workers-and-storage-reviewers,sg?
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 30 Jan 2020 08:54:55 +0000 - rev 512408
Push 37087 by nbeleuzu@mozilla.com at Tue, 04 Feb 2020 04:04:16 +0000
Bug 1412856 part 4. Make SourcePromise have CopyableErrorResult as its rejection type. r=dom-workers-and-storage-reviewers,sg? Differential Revision: https://phabricator.services.mozilla.com/D61199
1cac745bf19e2e7265788babead9fbfe425eb940: Bug 1412856 part 3. Test for the right exception code for TypeErrors. r=dom-workers-and-storage-reviewers,perry?
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 30 Jan 2020 08:09:58 +0000 - rev 512407
Push 37087 by nbeleuzu@mozilla.com at Tue, 04 Feb 2020 04:04:16 +0000
Bug 1412856 part 3. Test for the right exception code for TypeErrors. r=dom-workers-and-storage-reviewers,perry? I think the current code made us filter out all the carefully crafted TypeError messages we might have reported... Differential Revision: https://phabricator.services.mozilla.com/D61198
aafd7c5a9d478ff0e994492fc5935413ba36f52f: Bug 1412856 part 2. Stop using NS_ERROR_DOM_TYPE_ERR in Client::Navigate. r=dom-workers-and-storage-reviewers,perry?
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 30 Jan 2020 08:09:38 +0000 - rev 512406
Push 37087 by nbeleuzu@mozilla.com at Tue, 04 Feb 2020 04:04:16 +0000
Bug 1412856 part 2. Stop using NS_ERROR_DOM_TYPE_ERR in Client::Navigate. r=dom-workers-and-storage-reviewers,perry? Differential Revision: https://phabricator.services.mozilla.com/D61197
0a3bf632a719c224b8cb03063bc763c53143da10: Bug 1412856 part 1. Change ClientOpPromise to use a CopyableErrorResult for its rejection type. r=dom-workers-and-storage-reviewers,sg?
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 30 Jan 2020 09:01:26 +0000 - rev 512405
Push 37087 by nbeleuzu@mozilla.com at Tue, 04 Feb 2020 04:04:16 +0000
Bug 1412856 part 1. Change ClientOpPromise to use a CopyableErrorResult for its rejection type. r=dom-workers-and-storage-reviewers,sg? Differential Revision: https://phabricator.services.mozilla.com/D61196
801277ae423f6f5183d62c45cda342ea28ee6040: Backed out 2 changesets (bug 1571974) for turning bug 1518179 into perma bc failures. on a CLOSED TREE
Oana Pop Rus <opoprus@mozilla.com> - Mon, 03 Feb 2020 22:00:29 +0200 - rev 512404
Push 37087 by nbeleuzu@mozilla.com at Tue, 04 Feb 2020 04:04:16 +0000
Backed out 2 changesets (bug 1571974) for turning bug 1518179 into perma bc failures. on a CLOSED TREE Backed out changeset dfb21632ea19 (bug 1571974) Backed out changeset 3549dd471446 (bug 1571974)
76ba712aa17975a92753b75c0d2ac3928aede74b: Bug 1610810 - FTP download prompt appears while authentication dialog is displayed, r=valentin
Michal Novotny <michal.novotny@gmail.com> - Mon, 03 Feb 2020 19:22:37 +0000 - rev 512403
Push 37087 by nbeleuzu@mozilla.com at Tue, 04 Feb 2020 04:04:16 +0000
Bug 1610810 - FTP download prompt appears while authentication dialog is displayed, r=valentin Set nsFtpChannel's content-type to application/octet-stream only when downloading a file. Differential Revision: https://phabricator.services.mozilla.com/D61494
74a6c4e121f08789fe53e8c9d9e1f8af226ec7d1: Bug 1611997 - Add WPT reftest for correct mapping between font-style:oblique and opentype 'slnt' axis. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Mon, 03 Feb 2020 19:14:18 +0000 - rev 512402
Push 37087 by nbeleuzu@mozilla.com at Tue, 04 Feb 2020 04:04:16 +0000
Bug 1611997 - Add WPT reftest for correct mapping between font-style:oblique and opentype 'slnt' axis. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D61229
719878745b59785ef8cacb3cd2994ef443b6fc10: Bug 1611997 - Invert the sign of the slant angle when mapping between CSS font-style and OpenType 'slnt' axis. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Fri, 31 Jan 2020 15:05:52 +0000 - rev 512401
Push 37087 by nbeleuzu@mozilla.com at Tue, 04 Feb 2020 04:04:16 +0000
Bug 1611997 - Invert the sign of the slant angle when mapping between CSS font-style and OpenType 'slnt' axis. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D61228
3e9ae70573011a8e393603157578a003f09e9c1d: Bug 1611588 - Handle null BrowsingContext in ExternalHelperAppParent. r=nika
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 03 Feb 2020 18:57:08 +0000 - rev 512400
Push 37087 by nbeleuzu@mozilla.com at Tue, 04 Feb 2020 04:04:16 +0000
Bug 1611588 - Handle null BrowsingContext in ExternalHelperAppParent. r=nika Differential Revision: https://phabricator.services.mozilla.com/D61309
cc1190f55c4665af33dc74ce2a23f4b1ef9a8ce5: Bug 1607769 - Remove script loader telemetry added by Bug 1579876 and Bug 1573904. r=jorendorff
Nicolas B. Pierron <nicolas.b.pierron@nbp.name> - Mon, 03 Feb 2020 18:55:44 +0000 - rev 512399
Push 37087 by nbeleuzu@mozilla.com at Tue, 04 Feb 2020 04:04:16 +0000
Bug 1607769 - Remove script loader telemetry added by Bug 1579876 and Bug 1573904. r=jorendorff Differential Revision: https://phabricator.services.mozilla.com/D60288
f5d0ed5f15d409551fba466e5a68e7568044e25c: Bug 1610702 - Generalize Vector::podResizeToFit into Vector::shrinkStorageToFit(). r=froydnj
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 03 Feb 2020 17:32:12 +0000 - rev 512398
Push 37087 by nbeleuzu@mozilla.com at Tue, 04 Feb 2020 04:04:16 +0000
Bug 1610702 - Generalize Vector::podResizeToFit into Vector::shrinkStorageToFit(). r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D61337
dfb21632ea198c1acdc6a34ee08113d516f666d5: Bug 1571974: Simplify orientation handling in line decoration shaders. r=kvark
Jim Blandy <jimb@mozilla.com> - Fri, 24 Jan 2020 21:46:56 +0000 - rev 512397
Push 37087 by nbeleuzu@mozilla.com at Tue, 04 Feb 2020 04:04:16 +0000
Bug 1571974: Simplify orientation handling in line decoration shaders. r=kvark We want to use the same line decoration (dashed, dotted, wavy) shader code for both horizontal and vertical lines, so it makes sense for them to use a coordinate system that has been rotated (transposed, actually) so that .x always runs parallel to the line being decorated, and .y is always perpendicular. Before this patch, we passed the orientation enum as a vertex attribute, used a switch to swap coordinates in the vertex shader, and then swapped them again in the fragment shader. This patch trades the orientation for a f32 'axis select' vertex attribute, and uses `mix` to swap them in the vertex shader. Then no consideration is necessary in the fragment shader: the vLocalPos varying is already in the appropriate form. Since get_line_decoration_sizes is already thinking in terms of line-parallel coordinates, it might seem like a good idea for decoration jobs to simply use line-parallel coordinates throughout. However, this actually results in more swapping and opportunities for confusion: much of the CPU work is concerned with the rectangle the decoration's mask occupies in the texture cache, which is axis-aligned. Differential Revision: https://phabricator.services.mozilla.com/D60926
3549dd471446c291864822736f4587c81741cd56: Bug 1571974: Make prim_store::get_line_decoration_sizes return an oriented LayoutSize. r=kvark
Jim Blandy <jimb@mozilla.com> - Mon, 03 Feb 2020 09:31:22 +0000 - rev 512396
Push 37087 by nbeleuzu@mozilla.com at Tue, 04 Feb 2020 04:04:16 +0000
Bug 1571974: Make prim_store::get_line_decoration_sizes return an oriented LayoutSize. r=kvark Without this change, get_line_decoration_sizes returns an (inline_size, block_size) pair, where inline_size is parallel to the line being decorated, and block_size perpendicular. However, these values are generally used as the dimensions of an axis-aligned bounding box for the line, not as specific parameters to the rendering process, so it makes sense to arrange them into a LayoutSize value in this function, since it is already taking the orientation into account anyway. The caller, SceneBuilder::add_line, then doesn't need to swap the components, and the adjustment of the clipping rectangle to avoid partial dots looks a bit more natural: widths with widths, heights with heights. Differential Revision: https://phabricator.services.mozilla.com/D60925
9f8766e42efea809351839114d64085d7518adf9: Bug 1612909 - Import WebCompat GoFaster 7.0.0 sources; r=miketaylr
Ksenia Berezina <kberezina@mozilla.com> - Mon, 03 Feb 2020 18:01:37 +0000 - rev 512395
Push 37086 by nbeleuzu@mozilla.com at Mon, 03 Feb 2020 21:47:17 +0000
Bug 1612909 - Import WebCompat GoFaster 7.0.0 sources; r=miketaylr Differential Revision: https://phabricator.services.mozilla.com/D61482
0ba32b2a39656edc9fc63b5a66b7f9b861d28302: Bug 1606918 - Port the Update Intervention from the experiment, part 2: Tests. r=harry
Drew Willcoxon <adw@mozilla.com> - Mon, 03 Feb 2020 12:46:22 +0000 - rev 512394
Push 37086 by nbeleuzu@mozilla.com at Mon, 03 Feb 2020 21:47:17 +0000
Bug 1606918 - Port the Update Intervention from the experiment, part 2: Tests. r=harry Differential Revision: https://phabricator.services.mozilla.com/D60786
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip