6fb2488117b99af2ac8a7073d7fca6e005a3c01d: Bug 1681441 - Update valgrind package to Debian's 3.16.1. r=firefox-build-system-reviewers,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Wed, 09 Dec 2020 15:50:05 +0000 - rev 560124
Push 38019 by apavel@mozilla.com at Thu, 10 Dec 2020 15:59:12 +0000
Bug 1681441 - Update valgrind package to Debian's 3.16.1. r=firefox-build-system-reviewers,mhentges Differential Revision: https://phabricator.services.mozilla.com/D99182
737dfc84e95f28725c0211ba68db231b39ac9751: Bug 1681510: Remove unused argument aPrincipal from CopyFavicon() in Pcontent.ipdl r=nika
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Thu, 10 Dec 2020 05:53:17 +0000 - rev 560123
Push 38019 by apavel@mozilla.com at Thu, 10 Dec 2020 15:59:12 +0000
Bug 1681510: Remove unused argument aPrincipal from CopyFavicon() in Pcontent.ipdl r=nika Differential Revision: https://phabricator.services.mozilla.com/D99226
73f050da7d204fcfb59aa2528f3d22665bc043d3: Bug 1681242 - Remove obsolete CGEvent workaround needed for macOS versions < 10.10.2. r=haik,spohl
Chris Peterson <cpeterson@mozilla.com> - Wed, 09 Dec 2020 19:31:23 +0000 - rev 560122
Push 38018 by abutkovits@mozilla.com at Thu, 10 Dec 2020 09:28:00 +0000
Bug 1681242 - Remove obsolete CGEvent workaround needed for macOS versions < 10.10.2. r=haik,spohl This workaround is no longer needed because Firefox >= 79 requires macOS >= 10.12. Differential Revision: https://phabricator.services.mozilla.com/D99019
3d35212af4238764015398e979add3b637e29c36: Bug 1676388 - Part 3: Disable print setting inputs while loading printer settings r=sfoster
Mark Striemer <mstriemer@mozilla.com> - Thu, 10 Dec 2020 04:34:42 +0000 - rev 560121
Push 38018 by abutkovits@mozilla.com at Thu, 10 Dec 2020 09:28:00 +0000
Bug 1676388 - Part 3: Disable print setting inputs while loading printer settings r=sfoster When loading a printer's settings it can take a few seconds for physical printers. If this happens then changes made while the settings are being fetched could be thrown away. Disable the form while we're loading settings for a printer to avoid losing settings changes. Differential Revision: https://phabricator.services.mozilla.com/D99156
66c31bb28425c50e5fd6d289c493c94ecf288440: Bug 1676388 - Part 2: Only listen to input events in print dialog r=sfoster
Mark Striemer <mstriemer@mozilla.com> - Thu, 10 Dec 2020 04:34:39 +0000 - rev 560120
Push 38018 by abutkovits@mozilla.com at Thu, 10 Dec 2020 09:28:00 +0000
Bug 1676388 - Part 2: Only listen to input events in print dialog r=sfoster This removes all the change event listeners so that all the elements listen for just the input event. Listening to both could cause two settings change events to be dispatched and requires writing code to ignore change events in many components. Differential Revision: https://phabricator.services.mozilla.com/D99136
4542bcff02f39342184d5ffa36ce567fe4f5957f: Bug 1676388 - Part 1: Don't update to new printer settings if printer has since changed r=sfoster
Mark Striemer <mstriemer@mozilla.com> - Thu, 10 Dec 2020 04:34:37 +0000 - rev 560119
Push 38018 by abutkovits@mozilla.com at Thu, 10 Dec 2020 09:28:00 +0000
Bug 1676388 - Part 1: Don't update to new printer settings if printer has since changed r=sfoster When changing printers one of them could be slower than another. If you change to a slow printer and back to an already loaded/fast printer then the slow printer shouldn't overwrite the settings once it finally loads. Example: Start print on PDF printer, switch to a physical printer and back to PDF. If the physical printer had to be contacted to pull settings this operation could take a few seconds, at which point the settings from the physical printer could overwrite the PDF printer settings. Differential Revision: https://phabricator.services.mozilla.com/D99135
4f79a1f4172303aefbad283c5aa0774df16d62d5: Bug 1680258 - Relax startup IPC test for skeleton UI due to paint timings r=florian
Doug Thayer <dothayer@mozilla.com> - Thu, 10 Dec 2020 03:38:37 +0000 - rev 560118
Push 38018 by abutkovits@mozilla.com at Thu, 10 Dec 2020 09:28:00 +0000
Bug 1680258 - Relax startup IPC test for skeleton UI due to paint timings r=florian I don't have a crystal clear story of why these timings are different with the skeleton UI enabled. However, it's not remarkably surprising that it changes the order of some events during startup which come from the core Windows event loop. I don't think it's worth diving incredibly deep to understand this - looking at the profile we still only see one of each of these events. Differential Revision: https://phabricator.services.mozilla.com/D99111
00e863166a867bb1ccde6c5c9880f19597f01955: Bug 1680258 - Ensure we properly clamp values to draw region r=mstange
Doug Thayer <dothayer@mozilla.com> - Thu, 10 Dec 2020 03:38:29 +0000 - rev 560117
Push 38018 by abutkovits@mozilla.com at Thu, 10 Dec 2020 09:28:00 +0000
Bug 1680258 - Ensure we properly clamp values to draw region r=mstange Differential Revision: https://phabricator.services.mozilla.com/D99110
3c29ebb6584083f83709108a112fec7651f82006: Bug 1680258 - Ensure UI state initialized for skeleton UI r=mhowell
Doug Thayer <dothayer@mozilla.com> - Thu, 10 Dec 2020 03:38:22 +0000 - rev 560116
Push 38018 by abutkovits@mozilla.com at Thu, 10 Dec 2020 09:28:00 +0000
Bug 1680258 - Ensure UI state initialized for skeleton UI r=mhowell This was causing us to have slightly wrong focusring behavior, leading to wpt failures in focus-visible-005.html. Differential Revision: https://phabricator.services.mozilla.com/D98479
4b8533805da744a3d0501f989b978526964140a9: Bug 1680258 - Change first paint notification event when skele UI enabled r=florian
Doug Thayer <dothayer@mozilla.com> - Thu, 10 Dec 2020 03:38:14 +0000 - rev 560115
Push 38018 by abutkovits@mozilla.com at Thu, 10 Dec 2020 09:28:00 +0000
Bug 1680258 - Change first paint notification event when skele UI enabled r=florian Having the window present earlier changes the ordering of these events, such that it doesn't come through at the time that the browser_startup test needs it to. I think this event should be correct anyway, given that we already painted the skeleton UI? Differential Revision: https://phabricator.services.mozilla.com/D98478
dc51252ef65c223810919ba817d035c19febcc4c: Bug 1680258 - Don't try to draw rects with 0 width or height r=emalysz
Doug Thayer <dothayer@mozilla.com> - Thu, 10 Dec 2020 03:38:07 +0000 - rev 560114
Push 38018 by abutkovits@mozilla.com at Thu, 10 Dec 2020 09:28:00 +0000
Bug 1680258 - Don't try to draw rects with 0 width or height r=emalysz This prevents an assertion from tripping below. Differential Revision: https://phabricator.services.mozilla.com/D98476
b937607a208679346bb30424372f97e5f39eec44: Bug 1680258 - Check for problematic env vars for skeleton UI r=Gijs
Doug Thayer <dothayer@mozilla.com> - Thu, 10 Dec 2020 03:37:59 +0000 - rev 560113
Push 38018 by abutkovits@mozilla.com at Thu, 10 Dec 2020 09:28:00 +0000
Bug 1680258 - Check for problematic env vars for skeleton UI r=Gijs Some env vars have effects similar to command line arguments which present problems for the skeleton UI, and we want to treat these env vars similarly. Differential Revision: https://phabricator.services.mozilla.com/D98475
b2ec458a63aa3414d6462a7368e254f167c88c23: Bug 1680258 - Improve skeleton UI arg checking for marionette r=Gijs
Doug Thayer <dothayer@mozilla.com> - Thu, 10 Dec 2020 03:37:52 +0000 - rev 560112
Push 38018 by abutkovits@mozilla.com at Thu, 10 Dec 2020 09:28:00 +0000
Bug 1680258 - Improve skeleton UI arg checking for marionette r=Gijs Previously, we implemented arg checking with `marionette` just carrying a free pass, so we could let the arguments which typically come when running tests. However, some marionette tests do like to play with arguments which we do not want to get a free pass, such as -safe-mode. These changes allow just the -profile argument through, as that is necessary for running tests. Differential Revision: https://phabricator.services.mozilla.com/D98474
6896b25d63ba60a9fda84befca667f1c825df103: Bug 1681207: Remove unwanted WDBA shortcut on post update and uninstall. r=mhowell
Adam Gashlin <agashlin@mozilla.com> - Thu, 10 Dec 2020 04:28:36 +0000 - rev 560111
Push 38018 by abutkovits@mozilla.com at Thu, 10 Dec 2020 09:28:00 +0000
Bug 1681207: Remove unwanted WDBA shortcut on post update and uninstall. r=mhowell Differential Revision: https://phabricator.services.mozilla.com/D99303
7ffa5edf05adb8b4addf073d8fdf5b67d1b2a437: Bug 1676199, do not refresh preview for changes to copies or duplex printing r=sfoster
Emma Malysz <emalysz@mozilla.com> - Thu, 10 Dec 2020 03:00:38 +0000 - rev 560110
Push 38018 by abutkovits@mozilla.com at Thu, 10 Dec 2020 09:28:00 +0000
Bug 1676199, do not refresh preview for changes to copies or duplex printing r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D98980
dd7525e10639fd9fb2c2ce71bd1af8718925becd: Bug 1680716 - Fix a remaining bit of metadata. r=malexandru
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 10 Dec 2020 02:45:19 +0000 - rev 560109
Push 38018 by abutkovits@mozilla.com at Thu, 10 Dec 2020 09:28:00 +0000
Bug 1680716 - Fix a remaining bit of metadata. r=malexandru Differential Revision: https://phabricator.services.mozilla.com/D99298
3bdad2b2b82af14bd972352f88b72918d0b41752: Bug 1681565 - Turn cbindgen asserts on in nightly / early-beta. r=boris
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 09 Dec 2020 22:36:02 +0000 - rev 560108
Push 38018 by abutkovits@mozilla.com at Thu, 10 Dec 2020 09:28:00 +0000
Bug 1681565 - Turn cbindgen asserts on in nightly / early-beta. r=boris Differential Revision: https://phabricator.services.mozilla.com/D99270
ae67665f4e1eccf361aff237a4e6246ee7b4d1cf: Bug 1681026 - Fix PrintPreviewScrollToPage assert and simplify it. r=hiro
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 09 Dec 2020 21:17:22 +0000 - rev 560107
Push 38018 by abutkovits@mozilla.com at Thu, 10 Dec 2020 09:28:00 +0000
Bug 1681026 - Fix PrintPreviewScrollToPage assert and simplify it. r=hiro It was off-by-one as the pages are one-indexed. Differential Revision: https://phabricator.services.mozilla.com/D99212
cd48ff4663351a06d0b751580406ee38ea4f2ff1: Bug 1681582 - Disable Rust CFG on aarch64-windows r=firefox-build-system-reviewers,mhentges
David Major <dmajor@mozilla.com> - Thu, 10 Dec 2020 01:27:38 +0000 - rev 560106
Push 38018 by abutkovits@mozilla.com at Thu, 10 Dec 2020 09:28:00 +0000
Bug 1681582 - Disable Rust CFG on aarch64-windows r=firefox-build-system-reviewers,mhentges This is bug 1639318 all over again except from Rust rather than C++. It's the same symptom, nsXPTCStub vtables aren't marked as valid targets. In the earlier bug we disabled CFG for C++ on ARM64. Let's do the same for Rust. According to that bug, "It's not clear why this doesn't happen on x86 builds. Given priorities, I can't really justify investigating this, although I suspect that fixing the underlying issue would be pretty much bug 1483885." Differential Revision: https://phabricator.services.mozilla.com/D99278
7b5facb4df3a77bd60d21045be212161c91cea12: Bug 1675360 - Shutdown MediaKeys when parent inner window is destroyed rather than document. r=karlt
Bryce Seager van Dyk <bvandyk@mozilla.com> - Thu, 10 Dec 2020 01:03:27 +0000 - rev 560105
Push 38017 by cbrindusan@mozilla.com at Thu, 10 Dec 2020 03:47:02 +0000
Bug 1675360 - Shutdown MediaKeys when parent inner window is destroyed rather than document. r=karlt Rework the MediaKeys class to shutdown when its parent inner window is destroyed rather than the document it's created in. This is done to mitigate the case where a MediaKeys is created in an about:blank document that has not yet undergone its async load (i.e. blank document that will stay blank, blank documents loading to other pages will still clobber their keys on load). This specifically addresses cases where sites could create an iframe, not wait for load, create a MediaKeys in the iframe, and then find the keys had become unusable. This is achieved by associating MediaKeys instances with their inner window and having the window notify keys when a window is going to be destroyed. I decided to use this approach rather than have MediaKeys observe for window destruction for a few reasons: - The keys would need to support weak references to use the observer service in the desired way. Implementing this interface on the MediaKeys adds a non-trivial level of complexity and means the keys would implement the WeakPtr interface (already in place prior to this patch) and also the NS weak reference interface, which I found confusing. - If the inner window stores pointers to MediaKeys created in it, it can be self aware of if EME activity is taking place within it. The allows us to better identify EME activity in documents. Historically one of the ways we'd determined EME activity by checking if media elements have MediaKeys attached, but this had lead to issues where if MediaKeys are created but not attached to a media element we overlook them. With this patch's changes, we can also have a document check its inner window to see if there are any MediaKeys. This patch uses this to extend our check to avoid bfcaching pages with EME content. - There appears to be prior art using a similar approach for audio contexts and peer connections, which I assume is sensible and I'm not reinventing the wheel by following. Differential Revision: https://phabricator.services.mozilla.com/D98641
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip