6d749b36ef6cb68085e8d670ef2c821413bd82c5: Bug 1617033 - part6 : make utility functions more general. r=chunmin
alwu <alwu@mozilla.com> - Fri, 06 Mar 2020 17:50:18 +0000 - rev 517286
Push 37189 by cbrindusan@mozilla.com at Sat, 07 Mar 2020 09:32:21 +0000
Bug 1617033 - part6 : make utility functions more general. r=chunmin By providing element Id, we can use these functions to access video element on other files. Differential Revision: https://phabricator.services.mozilla.com/D64173
b92e7ec309ac51bf22cb08d7492bced3087732a3: Bug 1617033 - part5 : remove unecessary async. r=chunmin
alwu <alwu@mozilla.com> - Fri, 06 Mar 2020 17:48:54 +0000 - rev 517285
Push 37189 by cbrindusan@mozilla.com at Sat, 07 Mar 2020 09:32:21 +0000
Bug 1617033 - part5 : remove unecessary async. r=chunmin `async` is actually useless here because we don't have anything to do after `await` so we could return the promise `SpecialPowers.spawn()` generate instead. Differential Revision: https://phabricator.services.mozilla.com/D63944
5f1478173ec6996d4085f262c35739fe992d9e6a: Bug 1617033 - part4 : add a timer to stop listening to media control key events. r=chunmin
alwu <alwu@mozilla.com> - Fri, 06 Mar 2020 17:47:58 +0000 - rev 517284
Push 37189 by cbrindusan@mozilla.com at Sat, 07 Mar 2020 09:32:21 +0000
Bug 1617033 - part4 : add a timer to stop listening to media control key events. r=chunmin This patch is used to prevent intercepting media keys from other applications which should really receive media keys. For example, if user finishes watching a video but doesn't close that tab, and switch to other tasks. Then if they have other applications which are playing music, when they press media keys, the application which should receive media keys should be those background music app, not Firefox. Therefore, if the media has been paused for a while, then that might indicate that user won't need to control this media anymore. Therefore, we create a timer, which default expire time is 60s, to stop listening media control key events for those kinds of media. But if the media starts again during this period, we would destroy timer and continue to control that media. Differential Revision: https://phabricator.services.mozilla.com/D63918
10d38000b11cfa4bd0db3d0bc472448c38ff43d9: Bug 1617033 - part3 : add comment to explicitly mention some functions should only be used after starting listener. r=chunmin
alwu <alwu@mozilla.com> - Fri, 06 Mar 2020 17:46:44 +0000 - rev 517283
Push 37189 by cbrindusan@mozilla.com at Sat, 07 Mar 2020 09:32:21 +0000
Bug 1617033 - part3 : add comment to explicitly mention some functions should only be used after starting listener. r=chunmin Differential Revision: https://phabricator.services.mozilla.com/D63916
a33e9c0dcea1eb7eeb168b103cbfc3bba2b82525: Bug 1617033 - part2 : only update audible state after starting listener successfully. r=chunmin
alwu <alwu@mozilla.com> - Fri, 06 Mar 2020 17:46:07 +0000 - rev 517282
Push 37189 by cbrindusan@mozilla.com at Sat, 07 Mar 2020 09:32:21 +0000
Bug 1617033 - part2 : only update audible state after starting listener successfully. r=chunmin It's useless to update the audible state before starting listening to the media control keys event, so we make it consistent with other functions which could only be used after starting the listener. As the audible change could happen before we start the listener, we have to manually update audible state to the controller after we start the listener. Differential Revision: https://phabricator.services.mozilla.com/D63943
6acd67af0e321ab2e6be81ded374580975c82341: Bug 1617033 - part1 : start listening to the event after media becomes audible. r=chunmin
alwu <alwu@mozilla.com> - Fri, 06 Mar 2020 17:45:29 +0000 - rev 517281
Push 37189 by cbrindusan@mozilla.com at Sat, 07 Mar 2020 09:32:21 +0000
Bug 1617033 - part1 : start listening to the event after media becomes audible. r=chunmin When media is not audible yet, or it's inaudible at all (maybe it's used as a background video or GIF-like image), or the media is in the tab which has been muted totally, we don't want to use media control to control those media, so we should postpone starting listening to the media control keys for them event until they become audible. Once they become audible, we would keep control them all the time even if they become inaudible again. Differential Revision: https://phabricator.services.mozilla.com/D63915
565b8e750095a729377c287c75525c8304f0147b: Backed out changeset 2a5f4092b45b (bug 1618867) for build bustages on a CLOSED TREE
Andreea Pavel <apavel@mozilla.com> - Fri, 06 Mar 2020 19:54:04 +0200 - rev 517280
Push 37189 by cbrindusan@mozilla.com at Sat, 07 Mar 2020 09:32:21 +0000
Backed out changeset 2a5f4092b45b (bug 1618867) for build bustages on a CLOSED TREE
8395b76e5be7670d6c3cc2fbd1b53a74e1e7fd34: Bug 1620258 - Added telemetry ping to the "Start Browsing" button in simplified about:welcome. r=pdahiya
emcminn <emcminn@mozilla.com> - Fri, 06 Mar 2020 17:51:46 +0000 - rev 517279
Push 37189 by cbrindusan@mozilla.com at Sat, 07 Mar 2020 09:32:21 +0000
Bug 1620258 - Added telemetry ping to the "Start Browsing" button in simplified about:welcome. r=pdahiya Differential Revision: https://phabricator.services.mozilla.com/D65646
a815e28f736a90fd5dfd5df3addc23c15d2ece75: Bug 1620227 - Handle shutdown occurring during SearchService initialisation. r=mikedeboer
Mark Banner <standard8@mozilla.com> - Fri, 06 Mar 2020 14:32:13 +0000 - rev 517278
Push 37189 by cbrindusan@mozilla.com at Sat, 07 Mar 2020 09:32:21 +0000
Bug 1620227 - Handle shutdown occurring during SearchService initialisation. r=mikedeboer Abort it before writing the cache to avoid potentially writing a incomplete cache. Differential Revision: https://phabricator.services.mozilla.com/D65723
ade1286ccf20b2c2acb7e10c92644bb3cc64dc37: Bug 1607894 - Add debugging assert to Normandy test for intermittent r=leplatrem
Michael Cooper <mcooper@mozilla.com> - Fri, 06 Mar 2020 17:47:12 +0000 - rev 517277
Push 37189 by cbrindusan@mozilla.com at Sat, 07 Mar 2020 09:32:21 +0000
Bug 1607894 - Add debugging assert to Normandy test for intermittent r=leplatrem Differential Revision: https://phabricator.services.mozilla.com/D63936
2a5f4092b45b9fccceaa83bb5cbb9107ae837f4e: Bug 1618867 - Standardize /urlbar/tests names. r=adw
Harry Twyford <htwyford@mozilla.com> - Fri, 06 Mar 2020 17:42:42 +0000 - rev 517276
Push 37189 by cbrindusan@mozilla.com at Sat, 07 Mar 2020 09:32:21 +0000
Bug 1618867 - Standardize /urlbar/tests names. r=adw Differential Revision: https://phabricator.services.mozilla.com/D65192
f6f02d0b050dba135ac1bf16b3b5d2ad0b89842a: Bug 1448992. Get rid of nsXPCComponentsBase. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 06 Mar 2020 17:40:57 +0000 - rev 517275
Push 37189 by cbrindusan@mozilla.com at Sat, 07 Mar 2020 09:32:21 +0000
Bug 1448992. Get rid of nsXPCComponentsBase. r=bholley Differential Revision: https://phabricator.services.mozilla.com/D65737
23f30786c17df6eb9dc058e6ad41bf90a5ab839f: Bug 1620449 - Convert gen_cert_header.py to py3; r=firefox-build-system-reviewers,rstewart
Mike Shal <mshal@mozilla.com> - Fri, 06 Mar 2020 17:31:15 +0000 - rev 517274
Push 37189 by cbrindusan@mozilla.com at Sat, 07 Mar 2020 09:32:21 +0000
Bug 1620449 - Convert gen_cert_header.py to py3; r=firefox-build-system-reviewers,rstewart Differential Revision: https://phabricator.services.mozilla.com/D65632
c509818e9bf9e310feb0710a3f1424eb709ff877: Bug 1619788 - Ensure files generated by `./mach configure` don't have CRLF line endings, even under Python 3 r=glandium
Ricky Stewart <rstewart@mozilla.com> - Fri, 06 Mar 2020 02:19:21 +0000 - rev 517273
Push 37189 by cbrindusan@mozilla.com at Sat, 07 Mar 2020 09:32:21 +0000
Bug 1619788 - Ensure files generated by `./mach configure` don't have CRLF line endings, even under Python 3 r=glandium Differential Revision: https://phabricator.services.mozilla.com/D65354
1843cd41ed4f133f97abfc9664a1d006246d076e: Bug 1620239 - ensure not to access null pointer; r=Ehsan
Liang-Heng Chen <xeonchen@gmail.com> - Fri, 06 Mar 2020 17:20:49 +0000 - rev 517272
Push 37189 by cbrindusan@mozilla.com at Sat, 07 Mar 2020 09:32:21 +0000
Bug 1620239 - ensure not to access null pointer; r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D65576
643f78f84dd0e9c04a47f264c4113b1821fb3c16: Bug 1599806 - update accessibility actors tests to support parent accessibility actor. r=ochameau
Yura Zenevich <yura.zenevich@gmail.com> - Fri, 06 Mar 2020 16:28:27 +0000 - rev 517271
Push 37189 by cbrindusan@mozilla.com at Sat, 07 Mar 2020 09:32:21 +0000
Bug 1599806 - update accessibility actors tests to support parent accessibility actor. r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D58808
2430d82847ef7c4bf338378aa2149c9f6d17b102: Bug 1599806 - remove setupInParent from accessibility actor and split up child/parent functionality into two separate actors. r=ochameau
Yura Zenevich <yura.zenevich@gmail.com> - Fri, 06 Mar 2020 17:18:58 +0000 - rev 517270
Push 37189 by cbrindusan@mozilla.com at Sat, 07 Mar 2020 09:32:21 +0000
Bug 1599806 - remove setupInParent from accessibility actor and split up child/parent functionality into two separate actors. r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D58807
0a31f55cec08749174e1b35b40e38e3ff4d3876f: Bug 1599806 - introduce accessibility proxy that would be responsible for interacting with panel's UI instead of directly referencing accessibility related fronts. r=rcaliman
Yura Zenevich <yura.zenevich@gmail.com> - Fri, 06 Mar 2020 16:28:07 +0000 - rev 517269
Push 37189 by cbrindusan@mozilla.com at Sat, 07 Mar 2020 09:32:21 +0000
Bug 1599806 - introduce accessibility proxy that would be responsible for interacting with panel's UI instead of directly referencing accessibility related fronts. r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D58806
53f21efd04f2a243a400f5de00d3c439c8c2be6a: Bug 1605757 - decouple accessibility front front the accessibility panel UI. r=rcaliman
Yura Zenevich <yura.zenevich@gmail.com> - Fri, 06 Mar 2020 16:27:59 +0000 - rev 517268
Push 37189 by cbrindusan@mozilla.com at Sat, 07 Mar 2020 09:32:21 +0000
Bug 1605757 - decouple accessibility front front the accessibility panel UI. r=rcaliman Differential Revision: https://phabricator.services.mozilla.com/D58553
4926363449ffa32cb6bd34f2f0796e2f6b20300b: Bug 1619590 - Fix Failed prop type warnings in InspectAction and _ActionButton r=jdescottes
manishsahani1351111 <manishsahani1351111@gmail.com:> - Fri, 06 Mar 2020 17:04:33 +0000 - rev 517267
Push 37189 by cbrindusan@mozilla.com at Sat, 07 Mar 2020 09:32:21 +0000
Bug 1619590 - Fix Failed prop type warnings in InspectAction and _ActionButton r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D65217
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip