69eacc5c3ab87fdeb2a91e7ee00bf2bc5ef2bde5: Bug 1460022: Part 5 - Update launcher process to work with new DLL interceptor interface; r=mhowell
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:49:30 -0600 - rev 424949
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 5 - Update launcher process to work with new DLL interceptor interface; r=mhowell
34aa7c29b31e7fa888e8ef1c7ae8c78806c945d3: Bug 1460022: Part 4 - Update a11y code to reflect new interface for DLL interceptor; r=Jamie
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:49:17 -0600 - rev 424948
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 4 - Update a11y code to reflect new interface for DLL interceptor; r=Jamie
00b20c0a763741ef161ecc48794d28b1db97cbe9: Bug 1460022: Part 3 - Update TestDllInterceptorCrossProcess to reflect new interceptor interface; r=handyman
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:48:45 -0600 - rev 424947
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 3 - Update TestDllInterceptorCrossProcess to reflect new interceptor interface; r=handyman
b8e8aea4a01f596dc543216fa946ac0170b4d616: Bug 1460022: Part 2 - Update TestDllInterceptor to use new DLL interceptor interface; r=handyman
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:48:28 -0600 - rev 424946
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 2 - Update TestDllInterceptor to use new DLL interceptor interface; r=handyman In addition to updating the interface, this patch also significantly alters the structure of this test. In particular, it removes the Test* functions in favour of using template magic. I did this because I noticed that, in the majority of cases, the stub function was being called with all zero arguments, and then we check for the expected error code. I thought that maybe we could replace that repetition with some templates that instantiate a blank tuple that may then be applied to a callable object. See the (MAYBE_)TEST_HOOK* and TEST_DETOUR* macro definitions for detailed information about how to use these things. The test successfully completes with both 32-bit and 64-bit builds.
15822d9848d8647ef9a143f4b718d8d5d66a4c0a: Bug 1460022: Part 1 - Modify DLL interceptor to use one-time initialization when setting hooks; r=handyman
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:48:05 -0600 - rev 424945
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 1 - Modify DLL interceptor to use one-time initialization when setting hooks; r=handyman This patch makes the interceptor's AddHook functions private, and converts the stubs from simple function pointers into objects containing both the stub function pointer, plus a INIT_ONCE sentinel. Setting a hook now requires calling Set or SetDetour on the stub, which ensures that the hook attempt happens once and only once. The constructor for the new object is constexpr, so it should not generate static initializers if it is declared statically. Note that, as a corollary of the new behaviour, we no longer need to set guards around any hook setting code. I have removed those when present.
3a415f165864dc3c17ea1e49d66d34245d660fd4: Backed out 13 changesets (bug 1460022) for bustages in builds/worker/workspace/build/src/dom/plugins/ipc/FunctionHook.h:100:24 on a CLOSED TREE
shindli <shindli@mozilla.com> - Wed, 04 Jul 2018 02:49:24 +0300 - rev 424944
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Backed out 13 changesets (bug 1460022) for bustages in builds/worker/workspace/build/src/dom/plugins/ipc/FunctionHook.h:100:24 on a CLOSED TREE Backed out changeset 0734142a3f35 (bug 1460022) Backed out changeset 18fbfa7ca685 (bug 1460022) Backed out changeset 2df129bd5692 (bug 1460022) Backed out changeset 02a7ed68933f (bug 1460022) Backed out changeset 221137d1c2de (bug 1460022) Backed out changeset 9cb0b7a15402 (bug 1460022) Backed out changeset 18f8f85c0307 (bug 1460022) Backed out changeset 867a1351efff (bug 1460022) Backed out changeset 933e0b698f8e (bug 1460022) Backed out changeset 09da660071e1 (bug 1460022) Backed out changeset 8bb5142d3f53 (bug 1460022) Backed out changeset 0ddf581bdaac (bug 1460022) Backed out changeset 1cd5f9b4a6af (bug 1460022)
0734142a3f358117ac8baddd994dc5526d124593: Bug 1460022: Part 13 - Update profiler to use revised DLL interceptor interface; r=njn
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 14:23:29 -0600 - rev 424943
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 13 - Update profiler to use revised DLL interceptor interface; r=njn
18fbfa7ca68556a5fb6de2c85eab23e796bb1ce8: Bug 1460022: Part 12 - Update XPCOM to use revised DLL interceptor interface; r=froydnj
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:52:18 -0600 - rev 424942
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 12 - Update XPCOM to use revised DLL interceptor interface; r=froydnj
2df129bd56925466d6024d22b493037c6436e63c: Bug 1460022: Part 11 - Update Win32 nsWindow to work with revised DLL interceptor interface; r=mhowell
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:52:01 -0600 - rev 424941
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 11 - Update Win32 nsWindow to work with revised DLL interceptor interface; r=mhowell
02a7ed68933f925927b7037d3532f1128e5a6527: Bug 1460022: Part 10 - Update crash reporter to work with revised DLL interceptor interface; r=dmajor
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:51:40 -0600 - rev 424940
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 10 - Update crash reporter to work with revised DLL interceptor interface; r=dmajor
221137d1c2de7988bfcb63deb258737fe8fb29ce: Bug 1460022: Part 9 - Update sandboxing code to work with revised DLL interceptor interface; r=bobowen
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:51:29 -0600 - rev 424939
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 9 - Update sandboxing code to work with revised DLL interceptor interface; r=bobowen
9cb0b7a1540255ca017c45eae89b227d9ed29ba1: Bug 1460022: Part 8 - Update DLL blocklist to work with revised DLL interceptor interface; r=mhowell
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:51:10 -0600 - rev 424938
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 8 - Update DLL blocklist to work with revised DLL interceptor interface; r=mhowell
18f8f85c03076707495a7e55929eba3bd3164214: Bug 1460022: Part 7 - Update plugin code to work with revised DLL interceptor interface; r=handyman
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:50:50 -0600 - rev 424937
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 7 - Update plugin code to work with revised DLL interceptor interface; r=handyman
867a1351efffcc0a3b4cab364e518d8f4d5d5983: Bug 1460022: Part 6 - Update GMP code to work with new DLL interceptor interface; r=cpearce
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:49:49 -0600 - rev 424936
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 6 - Update GMP code to work with new DLL interceptor interface; r=cpearce
933e0b698f8e8efb7706702e8c3565ba6449406e: Bug 1460022: Part 5 - Update launcher process to work with new DLL interceptor interface; r=mhowell
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:49:30 -0600 - rev 424935
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 5 - Update launcher process to work with new DLL interceptor interface; r=mhowell
09da660071e1705e6bebae64134af3d63b32d212: Bug 1460022: Part 4 - Update a11y code to reflect new interface for DLL interceptor; r=Jamie
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:49:17 -0600 - rev 424934
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 4 - Update a11y code to reflect new interface for DLL interceptor; r=Jamie
8bb5142d3f530f898f48105ef08e2d9eadd48577: Bug 1460022: Part 3 - Update TestDllInterceptorCrossProcess to reflect new interceptor interface; r=handyman
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:48:45 -0600 - rev 424933
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 3 - Update TestDllInterceptorCrossProcess to reflect new interceptor interface; r=handyman
0ddf581bdaac15f280673e3937c283cd65cc70a7: Bug 1460022: Part 2 - Update TestDllInterceptor to use new DLL interceptor interface; r=handyman
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:48:28 -0600 - rev 424932
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 2 - Update TestDllInterceptor to use new DLL interceptor interface; r=handyman In addition to updating the interface, this patch also significantly alters the structure of this test. In particular, it removes the Test* functions in favour of using template magic. I did this because I noticed that, in the majority of cases, the stub function was being called with all zero arguments, and then we check for the expected error code. I thought that maybe we could replace that repetition with some templates that instantiate a blank tuple that may then be applied to a callable object. See the (MAYBE_)TEST_HOOK* and TEST_DETOUR* macro definitions for detailed information about how to use these things. The test successfully completes with both 32-bit and 64-bit builds.
1cd5f9b4a6af952a3831281c27abe0b5aaa466c8: Bug 1460022: Part 1 - Modify DLL interceptor to use one-time initialization when setting hooks; r=handyman
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:48:05 -0600 - rev 424931
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1460022: Part 1 - Modify DLL interceptor to use one-time initialization when setting hooks; r=handyman This patch makes the interceptor's AddHook functions private, and converts the stubs from simple function pointers into objects containing both the stub function pointer, plus a INIT_ONCE sentinel. Setting a hook now requires calling Set or SetDetour on the stub, which ensures that the hook attempt happens once and only once. The constructor for the new object is constexpr, so it should not generate static initializers if it is declared statically. Note that, as a corollary of the new behaviour, we no longer need to set guards around any hook setting code. I have removed those when present.
bf97c22331fa4167201555670fd5f9593b9871dd: Bug 1473136: Cache mNeedsActiveLayer once for nsDisplayOpacity. r=mattwoodrow
Bas Schouten <bschouten@mozilla.com> - Tue, 03 Jul 2018 23:07:44 +0000 - rev 424930
Push 34227 by rgurzau@mozilla.com at Wed, 04 Jul 2018 09:59:03 +0000
Bug 1473136: Cache mNeedsActiveLayer once for nsDisplayOpacity. r=mattwoodrow
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip