699852463590fa8e58ed7537c4d6bc83dee59642: Backed out 2 changesets (bug 1422163) for mochitest bc6 failure on /browser_clearSiteData.js. on a CLOSED TREE
Narcis Beleuzu <nbeleuzu@mozilla.com> - Thu, 01 Feb 2018 16:33:52 +0200 - rev 402058
Push 33361 by ncsoregi@mozilla.com at Thu, 01 Feb 2018 18:09:52 +0000
Backed out 2 changesets (bug 1422163) for mochitest bc6 failure on /browser_clearSiteData.js. on a CLOSED TREE Backed out changeset f8a8160484c8 (bug 1422163) Backed out changeset 60cd03e9c5ac (bug 1422163)
232be6a415771aaf46825fcb5dd901d63edf7189: Bug 1434574 - Build wayland with EGL OpenGL backend, r=glandium
Martin Stransky <stransky@redhat.com> - Wed, 31 Jan 2018 13:13:50 +0100 - rev 402057
Push 33361 by ncsoregi@mozilla.com at Thu, 01 Feb 2018 18:09:52 +0000
Bug 1434574 - Build wayland with EGL OpenGL backend, r=glandium MozReview-Commit-ID: LpGmUVOYqRI
d3822c7998ece5a3af0ca3ce2c635a5ba040d3c0: Bug 1433420 - fix scrollbox width selector for emulated flex to only apply to tabbrowser scrollbox, r=bgrins,dao
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 31 Jan 2018 11:40:03 +0000 - rev 402056
Push 33361 by ncsoregi@mozilla.com at Thu, 01 Feb 2018 18:09:52 +0000
Bug 1433420 - fix scrollbox width selector for emulated flex to only apply to tabbrowser scrollbox, r=bgrins,dao MozReview-Commit-ID: 6WPoJKZFCAD
05d667efdfb8639bf21a4b93b9f641ab672b5b78: servo: Merge #19918 - style: Refactor font-feature-settings and font-variation-settings (from emilio:font-stuff-is-a-mess); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 01 Feb 2018 06:45:20 -0600 - rev 402055
Push 33361 by ncsoregi@mozilla.com at Thu, 01 Feb 2018 18:09:52 +0000
servo: Merge #19918 - style: Refactor font-feature-settings and font-variation-settings (from emilio:font-stuff-is-a-mess); r=nox This fixes all known issues with serialization and parsing of these two properties, and in particular calc handling and such: https://bugzilla.mozilla.org/show_bug.cgi?id=1434692 https://bugzilla.mozilla.org/show_bug.cgi?id=1434724 Also does a fair amount of cleanup and all that, which was needed, this code was a mess. There are further cleanups that can be done, like renaming the font-variation-settings animation stuff. Source-Repo: https://github.com/servo/servo Source-Revision: dcd13b857cc5085dcec5047433637af3d9013920
9352e0738ccf95cb541b0926d11a896024a0183b: servo: Merge #19903 - Derive more Parse implementations (fixes #19827) (from servo:derive-all-the-things); r=emilio
Anthony Ramine <n.oxyde@gmail.com> - Thu, 01 Feb 2018 05:52:08 -0600 - rev 402054
Push 33361 by ncsoregi@mozilla.com at Thu, 01 Feb 2018 18:09:52 +0000
servo: Merge #19903 - Derive more Parse implementations (fixes #19827) (from servo:derive-all-the-things); r=emilio Fixes #19827. Source-Repo: https://github.com/servo/servo Source-Revision: b4339ab5c8fc31d5eeb7e1fae55cab05e400ec9e
b4a42010118a987173f6b82dfb569c743f795d4c: Bug 1431535 Increase timeout for new connection in test_disable_enable_new_connections from timeout 1.0 to 10.0 r=whimboo
Amit Kumar <amit2rockpower@gmail.com> - Mon, 29 Jan 2018 18:24:24 +0530 - rev 402053
Push 33361 by ncsoregi@mozilla.com at Thu, 01 Feb 2018 18:09:52 +0000
Bug 1431535 Increase timeout for new connection in test_disable_enable_new_connections from timeout 1.0 to 10.0 r=whimboo MozReview-Commit-ID: KjRu5yMHxFO
8f9dcb9c62de9ef2ab82f42b7c5e5984d38bf55c: Bug 1399864 - Send If-Modified-Since header when polling for blocklist.xml changes, r=florian
Mathieu Leplatre <mathieu@mozilla.com> - Wed, 31 Jan 2018 11:45:53 +0000 - rev 402052
Push 33361 by ncsoregi@mozilla.com at Thu, 01 Feb 2018 18:09:52 +0000
Bug 1399864 - Send If-Modified-Since header when polling for blocklist.xml changes, r=florian MozReview-Commit-ID: oAM9lDhtlt
f8a8160484c854b2805bd995dfecf64d3b024d76: Bug 1422163 - Part 2 - Make a new test for clearing all site data with the new dialog. r=Gijs
Johann Hofmann <jhofmann@mozilla.com> - Wed, 10 Jan 2018 12:25:04 +0100 - rev 402051
Push 33361 by ncsoregi@mozilla.com at Thu, 01 Feb 2018 18:09:52 +0000
Bug 1422163 - Part 2 - Make a new test for clearing all site data with the new dialog. r=Gijs MozReview-Commit-ID: 6Lt3hPZ1YiO
60cd03e9c5acb74a22fd6cd50c365660c9cedeaf: Bug 1422163 - Part 1 - Make a new confirm dialog for clearing all site data that allows you to clear cache. r=Gijs
Johann Hofmann <jhofmann@mozilla.com> - Wed, 10 Jan 2018 12:24:40 +0100 - rev 402050
Push 33361 by ncsoregi@mozilla.com at Thu, 01 Feb 2018 18:09:52 +0000
Bug 1422163 - Part 1 - Make a new confirm dialog for clearing all site data that allows you to clear cache. r=Gijs MozReview-Commit-ID: G9xQXlfT9Ay
b8ad646de7a7e4a1a181f0d793de3720260ac974: Bug 1424648 - Provide proper face index to FreeType FontDescriptorOutput; r=lsalzman
Jan Steffens <jan.steffens@gmail.com> - Wed, 31 Jan 2018 21:42:18 +0100 - rev 402049
Push 33361 by ncsoregi@mozilla.com at Thu, 01 Feb 2018 18:09:52 +0000
Bug 1424648 - Provide proper face index to FreeType FontDescriptorOutput; r=lsalzman OpenType font collections (*.ttc) contain multiple faces in a single file, identified via index. When creating a font descriptor for a FreeType or Fontconfig font, we mistakenly set the index to zero, always. This bug became visible when layout and WebRender would disagree on the face in use, rendering text with the metrics from the proper face but the outlines of another. Unless, of course, the selected face was the first (or only) in the font file. MozReview-Commit-ID: 73qcPOD0HIr
6d21bdf7eab331e98bac5d4fa25faf6f41af647f: Bug 1434474: There's no need to rebuild font / counter styles / font feature values off a runnable. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 31 Jan 2018 11:12:36 +0100 - rev 402048
Push 33361 by ncsoregi@mozilla.com at Thu, 01 Feb 2018 18:09:52 +0000
Bug 1434474: There's no need to rebuild font / counter styles / font feature values off a runnable. r=bholley Everything that needs them up-to-date will call flush appropriately, there should be no need to do it manually. This way we coalesce all the stylist updates until the next style flush in the best case, or until one of the consumers actually needs them. MozReview-Commit-ID: BVsxXxhtcKL
5603121afc215f16aeb1a6b43e65f9670b97885b: Merge mozilla-central to autoland. a=merge CLOSED TREE
Brindusan Cristian <cbrindusan@mozilla.com> - Thu, 01 Feb 2018 12:15:12 +0200 - rev 402047
Push 33361 by ncsoregi@mozilla.com at Thu, 01 Feb 2018 18:09:52 +0000
Merge mozilla-central to autoland. a=merge CLOSED TREE
9fd276dbd33a3c1719ace73406d1cf68db6b19dc: Bug 1434587 - Configure absolute threshold for installer size alerts r=jmaher
Ionut Goldan <igoldan@mozilla.com> - Wed, 31 Jan 2018 15:31:37 +0200 - rev 402046
Push 33361 by ncsoregi@mozilla.com at Thu, 01 Feb 2018 18:09:52 +0000
Bug 1434587 - Configure absolute threshold for installer size alerts r=jmaher MozReview-Commit-ID: Ehrh49ACBC1
a34aa1fe1209000f3e3a39cad6d9d7d8f4cf7712: Bug 1430957 - [tl] Search engine setup for Firefox Mobile for Tagalog, r=flod
Delphine Lebédel <dlebedel@mozilla.com> - Wed, 31 Jan 2018 15:48:17 -0800 - rev 402045
Push 33361 by ncsoregi@mozilla.com at Thu, 01 Feb 2018 18:09:52 +0000
Bug 1430957 - [tl] Search engine setup for Firefox Mobile for Tagalog, r=flod MozReview-Commit-ID: D4iqh0OT6WD
5201997e7e01500176ce7d6e790593468f3b4259: Merge inbound to mozilla-central. a=merge
Narcis Beleuzu <nbeleuzu@mozilla.com> - Thu, 01 Feb 2018 12:05:39 +0200 - rev 402044
Push 33360 by nbeleuzu@mozilla.com at Thu, 01 Feb 2018 10:06:21 +0000
Merge inbound to mozilla-central. a=merge
03a0fe367bb10467ec034af93e4b26e23fc1e54c: Bug 1423840 - Temporarily disable a small part of the prefs parser gtest due to failures on Windows. r=me
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 01 Feb 2018 19:14:30 +1100 - rev 402043
Push 33360 by nbeleuzu@mozilla.com at Thu, 01 Feb 2018 10:06:21 +0000
Bug 1423840 - Temporarily disable a small part of the prefs parser gtest due to failures on Windows. r=me
4e655361be5a1971300c15f58ec65c81f82ba826: Bug 1423840 (attempt 2) - Rewrite the prefs parser. r=glandium,Manishearth
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 01 Feb 2018 16:21:47 +1100 - rev 402042
Push 33360 by nbeleuzu@mozilla.com at Thu, 01 Feb 2018 10:06:21 +0000
Bug 1423840 (attempt 2) - Rewrite the prefs parser. r=glandium,Manishearth The prefs parser has two significant problems. - It doesn't separate tokenizing from parsing. - It is implemented as a loop around a big switch on a "current state" variable. As a result, it is hard to understand and modify, slower than it could be, and in obscure cases (involving comments and whitespace) it fails to parse what should be valid input. This patch replaces it with a recursive descent parser (albeit one without any recursion!) that has separate tokenization. The new parser is easier to understand and modify, more correct, and has better error messages. It doesn't do error recovery, but that would be much easier to add than in the old parser. The new parser also runs about 1.9x faster than the existing parser. (As measured by parsing greprefs.js's contents from memory 1000 times in succession, omitting the prefs hash table construction. If the table construction is included, it's about 1.6x faster.) The new parser is slightly stricter than the old parser in a few ways. - Disconcertingly, the old parser allowed arbitrary junk between prefs (including at the start and end of the prefs file) so long as that junk didn't include any of the following chars: '/', '#', 'u', 's', 'p'. I.e. lines like these: !foo@bar&pref("prefname", true); ticky_pref("prefname", true); // missing 's' at start User_pref("prefname", true); // should be 'u' at start would all be treated the same as this: pref("prefname", true); The new parser disallows such junk because it isn't necessary and seems like an unintentional botch by the old parser. - The old parser allowed character 0x1a (SUB) between tokens and treated it like '\n'. The new parser does not allow this character. SUB was used to indicate end-of-file (*not* end-of-line) in some old operating systems such as MS-DOS, but this doesn't seem necessary today. - The old parser tolerated (with a warning) invalid escape sequences within string literals -- such as "\q" (not a valid escape) and "\x1" and "\u12" (both of which have insufficient hex digits) -- accepting them literally. The new parser does not tolerate invalid escape sequences because it doesn't seem necessary and would complicate things. - The old parser tolerated character 0x00 (NUL) within string literals; this is dangerous because C++ code that manipulates string values with embedded NULs will almost certainly consider those chars as end-of-string markers. The new parser treats NUL chars as end-of-file, to avoid this danger and because it facilitates a significant optimization (described within the code). - The old parser allowed integer literals to overflow, silently wrapping them. The new parser treats integer overflow as a parse error. This seems better, and it caught existing overflows of places.database.lastMaintenance, in testing/profiles/prefs_general.js (bug 1424030) and testing/talos/talos/config.py (bug 1434813). The first of these changes meant that a couple of existing prefs with ";;" at the end had to be changed (done in the preceding patch). The minor increase in strictness shouldn't be a problem for default pref files such as greprefs.js within the application (which we can modify), nor for app-written prefs files such as prefs.js. It could affect user-written prefs files such as user.js; the experience above suggests that integer overflow and ";;" are the most likely problems in practice. In my opinion, the risk here is acceptable. The new parser also does a better job of tracking line numbers because it (a) treats "\r\n" sequences as a single end-of-line marker, and (a) pays attention to end-of-line sequences within string literals. Finally, the patch adds thorough tests of both valid and invalid syntax. MozReview-Commit-ID: JD3beOQl4AJ
8ebdf597ade8b7c25edd3ea75babd721f28fc4a3: Bug 1423840 (attempt 2) - Remove extraneous semicolons in all.js. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 01 Feb 2018 15:44:29 +1100 - rev 402041
Push 33360 by nbeleuzu@mozilla.com at Thu, 01 Feb 2018 10:06:21 +0000
Bug 1423840 (attempt 2) - Remove extraneous semicolons in all.js. r=glandium MozReview-Commit-ID: 2BMfVOoEtQ2
a9ce3cd892a796726d4a7077b705204d1c9a30b0: Bug 1434813 - Fix integer overflow of places.database.lastMaintenance in testing/profiles/prefs_general.js. r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 01 Feb 2018 15:40:32 +1100 - rev 402040
Push 33360 by nbeleuzu@mozilla.com at Thu, 01 Feb 2018 10:06:21 +0000
Bug 1434813 - Fix integer overflow of places.database.lastMaintenance in testing/profiles/prefs_general.js. r=glandium. Bug 1383896 added this constant to testing/talos/talos/config.py: > FAR_IN_FUTURE = 7258114800 which is used as the value for the "places.database.lastMaintenance" pref. (7258114800 seconds after 1970 is the start of the year 2200.) libpref stores integers prefs as int32_t and the current parser doesn't detect overflow. So this overflows to -1331819792. (I detected this with the new prefs parser from bug 1423840, which does detect integer overflow.) As a result the condition testing this pref in toolkit/components/places/PlacesCategoriesStarter.js ends up always succeeding in tests, which is the exact opposite of what was intended. This patch changes it to 2147483647 (the year 2038), the maximum int32_t value. (Note: this is much the same as bug 1424030, which was fixed recently.) MozReview-Commit-ID: AQw4b8tmE9u
1afdba933156fc334921e7924e5edca02050e295: Bug 1403334 - Make sure the property value overflow is indented. r=gl
Liam Hodgins <canada8715@gmail.com> - Wed, 31 Jan 2018 22:50:51 -0500 - rev 402039
Push 33360 by nbeleuzu@mozilla.com at Thu, 01 Feb 2018 10:06:21 +0000
Bug 1403334 - Make sure the property value overflow is indented. r=gl
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip