6518ca61dbd02714bc86d6dbdcec3826983d765e: Bug 1516028 - Don't allow a null originalDefaultEngine. r=daleharvey
Michael Kaply <mozilla@kaply.com> - Thu, 07 Feb 2019 21:14:17 +0000 - rev 457694
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1516028 - Don't allow a null originalDefaultEngine. r=daleharvey Differential Revision: https://phabricator.services.mozilla.com/D17879
58654f30db8e02f1776a1f3b5b158f206c35628e: Bug 1520103 - Fixed non-unified Profiler build - r=mstange
Gerald Squelart <gsquelart@mozilla.com> - Thu, 07 Feb 2019 17:35:37 +0000 - rev 457693
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1520103 - Fixed non-unified Profiler build - r=mstange Found issues by forcing a local non-unified build. Also sorted #includes by logical groups (from most local to most global), and alphabetically within groups. Depends on D18621 Differential Revision: https://phabricator.services.mozilla.com/D18622
8ec4da862bdcb832acac3beb6d7c496b27e01c53: Bug 1520103 - Added missing includes in nsNativeCharsetUtils.h - r=froydnj
Gerald Squelart <gsquelart@mozilla.com> - Tue, 05 Feb 2019 00:01:58 +0000 - rev 457692
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1520103 - Added missing includes in nsNativeCharsetUtils.h - r=froydnj Found when forcing a non-unified build of the Gecko Profiler: - "nsError.h" needed to define `nsresult`. - "nsStringFwd.h" needed to declare `nsAString` and `nsACString`. Differential Revision: https://phabricator.services.mozilla.com/D18621
33b3cd76b2062083e9ef266aed6b701bdca16b53: Bug 1525833 - nsISearchService::addEngine does not support using a callback anymore, instead it returns a Promise. Update the searchbar's usage to reflect this. r=florian
Mike de Boer <mdeboer@mozilla.com> - Thu, 07 Feb 2019 16:17:54 +0000 - rev 457691
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1525833 - nsISearchService::addEngine does not support using a callback anymore, instead it returns a Promise. Update the searchbar's usage to reflect this. r=florian This also officially gets rid of the nsIBrowserSearchInitObserver and nsISearchInstallCallback from nsISearchService.idl, even though they're not used for anything anymore. Differential Revision: https://phabricator.services.mozilla.com/D18993
12ad58f888883c60675245be607fb021b04952bf: Bug 1522249 - ARM64: Pass atomics/basic-tests.js. r=nbp
Sean Stangl <sean.stangl@gmail.com> - Thu, 07 Feb 2019 21:18:13 +0000 - rev 457690
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1522249 - ARM64: Pass atomics/basic-tests.js. r=nbp ARM64: Pass atomics/basic-tests.js. Reuses existing code paths. Differential Revision: https://phabricator.services.mozilla.com/D18278
0b0101621dcf610ebf9f5776812d12ae12cb266c: Bug 1525987: [taskgraph] Allow docker images to be indexed as build products; r=dustin
Tom Prince <mozilla@hocat.ca> - Thu, 07 Feb 2019 20:06:37 +0000 - rev 457689
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1525987: [taskgraph] Allow docker images to be indexed as build products; r=dustin This is useful for the out-of-tree taskgraph code. Downstream products can pin the generated decision task image by revision, rather than contents. Differential Revision: https://phabricator.services.mozilla.com/D19032
0e6997e8f36502c84bf2c73675b4baecfc4f3ab6: Bug 1525987: [taskgraph] Allow docker images to not be cached; r=dustin
Tom Prince <mozilla@hocat.ca> - Thu, 07 Feb 2019 21:02:13 +0000 - rev 457688
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1525987: [taskgraph] Allow docker images to not be cached; r=dustin This allows images to be built on every commit. This is useful for the out-of-tree taskgraph, that builds a docker image with the taskgraph code installed. Differential Revision: https://phabricator.services.mozilla.com/D19031
17c5a7677d9f2b5487f2eb297ee27bc903c00011: Bug 1496684 - Dispatch commonly expected startup notifications when opening a GeckoView window. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 07 Feb 2019 20:41:16 +0000 - rev 457687
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1496684 - Dispatch commonly expected startup notifications when opening a GeckoView window. r=snorp Once a webextension using a blocking WebRequest listener has started loading, all network connections covered by the extension's manifest are held until the extension is ready the process them. One condition for the extension being ready apparently includes browser startup having progressed far enough, as signified by "browser-delayed-startup-finished" having been dispatched. Therefore, we have to start sending that notification when opening a new Gecko- View window, too, and copy Fennec's InitLater() system for that. Unlike Fennec, we cannot tie registration of those InitLater() runnables to the initial content load having progressed far enough because of a) e10s, which makes that approach neither easily possible nor really sensible, as content will load in a different process in that case, and b) because we're racing with extension startup here - if extensions are loaded quick enough to block even the initial page load, we'd be deadlocked: We cannot send the notification until the page finishes loading, but the page cannot load until we send the notification. Fennec isn't affected by the latter problem because "sessionstore-windows-restored", which Fennec will send in any case, serves as an alternative pathway for completing extension startup. And unlike Desktop, we don't really have any chrome content to paint, so we cannot tie delayed initialisation to a paint listener for that, either. Therefore, we simply fire off a runnable at the *end* of geckoview.js's startup() method, which should give more pressing initialisation tasks enough of a headstart. For completeness, we're also adding the "browser-idle-startup-tasks-finished" notification and thereby solve bug 1465832 as well, allowing the ScriptPreloader to detect which scripts are commonly loaded during GeckoView startup and to start caching and pre-parsing them. Differential Revision: https://phabricator.services.mozilla.com/D18865
c7a0af90beb9d0a0bab586524501673d54d427ff: Bug 1524325 Remove AddonEvent.needsRestart r=bzbarsky,kmag
Andrew Swan <aswan@mozilla.com> - Thu, 07 Feb 2019 20:47:14 +0000 - rev 457686
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1524325 Remove AddonEvent.needsRestart r=bzbarsky,kmag We haven't supported addons that require restarts in some time and a bunch of the underlying support for this flag is already gone from the addons manager. The mozAddonManager api is one of the last vestiges, this patch rips it out. Differential Revision: https://phabricator.services.mozilla.com/D18745
2ceeee1915ae3b22686d347dfbc88d6c5f171e1e: Bug 1519472 - [taskgraph] Support generic-worker caches in run_task, r=tomprince
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 07 Feb 2019 20:36:42 +0000 - rev 457685
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1519472 - [taskgraph] Support generic-worker caches in run_task, r=tomprince This implements support for adding generic-worker caches. As a consequence this also turns on caching for the gecko checkout if present. Differential Revision: https://phabricator.services.mozilla.com/D17690
b6e19a5b0ab9df269111be1b3bed58cf8804aba4: Bug 1519472 - [ci] Opt out of caching for generic-worker based Windows builds, r=tomprince
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 07 Feb 2019 20:31:57 +0000 - rev 457684
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1519472 - [ci] Opt out of caching for generic-worker based Windows builds, r=tomprince The hosts don't have enough disk space to cache mozilla-central. Depends on D17689 Differential Revision: https://phabricator.services.mozilla.com/D18738
0b8097689bb5091b4add86f0763fccd021089fbd: Bug 1519472 - [taskgraph] Factor logic for adding a cache in job.common to a new function, r=tomprince
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 07 Feb 2019 20:32:15 +0000 - rev 457683
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1519472 - [taskgraph] Factor logic for adding a cache in job.common to a new function, r=tomprince We add caches at various places in common.py. This consolidates the logic into a re-useable function. This is in preparation for adding generic-worker cache support. This also adds a test. The test is not terribly useful, but I've been looking for an excuse to lay some groundwork for further tests in the 'job' submodule. This will do. Differential Revision: https://phabricator.services.mozilla.com/D17689
933722dee47bb2a80d4b4fd32966f97448c6c79c: Bug 1504157 - make onsize event triggered once; r=smaug
Liang-Heng Chen <xeonchen@gmail.com> - Thu, 07 Feb 2019 20:34:06 +0000 - rev 457682
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1504157 - make onsize event triggered once; r=smaug avoid the condition been checked twice. Differential Revision: https://phabricator.services.mozilla.com/D18961
f96c1460ffc09ef61bf3e2c93bfda21cdb86fb2f: Bug 1515746 - [flake8] Unsupport subdir .flake8 files and use new 'per-file-ignores' config instead, r=egao
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 07 Feb 2019 20:17:02 +0000 - rev 457681
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1515746 - [flake8] Unsupport subdir .flake8 files and use new 'per-file-ignores' config instead, r=egao This removes all .flake8 files except for the one at the root of the repo. Instead we use the new 'per-file-ignores' config introduced in 3.7. To ignore specific errors in a subdirectory, add a line like this to the root .flake8: [per-file-ignores] path/to/subdir/*: E100, F200, ... The reasons for this change are: 1. Unblock flake8 blacklist (bug 1367092). 2. Simplify configuration and code. 3. Encourage more consistent styling. 4. Improve performance. 5. Greater editor consistency. Differential Revision: https://phabricator.services.mozilla.com/D18354
3c7c50fba28399ae0d1a3812e5088cde55aacd8e: Bug 1515746 - [flake8] Upgrade flake8 and dependencies, r=egao
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 07 Feb 2019 20:16:45 +0000 - rev 457680
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1515746 - [flake8] Upgrade flake8 and dependencies, r=egao This bumps flake8 to version 3.7.5. This also ignores the new lint rules that were added in the new versions. These rules are de-marked via comment so we know that they should be enabled at some point (as opposed to the other rules that are (presumably) ignored intentionally. Differential Revision: https://phabricator.services.mozilla.com/D18353
ba9e0f7f49a3b4844122676de241dc2ce6671e22: Bug 1515746 - [lint] Remove duplicate flake8 implementation, r=egao
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 07 Feb 2019 20:16:36 +0000 - rev 457679
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1515746 - [lint] Remove duplicate flake8 implementation, r=egao Somehow we have two copies of the flake8 linter implementation: - tools/lint/python/__init__.py - tools/lint/python/flake8.py I'm not really sure how this happened, but the latter is the one that we use, so let's remove the former. It wasn't really affecting anything, though could have caused confusion to people looking to modify the lint integration. Differential Revision: https://phabricator.services.mozilla.com/D18352
2e1a490ab0e9caa8c8a8c5ea2796755c2c718425: Bug 1525812 - Specify the correct directory for reading update-settings.ini when staging updates in updater.cpp. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Thu, 07 Feb 2019 18:46:03 +0000 - rev 457678
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1525812 - Specify the correct directory for reading update-settings.ini when staging updates in updater.cpp. r=mhowell Specifies the install dir instead of the working dir for update-settings.ini New xpcshell test to verify the correct directory is specified for update-settings.ini Creates a precomplete and update-settings.ini file for mochitest-browser-chrome and mochitest-chrome tests Updated xpcshell tests to handle failure codes when staging in the update log file Differential Revision: https://phabricator.services.mozilla.com/D18924
828188fd32032c610c7a41c8a3651640df3bef28: Bug 1492629 - Drop ShutdownLoaders phase, move only user to ShutdownFinal. r=mccr8
Adrian Wielgosik <adrian.wielgosik@gmail.com> - Thu, 07 Feb 2019 18:23:04 +0000 - rev 457677
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1492629 - Drop ShutdownLoaders phase, move only user to ShutdownFinal. r=mccr8 The only difference between ShutdownLoaders and ShutdownFinal was an observer service shutdown. Differential Revision: https://phabricator.services.mozilla.com/D18389
b804c63247f528392ab97cc17da10a28d6186266: Bug 1492629 - de-COM mozJSComponentLoader. r=mccr8
Adrian Wielgosik <adrian.wielgosik@gmail.com> - Wed, 06 Feb 2019 23:52:57 +0000 - rev 457676
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1492629 - de-COM mozJSComponentLoader. r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D18388
45fe8012bb583950b022e9c30e00e6399fabaa83: Bug 1519037 - Filter out objects that is about to be finalized when iterating for non-GC purpose. r=pbone
Tooru Fujisawa <arai_a@mac.com> - Fri, 08 Feb 2019 02:39:12 +0000 - rev 457675
Push 35517 by opoprus@mozilla.com at Fri, 08 Feb 2019 09:49:17 +0000
Bug 1519037 - Filter out objects that is about to be finalized when iterating for non-GC purpose. r=pbone Differential Revision: https://phabricator.services.mozilla.com/D18845
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip