629deef4613c09a0f081fc804507355b250aab77: Bug 1499049 - (Part 8) Clear the changes store when about to navigate to a new page; r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Thu, 25 Oct 2018 08:07:40 +0000 - rev 443108
Push 34939 by nerli@mozilla.com at Fri, 26 Oct 2018 15:47:55 +0000
Bug 1499049 - (Part 8) Clear the changes store when about to navigate to a new page; r=pbro Depends on D9257 We need to clear the store of previous changes but we should not remove references and event listeners to the ChangesActor since the DevTools session is still active. MozReview-Commit-ID: Okp2CcSlfw Differential Revision: https://phabricator.services.mozilla.com/D9659
c4f23d37432644acf51200bb418a5029e66b0a68: Bug 1499049 - (Part 7) Fix issues with toggled and renamed CSS declarations r=pbro;
Razvan Caliman <rcaliman@mozilla.com> - Thu, 25 Oct 2018 11:07:29 +0000 - rev 443107
Push 34939 by nerli@mozilla.com at Fri, 26 Oct 2018 15:47:55 +0000
Bug 1499049 - (Part 7) Fix issues with toggled and renamed CSS declarations r=pbro; Depends on D8967 This patch fixes an issue where toggling a new CSS declaration OFF then back ON would make the Changes panel lose track of its existence. This happened because tracked changes don't have context about "disabled" state, only "add" or "remove", like diffs. Additionally, this patch fixes the case where renaming a property would erroneously track two distinct operations (rename + add). To fix this, we prevent the inline editor for the property name from the CSS Rules view to advance and focus the property value, which then immediately blurred triggering a fake second operation to be tracked. Auto-advancing to the property value inline editor still works if adding a new declaration or if the property name ends with a colon, ":", therefore old behaviour is not lost. MozReview-Commit-ID: Faw2DeCJJYk Differential Revision: https://phabricator.services.mozilla.com/D9257
f7565ed1376dc6cc9ffa6b9f054a9a4aeaa2f480: Bug 1499049 - (Part 6) Support !important in changed CSS property values; r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Thu, 25 Oct 2018 11:06:56 +0000 - rev 443106
Push 34939 by nerli@mozilla.com at Fri, 26 Oct 2018 15:47:55 +0000
Bug 1499049 - (Part 6) Support !important in changed CSS property values; r=pbro Depends on D8722 Include the "!importat" priority flag when tracking changes to CSS declarations. Differential Revision: https://phabricator.services.mozilla.com/D8967
0b04c98133b3d22225d8aeb7c4df325ccaa0fea3: Bug 1499049 - (Part 5) Refactor Changes panel to render diff of nested CSS rule structures; r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Thu, 25 Oct 2018 13:42:05 +0000 - rev 443105
Push 34939 by nerli@mozilla.com at Fri, 26 Oct 2018 15:47:55 +0000
Bug 1499049 - (Part 5) Refactor Changes panel to render diff of nested CSS rule structures; r=pbro Depends on D8721 - Externalize reusable CSSDeclaration React component; - Introduce the ability to render rules with unlimited levels of nesting, but cap indentation in the UI at a reasonable level; - Remove accordion behavior from rules, but keep for sources; - Cleanup CSS styles for Changes panel. Differential Revision: https://phabricator.services.mozilla.com/D8722
578d839f3c6c472b43b0fc9b4753549ebdb9ccb3: Bug 1499049 - (Part 4) Remove tracked rules and sources that end up unchanged; r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Thu, 25 Oct 2018 11:05:55 +0000 - rev 443104
Push 34939 by nerli@mozilla.com at Fri, 26 Oct 2018 15:47:55 +0000
Bug 1499049 - (Part 4) Remove tracked rules and sources that end up unchanged; r=pbro Depends on D8720 If all of the changes to a CSS rule cancel each other out, remove the information about the rule from the Redux store. If none of the rules in a source end up changed, remove the information about the source form the Redux store. This ensures the Changes panel only shows actual diffs and not empty signatures of rules which were changed but the sum of their changes means nothing really changed. MozReview-Commit-ID: 4n9yRkFdmN4 Differential Revision: https://phabricator.services.mozilla.com/D8721
90491f2fdf3db959f918b6419f013c2f887f17a7: Bug 1499049 - (Part 3) Add new reducer logic for tracking CSS changes to nested rules; r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Thu, 25 Oct 2018 16:20:00 +0000 - rev 443103
Push 34939 by nerli@mozilla.com at Fri, 26 Oct 2018 15:47:55 +0000
Bug 1499049 - (Part 3) Add new reducer logic for tracking CSS changes to nested rules; r=pbro Depends on D8719 - Add methods to generate unique identifiers for stylesheets and CSS rules changed within those stylesheets. These are used as IDs in the Redux store; - Add logic to generate entries in the store for each one of the rule's ancestors and assign parent/child dependencies. This single-level structure for all rules in a source helps with quickly identifying a rule on subsequent changes independent of its rule tree (it avoids needless tree traversal). The parent/child references help with rendering of the nested rule structure in the Changes panel; - Deep clone Redux store state before aggregating tracked changes (no more mutations of previous state). Differential Revision: https://phabricator.services.mozilla.com/D8720
1d612a71f940facc02938a5666e68f56902e8022: Bug 1499049 - (Part 2) Remove old reducer logic for tracking CSS changes; r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Thu, 25 Oct 2018 13:21:38 +0000 - rev 443102
Push 34939 by nerli@mozilla.com at Fri, 26 Oct 2018 15:47:55 +0000
Bug 1499049 - (Part 2) Remove old reducer logic for tracking CSS changes; r=pbro Depends on D8718 Opting to first completely remove, then add the new logic, otherwise the diff gets very confusing since most of the code changed MozReview-Commit-ID: BbncSBhD5py Differential Revision: https://phabricator.services.mozilla.com/D8719
d476c9f67f34f5e89a6600baedb64711883193dc: Bug 1499049 - (Part 1) Log ancestor rule tree for changes to CSS declarations; r=pbro
Razvan Caliman <rcaliman@mozilla.com> - Wed, 24 Oct 2018 17:43:33 +0000 - rev 443101
Push 34939 by nerli@mozilla.com at Fri, 26 Oct 2018 15:47:55 +0000
Bug 1499049 - (Part 1) Log ancestor rule tree for changes to CSS declarations; r=pbro ⚠️ **To build locally, this change series depends on the [change series](https://phabricator.services.mozilla.com/D4399) which adds the ChangesActor**. 🏋️‍♂️ **To test hands-on, you can download a [custom macOS build](https://queue.taskcluster.net/v1/task/HIiZcwLXTuuSYYjfwEDmmA/runs/0/artifacts/public/build/target.dmg) (updated Wed, Oct 24) which includes both change series.** - Introduce ancestorRules getter to StyleRuleActor to get a flattened rule tree with the ancestors of the current rule; - Introduce CSSRuleTypeName to css-logic helpers to map between CSS rule type and human-readable name; - Log rule index position with each CSS declaration change to help differentiate between changes to rules with identical selectors at the same level of nesting. Differential Revision: https://phabricator.services.mozilla.com/D8718
8d38810fdc7309de2520fb9b36abbb09767a4bee: Bug 1497526 - TransactionTooLargeException when downloading from Data URLs; r=jchen
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 26 Oct 2018 07:39:01 +0000 - rev 443100
Push 34939 by nerli@mozilla.com at Fri, 26 Oct 2018 15:47:55 +0000
Bug 1497526 - TransactionTooLargeException when downloading from Data URLs; r=jchen The issue stems from putting download's source url as `cookie` in the pending intent for when the download notification is clicked. This cookie functions like a tag, allowing to identify a particular download. The problem is that a download's url can be a Data URL for which Mozilla imposes no size limit. When an Android Intent with that payload is used it counts against Binder's 1MB limit which can result in the TransactionTooLargeException. If we are to truncate download's source url to an arbitrary length of 100 we should still get a unique `cookie` for that download and at the same time avoid cluttering Notification's contentIntent. Differential Revision: https://phabricator.services.mozilla.com/D9666
095cb0042729b07598ca8139eb30284c5a564024: Bug 1500138 - Remove browser.urlbar.matchBehavior and some unused Address Bar behaviors. r=adw
Marco Bonardo <mbonardo@mozilla.com> - Thu, 25 Oct 2018 23:23:36 +0000 - rev 443099
Push 34939 by nerli@mozilla.com at Fri, 26 Oct 2018 15:47:55 +0000
Bug 1500138 - Remove browser.urlbar.matchBehavior and some unused Address Bar behaviors. r=adw Remove browser.urlbar.matchBehavior pref. Remove code for BEGINNING behaviors, and stop referencing MATCH_BOUNDARY_ANYWHERE from our code. Differential Revision: https://phabricator.services.mozilla.com/D9806
eaf542a7bdb119fdb0585e149e4827eed185b456: Bug 1501113 Disable local partials caching to work around races r=aki
Simon Fraser <sfraser@mozilla.com> - Thu, 25 Oct 2018 18:57:22 +0000 - rev 443098
Push 34939 by nerli@mozilla.com at Fri, 26 Oct 2018 15:47:55 +0000
Bug 1501113 Disable local partials caching to work around races r=aki Differential Revision: https://phabricator.services.mozilla.com/D9628
44cd913c18f8f185a8b5ad3aad6a34b26c947cae: Bug 1492607 - Part 3: Exempting the check of OAs for postMessage with the target origin is '*' if it is coming from the system principal r=baku
Tim Huang <tihuang@mozilla.com> - Fri, 26 Oct 2018 07:13:25 +0000 - rev 443097
Push 34939 by nerli@mozilla.com at Fri, 26 Oct 2018 15:47:55 +0000
Bug 1492607 - Part 3: Exempting the check of OAs for postMessage with the target origin is '*' if it is coming from the system principal r=baku It turns out that many tests are going to post Messages to content from chrome with a mismatched OA. This patch exempt the check in that case. Depends on D8522 Differential Revision: https://phabricator.services.mozilla.com/D9753
0b4b3d826b3f5cacbf554d1da07408bca0660a07: Bug 1492607 - Part 2: Add a test case for assuring postMessage cannot post across OAs r=arthuredelstein,baku
Tim Huang <tihuang@mozilla.com> - Thu, 25 Oct 2018 06:47:18 +0000 - rev 443096
Push 34939 by nerli@mozilla.com at Fri, 26 Oct 2018 15:47:55 +0000
Bug 1492607 - Part 2: Add a test case for assuring postMessage cannot post across OAs r=arthuredelstein,baku This test case will turn on the first party isolation and try to open two tabs that the first tab is the opener of the second tab. It will test for different settings and making sure that postMessage cannot go across with the targetOrigin '*' for different FPDs when the pref 'privacy.firstparty.isolate.block_post_message' is enabled. Depends on D8521 Differential Revision: https://phabricator.services.mozilla.com/D8522
dfc3795ef568e5236301d0fb9e864c58fe5f63e6: Bug 1492607 - Part 1: Making postMessage to be aware of OAs when the targetOrigin is "*." r=arthuredelstein,baku
Tim Huang <tihuang@mozilla.com> - Thu, 25 Oct 2018 06:47:08 +0000 - rev 443095
Push 34939 by nerli@mozilla.com at Fri, 26 Oct 2018 15:47:55 +0000
Bug 1492607 - Part 1: Making postMessage to be aware of OAs when the targetOrigin is "*." r=arthuredelstein,baku This patch adds a MOZ_DIAGNOSTIC_ASSERT for assuring the OAs are matching when the targetOrigin is "*" for the postMessage(). But it ignores the FPD in OA since the FPDs are possible to be different. We also add a new pref 'privacy.firstparty.isolate.block_post_message' for allowing blocking postMessage across different FPDs. Differential Revision: https://phabricator.services.mozilla.com/D8521
f1a13ca79a5dbf5cfef03097748ed281de7cd168: Bug 1468320 - Fix preferences search to work well with tooltips. r=johannh
prathiksha <prathikshaprasadsuman@gmail.com> - Wed, 24 Oct 2018 15:21:42 +0000 - rev 443094
Push 34939 by nerli@mozilla.com at Fri, 26 Oct 2018 15:47:55 +0000
Bug 1468320 - Fix preferences search to work well with tooltips. r=johannh Fix preferences search to work well with tooltips. Differential Revision: https://phabricator.services.mozilla.com/D9486
e4759dfa794a9693a49382fe5c96f2d9b2a381be: Bug 1501811 - Remove livemarks support from browserPlacesViews/treeView. r=mak
Mark Banner <standard8@mozilla.com> - Fri, 26 Oct 2018 07:40:15 +0000 - rev 443093
Push 34939 by nerli@mozilla.com at Fri, 26 Oct 2018 15:47:55 +0000
Bug 1501811 - Remove livemarks support from browserPlacesViews/treeView. r=mak Differential Revision: https://phabricator.services.mozilla.com/D9701
700e65c0ab9bb8ec1182b890bd51722b95eb0f24: Backed out changeset 444ecc63baf3 (bug 1480006) for crashes on Android (bug 1489553). a=backout
Margareta Eliza Balazs <ebalazs@mozilla.com> - Fri, 26 Oct 2018 14:37:30 +0300 - rev 443092
Push 34938 by ebalazs@mozilla.com at Fri, 26 Oct 2018 11:37:41 +0000
Backed out changeset 444ecc63baf3 (bug 1480006) for crashes on Android (bug 1489553). a=backout
9d294202030e9426769682c2901fe95503868b2b: Backed out changeset 70b12731ca43 (bug 1483190) for crashes on Android (bug 1489553) a=backout
Margareta Eliza Balazs <ebalazs@mozilla.com> - Fri, 26 Oct 2018 14:36:09 +0300 - rev 443091
Push 34938 by ebalazs@mozilla.com at Fri, 26 Oct 2018 11:37:41 +0000
Backed out changeset 70b12731ca43 (bug 1483190) for crashes on Android (bug 1489553) a=backout
2db84dbb7f99acbe326b372d03be97620b27fba0: Backed out changeset aea0e7fadf7d (bug 1502002)for ES lint failure on components/FlexItemSizingOutline.js "CLOSED TREE"
arthur.iakab <aiakab@mozilla.com> - Fri, 26 Oct 2018 10:11:45 +0300 - rev 443090
Push 34937 by nerli@mozilla.com at Fri, 26 Oct 2018 09:49:07 +0000
Backed out changeset aea0e7fadf7d (bug 1502002)for ES lint failure on components/FlexItemSizingOutline.js "CLOSED TREE"
4579afb8b513704a4c668ebcf774dac31b25ab04: Bug 1502076 - Part 2: Remove the fastblock UI from the Control Centre r=johannh
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 26 Oct 2018 06:55:20 +0000 - rev 443089
Push 34937 by nerli@mozilla.com at Fri, 26 Oct 2018 09:49:07 +0000
Bug 1502076 - Part 2: Remove the fastblock UI from the Control Centre r=johannh Depends on D9794 Differential Revision: https://phabricator.services.mozilla.com/D9795
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip