60668e84331f40ff3185d658a33d91ae89fa2dad: Bug 1504464 - Part 11: Remaining random changes. r=jwalden
Jason Orendorff <jorendorff@mozilla.com> - Mon, 14 Jan 2019 20:36:08 +0000 - rev 453822
Push 35374 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:37:11 +0000
Bug 1504464 - Part 11: Remaining random changes. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D14509
956a058f383c93234f7bb01656afbb67a077386a: Bug 1504464 - Part 10: Rename a local variable to follow the `unwrapped` convention. r=jwalden
Jason Orendorff <jorendorff@mozilla.com> - Mon, 14 Jan 2019 20:35:37 +0000 - rev 453821
Push 35374 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:37:11 +0000
Bug 1504464 - Part 10: Rename a local variable to follow the `unwrapped` convention. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D14508
b07b0b1afe6600cd07a46f66ba25b73320c72a68: Bug 1504464 - Part 9: Rename function that implements ReadableStreamControllerCanCloseOrEnqueue. r=jwalden
Jason Orendorff <jorendorff@mozilla.com> - Mon, 14 Jan 2019 20:35:17 +0000 - rev 453820
Push 35374 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:37:11 +0000
Bug 1504464 - Part 9: Rename function that implements ReadableStreamControllerCanCloseOrEnqueue. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D14507
3ff6421bac545fc4abd1fbe35f20e521c9fd4ec2: Bug 1504464 - Part 8: Rename the handler called when a tee'd stream becomes errored. r=jwalden
Jason Orendorff <jorendorff@mozilla.com> - Mon, 14 Jan 2019 20:35:12 +0000 - rev 453819
Push 35374 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:37:11 +0000
Bug 1504464 - Part 8: Rename the handler called when a tee'd stream becomes errored. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D14506
8a450893e90a2b4fb9e8fdc5328e6622026ad6eb: Bug 1504464 - Part 7: Stop using GetPropertyPure in Streams.cpp. r=jwalden
Jason Orendorff <jorendorff@mozilla.com> - Mon, 14 Jan 2019 20:35:08 +0000 - rev 453818
Push 35374 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:37:11 +0000
Bug 1504464 - Part 7: Stop using GetPropertyPure in Streams.cpp. r=jwalden No change in behavior that I'm aware of. It should be correct either way, since the object is guaranteed to be an object created just so by code elsewhere in the Streams implementation. But the intended purpose of GetPropertyPure is in a fast path, backstopped by an actual GetProperty, not for cases like this. Differential Revision: https://phabricator.services.mozilla.com/D14505
7afcd486bdc615bbdca8a9afd432c61299441a4b: Bug 1504464 - Part 6: Rearrange control flow in ReadableStream_getReader slightly to resemble the standard steps. r=jwalden
Jason Orendorff <jorendorff@mozilla.com> - Mon, 14 Jan 2019 20:33:30 +0000 - rev 453817
Push 35374 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:37:11 +0000
Bug 1504464 - Part 6: Rearrange control flow in ReadableStream_getReader slightly to resemble the standard steps. r=jwalden No change in behavior. Differential Revision: https://phabricator.services.mozilla.com/D14504
de74494a1aa7ddfbc6a6475b8e2c3a91eba4dad9: Bug 1504464 - Part 5: Fix destructuring behavior in ReadableStream.prototype.getReader. r=jwalden
Jason Orendorff <jorendorff@mozilla.com> - Mon, 14 Jan 2019 20:33:01 +0000 - rev 453816
Push 35374 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:37:11 +0000
Bug 1504464 - Part 5: Fix destructuring behavior in ReadableStream.prototype.getReader. r=jwalden The section headers in the spec that look like JS destructuring are in fact normative. The methods have to behave just like JS destructuring; see <https://streams.spec.whatwg.org/#conventions> for details. This means the getReader method <https://streams.spec.whatwg.org/#rs-get-reader> must do a full property Get for options.mode, even if that means querying %ObjectPrototype%, absurd as it sounds. Differential Revision: https://phabricator.services.mozilla.com/D14503
d35260c2032c61c08e1e9af2f5f9fda142097de8: Bug 1504464 - Part 4: Comment-only changes. r=jwalden
Jason Orendorff <jorendorff@mozilla.com> - Mon, 14 Jan 2019 20:32:31 +0000 - rev 453815
Push 35374 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:37:11 +0000
Bug 1504464 - Part 4: Comment-only changes. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D14499
0030c59cdea424b2f7a4dd77a83b9ba5d4b71dd4: Bug 1504464 - Part 3: Update CreateExternalReadableByteStreamController to the current standard. r=jwalden
Jason Orendorff <jorendorff@mozilla.com> - Mon, 14 Jan 2019 20:31:55 +0000 - rev 453814
Push 35374 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:37:11 +0000
Bug 1504464 - Part 3: Update CreateExternalReadableByteStreamController to the current standard. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D14498
d087b9c8c3891aac295ca973277ffd37e7fe2daa: Bug 1504464 - Part 2: Mark reader.[[closedPromise]] as handled in reader.releaseLock(). r=jwalden
Jason Orendorff <jorendorff@mozilla.com> - Mon, 14 Jan 2019 20:31:29 +0000 - rev 453813
Push 35374 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:37:11 +0000
Bug 1504464 - Part 2: Mark reader.[[closedPromise]] as handled in reader.releaseLock(). r=jwalden In this case, it's likely the user doesn't see this as an error at all. Differential Revision: https://phabricator.services.mozilla.com/D14497
72b109d30535050adb88689314d01bad4ac3aea6: Bug 1504464 - Part 1: Mark reader.[[closedPromise]] as handled when creating a reader for an already-errored stream. r=jwalden
Jason Orendorff <jorendorff@mozilla.com> - Mon, 14 Jan 2019 20:30:56 +0000 - rev 453812
Push 35374 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:37:11 +0000
Bug 1504464 - Part 1: Mark reader.[[closedPromise]] as handled when creating a reader for an already-errored stream. r=jwalden I don't know why it's OK to drop this particular error; my guess is that the error was already reported previously, when the stream became errored, and there's no point reporting it again. Differential Revision: https://phabricator.services.mozilla.com/D14496
848d8e9a1f031827544f0c14c7c018fdcde6c774: Bug 1519461 - Don't return values from docShellIsActive, renderLayers, and userTypedValue setters;r=mconley
Brian Grinstead <bgrinstead@mozilla.com> - Mon, 14 Jan 2019 20:36:25 +0000 - rev 453811
Push 35374 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:37:11 +0000
Bug 1519461 - Don't return values from docShellIsActive, renderLayers, and userTypedValue setters;r=mconley This is more consistent with other setters, and lets us handle the null frameLoader case a bit more simply. Differential Revision: https://phabricator.services.mozilla.com/D16370
e00e03df2c6b67ddb2be816cca1be77d5b3ef25d: Bug 1519461 - Unify the hasLayers getter to use the same frameLoader check as renderLayers and docShellIsActive;r=mconley
Brian Grinstead <bgrinstead@mozilla.com> - Mon, 14 Jan 2019 20:36:23 +0000 - rev 453810
Push 35374 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:37:11 +0000
Bug 1519461 - Unify the hasLayers getter to use the same frameLoader check as renderLayers and docShellIsActive;r=mconley Differential Revision: https://phabricator.services.mozilla.com/D16369
c036c740fbbc3e0fb8a4270ef029aaa160d30c9a: Bug 1519461 - Check for frameLoader existence before accessing it in docShellIsActive;r=mconley
Brian Grinstead <bgrinstead@mozilla.com> - Mon, 14 Jan 2019 20:36:16 +0000 - rev 453809
Push 35374 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:37:11 +0000
Bug 1519461 - Check for frameLoader existence before accessing it in docShellIsActive;r=mconley Alternatively, we could check for mInitialized in `AsyncTabSwitcher.logState` before accessing the getter. But this matches an existing pattern for other browser getters that rely on the frameLoader existing, and will support other callers that hit this case. Differential Revision: https://phabricator.services.mozilla.com/D16368
36ec37a680354b2a1fb3b2232f24a65172d71962: Bug 1516660 - Add pattern encryption params to GMP IPDL and plumb to the CDM. r=cpearce
Bryce Van Dyk <bvandyk@mozilla.com> - Mon, 14 Jan 2019 20:24:57 +0000 - rev 453808
Push 35374 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:37:11 +0000
Bug 1516660 - Add pattern encryption params to GMP IPDL and plumb to the CDM. r=cpearce Note, we only pass the relevant IV across the IPC boundry. I.e. if the crypto scheme is cenc we do not pass a constant IV (this is only used by cbcs), and only pass per sample IVs. For cbcs we do the converse. This means in the CDM child we're only receiving one IV, which should be appropriate for whatever scheme (this is similar to how Chromium handle IVs being passed to the CDM). The CDM child side now writes pattern information to samples it's preparing for CDM. With these changes we should be passing all the information required to handle cbcs to the CDM. Differential Revision: https://phabricator.services.mozilla.com/D16459
1cf230625662499e8c2d0315cfa9d7cd161e1a48: Bug 1519968 - [mach] Minor improvements to autocomplete docs, r=jmaher
Andrew Halberstadt <ahalberstadt@mozilla.com> - Mon, 14 Jan 2019 19:43:53 +0000 - rev 453807
Push 35374 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:37:11 +0000
Bug 1519968 - [mach] Minor improvements to autocomplete docs, r=jmaher Differential Revision: https://phabricator.services.mozilla.com/D16495
1ce15a2a79e08b2b8803d42b06476d5b101111d0: Bug 1317416 - GetPrototypeFromConstructor needs to retrieve the fallback prototype from the constructor's realm. r=jandem
Jason Orendorff <jorendorff@mozilla.com> - Mon, 14 Jan 2019 20:19:09 +0000 - rev 453806
Push 35374 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:37:11 +0000
Bug 1317416 - GetPrototypeFromConstructor needs to retrieve the fallback prototype from the constructor's realm. r=jandem Differential Revision: https://phabricator.services.mozilla.com/D14907
54c6397bb3844b170f930425188003d2d35b126a: Bug 1518648 - Tighten up a couple of assertions. r=jwalden
Jason Orendorff <jorendorff@mozilla.com> - Mon, 14 Jan 2019 20:04:28 +0000 - rev 453805
Push 35374 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:37:11 +0000
Bug 1518648 - Tighten up a couple of assertions. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D15991
3b55c65ded33d50a48b0284f0b9e0c7b8b0188ac: Bug 1514016 - Check that all events are fired as expected for MediaRecorder-stop.html. r=jib
Andreas Pehrson <apehrson@mozilla.com> - Mon, 14 Jan 2019 18:32:58 +0000 - rev 453804
Push 35374 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:37:11 +0000
Bug 1514016 - Check that all events are fired as expected for MediaRecorder-stop.html. r=jib Differential Revision: https://phabricator.services.mozilla.com/D15912
b7b6a2978011a99cb8b65deb73b293a52fd13874: Bug 1514016 - Check that MediaRecorder::Stop is idempotent. r=jib
Andreas Pehrson <apehrson@mozilla.com> - Mon, 14 Jan 2019 18:32:57 +0000 - rev 453803
Push 35374 by cbrindusan@mozilla.com at Tue, 15 Jan 2019 04:37:11 +0000
Bug 1514016 - Check that MediaRecorder::Stop is idempotent. r=jib Differential Revision: https://phabricator.services.mozilla.com/D15911
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip