5f61649cdc967a95fccb1b13d8beaf6f97811ee5: Bug 1451672 - part 5: Rename EditorBase::JoinNodes() and related methods with "WithTransaction" postfix r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 10 Apr 2018 03:46:44 +0900 - rev 414825
Push 33878 by apavel@mozilla.com at Sat, 21 Apr 2018 09:30:31 +0000
Bug 1451672 - part 5: Rename EditorBase::JoinNodes() and related methods with "WithTransaction" postfix r=m_kato This patch renames: EditorBase::JoinNodes() -> EditorBase::JoinNodesWithTransaction() EditorBase::JoinNodeDeep() -> EditorBase::JoinNodesDeepWithTransaction() HTMLEditRules::JoinNodesSmart() -> HTMLEditRules::JoinNearestEditableNodesWithTransaction() HTMLEditRules::TryToJoinBlocks() -> HTMLEditRules::TryToJoinBlocksWithTransaction() MozReview-Commit-ID: Ao16GhAcyIZ
1f538ba260f81864adfee97c14b81a03e032f275: Bug 1451672 - part 4: Rename EditorBase::SplitNodeImpl() to EditorBase::DoSplitNode() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 10 Apr 2018 02:32:33 +0900 - rev 414824
Push 33878 by apavel@mozilla.com at Sat, 21 Apr 2018 09:30:31 +0000
Bug 1451672 - part 4: Rename EditorBase::SplitNodeImpl() to EditorBase::DoSplitNode() r=m_kato EditorBase::SplitNodeImpl() is called by SplitNodeTransaction::DoTransaction() for actually splitting a node. However, "WithoutTransaction" postfix is really redundant. Perhaps, just naming DoSplitNode() is better since "Impl" isn't unclear and not useful if somebody wants to use it as a utility method and there has already been EditorBase::SplitNode() which is an override of nsIEditor::SplitNode(). It must not be good to use same name for different purpose (EditorBase::SplitNode() creates a transaction). MozReview-Commit-ID: Akjeyp52vVv
6c75071ac1bb3dd1cf36f479fdee7e1c56c4723d: Bug 1451672 - part 3: Rename EditorBase::SplitNode() and related methods to ending with "WithTransaction" r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 10 Apr 2018 02:16:49 +0900 - rev 414823
Push 33878 by apavel@mozilla.com at Sat, 21 Apr 2018 09:30:31 +0000
Bug 1451672 - part 3: Rename EditorBase::SplitNode() and related methods to ending with "WithTransaction" r=m_kato This patch renames: EditorBase::SplitNode() -> EditorBase::SplitNodeWithTransaction() EditorBase::SplitNodeDeep() -> EditorBase::SplitNodeDeepWithTransaction() HTMLEditRules::MaybeSplitAncestorsForInsert() -> HTMLEditRules::MaybeSplitAncestorsForInsertWithTransaction() Note it might be that some callers of those methods should be renamed too. However, we should do it in follow up bug after landing those patches since we can investigate it with searchfox.org after landing patches. MozReview-Commit-ID: FfxCfaI85z5
ef997456c777746bce4b47fed65230ea64fae64e: Bug 1451672 - part 2: Rename EditorBase::InsertNode() to EditorBase::InsertNodeWithTransaction() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 10 Apr 2018 01:34:29 +0900 - rev 414822
Push 33878 by apavel@mozilla.com at Sat, 21 Apr 2018 09:30:31 +0000
Bug 1451672 - part 2: Rename EditorBase::InsertNode() to EditorBase::InsertNodeWithTransaction() r=m_kato MozReview-Commit-ID: 4n5EVvUKrux
16bc145641f907a78b3ac60b5f128292d1f6bfb0: Bug 1451672 - part 1: Rename EditorBase::CreateNode() to EditorBase::CreateNodeWithTransaction() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 10 Apr 2018 01:17:26 +0900 - rev 414821
Push 33878 by apavel@mozilla.com at Sat, 21 Apr 2018 09:30:31 +0000
Bug 1451672 - part 1: Rename EditorBase::CreateNode() to EditorBase::CreateNodeWithTransaction() r=m_kato EditorBase::CreateNode() creates an element node with transaction. I.e., it's undoable. So, if somebody would use this method as a helper method for changing the DOM tree, that would cause unexpected undoable transaction. So, we should make the method name clearer to avoid such bug. MozReview-Commit-ID: GZsOGBfqog
daaa0c840a9fb865971d59b4c5ba90d25f8cf42a: Backed out changeset 2dad6e7f5092 (bug 1353631) for XPCShell failures on devtools/shared/tests/unit/test_css-properties-db.js
Dorel Luca <dluca@mozilla.com> - Sat, 21 Apr 2018 06:57:36 +0300 - rev 414820
Push 33878 by apavel@mozilla.com at Sat, 21 Apr 2018 09:30:31 +0000
Backed out changeset 2dad6e7f5092 (bug 1353631) for XPCShell failures on devtools/shared/tests/unit/test_css-properties-db.js
8e02766aa3bc7d75dbe4a65a69960e92aa204af9: Backed out 2 changesets (bug 1454864) as requested by dev kitcambridge
Dorel Luca <dluca@mozilla.com> - Sat, 21 Apr 2018 05:07:55 +0300 - rev 414819
Push 33878 by apavel@mozilla.com at Sat, 21 Apr 2018 09:30:31 +0000
Backed out 2 changesets (bug 1454864) as requested by dev kitcambridge Backed out changeset b497152c37e8 (bug 1454864) Backed out changeset 93eea5f99ab7 (bug 1454864)
2dad6e7f5092b3f52625bc339eb584f7d97163be: Bug 1353631: Set preference default to true in Nightly for layout.css.shape-outside.enabled. r=dholbert
Brad Werth <bwerth@mozilla.com> - Fri, 20 Apr 2018 15:56:05 -0700 - rev 414818
Push 33878 by apavel@mozilla.com at Sat, 21 Apr 2018 09:30:31 +0000
Bug 1353631: Set preference default to true in Nightly for layout.css.shape-outside.enabled. r=dholbert MozReview-Commit-ID: 5L6FCfLWM3E
434e9f18678ce97a0782c73eba1351b0b8216fa4: Merge mozilla-central to autoland. CLOSED TREE
Dorel Luca <dluca@mozilla.com> - Sat, 21 Apr 2018 04:54:41 +0300 - rev 414817
Push 33878 by apavel@mozilla.com at Sat, 21 Apr 2018 09:30:31 +0000
Merge mozilla-central to autoland. CLOSED TREE
e56c4c3f751fdf9ccbb60242e7aba379142dfb8f: Bug 1454931 - Display help screen when no service worker is available;r=sole
Julian Descottes <jdescottes@mozilla.com> - Mon, 19 Mar 2018 18:55:22 +0100 - rev 414816
Push 33878 by apavel@mozilla.com at Sat, 21 Apr 2018 09:30:31 +0000
Bug 1454931 - Display help screen when no service worker is available;r=sole MozReview-Commit-ID: JDPX45YIkrB
b2174d5770ef7e79c958349fa04225c5ea4926ad: Merge mozilla-central to autoland
Dorel Luca <dluca@mozilla.com> - Sat, 21 Apr 2018 02:03:27 +0300 - rev 414815
Push 33878 by apavel@mozilla.com at Sat, 21 Apr 2018 09:30:31 +0000
Merge mozilla-central to autoland
953065718894941b5f4718f1767861716d79b37a: Bug 1399985. Add build ID and update channel to WebCompatReporter details param. r=Gijs
Mike Taylor <miket@mozilla.com> - Mon, 16 Apr 2018 18:20:27 -0500 - rev 414814
Push 33878 by apavel@mozilla.com at Sat, 21 Apr 2018 09:30:31 +0000
Bug 1399985. Add build ID and update channel to WebCompatReporter details param. r=Gijs MozReview-Commit-ID: HHok94kGFfe
5d2486077e4b1c7fd0fb059d38cb1b0733b96845: Bug 1455216 - Add download Highlights, Highlights options and bug fixes to Activity Stream. r=ursula
Ed Lee <edilee@mozilla.com> - Fri, 20 Apr 2018 14:08:59 -0700 - rev 414813
Push 33878 by apavel@mozilla.com at Sat, 21 Apr 2018 09:30:31 +0000
Bug 1455216 - Add download Highlights, Highlights options and bug fixes to Activity Stream. r=ursula MozReview-Commit-ID: EqgiQamoB3f
6225ece1cd5c51074488ee4997dd57abaec7b2a0: Backed out changeset 42f5c08a4d86 (bug 1399985) on request from miketaylr
Sebastian Hengst <archaeopteryx@coole-files.de> - Sat, 21 Apr 2018 01:44:52 +0300 - rev 414812
Push 33878 by apavel@mozilla.com at Sat, 21 Apr 2018 09:30:31 +0000
Backed out changeset 42f5c08a4d86 (bug 1399985) on request from miketaylr
b041e24789f9656580976e54470b433d781f9f87: Bug 1446019 - Improve error message for LOCAL_INCLUDES pointing to topobjdir; r=froydnj
Gregory Szorc <gps@mozilla.com> - Thu, 15 Mar 2018 09:43:35 -0700 - rev 414811
Push 33878 by apavel@mozilla.com at Sat, 21 Apr 2018 09:30:31 +0000
Bug 1446019 - Improve error message for LOCAL_INCLUDES pointing to topobjdir; r=froydnj The old message is ambiguous as to why it failed. The new one tells you why and hopefully gives you enough info to fix it. MozReview-Commit-ID: 9cBpYLpCFmt
b0d116ec45465be143a9e3504efd9e6ea19c6c0c: Bug 1310630 - Pass a createLongStringClient prop to the ObjectInspector; r=bgrins,Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 16 Apr 2018 11:32:29 +0200 - rev 414810
Push 33878 by apavel@mozilla.com at Sat, 21 Apr 2018 09:30:31 +0000
Bug 1310630 - Pass a createLongStringClient prop to the ObjectInspector; r=bgrins,Honza. This will allow long strings to be expanded. Tests will be added per Bug 1403448. MozReview-Commit-ID: CUUN6uWTMDF
2ddb032c4520f9ca8dddfa655f72b2d1e8481890: Bug 1442542 - Make checkboxes in the clear site data dialog use a label attribute. r=dao,flod
Johann Hofmann <jhofmann@mozilla.com> - Tue, 17 Apr 2018 16:30:27 +0200 - rev 414809
Push 33878 by apavel@mozilla.com at Sat, 21 Apr 2018 09:30:31 +0000
Bug 1442542 - Make checkboxes in the clear site data dialog use a label attribute. r=dao,flod MozReview-Commit-ID: 9yj90NirV9y
40c5d3600d35e2d3df7a4f2ab75c64688ee7dc6d: Bug 1455737 - Remove the result object from DownloadHistory when removing the view r=Mardak
Ursula Sarracini <usarracini@mozilla.com> - Fri, 20 Apr 2018 16:57:07 -0400 - rev 414808
Push 33878 by apavel@mozilla.com at Sat, 21 Apr 2018 09:30:31 +0000
Bug 1455737 - Remove the result object from DownloadHistory when removing the view r=Mardak MozReview-Commit-ID: 5Qb5j30eqFO
42f5c08a4d86967ccd3df66c3fc3c30cc52c6497: Bug 1399985. Add build ID and update channel to WebCompatReporter details param. r=Gijs
Mike Taylor <miket@mozilla.com> - Mon, 16 Apr 2018 18:20:27 -0500 - rev 414807
Push 33878 by apavel@mozilla.com at Sat, 21 Apr 2018 09:30:31 +0000
Bug 1399985. Add build ID and update channel to WebCompatReporter details param. r=Gijs MozReview-Commit-ID: HHok94kGFfe
427e3dce92c2eec8fa9a167fef3f2a726b4010a6: Bug 1455680 - Notify document-element-inserted in XUL documents;r=bz
Brian Grinstead <bgrinstead@mozilla.com> - Fri, 20 Apr 2018 13:55:51 -0700 - rev 414806
Push 33878 by apavel@mozilla.com at Sat, 21 Apr 2018 09:30:31 +0000
Bug 1455680 - Notify document-element-inserted in XUL documents;r=bz We'll want to use this event to inject scripts before other scripts run in XUL documents. It already fires in HTML documents. MozReview-Commit-ID: 7FW0R8r9o9G
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip