5ead4048955fa24b83dc4a6f407d1db9ebd886f2: Bug 1655465 - Part 9: Avoid MToString on string-typed inputs in Warp. r=jandem
André Bargull <andre.bargull@gmail.com> - Fri, 31 Jul 2020 14:07:58 +0000 - rev 542941
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1655465 - Part 9: Avoid MToString on string-typed inputs in Warp. r=jandem Warp can't currently fold away `MToString`, as a workaround handle the already string case in WarpBuilder. Differential Revision: https://phabricator.services.mozilla.com/D84988
8b030b7d13aba732ad792cacb17a4dbee294fd9a: Bug 1655465 - Part 8: Support StringReplaceString in CacheIR and Warp. r=jandem
André Bargull <andre.bargull@gmail.com> - Fri, 31 Jul 2020 14:07:30 +0000 - rev 542940
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1655465 - Part 8: Support StringReplaceString in CacheIR and Warp. r=jandem Drive-by change: - Remove a bogus `resumeAfter()`, `MStringReplace` is never effectful. Differential Revision: https://phabricator.services.mozilla.com/D84987
1682c7ee28f98a7b653aee2d4328afaf0ac4ef93: Bug 1655465 - Part 7: Support ObjectHasPrototype in CacheIR. r=jandem
André Bargull <andre.bargull@gmail.com> - Fri, 31 Jul 2020 14:06:02 +0000 - rev 542939
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1655465 - Part 7: Support ObjectHasPrototype in CacheIR. r=jandem Inling `ObjectHasPrototype()` using the `GuardProto` CacheIR op for the normal case when the prototype chain wasn't modified. Also change `intrinsic_ObjectHasPrototype()` to expect that both objects are `NativeObject`, because then we don't need to handle proxies in CacheIR. Drive-by change: - Use `staticPrototype()` in ObjectOperations-inl.h instead of effectively inlining it. Differential Revision: https://phabricator.services.mozilla.com/D84984
7527a8726d9c23e80013021d529a11ca5a01ecf6: Bug 1655465 - Part 6: Fold MCompare with typeof to check the value tag. r=jandem
André Bargull <andre.bargull@gmail.com> - Fri, 31 Jul 2020 14:04:59 +0000 - rev 542938
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1655465 - Part 6: Fold MCompare with typeof to check the value tag. r=jandem String built-ins use `typeof thing === "string"` to check for string values. These were compiled to `LTypeOfV` followed by a string comparison. Using `MLoadValueTag` from part 1 can make this more efficient. Differential Revision: https://phabricator.services.mozilla.com/D84983
367207c1cecec386d93e817558d8fb53ab0a14c6: Bug 1655465 - Part 5: Rename `tryFoldTypeOf` to `tryFoldConstantTypeOf`. r=jandem
André Bargull <andre.bargull@gmail.com> - Fri, 31 Jul 2020 14:04:21 +0000 - rev 542937
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1655465 - Part 5: Rename `tryFoldTypeOf` to `tryFoldConstantTypeOf`. r=jandem The next part will add a different `tryFoldTypeOf()` method, so rename the existing one to avoid any confusion. Drive-by change: Correct the access specifiers. Differential Revision: https://phabricator.services.mozilla.com/D84982
bc2378fcaf0f79f6d09e6678c93c927eac49f129: Bug 1655465 - Part 4: Transpile GuardTagNotEqual in Warp. r=jandem
André Bargull <andre.bargull@gmail.com> - Fri, 31 Jul 2020 14:03:43 +0000 - rev 542936
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1655465 - Part 4: Transpile GuardTagNotEqual in Warp. r=jandem This is part two to support comparing strictly different types in Warp. The operation doesn't have any result, so when folding it, `MNop` is used to optimise it away when the value tags are already different at compile time. Differential Revision: https://phabricator.services.mozilla.com/D84980
66ff72ea169b382ebff59865f32ca82ebd095ab1: Bug 1655465 - Part 3: Use BytecodeUtil.h helpers to test for equality operations. r=jandem
André Bargull <andre.bargull@gmail.com> - Fri, 31 Jul 2020 14:01:28 +0000 - rev 542935
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1655465 - Part 3: Use BytecodeUtil.h helpers to test for equality operations. r=jandem Differential Revision: https://phabricator.services.mozilla.com/D84978
737e3a6415de8d4edb5c8db2efde0e7c10c879e5: Bug 1655465 - Part 2: Test node is commutative before swapping the operands. r=jandem
André Bargull <andre.bargull@gmail.com> - Fri, 31 Jul 2020 14:01:00 +0000 - rev 542934
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1655465 - Part 2: Test node is commutative before swapping the operands. r=jandem Swapping `bi`'s operands should depend on `bi` itself being commutative. Drive-by change: Use `std::swap` to swap the operands. Differential Revision: https://phabricator.services.mozilla.com/D84977
4dbe80f41370d649d3a0088cfd69b2ee448c89f5: Bug 1655465 - Part 1: Transpile LoadValueTag in Warp. r=jandem
André Bargull <andre.bargull@gmail.com> - Fri, 31 Jul 2020 14:00:22 +0000 - rev 542933
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1655465 - Part 1: Transpile LoadValueTag in Warp. r=jandem LoadValueTag is used when comparing strictly different types. This happens in the string built-ins when the this-value is a primitive string and it is compared against null or undefined. Value tags are represented as MIRType::Int32 and folding is supported to be able to optimise away the checks after inlining. Differential Revision: https://phabricator.services.mozilla.com/D84976
d79a45fa9d678e243867afa384516f79556451d9: Bug 1656071 - Record profiler stats into captures to assist with debugging talos regressions. r=kvark
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 31 Jul 2020 18:53:56 +0000 - rev 542932
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1656071 - Record profiler stats into captures to assist with debugging talos regressions. r=kvark This adds a profiler-stats.txt file to captures that dumps the profiler stats, if those are being recorded. They get recorded if the profiler is visible, or if the (newly added) PROFILER_CAPTURE debug option is enabled. Differential Revision: https://phabricator.services.mozilla.com/D85592
4eaef350187e2474d07a070de73daa73c4c3b3d6: Bug 1654074: Make @CommandProvider validation more specific r=firefox-build-system-reviewers,rstewart
Mitchell Hentges <mhentges@mozilla.com> - Thu, 30 Jul 2020 22:25:05 +0000 - rev 542931
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1654074: Make @CommandProvider validation more specific r=firefox-build-system-reviewers,rstewart @CommandProvider does parameter validation and collects information (such as "pass_context") that will be needed by Registrar. However, rather than just checking parameter length, we can make it more specific and assert that the specific expected parameter ("context") exists. Differential Revision: https://phabricator.services.mozilla.com/D85482
9fffa3ba4729f55c1b6e6c9af9d2c449fa3f5654: Bug 1652068: Log mozbuild prioritization on configure path r=firefox-build-system-reviewers,rstewart
Mitchell Hentges <mhentges@mozilla.com> - Tue, 28 Jul 2020 20:50:03 +0000 - rev 542930
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1652068: Log mozbuild prioritization on configure path r=firefox-build-system-reviewers,rstewart The order in which toolchain binaries are resolved change based on environmental factors, such as whether Firefox is being built in release mode or not. An informative log was added in either case. Differential Revision: https://phabricator.services.mozilla.com/D84439
2c5cc308bfacfb6683ec2f7357cbfb9221954003: Bug 1656534: devtools preset no longer runs linux opt fission tests (moved to --full task list). r=Callek
Ben Hearsum <bhearsum@mozilla.com> - Fri, 31 Jul 2020 18:22:02 +0000 - rev 542929
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1656534: devtools preset no longer runs linux opt fission tests (moved to --full task list). r=Callek Differential Revision: https://phabricator.services.mozilla.com/D85614
2e136f5155d5675264abca04ed8cc94c3d04ef17: Bug 1627495 - part 2: new test cases for addon updates in a pending state. r=mstriemer,mixedpuppy
Luca Greco <lgreco@mozilla.com> - Fri, 31 Jul 2020 10:48:29 +0000 - rev 542928
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1627495 - part 2: new test cases for addon updates in a pending state. r=mstriemer,mixedpuppy Depends on D85564 Differential Revision: https://phabricator.services.mozilla.com/D76476
43b7f80916a9901b824cbe740b52d744e5396c56: Bug 1627495 - part 1-2: about:addons should detach the promptHandler function attached to the AddonInstall objects. r=mixedpuppy,mstriemer
Luca Greco <lgreco@mozilla.com> - Fri, 31 Jul 2020 18:11:49 +0000 - rev 542927
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1627495 - part 1-2: about:addons should detach the promptHandler function attached to the AddonInstall objects. r=mixedpuppy,mstriemer Depends on D72452 Differential Revision: https://phabricator.services.mozilla.com/D85564
ec1ea283bdea98608578c226e872b590c1af2a6b: Bug 1627495 - part 1: Addons updates in a pending state visible in about:addons and upgradable without browser restart. r=fluent-reviewers,mstriemer,flod,mixedpuppy
Luca Greco <lgreco@mozilla.com> - Fri, 31 Jul 2020 10:41:40 +0000 - rev 542926
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1627495 - part 1: Addons updates in a pending state visible in about:addons and upgradable without browser restart. r=fluent-reviewers,mstriemer,flod,mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D72452
218356aac33db56e473895aaa4e1ba85e0f154ee: Bug 1655520 - Replace nsDocShell::GetAllDocShellsInSubtree in OnPrefChange, r=farre
Kashav Madan <kmadan@mozilla.com> - Fri, 31 Jul 2020 18:16:32 +0000 - rev 542925
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1655520 - Replace nsDocShell::GetAllDocShellsInSubtree in OnPrefChange, r=farre Differential Revision: https://phabricator.services.mozilla.com/D85342
7df4a30f6382e018c29a7ad72ec8795bf77e2d86: Bug 1654045 - part4 : add a test to ensure we would stop controlling media when it reaches to the end. r=chunmin
alwu <alwu@mozilla.com> - Fri, 31 Jul 2020 17:26:46 +0000 - rev 542924
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1654045 - part4 : add a test to ensure we would stop controlling media when it reaches to the end. r=chunmin Differential Revision: https://phabricator.services.mozilla.com/D85231
5acecd5380048d1880ec44350ffedae250898078: Bug 1654045 - part3 : porting other attributes to media controller's webidl interface. r=chunmin
alwu <alwu@mozilla.com> - Fri, 31 Jul 2020 02:56:20 +0000 - rev 542923
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1654045 - part3 : porting other attributes to media controller's webidl interface. r=chunmin We have already had these functions on `MediaController` so we just need to expose them on the media controller's webidl interface, and they can be used in testing and the future plan of supporting media hub. Differential Revision: https://phabricator.services.mozilla.com/D85230
5640e25c2d1d61a216bc5a9cac70b6843b7fe73f: Bug 1654045 - part2 : add 'onactivated/ondeactivated' event handlers and 'isActive' on the media control webidl interface. r=chunmin
alwu <alwu@mozilla.com> - Fri, 31 Jul 2020 17:26:38 +0000 - rev 542922
Push 37657 by nerli@mozilla.com at Sat, 01 Aug 2020 09:48:10 +0000
Bug 1654045 - part2 : add 'onactivated/ondeactivated' event handlers and 'isActive' on the media control webidl interface. r=chunmin Add an event handler `onactivated/ondeactivated` and a readonly attribute `isActive` on the media control webidl interface, and they can be used in testing and the future plan of supporting media hub. Differential Revision: https://phabricator.services.mozilla.com/D85229
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip