5cfc67d643e09d054856546a18414177f4dcab67: Bug 1409635 (part 2) - Fix up nsIPrefLocalizedString. r=froydnj.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 18 Oct 2017 16:51:56 +1100 - rev 387098
Push 32709 by archaeopteryx@coole-files.de at Thu, 19 Oct 2017 09:27:00 +0000
Bug 1409635 (part 2) - Fix up nsIPrefLocalizedString. r=froydnj. nsIPrefLocalizedString is meant to be a wrapper for nsISupportsString, basically identical but with a different identifier. But it's not a sub-interface of nsISupportsString. Instead it (almost) duplicates nsISupportsString's internals. Specifically, nsISupportsString has `attribute AString data`, resulting in these C++ methods: > NS_IMETHOD GetData(nsAString& aData) > NS_IMETHOD SetData(const nsAString& aData) nsIPrefLocalizedString has `attribute wstring data`, resulting in these C++ methods: > NS_IMETHOD GetData(char16_t** aData) > NS_IMETHOD SetData(const char16_t* aData) Then we have nsPrefLocalizedString, the concrete subclass of nsIPrefLocalizedString. It implements the AString methods via NS_FORWARD_NSISUPPORTSSTRING, which forwards to mUnicodeString. It also implements the wstring methods explicitly, and they just call the AString methods. It's all a bit of a mess. (Both interfaces also have `wstring toString()`. The forwarding works more smoothly for that method.) This patch changes nsIPrefLocalizedString so it is a trivial sub-interface of nsISupportsString. This change eliminates the need for the wstring methods, so the patch removes them as well. The net result is we have less code, and fewer conversions between C strings and Gecko strings. The patch also merges the nsISupportsString and nsIPrefLocalizedString cases in nsPrefBranch::SetComplexValue(), because they are now identical. (The nsISupportsString and nsIPrefLocalizedString cases in nsPrefBranch::GetComplexValue() remain distinct; indeed, that's the whole reason for having them as separate interfaces.)
2e368dcaf9888ee6c16a55a532819ca00baa5818: Bug 1409635 (part 1) - Remove nsIPrefLocalizedString::setDataWithLength. r=froydnj.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 18 Oct 2017 16:39:52 +1100 - rev 387097
Push 32709 by archaeopteryx@coole-files.de at Thu, 19 Oct 2017 09:27:00 +0000
Bug 1409635 (part 1) - Remove nsIPrefLocalizedString::setDataWithLength. r=froydnj. It's unused.
c2d3e50e7a8ecc231b8d9c0b9ef1c436a1bb6e2e: Bug 1409598 - Change nsIXPCScriptable::className and nsIClassInfo::{contractID,classDescription} from string to AUTF8String. r=froydnj.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 18 Oct 2017 13:17:26 +1100 - rev 387096
Push 32709 by archaeopteryx@coole-files.de at Thu, 19 Oct 2017 09:27:00 +0000
Bug 1409598 - Change nsIXPCScriptable::className and nsIClassInfo::{contractID,classDescription} from string to AUTF8String. r=froydnj. This lets us replace moz_xstrdup() of string literals with AssignLiteral(), among other improvements.
4212d0d0ca7762e8821d5912e5f987ffa4c2d595: Bug 1404232 - Add mGL->MakeCurrent() calling in SetGLContext() r=jrmuizel
sotaro <sotaro.ikeda.g@gmail.com> - Thu, 19 Oct 2017 13:03:28 +0900 - rev 387095
Push 32709 by archaeopteryx@coole-files.de at Thu, 19 Oct 2017 09:27:00 +0000
Bug 1404232 - Add mGL->MakeCurrent() calling in SetGLContext() r=jrmuizel
a88fa8d0eaa0b8c908f8ab0d2923da526b787e9f: Bug 1404232 - Add WebRenderCommandBuilder::ClearCachedResources() r=jrmuizel
sotaro <sotaro.ikeda.g@gmail.com> - Thu, 19 Oct 2017 13:03:08 +0900 - rev 387094
Push 32709 by archaeopteryx@coole-files.de at Thu, 19 Oct 2017 09:27:00 +0000
Bug 1404232 - Add WebRenderCommandBuilder::ClearCachedResources() r=jrmuizel
fef60dc3adecc4378456e6e73bb60eca28de9921: Bug 1404232 - Add WebRenderLayerManager::WrUpdated() r=jrmuizel
sotaro <sotaro.ikeda.g@gmail.com> - Thu, 19 Oct 2017 13:02:47 +0900 - rev 387093
Push 32709 by archaeopteryx@coole-files.de at Thu, 19 Oct 2017 09:27:00 +0000
Bug 1404232 - Add WebRenderLayerManager::WrUpdated() r=jrmuizel
c2c51e5a288272438957ed08e50b624c4e5801c0: Bug 1408678 - Remove unnecessary calls to ReparentFloatsForInlineChild in nsInlineFrame. r=dholbert
Mats Palmgren <mats@mozilla.com> - Thu, 19 Oct 2017 04:31:14 +0200 - rev 387092
Push 32709 by archaeopteryx@coole-files.de at Thu, 19 Oct 2017 09:27:00 +0000
Bug 1408678 - Remove unnecessary calls to ReparentFloatsForInlineChild in nsInlineFrame. r=dholbert MozReview-Commit-ID: HcCjuiUVnU2
73f036e178e676486ad7024a37064cfd793370ca: Bug 1409594 - Check if root WebRenderBridgeParent exists r=kats
sotaro <sotaro.ikeda.g@gmail.com> - Thu, 19 Oct 2017 11:15:46 +0900 - rev 387091
Push 32709 by archaeopteryx@coole-files.de at Thu, 19 Oct 2017 09:27:00 +0000
Bug 1409594 - Check if root WebRenderBridgeParent exists r=kats
a94c21fb2d184b93e0b2b9dd01254d79ad4f6491: Bug 1373581: Make transition into and out of native fullscreen smoother on macOS. r=mstange
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Wed, 18 Oct 2017 21:50:47 -0400 - rev 387090
Push 32709 by archaeopteryx@coole-files.de at Thu, 19 Oct 2017 09:27:00 +0000
Bug 1373581: Make transition into and out of native fullscreen smoother on macOS. r=mstange
e6f88e18e1bcedb34d71fc74c25d8a7a6f2c60fb: Bug 1409595 - Add pointer check in WebRenderLayerManager::DidComposite() r=kats
sotaro <sotaro.ikeda.g@gmail.com> - Thu, 19 Oct 2017 10:26:26 +0900 - rev 387089
Push 32709 by archaeopteryx@coole-files.de at Thu, 19 Oct 2017 09:27:00 +0000
Bug 1409595 - Add pointer check in WebRenderLayerManager::DidComposite() r=kats
629afbb52163b54ec832d8f83f90bb3bcbe929a2: Bug 1406859 - [DateTimePicker] Let the first picker close gracefully before opening a second picker. r=mconley
Jessica Jong <jjong@mozilla.com> - Thu, 19 Oct 2017 09:14:56 +0800 - rev 387088
Push 32709 by archaeopteryx@coole-files.de at Thu, 19 Oct 2017 09:27:00 +0000
Bug 1406859 - [DateTimePicker] Let the first picker close gracefully before opening a second picker. r=mconley If we're trying to open a picker while one is already open, we should let the first one close gracefully, that is, we should consume the popuphidden event, otherwise the event will be fired when we re-add the listeners. MozReview-Commit-ID: CGy86le1F4g
76fa19a2eef05b2ca1e9db36e3cda4a9cd27669f: Bug 1408452 - Add test262 test case. r=arai
Zirak <zirakertan@gmail.com> - Wed, 18 Oct 2017 15:37:00 -0400 - rev 387087
Push 32709 by archaeopteryx@coole-files.de at Thu, 19 Oct 2017 09:27:00 +0000
Bug 1408452 - Add test262 test case. r=arai
e3faec07144544074ad9b9c7a500f4dd301e6130: Bug 1408452 - Fix RegExpParser position tracking. r=arai
Zirak <zirakertan@gmail.com> - Wed, 18 Oct 2017 15:29:00 -0400 - rev 387086
Push 32709 by archaeopteryx@coole-files.de at Thu, 19 Oct 2017 09:27:00 +0000
Bug 1408452 - Fix RegExpParser position tracking. r=arai Alongside setting has_more_, we also need to set next_pos_ accordingly, otherwise calling RegExpParser::Reset could inadvertently leave us in a bad state.
6d0f18e0387602d534a03c2cae10cf6b814ea9fd: merge autoland to mozilla-central. r=merge a=merge
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 19 Oct 2017 11:22:55 +0200 - rev 387085
Push 32708 by archaeopteryx@coole-files.de at Thu, 19 Oct 2017 09:23:25 +0000
merge autoland to mozilla-central. r=merge a=merge MozReview-Commit-ID: 7BbAIKxBpcI
6fef2d72c81741554f8b2abdd88b07f91f3ecbd1: Bug 1399142 - PART II: update illustration;r=Fischer
gasolin <gasolin@gmail.com> - Tue, 17 Oct 2017 17:15:45 +0800 - rev 387084
Push 32708 by archaeopteryx@coole-files.de at Thu, 19 Oct 2017 09:23:25 +0000
Bug 1399142 - PART II: update illustration;r=Fischer MozReview-Commit-ID: 5eX0IdaXIF0
583e197f3feea6a08b65bce3c3bb3fdf2012cb49: Bug 1399142 - PART I: update the tour overlay colors;r=Fischer
gasolin <gasolin@gmail.com> - Tue, 17 Oct 2017 11:02:01 +0800 - rev 387083
Push 32708 by archaeopteryx@coole-files.de at Thu, 19 Oct 2017 09:23:25 +0000
Bug 1399142 - PART I: update the tour overlay colors;r=Fischer MozReview-Commit-ID: 9fPva9qUCHi
72cce53ae7fdf5183afb4e959f20058455267d51: Bug 1360694 - [Form Autofill] Cap the length of profile fields saved in storage. r=ralin
Luke Chang <lchang@mozilla.com> - Thu, 19 Oct 2017 12:06:40 +0800 - rev 387082
Push 32708 by archaeopteryx@coole-files.de at Thu, 19 Oct 2017 09:23:25 +0000
Bug 1360694 - [Form Autofill] Cap the length of profile fields saved in storage. r=ralin MozReview-Commit-ID: I9x0tnGEt1Y
d868d37155547fdfb02e68d477ae55e32f924ea4: servo: Merge #18926 - Update WR (box shadows, subpixel + alpha text) (from glennw:update-wr-bs); r=jdm
Glenn Watson <github@intuitionlibrary.com> - Wed, 18 Oct 2017 23:52:54 -0500 - rev 387081
Push 32708 by archaeopteryx@coole-files.de at Thu, 19 Oct 2017 09:23:25 +0000
servo: Merge #18926 - Update WR (box shadows, subpixel + alpha text) (from glennw:update-wr-bs); r=jdm Source-Repo: https://github.com/servo/servo Source-Revision: 59d727b020f18260e0bacc9aed6ffa5b75b3f0b6
760469149d9d9736e7ddca3129163509a804f7a2: Bug 1407966 - part 2: EditorBase::InsertTextImpl() shouldn't assume that aInOutChildAtOffset is never nullptr r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 17 Oct 2017 01:59:28 +0900 - rev 387080
Push 32708 by archaeopteryx@coole-files.de at Thu, 19 Oct 2017 09:23:25 +0000
Bug 1407966 - part 2: EditorBase::InsertTextImpl() shouldn't assume that aInOutChildAtOffset is never nullptr r=m_kato Since if the container is not a container node like a text node or the offset is same as the length, child at the offset can be nullptr. MozReview-Commit-ID: DCnFwUjNgk7
ad96b27c86c5eb4a5db79be2f64c3c96d4f81790: Bug 1407966 - part 1: Update |selChild| when HTMLEditRules::WillInsertText() updates |curNode| and |curOffset| r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 17 Oct 2017 01:17:07 +0900 - rev 387079
Push 32708 by archaeopteryx@coole-files.de at Thu, 19 Oct 2017 09:23:25 +0000
Bug 1407966 - part 1: Update |selChild| when HTMLEditRules::WillInsertText() updates |curNode| and |curOffset| r=m_kato |selChild| should be a node which is at |curOffset| in |curNode|, however, it's not updated when |curOffset| is updated by a call of CreateBRImpl(). So, it should be next sibling of the created br node. MozReview-Commit-ID: IVfTjVMp3lB
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip