577309fc4bbb328a7825b26818089c2af6c7bbf2: Bug 1282410 - part2 : open media with external apps. r=Margaret
Alastor Wu <alwu@mozilla.com> - Wed, 06 Jul 2016 10:53:53 +0800 - rev 303783
Push
30401 by cbook@mozilla.com at Wed, 06 Jul 2016 09:40:34 +0000
Bug 1282410 - part2 : open media with external apps. r=Margaret
MozReview-Commit-ID: KQDmOf2RURN
339b5c5d3595fcbf3cafd35df8a2a2ecce484b5a: Bug 1282410 - part1 : open unsupported type media. r=cpearce
Alastor Wu <alwu@mozilla.com> - Wed, 06 Jul 2016 10:34:29 +0800 - rev 303782
Push
30401 by cbook@mozilla.com at Wed, 06 Jul 2016 09:40:34 +0000
Bug 1282410 - part1 : open unsupported type media. r=cpearce
MozReview-Commit-ID: 4fjkDlRgdt7
1ec6e0357c4219fcbfa68f027b619bd8cedacbe1: Bug 906116 - part4: Remove NS_STYLE_HINT_FRAMECHANGE. r=dbaron
Jeremy Chen <jeremychen@mozilla.com> - Wed, 06 Jul 2016 09:59:56 +0800 - rev 303781
Push
30401 by cbook@mozilla.com at Wed, 06 Jul 2016 09:40:34 +0000
Bug 906116 - part4: Remove NS_STYLE_HINT_FRAMECHANGE. r=dbaron
MozReview-Commit-ID: IXPWY2B6k48
8c1f9996a7d652b313070ef160105149201d8cb2: Bug 906116 - part3.3: Replace NS_STYLE_HINT_FRAMECHANGE with nsChangeHint_ReconstructFrame. r=dbaron
Jeremy Chen <jeremychen@mozilla.com> - Wed, 06 Jul 2016 09:59:56 +0800 - rev 303780
Push
30401 by cbook@mozilla.com at Wed, 06 Jul 2016 09:40:34 +0000
Bug 906116 - part3.3: Replace NS_STYLE_HINT_FRAMECHANGE with nsChangeHint_ReconstructFrame. r=dbaron
Use ReconstructFrame to replace NS_STYLE_HINT_FRAMECHANGE in many places, such
as HTML*Element::GetAttributeChangeHint and HTMLFrameSetElement::SetAttr.
MozReview-Commit-ID: EHbc4RMeuu0
34c54dbb1b7d8acbd2575e10b6f8c74683ab5d76: Bug 906116 - part3.2: Replace NS_STYLE_HINT_FRAMECHANGE with nsChangeHint_ReconstructFrame. r=dbaron
Jeremy Chen <jeremychen@mozilla.com> - Wed, 06 Jul 2016 09:59:56 +0800 - rev 303779
Push
30401 by cbook@mozilla.com at Wed, 06 Jul 2016 09:40:34 +0000
Bug 906116 - part3.2: Replace NS_STYLE_HINT_FRAMECHANGE with nsChangeHint_ReconstructFrame. r=dbaron
Use ReconstructFrame | (any ther bits needed) to replace
NS_STYLE_HINT_FRAMECHANGE in nsStyle*::MaxDifference.
For those nsStyle* that do not have nsChangeHint_NeutralChange in their
CalcDifference, we should be able to elimate nsChangeHint_NeutralChange from
their MaxDifference as well.
MozReview-Commit-ID: B3VJWt6gKoL
17d17aeec1fa72b374d8772f11c7561e304551c9: Bug 906116 - part3.1: Replace NS_STYLE_HINT_FRAMECHANGE with nsChangeHint_ReconstructFrame. r=dbaron
Jeremy Chen <jeremychen@mozilla.com> - Wed, 06 Jul 2016 09:59:55 +0800 - rev 303778
Push
30401 by cbook@mozilla.com at Wed, 06 Jul 2016 09:40:34 +0000
Bug 906116 - part3.1: Replace NS_STYLE_HINT_FRAMECHANGE with nsChangeHint_ReconstructFrame. r=dbaron
Replace NS_STYLE_HINT_FRAMECHANGE with nsChangeHint_ReconstructFrame in
nsStyle*::CalcDifference.
MozReview-Commit-ID: 85WPCyYolal
d84c0edb69128ea3741ff0636056ad53fd8df1ec: Bug 906116 - part2: Fix comment for nsChangeHint_ReconstructFrame. r=dbaron
Jeremy Chen <jeremychen@mozilla.com> - Wed, 06 Jul 2016 09:59:55 +0800 - rev 303777
Push
30401 by cbook@mozilla.com at Wed, 06 Jul 2016 09:40:34 +0000
Bug 906116 - part2: Fix comment for nsChangeHint_ReconstructFrame. r=dbaron
The comment for nsChangeHint_ReconstructFrame is out-of-date.
In RestyleManager::ProcessRestyledFrames, we actually ignore all of the other
hints if ReconstructFrame is set. The old version was written when
ReconstructFrame was listed last. So, update the comment.
MozReview-Commit-ID: 97wMrW6S6ID
0f4e9c57ee8eb766c9237f98d52d7270292335d1: Bug 906116 - part1: Ensure bracing all controlled statements in nsStyleStruct.h and nsStyleStruct.cpp. r=dbaron
Jeremy Chen <jeremychen@mozilla.com> - Wed, 06 Jul 2016 09:59:55 +0800 - rev 303776
Push
30401 by cbook@mozilla.com at Wed, 06 Jul 2016 09:40:34 +0000
Bug 906116 - part1: Ensure bracing all controlled statements in nsStyleStruct.h and nsStyleStruct.cpp. r=dbaron
According to our coding style guide, we should always brace controlled
statements, even a single-line consequent of an if-else-statement. It avoids
dangling else bugs.
MozReview-Commit-ID: FT1AR5MqOGw
78d2fb74e22f7d4858c88173071a5b6988c07389: Bug 1283106 - Put empty skip chars in gfxPlatform singleton rather than static local variable. r=jfkthame
Xidorn Quan <me@upsuper.org> - Tue, 05 Jul 2016 11:02:24 +1000 - rev 303775
Push
30401 by cbook@mozilla.com at Wed, 06 Jul 2016 09:40:34 +0000
Bug 1283106 - Put empty skip chars in gfxPlatform singleton rather than static local variable. r=jfkthame
MozReview-Commit-ID: 5SU6ewm5wbd
28c44b72633b5f94f60863f0fcec408e633db675: Bug 1282658. Part 17 - rename and remove some functions. r=kaku
JW Wang <jwwang@mozilla.com> - Tue, 05 Jul 2016 17:00:28 +0800 - rev 303774
Push
30401 by cbook@mozilla.com at Wed, 06 Jul 2016 09:40:34 +0000
Bug 1282658. Part 17 - rename and remove some functions. r=kaku
MozReview-Commit-ID: 1v8WOlz2671
0468b7cedfcf9afdee4a37b79399bc4fa50d3aed: Bug 1282658. Part 16 - remove checks for |mReader->IsWaiting{Audio,Video}Data()|. r=kaku
JW Wang <jwwang@mozilla.com> - Wed, 29 Jun 2016 17:26:13 +0800 - rev 303773
Push
30401 by cbook@mozilla.com at Wed, 06 Jul 2016 09:40:34 +0000
Bug 1282658. Part 16 - remove checks for |mReader->IsWaiting{Audio,Video}Data()|. r=kaku
EnsureAudioDecodeTaskQueued() is called from several places where
mReader->IsWaitingAudioData() can be proven to be false:
1. OnAudioDecoded() - definitely false.
2. OnNotDecoded() - false because aReason is MediaDecoderReader::CANCELED.
3. OnSeekResolved() - false becuase we haven't requested any samples.
4. SetCallbacks() - false because AudioWaitCallback is resolved.
MozReview-Commit-ID: 8ppYIQQw0uK
44ed26a7269a015e55f2c8035884ccbb577615a4: Bug 1282658. Part 15 - optimize checking of seek complete. r=kaku
JW Wang <jwwang@mozilla.com> - Wed, 29 Jun 2016 17:06:00 +0800 - rev 303772
Push
30401 by cbook@mozilla.com at Wed, 06 Jul 2016 09:40:34 +0000
Bug 1282658. Part 15 - optimize checking of seek complete. r=kaku
We need to request another audio sample in OnAudioDecoded() only when
mDoneAudioSeeking is false which also applies OnVideoDecodd().
Therefore we remove calls to Ensure{Audio,Video}DecodeTaskQueued()
from CheckIfSeekComplete() to prevent requesting video samples inside
OnAudioDecoded() for they will be handled by OnVideoDecodd().
This also allows us to remove checking of mReader->IsRequesting{Audio,Video}Data()
from Ensure{Audio,Video}DecodeTaskQueued().
MozReview-Commit-ID: LpXjiacp0D9
4c079c504dfee12c130ee184fa20648a11d0fa2f: Bug 1282658. Part 14 - remove mDrop{Audio,Video}UntilNextDiscontinuity for MediaData::mDiscontinuity is guaranteed to be true for the 1st sample after seeking. r=kaku
JW Wang <jwwang@mozilla.com> - Wed, 29 Jun 2016 16:52:09 +0800 - rev 303771
Push
30401 by cbook@mozilla.com at Wed, 06 Jul 2016 09:40:34 +0000
Bug 1282658. Part 14 - remove mDrop{Audio,Video}UntilNextDiscontinuity for MediaData::mDiscontinuity is guaranteed to be true for the 1st sample after seeking. r=kaku
MozReview-Commit-ID: CttpYi6CV32
d7f5babfb534b689762bfbb1ea6993ea2b9e48ea: Bug 1282658. Part 13 - replace use of int64_t with media::TimeUnit. r=kaku
JW Wang <jwwang@mozilla.com> - Tue, 28 Jun 2016 17:16:31 +0800 - rev 303770
Push
30401 by cbook@mozilla.com at Wed, 06 Jul 2016 09:40:34 +0000
Bug 1282658. Part 13 - replace use of int64_t with media::TimeUnit. r=kaku
MozReview-Commit-ID: 6LVuqpgWGUg
eb18fb6afd688f6155c3074e14639de6c45ac2e2: Bug 1282658. Part 12 - extract common code about adjusting fast seek. r=kaku
JW Wang <jwwang@mozilla.com> - Tue, 28 Jun 2016 17:07:34 +0800 - rev 303769
Push
30401 by cbook@mozilla.com at Wed, 06 Jul 2016 09:40:34 +0000
Bug 1282658. Part 12 - extract common code about adjusting fast seek. r=kaku
MozReview-Commit-ID: 5ZMdr3OA6Xk
111114fbbe27deff5d3f038d6c63affc2ffc0577: Bug 1282658. Part 11 - merge OnAudioNotDecoded() and OnVideoNotDecoded(). r=kaku
JW Wang <jwwang@mozilla.com> - Tue, 28 Jun 2016 16:54:38 +0800 - rev 303768
Push
30401 by cbook@mozilla.com at Wed, 06 Jul 2016 09:40:34 +0000
Bug 1282658. Part 11 - merge OnAudioNotDecoded() and OnVideoNotDecoded(). r=kaku
MozReview-Commit-ID: GE0IZc6cqBY
a0325c3082b81c77fd8ba3537164d04031490def: Bug 1282658. Part 10 - merge Request{Audio,Video}Data() into Ensure{Audio,Video}DecodeTaskQueued() for the logs are not quite useful. r=kaku
JW Wang <jwwang@mozilla.com> - Tue, 28 Jun 2016 16:13:09 +0800 - rev 303767
Push
30401 by cbook@mozilla.com at Wed, 06 Jul 2016 09:40:34 +0000
Bug 1282658. Part 10 - merge Request{Audio,Video}Data() into Ensure{Audio,Video}DecodeTaskQueued() for the logs are not quite useful. r=kaku
MozReview-Commit-ID: G1M9St1uLaN
1668f3d274b73757f93f0c5c9dd26b031c369b00: Bug 1282658. Part 9 - return void for Ensure{Audio,Video}DecodeTaskQueued() for they always return NS_OK. r=kaku.
JW Wang <jwwang@mozilla.com> - Tue, 28 Jun 2016 15:39:42 +0800 - rev 303766
Push
30401 by cbook@mozilla.com at Wed, 06 Jul 2016 09:40:34 +0000
Bug 1282658. Part 9 - return void for Ensure{Audio,Video}DecodeTaskQueued() for they always return NS_OK. r=kaku.
MozReview-Commit-ID: 2eRnY5D9Vin
c0910b20aefcbe2735ef153937621612faabc71f: Bug 1282658. Part 8 - remove asserting |mReader->IsWaitForDataSupported()| for mReader->WaitForData() will crash if the method has no override. r=kaku
JW Wang <jwwang@mozilla.com> - Tue, 28 Jun 2016 15:03:56 +0800 - rev 303765
Push
30401 by cbook@mozilla.com at Wed, 06 Jul 2016 09:40:34 +0000
Bug 1282658. Part 8 - remove asserting |mReader->IsWaitForDataSupported()| for mReader->WaitForData() will crash if the method has no override. r=kaku
MozReview-Commit-ID: 2t1viejYHgh
cea92d10be95c8e41fe3d8269948b398e6a8f02e: Bug 1282658. Part 7 - remove setting mNeedToStopPrerolling{Audio,Video} per discussion in https://reviewboard.mozilla.org/r/43689/#comment54421. r=kaku
JW Wang <jwwang@mozilla.com> - Tue, 28 Jun 2016 14:58:05 +0800 - rev 303764
Push
30401 by cbook@mozilla.com at Wed, 06 Jul 2016 09:40:34 +0000
Bug 1282658. Part 7 - remove setting mNeedToStopPrerolling{Audio,Video} per discussion in https://reviewboard.mozilla.org/r/43689/#comment54421. r=kaku
MozReview-Commit-ID: JWdJVj4aW56
