54964c38d7902f71e0d821b22f8acf1206bdf957: Bug 1514050 part 2. Stop recomputing cross-compartment wrappers on document.domain changes. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 30 Jan 2019 19:02:34 +0000 - rev 457602
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1514050 part 2. Stop recomputing cross-compartment wrappers on document.domain changes. r=bholley The change to test_clonewrapper.xul is because in the new setup we've already tried handing an object across origins via chrome code, so it has a cached (opaque) wrapper. When we set document.domain and pass the same object again, we end up picking up the cached wrapper when we try to wrap across the compartment boundary, so don't grant access when perhaps we should... This does lead to a possible spec violation in the following situation: 1) Two documents (A, B) start out same-site but different-origin. 2) Privileged code (system or extension) puts a reference to an object from site A into site B. This object gets an opaque CCW. 3) Both sites set document.domain to become same-effective-script-origin and then site B goes through the site A Window and the object graph hanging off it and gets to the object involved. It gets an opaque CCW when it should have a transparent CCW. We could fix this if we kept recomputing wrappers on document.domain change and just fixed the compartment filter used by the recomputation. But this seems like a pretty rare situation, and not one web sites can get into without an assist from a somewhat buggy extension or system code, so let's see whether we can just live with it and remove the recomputation. Differential Revision: https://phabricator.services.mozilla.com/D18032
97aaced3f817773ab004df571077806b59632555: Bug 1514050 part 1. Change the cross-compartment wrappers we use for web objects so we can avoid recomputing them when document.domain changes. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 01 Feb 2019 05:26:48 +0000 - rev 457601
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1514050 part 1. Change the cross-compartment wrappers we use for web objects so we can avoid recomputing them when document.domain changes. r=bholley We want to use a transparent CCW if there is any pair of globals, one from each compartment, which are, or have ever been, same origin-domain in the HTML spec sense. This is obviously required in the "are now same origin-domain" case, and in the "were same origin-domain" case it's required because there may be existing transparent CCWs between the compartments and we don't want them to become opaque due to a roundtrip through the compartment boundary. In practice, we need to consider two cases: 1) The two compartments started out same-origin. In this case the two CompartmentOriginInfos will have matching (in the Equals() sense) GetPrincipalIgnoringDocumentDomain(). They will also have matching SiteRef(), of course. 2) The two compartments started out different-origin but then at some point two globals in the compartments ended up same origin-domain. That requires that the two globals be same TLD+1 and have both set document.domain. So in this case the two CompartmentOriginInfos have matching SiteRef() and both test true for HasChangedDocumentDomain(). We only need to worry about this for web compartments, which means that we only need to worry about cases when security checks are symmetric (i.e. originSubsumesTarget == targetSubsumesOrigin) and neither compartment is forcing Xrays. Differential Revision: https://phabricator.services.mozilla.com/D18031
9611438fd389756583f1cdc330bd4725810bcb38: Bug 1524244 - Make the netmonitor localhost icon use a smaller size and inherit currentColor; r=Honza
Florens Verschelde <florens@fvsch.com> - Thu, 07 Feb 2019 12:22:04 +0000 - rev 457600
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1524244 - Make the netmonitor localhost icon use a smaller size and inherit currentColor; r=Honza Differential Revision: https://phabricator.services.mozilla.com/D18211
bea77f447a7ada7e7339a39e5948f37d701fa00d: Backed out 3 changesets (bug 1523272) for Browser-chrome and tv failures in browser/components/preferences/in-content/tests/siteData/browser_siteData3.js
Dorel Luca <dluca@mozilla.com> - Thu, 07 Feb 2019 13:55:33 +0200 - rev 457599
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Backed out 3 changesets (bug 1523272) for Browser-chrome and tv failures in browser/components/preferences/in-content/tests/siteData/browser_siteData3.js Backed out changeset ddf39b3e96df (bug 1523272) Backed out changeset 8fbf00832008 (bug 1523272) Backed out changeset 7250b9f956b6 (bug 1523272)
ce0770fa1ddfcd095a4e6fcda578010458f9fc0e: Bug 1524223 - Fix flaky test browser_multiselect_tabs_move_to_new_window_contextmenu.js. r=jaws
Oriol Brufau <oriol-bugzilla@hotmail.com> - Thu, 07 Feb 2019 04:01:15 +0000 - rev 457598
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1524223 - Fix flaky test browser_multiselect_tabs_move_to_new_window_contextmenu.js. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D18820
b1514d57bcdc98b0accb4f727ad0d91380ea5f28: Bug 1517496 - Make misused string test also check fluent files, r=jaws,flod
Yuan Cheng <chengy12@msu.edu> - Thu, 07 Feb 2019 10:38:24 +0000 - rev 457597
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1517496 - Make misused string test also check fluent files, r=jaws,flod Differential Revision: https://phabricator.services.mozilla.com/D18524
c90fe3ee1999efedec2bddca08db72b8975fc561: Bug 1525371 - followup: fix rusttests to reopen the CLOSED TREE.
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 07 Feb 2019 11:38:23 +0100 - rev 457596
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1525371 - followup: fix rusttests to reopen the CLOSED TREE.
d9be4af74c4b90d08a03fbce96bdabf7dca9faf8: Bug 1525371 - Fix a very subtle invalidation bug exposed by test_initial_computation.html. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 06 Feb 2019 18:12:17 +0100 - rev 457595
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1525371 - Fix a very subtle invalidation bug exposed by test_initial_computation.html. r=jwatt Now that there's no ArenaRefPtr, the styles aren't cleared when the shell goes away (due to an iframe becoming display: none or what not). This caused a few very confusing failures in test_initial_computation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2746a05ce7b20759a820d6f26a55a3200d8e6b8&selectedJob=226267113 Which holds on to a reference of a style on a display: none iframe[1], reframes it periodically[2], exposing this bug. For now, keep the id of the shell we got the style from around. When we support computing styles in display: none iframes this may need more work, but that's out of the scope of this bug. [1]: https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/layout/style/test/test_initial_computation.html#56 [2]: https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/layout/style/test/test_initial_computation.html#147 Differential Revision: https://phabricator.services.mozilla.com/D18853
56eeff69792c1809cd2dd51a77ea276cde635cdc: Bug 1525371 - Remove ArenaRefPtr. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 05 Feb 2019 20:25:22 +0100 - rev 457594
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1525371 - Remove ArenaRefPtr. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D18735
525e804dc7e63855e026be9557af15340d71455a: Bug 1525371 - Kill ComputedStyle::mPresContext, move the pointer to the frame instead. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 05 Feb 2019 17:45:54 +0100 - rev 457593
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1525371 - Kill ComputedStyle::mPresContext, move the pointer to the frame instead. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D18734
c944db09eff52b26d73e00f561beefa200a8bef0: Bug 1525371 - Kill ComputedStyle::ComputedData. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 05 Feb 2019 17:44:57 +0100 - rev 457592
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1525371 - Kill ComputedStyle::ComputedData. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D18733
03904adbe5633680c82ec865e78ad127f3894455: Bug 1518776 Add Tumblr to tp6 r=rwood
Florin Strugariu <bebe@mozilla.ro> - Wed, 06 Feb 2019 17:10:06 +0000 - rev 457591
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1518776 Add Tumblr to tp6 r=rwood Differential Revision: https://phabricator.services.mozilla.com/D16054
d8420442ba8932cb6b89e12debc7c43e40e2fb1b: Bug 1466208 - part 12: Get rid of `frame` variable from PresShell::EventHandler::HandleEvent() r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 07 Feb 2019 01:53:38 +0000 - rev 457590
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1466208 - part 12: Get rid of `frame` variable from PresShell::EventHandler::HandleEvent() r=smaug There is an unclear variable `frame` in PresShell::EventHandler::HandleEvent(). It's overwritten with different frame and its meanings is changed sometimes. Finally, it's necessary only in the `if (aGUIEvent->IsUsingCoordinates())` block. Therefore, we can move it into the block and rename it when them for each purpose. Differential Revision: https://phabricator.services.mozilla.com/D18521
e80ee365c75ac9e85278635982f86e2a9c14e4a3: Bug 1228678 - Followup to fix failing upstream wpt test r=jgraham
Wes Kocher <wkocher@mozilla.com> - Thu, 07 Feb 2019 10:03:53 +0000 - rev 457589
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1228678 - Followup to fix failing upstream wpt test r=jgraham Differential Revision: https://phabricator.services.mozilla.com/D18888
29e9a6507e6466ec0c2dbd813d172908d80116c0: Merge mozilla-central to autoland. a=merge CLOSED TREE
Oana Pop Rus <opoprus@mozilla.com> - Thu, 07 Feb 2019 11:55:25 +0200 - rev 457588
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Merge mozilla-central to autoland. a=merge CLOSED TREE
6b80df33062048df75ec1c674181ff7b64a9f9e5: Bug 1525475 - Mark clip-transform-order-2.html as failing on android due to fuzziness. r=mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 06 Feb 2019 21:34:19 +0000 - rev 457587
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1525475 - Mark clip-transform-order-2.html as failing on android due to fuzziness. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D18763
ddf39b3e96df92b6f059a143ba57387822c5aae6: Bug 1523272 - Remove mock code from about:preferences siteData tests. r=baku
Johann Hofmann <jhofmann@mozilla.com> - Thu, 07 Feb 2019 09:02:47 +0000 - rev 457586
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1523272 - Remove mock code from about:preferences siteData tests. r=baku These tests used to mock out the SiteDataManager to test only the UI for things like removing site data or sorting. This bug breaks that possibility, because the SiteDataManager no longer uses its internal data to remove site data but delegates the logic to ClearSiteDataService. I don't think it's a loss, that mocking was always a little weird. Differential Revision: https://phabricator.services.mozilla.com/D18283
8fbf00832008f77310c5e1306c653281ebc10c8b: Bug 1523272 - Add unit tests for the SiteDataManager. r=baku
Johann Hofmann <jhofmann@mozilla.com> - Thu, 07 Feb 2019 09:02:45 +0000 - rev 457585
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1523272 - Add unit tests for the SiteDataManager. r=baku Differential Revision: https://phabricator.services.mozilla.com/D17871
7250b9f956b65d1f54da8f1cb7ef6ca735d9756a: Bug 1523272 - Use ClearDataService to clear site data in SiteDataManager.jsm. r=baku
Johann Hofmann <jhofmann@mozilla.com> - Thu, 07 Feb 2019 09:02:43 +0000 - rev 457584
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1523272 - Use ClearDataService to clear site data in SiteDataManager.jsm. r=baku Differential Revision: https://phabricator.services.mozilla.com/D17870
c948bb3bd63bd9ce9181d3e391aa6e03999581f0: Bug 1525763 - Use browser:purge-sessionStorage instead of extension:purge-sessionStorage in SiteDataManager.jsm. r=asuth
Johann Hofmann <jhofmann@mozilla.com> - Thu, 07 Feb 2019 08:06:21 +0000 - rev 457583
Push 35516 by rmaries@mozilla.com at Fri, 08 Feb 2019 04:23:26 +0000
Bug 1525763 - Use browser:purge-sessionStorage instead of extension:purge-sessionStorage in SiteDataManager.jsm. r=asuth Differential Revision: https://phabricator.services.mozilla.com/D18894
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip