53ae0fe008c76de2022927a3b1192c339bffeb4b: Bug 1556087 - part1 : remove unnecessary break in reference files. r=heycam
alwu <alwu@mozilla.com> - Fri, 14 Jun 2019 00:01:17 +0000 - rev 478811
Push 36152 by btara@mozilla.com at Fri, 14 Jun 2019 10:00:22 +0000
Bug 1556087 - part1 : remove unnecessary break in reference files. r=heycam In reference files `align_center_position_*.html`, the text `Awesome!!!` doesn't exceed the line box's boundary, so it won't wrap to multiple lines. In other files, we don't have to set the break explicitly, texts would automatically wrap to multiple lines when it exceeds the line box's boundary. Differential Revision: https://phabricator.services.mozilla.com/D33381
105cb00bea7c5e359ae30d8fb58091196f41fe32: Bug 1557412 - enable several wpts which are actually able to pass. r=heycam
alwu <alwu@mozilla.com> - Fri, 14 Jun 2019 00:37:32 +0000 - rev 478810
Push 36152 by btara@mozilla.com at Fri, 14 Jun 2019 10:00:22 +0000
Bug 1557412 - enable several wpts which are actually able to pass. r=heycam These wpt are actually able to pass without having any modification, we should enable them. Differential Revision: https://phabricator.services.mozilla.com/D34103
a2930bb79701c54c30bc67ff27d35ee928ee4335: Backed out 2 changesets (bug 1558364) for build bustages at MediaSpan.h. CLOSED TREE
Brindusan Cristian <cbrindusan@mozilla.com> - Fri, 14 Jun 2019 03:48:51 +0300 - rev 478809
Push 36152 by btara@mozilla.com at Fri, 14 Jun 2019 10:00:22 +0000
Backed out 2 changesets (bug 1558364) for build bustages at MediaSpan.h. CLOSED TREE Backed out changeset 098ce3586133 (bug 1558364) Backed out changeset 2e64d8db2b4b (bug 1558364)
5db908b26d508d9369153131e969bd665028d4d9: Bug 1494796 - exit gracefully if docShell has been destroyed; r=jdescottes
yulia <ystartsev@mozilla.com> - Fri, 14 Jun 2019 00:21:41 +0000 - rev 478808
Push 36152 by btara@mozilla.com at Fri, 14 Jun 2019 10:00:22 +0000
Bug 1494796 - exit gracefully if docShell has been destroyed; r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D32724
c48f00f0df7277bb9e4ec6a5ff885fa754e305d7: Bug 1494796 - update setBreakpoint action on the debugger to be aware of server response; r=jdescottes,jlast
yulia <ystartsev@mozilla.com> - Fri, 14 Jun 2019 00:19:20 +0000 - rev 478807
Push 36152 by btara@mozilla.com at Fri, 14 Jun 2019 10:00:22 +0000
Bug 1494796 - update setBreakpoint action on the debugger to be aware of server response; r=jdescottes,jlast This was a difficult situation. We are not waiting for a server response when setting or removing breakpoints. The result is that the server has not completed those actions by the time the test closed, leaving setBreakpoint or removeBreakpoint requests hanging, causing a number of tests to fail. In order to get around this, I made the panel action "SET_BREAKPOINT" and "REMOVE_BREAKPOINT" aware of the server response. This involved rewriting the helper methods `clientSetBreakpoint` and `clientRemoveBreakpoint` so that they no longer relied on the dispatch. It was not possible to use the dispatches to wait, as they had no event exposed to the tests, especially in cases when we triggered these requests via button presses. Differential Revision: https://phabricator.services.mozilla.com/D32710
591453b88e8beb6adf48abb7f3a8b7ba65514ee8: Bug 1494796 - change test code for reaching into the server; r=jdescottes
yulia <ystartsev@mozilla.com> - Fri, 14 Jun 2019 00:19:02 +0000 - rev 478806
Push 36152 by btara@mozilla.com at Fri, 14 Jun 2019 10:00:22 +0000
Bug 1494796 - change test code for reaching into the server; r=jdescottes we shouldn't have this code, but we do Differential Revision: https://phabricator.services.mozilla.com/D32720
a14e820311bc76670276b75e499cc53a093a0ba4: Bug 1494796 - Fix host resize test caused by timing issue; r=jdescottes
yulia <ystartsev@mozilla.com> - Fri, 14 Jun 2019 00:18:40 +0000 - rev 478805
Push 36152 by btara@mozilla.com at Fri, 14 Jun 2019 10:00:22 +0000
Bug 1494796 - Fix host resize test caused by timing issue; r=jdescottes this is the weird one. we have a Debugger.executeSoon call for the destruction of the host. However, before this happened immediately after the test closed. Now, it happens a little later, and this messes up the data set up. The comment says that we cannot remove this. Differential Revision: https://phabricator.services.mozilla.com/D32722
0e214d450b3598432c78cba1bdefd7e3e6138cff: Bug 1494796 - Delete registerClient functionality; r=jdescottes
yulia <ystartsev@mozilla.com> - Fri, 14 Jun 2019 00:18:32 +0000 - rev 478804
Push 36152 by btara@mozilla.com at Fri, 14 Jun 2019 10:00:22 +0000
Bug 1494796 - Delete registerClient functionality; r=jdescottes The webConsoleFront and the threadClient front both used to depend on the debugger-client to destroy them via registered clients. This is no longer the case, and this code can be deleted Differential Revision: https://phabricator.services.mozilla.com/D32699
1a4ab8b35a85a5b4d25fdab2ff4ce202fa157899: Bug 1494796 - maintain backwards compatibility r=jdescottes
yulia <ystartsev@mozilla.com> - Fri, 14 Jun 2019 00:18:25 +0000 - rev 478803
Push 36152 by btara@mozilla.com at Fri, 14 Jun 2019 10:00:22 +0000
Bug 1494796 - maintain backwards compatibility r=jdescottes Introduce a flag to maintain backwards compatibility with old servers Differential Revision: https://phabricator.services.mozilla.com/D34184
fe1559f5f1d4ca7e10be2004dcf36f36389e30eb: Bug 1494796 - use getFront to retrieve threadClient; r=jdescottes
yulia <ystartsev@mozilla.com> - Fri, 14 Jun 2019 00:18:19 +0000 - rev 478802
Push 36152 by btara@mozilla.com at Fri, 14 Jun 2019 10:00:22 +0000
Bug 1494796 - use getFront to retrieve threadClient; r=jdescottes In order for a front to be available to getFront on a given target, it must be first -- registered on the target scope, and second -- set on the target's targetForm. This makes that update for both browsing context and worker targets. This works as part of a work around until we can get the server into better shape. Differential Revision: https://phabricator.services.mozilla.com/D32698
35d967de4223d278664ca08d75732b1ca8df34b1: Bug 1494796 - Removing threadClient specifics from DebuggerClient Special case resume; r=jdescottes,jlast
yulia <ystartsev@mozilla.com> - Fri, 14 Jun 2019 00:18:17 +0000 - rev 478801
Push 36152 by btara@mozilla.com at Fri, 14 Jun 2019 10:00:22 +0000
Bug 1494796 - Removing threadClient specifics from DebuggerClient Special case resume; r=jdescottes,jlast The resume case is much more complex than the other events, because we do an unsafeSynchronize to send an unsolicited pause. In the old system, the resume response would have been ignored, but that is no longer the case. With the new system, we do not want to send a response to a resume action if it did not come from the UI. This also update the debugger panel code to accept a resume. Differential Revision: https://phabricator.services.mozilla.com/D32697
1d21a55cae1533f21af17b7b7cd1d90ff7381a37: Bug 1494796 - get rid of ThreadClient specifics in DebuggerClient, interrupt method; r=jdescottes
yulia <ystartsev@mozilla.com> - Fri, 14 Jun 2019 00:16:39 +0000 - rev 478800
Push 36152 by btara@mozilla.com at Fri, 14 Jun 2019 10:00:22 +0000
Bug 1494796 - get rid of ThreadClient specifics in DebuggerClient, interrupt method; r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D32847
33eec873a43e5d10d7e999a1b0d8be68646d562f: Bug 1494796 - get rid of ThreadClient specifics in DebuggerClient, attach/detach methods and events; r=jdescottes
yulia <ystartsev@mozilla.com> - Fri, 14 Jun 2019 00:32:28 +0000 - rev 478799
Push 36152 by btara@mozilla.com at Fri, 14 Jun 2019 10:00:22 +0000
Bug 1494796 - get rid of ThreadClient specifics in DebuggerClient, attach/detach methods and events; r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D32845
25e69c21dc2e27e578db2d79f5564b0493e0e2a5: Bug 1494796 - get rid of ThreadClient specifics in DebuggerClient ; r=jdescottes
yulia <ystartsev@mozilla.com> - Fri, 14 Jun 2019 00:28:03 +0000 - rev 478798
Push 36152 by btara@mozilla.com at Fri, 14 Jun 2019 10:00:22 +0000
Bug 1494796 - get rid of ThreadClient specifics in DebuggerClient ; r=jdescottes This is part one of removing threadClient specifics out of the debuggerClient. We were managing messages from the thread client in a special way -- this was the "Unsolicited Pauses" object that we had before. This patch updates the threadClient to use Front style events. This required updating the spec for the threadClient, and several of the methods. What has not been fully migrated here is the "resumed" event, as this is much more complex. This is taken care of in the next patch. Differential Revision: https://phabricator.services.mozilla.com/D32695
b900d41c8ae892b523619423b77ac28edd1a4727: Bug 1494796 - Convert ThreadClient into a Front; r=jdescottes
yulia <ystartsev@mozilla.com> - Fri, 14 Jun 2019 00:14:58 +0000 - rev 478797
Push 36152 by btara@mozilla.com at Fri, 14 Jun 2019 10:00:22 +0000
Bug 1494796 - Convert ThreadClient into a Front; r=jdescottes This is the first part of the threadClient refactor. It only moves the methods to the new front. and does some basic fixes. Differential Revision: https://phabricator.services.mozilla.com/D32692
c2a034e34fa61dc7890f3a2046d97d07aabac001: Bug 1494796 - fork threadclient for backwards compatibility r=jdescottes
yulia <ystartsev@mozilla.com> - Fri, 14 Jun 2019 00:14:36 +0000 - rev 478796
Push 36152 by btara@mozilla.com at Fri, 14 Jun 2019 10:00:22 +0000
Bug 1494796 - fork threadclient for backwards compatibility r=jdescottes make sure we have a copy of thread client for old servers Differential Revision: https://phabricator.services.mozilla.com/D34179
aa7f507ac74362abce9fda28f503851e53ea163b: Bug 1558674 - Allow chrome privileged documents to enable/disable copy/paste. r=Ehsan
Brendan Dahl <bdahl@mozilla.com> - Fri, 14 Jun 2019 00:32:21 +0000 - rev 478795
Push 36152 by btara@mozilla.com at Fri, 14 Jun 2019 10:00:22 +0000
Bug 1558674 - Allow chrome privileged documents to enable/disable copy/paste. r=Ehsan For content HTML/XHTML copy/paste should always be enabled, but for chrome docs we can support enabling/disabling copy/paste. Also, restores tests to how they were before copy/paste was always enabled. Differential Revision: https://phabricator.services.mozilla.com/D34805
098ce3586133fe57aa1d53fe4bdf541b26243563: Bug 1558364 - Convert TrackBuffersManager::mPendingInput into a MediaSpan. r=jya
Chris Pearce <cpearce@mozilla.com> - Fri, 14 Jun 2019 00:31:06 +0000 - rev 478794
Push 36152 by btara@mozilla.com at Fri, 14 Jun 2019 10:00:22 +0000
Bug 1558364 - Convert TrackBuffersManager::mPendingInput into a MediaSpan. r=jya This allows us to avoid a (probably small) copy when we stash the pending input. Differential Revision: https://phabricator.services.mozilla.com/D34662
2e64d8db2b4b630e990903a57bc75c0bfbaca237: Bug 1558364 - Add MediaSpan and use it for TrackBuffersManager::mInputBuffer. r=jya
Chris Pearce <cpearce@mozilla.com> - Fri, 14 Jun 2019 00:31:02 +0000 - rev 478793
Push 36152 by btara@mozilla.com at Fri, 14 Jun 2019 10:00:22 +0000
Bug 1558364 - Add MediaSpan and use it for TrackBuffersManager::mInputBuffer. r=jya As seen in this profile of a Twitch replay: https://perfht.ml/2K9Ydb3 we can often end up spending time in TrackBuffersManager::CodedFrameProcessing() shaving off bytes from the front off TrackBuffersManager::mInputBuffer. This requires all the remaining bytes to be memmove'd down to the start of this array. Sometimes we have close to 1MB in that buffer, and when we're just trying to consume a few hundred bytes, that becomes high overhead. So intead of using this "slice off, shuffle down" approach change TrackBuffersManager::mInputBuffer to be a new type MediaSpan, which maintains a RefPtr to a MediaByteBuffer and a span defining the subregion of the buffer we care about. This means the RemoveElementsAt(0,N) operation becomes basically free, and we can eliminate a few other copies we were doing as well. Differential Revision: https://phabricator.services.mozilla.com/D34661
1eba4a29505b3a57006a1325fa64d8d5aecc2682: Bug 1557792 - Show missing private browsing rows in about:addons r=mixedpuppy
Rob Wu <rob@robwu.nl> - Thu, 13 Jun 2019 22:27:30 +0000 - rev 478792
Push 36152 by btara@mozilla.com at Fri, 14 Jun 2019 10:00:22 +0000
Bug 1557792 - Show missing private browsing rows in about:addons r=mixedpuppy For parity with the XUL about:addons page, this commit adds missing rows to the details view: - Bug 1557792 - incognito not_allowed should show "Not Allowed in Private Windows" - Bug 1551947 - extensions with locked private browsing flag should not show inputs to control the flag, but "Requires Access to Private Windows" Differential Revision: https://phabricator.services.mozilla.com/D34936
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip