51abf3731a71737a336d196b2f004f18b49edff9: Bug 1476016: Fix DEAD_STORE issue in nsMIMEHeaderParamImpl. r=michal
Robert Bartlensky <rbartlensky@mozilla.com> - Tue, 17 Jul 2018 12:32:42 +0100 - rev 428017
Push 34324 by nbeleuzu@mozilla.com at Tue, 24 Jul 2018 22:19:28 +0000
Bug 1476016: Fix DEAD_STORE issue in nsMIMEHeaderParamImpl. r=michal MozReview-Commit-ID: F1p3ji1ezp3
f2a5ae30413b0bb9dbe827b3446025e633cf51db: Bug 1477640 - Make AsyncEventDispatcher(dom::EventTarget* aTarget, dom::Event* aEvent) crash in debug build if aEvent is not safe to be dispatched asynchronously r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 24 Jul 2018 14:51:32 +0900 - rev 428016
Push 34324 by nbeleuzu@mozilla.com at Tue, 24 Jul 2018 22:19:28 +0000
Bug 1477640 - Make AsyncEventDispatcher(dom::EventTarget* aTarget, dom::Event* aEvent) crash in debug build if aEvent is not safe to be dispatched asynchronously r=smaug AsyncEventDispatcher(dom::EventTarget* aTarget, dom::Event* aEvent) just stores aEvent with RefPtr. So, this constructor assumes that aEvent->mEvent is always allocated by dom::Event or its subclasses. For avoiding some callers use dom::Event instances which are created with Widget*Event or Internal*Event in the stack and its DuplicatePrivateData() has never been called, this patch add MOZ_ASSERT to check if aEvent->mEventIsInternal is true. MozReview-Commit-ID: FrmUK2pVasu
5c1bb5087c9daa0cf29e5848e2cd8e87ecf14458: Bug 1477889 - Remove *.google.com from "dom.keyboardevent.keypress.hack.dispatch_non_printable_keys" r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 24 Jul 2018 14:15:33 +0900 - rev 428015
Push 34324 by nbeleuzu@mozilla.com at Tue, 24 Jul 2018 22:19:28 +0000
Bug 1477889 - Remove *.google.com from "dom.keyboardevent.keypress.hack.dispatch_non_printable_keys" r=smaug Google fixed to support Firefox Nightly with strict keypress dispatching mode. So, we can now drop *.google.com from the blacklist. MozReview-Commit-ID: EICAwlVmjLn
2c8b3ee0775181c54cbadc5c96e449783ef02e3b: Bug 1476897 - part 7: Drop nsIEditorMailSupport interface from TextEditor r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 23 Jul 2018 16:45:07 +0900 - rev 428014
Push 34324 by nbeleuzu@mozilla.com at Tue, 24 Jul 2018 22:19:28 +0000
Bug 1476897 - part 7: Drop nsIEditorMailSupport interface from TextEditor r=m_kato Nobody uses nsIEditorMailSupport interface with TextEditor instances. Therefore, stopping nsIEditorMailSupport interface support of TextEditor saves memory of TextEditor which may be created a lot even in a document. MozReview-Commit-ID: BJ4ucCaeYHl
62e18ecb29eaab944ffd617c403586a289013cb8: Bug 1476897 - part 6: Move implementation of both TextEditor::PasteAsQuotation() and HTMLEditor::PasteAsQuotation() to new virtual methods r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 23 Jul 2018 16:34:03 +0900 - rev 428013
Push 34324 by nbeleuzu@mozilla.com at Tue, 24 Jul 2018 22:19:28 +0000
Bug 1476897 - part 6: Move implementation of both TextEditor::PasteAsQuotation() and HTMLEditor::PasteAsQuotation() to new virtual methods r=m_kato Neither TextEditor::PasteAsQuotation() nor HTMLEditor::PasteAsQuotation() is used via nsIEditorMailSupport. So, perhaps, we can remove this method from the interface. But for now, we should move each implementation to new virtual methods and make only HTMLEditor::PasteAsQuotation() calls new method since nobody uses nsIEditorMailSupport with TextEditor instances. MozReview-Commit-ID: Eilxk74VHwT
2356492fb27c4a12abc8b8e87508c651ac21e68a: Bug 1476897 - part 5: Move implementation of TextEditor::InsertAsQuotation() to new method r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 23 Jul 2018 16:05:30 +0900 - rev 428012
Push 34324 by nbeleuzu@mozilla.com at Tue, 24 Jul 2018 22:19:28 +0000
Bug 1476897 - part 5: Move implementation of TextEditor::InsertAsQuotation() to new method r=m_kato TextEditor::InsertAsQuotation() is not used as a method of nsIEditorMailSupport, however, this is used internally. So, we need to keep this method's function as a non-virtual method but we can make the method just return NS_ERROR_NOT_IMPLEMENTED. MozReview-Commit-ID: 2CcY4SZGwyr
e5c9e728940a184eab5f0442fa4ee95acadf76d9: Bug 1476897 - part 4: Make TextEditor::InsertTextWithQuotations() returns NS_ERROR_NOT_IMPLEMENTED since it's never used r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 23 Jul 2018 15:25:18 +0900 - rev 428011
Push 34324 by nbeleuzu@mozilla.com at Tue, 24 Jul 2018 22:19:28 +0000
Bug 1476897 - part 4: Make TextEditor::InsertTextWithQuotations() returns NS_ERROR_NOT_IMPLEMENTED since it's never used r=m_kato InsertTextWithQuotations() is called only by HTMLEditor::Rewrap(). So, HTMLEditor::InsertTextWithQuotations() is always called. Therefore, we can make it just return NS_ERROR_NOT_IMPLEMENTED. MozReview-Commit-ID: FvmY2x3OOn7
e8d209654ba4a26aaa5a5d9f444ab0576c9c5e2e: Bug 1476897 - part 3: Make TextEditor::InsertAsCitedQuotation() return NS_ERROR_NOT_IMPLEMENTED since nobody uses this method with TextEditor instances r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 23 Jul 2018 15:17:03 +0900 - rev 428010
Push 34324 by nbeleuzu@mozilla.com at Tue, 24 Jul 2018 22:19:28 +0000
Bug 1476897 - part 3: Make TextEditor::InsertAsCitedQuotation() return NS_ERROR_NOT_IMPLEMENTED since nobody uses this method with TextEditor instances r=m_kato MozReview-Commit-ID: 487sf6d2wrt
39ff01e6d72995b28393984eb33f65f38a3fbf3d: Bug 1476897 - part 2: Make TextEditor::GetEmbeddedObjects() just return NS_ERROR_NOT_IMPLEMENTED since it's never used r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 23 Jul 2018 15:07:35 +0900 - rev 428009
Push 34324 by nbeleuzu@mozilla.com at Tue, 24 Jul 2018 22:19:28 +0000
Bug 1476897 - part 2: Make TextEditor::GetEmbeddedObjects() just return NS_ERROR_NOT_IMPLEMENTED since it's never used r=m_kato TextEditor::GetEmbeddedObjects() is never called unless nsIEditorMailSupport::GetEmbeddedObjects() is used with TextEditor instance. However, nobody uses nsIEditorMailSupport interface with TextEditor instance. MozReview-Commit-ID: 4HTnL7KsNGf
07d193decac0486f7fc15ee537a65841023b6923: Bug 1476897 - part 1: Implement nsIEditorMailSupport in HTMLEditor since it's never used with TextEditor instance r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 23 Jul 2018 14:40:05 +0900 - rev 428008
Push 34324 by nbeleuzu@mozilla.com at Tue, 24 Jul 2018 22:19:28 +0000
Bug 1476897 - part 1: Implement nsIEditorMailSupport in HTMLEditor since it's never used with TextEditor instance r=m_kato MozReview-Commit-ID: 5JT4m0IftXY
500fb6bfc8717dd8e3affd94c39c9085c01f5035: Bug 1471893 - Write to a new property if the one we're trying is disabled or overwritten. r=pbro
Patrick Brosset <pbrosset@mozilla.com> - Fri, 20 Jul 2018 15:41:37 +0200 - rev 428007
Push 34324 by nbeleuzu@mozilla.com at Tue, 24 Jul 2018 22:19:28 +0000
Bug 1471893 - Write to a new property if the one we're trying is disabled or overwritten. r=pbro MozReview-Commit-ID: B306en6o2M0
e679e55fc5d485d52ce5893bb2cb5315a1839390: Backed out changeset 9162b1c01237 (bug 1452061) for failing at performance/components/test/test_jit_optimizations_01.html on a CLOSED TREE
Gurzau Raul <rgurzau@mozilla.com> - Tue, 24 Jul 2018 17:11:01 +0300 - rev 428006
Push 34324 by nbeleuzu@mozilla.com at Tue, 24 Jul 2018 22:19:28 +0000
Backed out changeset 9162b1c01237 (bug 1452061) for failing at performance/components/test/test_jit_optimizations_01.html on a CLOSED TREE
ab1b54921f26a02fb155b855a95ecffb94efe016: Bug 1476053 - Handle invalid json in metadata updates, r=ato
James Graham <james@hoppipolla.co.uk> - Mon, 23 Jul 2018 19:13:41 +0100 - rev 428005
Push 34324 by nbeleuzu@mozilla.com at Tue, 24 Jul 2018 22:19:28 +0000
Bug 1476053 - Handle invalid json in metadata updates, r=ato Sometimes we get errors that result in invalid json in the logs. There's nothing reasonable to do about this during metadata updates so just skip it MozReview-Commit-ID: 4QuM7M3lXGv
bfb7d92282e8ab7fa61ae3784b73d30d63cfb44f: Bug 1476053 - Enabling updating wpt metadata from wptreport.json files, r=ato
James Graham <james@hoppipolla.co.uk> - Tue, 10 Jul 2018 10:42:48 +0100 - rev 428004
Push 34324 by nbeleuzu@mozilla.com at Tue, 24 Jul 2018 22:19:28 +0000
Bug 1476053 - Enabling updating wpt metadata from wptreport.json files, r=ato Raw log files have the big disadvantage that they are large and we therefore spend a lot of time just downloading the log files and parsing json. wptreport.json files are much smaller and so reduce these issues. In order to support both formats, we first try parsing the log as json. If that succeeds, and we have the expected keys, we parse it as a wptreport file by reconstructing the events we would have got in a raw log. If that doesn't work we fall back to the standard raw log processing. MozReview-Commit-ID: 7rjTJJUPhpz
fcf3f7f2079a3091f7f08df6987985d4acedeab8: Bug 1476053 - Optimise wpt metadata updates, r=ato
James Graham <james@hoppipolla.co.uk> - Tue, 10 Jul 2018 10:13:02 +0100 - rev 428003
Push 34324 by nbeleuzu@mozilla.com at Tue, 24 Jul 2018 22:19:28 +0000
Bug 1476053 - Optimise wpt metadata updates, r=ato The previous strategy for wpt metadata updates was to read add the existing expected files, annotate them with the new results, compute the resulting expectation file, and reserialize everything. This was quite straighforward, but it has a number of disadvantages: * Slow, since all expectation files need to be read and written, even when there were no changes affecting those files. * Memory intensive, since we have to load all the results and the metadata at the same time, and little optimisation had been done. This could lead to OOM for large updates on some machines. * Confusing, since parsing and reserializing files leads to changes in "unrelated" metadata Instead we take the approach that we should only update the metadata in cases where there are actually changes. Inteads of loading all the expectation files, we do the following: * Load all the results data into a large nested dictionary, keeping track of which results files had an update that requires regenerating metadata. * Load/serialize metadata only in the cases it changed, and one at a time. Loading all the data upfront is still necessary because we effectively need to traspose the input data in cases where we have multiple configurations running the same test (i.e. we get the data per run and want the data for all runs per test). This approach also has the disadvantage that it's more likely to miss a necessary update. However the tradeoffs for better performance are still worthwhile. MozReview-Commit-ID: 1jevEmRsJxc
1380819f4aa5161236678f5df54a63c0c5442b78: Bug 1476053 - Add lsan leak reports to wptreport output, r=ato
James Graham <james@hoppipolla.co.uk> - Tue, 10 Jul 2018 10:11:15 +0100 - rev 428002
Push 34324 by nbeleuzu@mozilla.com at Tue, 24 Jul 2018 22:19:28 +0000
Bug 1476053 - Add lsan leak reports to wptreport output, r=ato This adds a top level key lsan_leaks iff there are any leaks detected in the run. The data is equivalent to that in the underlying structured logger. MozReview-Commit-ID: I3ex7Yamhoh
bc1c54e5dceab68e5ea448ca69b26ed8d74edb09: Bug 1476053 - Add an option not to store state when running wpt-update, r=jdm
James Graham <james@hoppipolla.co.uk> - Tue, 10 Jul 2018 10:09:43 +0100 - rev 428001
Push 34324 by nbeleuzu@mozilla.com at Tue, 24 Jul 2018 22:19:28 +0000
Bug 1476053 - Add an option not to store state when running wpt-update, r=jdm This adds some overhead and can be annoying since it requries explicitly aborting failed jobs. The state storage isn't very useful for just udpating metadata (the typical gecko usecase), but is useful for performing syncs (a typical servo usecase). Therefore add a --no-store-state option and set it by default in the gecko mach frontend. MozReview-Commit-ID: LhEcMkyuRHD
cf969e57bc7b713077f2cafe40e3c4349de3c1ff: Bug 1476678 - Remove document.persist from XULDocument;r=bz
Brian Grinstead <bgrinstead@mozilla.com> - Sat, 21 Jul 2018 10:46:25 -0700 - rev 428000
Push 34324 by nbeleuzu@mozilla.com at Tue, 24 Jul 2018 22:19:28 +0000
Bug 1476678 - Remove document.persist from XULDocument;r=bz Also remove overload for XULDocument::Persist and the implementation of XULDocument::DoPersist, since there's only one remaining caller. MozReview-Commit-ID: CPaTdFJ4GOx
61f33f8c87508dae19c577c74ec71eae459c6aaf: Bug 1468812 - [ci] Support MOZ_FETCHES and fetch-content in run-task r=gps
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 24 Jul 2018 13:11:25 +0000 - rev 427999
Push 34324 by nbeleuzu@mozilla.com at Tue, 24 Jul 2018 22:19:28 +0000
Bug 1468812 - [ci] Support MOZ_FETCHES and fetch-content in run-task r=gps This removes the 'use-artifacts' mechanism in favour of fetches. There are a few pieces here that need to land atomically: 1. Remove use-artifact related code 2. Call 'fetch-content' from the run-task script 3. Convert existing tasks on top of fetches (jsshell, python unittest) 4. Stop calling 'fetch-content' from toolchain setup tasks (as this now gets handled in run-task) Depends on D2166. Differential Revision: https://phabricator.services.mozilla.com/D2167
79426f83650f78d8d4b6f8ad8832112e2637ac18: Bug 1477246 - Remove horizontal padding from bookmark panel bottom buttons. r=mak
Dão Gottwald <dao@mozilla.com> - Fri, 20 Jul 2018 15:16:57 +0200 - rev 427998
Push 34324 by nbeleuzu@mozilla.com at Tue, 24 Jul 2018 22:19:28 +0000
Bug 1477246 - Remove horizontal padding from bookmark panel bottom buttons. r=mak MozReview-Commit-ID: BQcMPddyylI
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip