50d1b7c5b1a170997c7706e8f8fc5ff4df730077: Bug 1493525 - Part I, Access layout dimensions in resizevideocontrols event only r=jaws
Timothy Guan-tin Chien <timdream@gmail.com> - Thu, 27 Sep 2018 17:44:44 +0000 - rev 438563
Push 34724 by ccoroiu@mozilla.com at Thu, 27 Sep 2018 21:36:09 +0000
Bug 1493525 - Part I, Access layout dimensions in resizevideocontrols event only r=jaws Given that the videocontrols UA Widget initializes when the DOM is inserted (as opposed to the XBL binding only when the element is visible), the code should not be tapping into layout until it updates. Differential Revision: https://phabricator.services.mozilla.com/D6725
4ff0fcd61c7a1f791414516a6e22efca94530f19: Bug 1490805 - Add a required CSC/CVV field to the add card page. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 27 Sep 2018 17:26:24 +0000 - rev 438562
Push 34724 by ccoroiu@mozilla.com at Thu, 27 Sep 2018 21:36:09 +0000
Bug 1490805 - Add a required CSC/CVV field to the add card page. r=jaws Depends on D6882 Differential Revision: https://phabricator.services.mozilla.com/D6883
39762ef5d56e07f8046bf9dfb1b32f194c6ea1bd: bug 1493427 - use the docShell to call OnSecurityChange in nsSecureBrowserUIImpl::OnLocationChange r=Gijs
Dana Keeler <dkeeler@mozilla.com> - Thu, 27 Sep 2018 17:26:00 +0000 - rev 438561
Push 34724 by ccoroiu@mozilla.com at Thu, 27 Sep 2018 21:36:09 +0000
bug 1493427 - use the docShell to call OnSecurityChange in nsSecureBrowserUIImpl::OnLocationChange r=Gijs When navigating to an about: page that doesn't exist (e.g. "about:somethingthatdoesnotexist"), the docShell will call nsSecureBrowserUIImpl::OnLocationChange with a request that is null. Consequently, we can't use that to QueryInterface to a nsISecurityEventSink to call OnSecurityChange. The previous implementation would use the prior request's nsISecurityEventSink, which was a bug but luckily this produced the correct behavior. Since the original docShell the nsSecureBrowserUIImpl was initialized with is what needs to be notified, we can just QueryInterface that to an nsISecurityEventSink and call OnSecurityChange directly instead. Differential Revision: https://phabricator.services.mozilla.com/D6951
95ae87f521480c6fa1e9b4647993e44077d58342: Bug 1410820 - Extensively test top-level await evaluation; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 27 Sep 2018 16:01:16 +0000 - rev 438560
Push 34724 by ccoroiu@mozilla.com at Thu, 27 Sep 2018 21:36:09 +0000
Bug 1410820 - Extensively test top-level await evaluation; r=bgrins. We add several tests and modify the existing one to make sure we handle top level await correctly in different situation (resolving, rejecting, when paused in the debugger, when using $_, …). Depends on D6925 Differential Revision: https://phabricator.services.mozilla.com/D6926
a7edd08b7f6d0755191a8eadb000ed63bc10e082: Bug 1410820 - Enhance webconsole test helpers; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 27 Sep 2018 16:00:32 +0000 - rev 438559
Push 34724 by ccoroiu@mozilla.com at Thu, 27 Sep 2018 21:36:09 +0000
Bug 1410820 - Enhance webconsole test helpers; r=bgrins. 1. Allow passing a selector to waitForMessage helper function: This will allow to wait for specific message (warning, error, result, …). This patch also fixes 2 tests that were already passing an erroneous selector to waitForMessage. 2. Add an executeAndWaitForMessage function: This will make a lot of our tests much easier to read. The function takes an input, an expected output and an optional selector, execute the input and resolves when a message matching the provided text (and selector if passed) is displayed in the output. Depends on D6903 Differential Revision: https://phabricator.services.mozilla.com/D6925
6fabe40627008d10c2ff8a78e8d2932264149cb5: Bug 1410820 - top-level await evaluation should be handled as regular evaluation; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 27 Sep 2018 15:59:47 +0000 - rev 438558
Push 34724 by ccoroiu@mozilla.com at Thu, 27 Sep 2018 21:36:09 +0000
Bug 1410820 - top-level await evaluation should be handled as regular evaluation; r=bgrins. This patch turns the current top-level handling, which relies on the console API to print the result of the await expression, into something natively handled by the server. First, we don't add a .then handler to the generated async iife by the mapper. We also removes the case we added in the JsTerm to *not* print the result for top-level await expression. In order to make the server capable of handling generated async iife caused by the mapper, we send to evaluateJsAsync the `mapped` object that `mapExpression` returns. This way, the server can check if an expression was originally a top-level await. If it is the case, we get the promise from the async iife and wait for it to settle. If it resolves, we simply return the result, as a grip, to the client. If it rejects, we return a special packet indicating to not print anything to the client. The error will be reported by the engine as `uncaught exception: …`. We add several tests and modify the existing one to make sure we handle top level await correctly in different situation (resolving, rejecting, when paused in the debugger, when using $_, …). Differential Revision: https://phabricator.services.mozilla.com/D6903
241b06f4daf2fe4d33362b1eb70ded785b088b36: Bug 1494545 - Make Ctrl+Space open the autocomplete popup in the console; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 27 Sep 2018 16:36:11 +0000 - rev 438557
Push 34724 by ccoroiu@mozilla.com at Thu, 27 Sep 2018 21:36:09 +0000
Bug 1494545 - Make Ctrl+Space open the autocomplete popup in the console; r=Honza. Differential Revision: https://phabricator.services.mozilla.com/D7049
e828cf7c367e0c1e73ef537f1dd5dec4bf7e43cf: Merge mozilla-central to autoland. a=merge CLOSED TREE
Gurzau Raul <rgurzau@mozilla.com> - Thu, 27 Sep 2018 19:45:35 +0300 - rev 438556
Push 34724 by ccoroiu@mozilla.com at Thu, 27 Sep 2018 21:36:09 +0000
Merge mozilla-central to autoland. a=merge CLOSED TREE
af12b0d1495408ede4ddadd92835763168ebc534: Backed out 5 changesets (bug 1494613) for failing at testing/geckodriver/src/marionette.rs
Gurzau Raul <rgurzau@mozilla.com> - Thu, 27 Sep 2018 18:49:58 +0300 - rev 438555
Push 34724 by ccoroiu@mozilla.com at Thu, 27 Sep 2018 21:36:09 +0000
Backed out 5 changesets (bug 1494613) for failing at testing/geckodriver/src/marionette.rs Backed out changeset 09e9cefc19ca (bug 1494613) Backed out changeset f9f4e7c55d61 (bug 1494613) Backed out changeset 457da8a172be (bug 1494613) Backed out changeset 8d26a58f754e (bug 1494613) Backed out changeset 729d8f3e1341 (bug 1494613)
92076b801e6b2720d7959645706f0917e9d7dc07: Bug 1493668 - Change UrlbarInput unit test to be a mochitest for easier setup. r=dao
Mark Banner <standard8@mozilla.com> - Thu, 27 Sep 2018 15:04:07 +0000 - rev 438554
Push 34724 by ccoroiu@mozilla.com at Thu, 27 Sep 2018 21:36:09 +0000
Bug 1493668 - Change UrlbarInput unit test to be a mochitest for easier setup. r=dao Differential Revision: https://phabricator.services.mozilla.com/D6664
44e5267358ebe8a413ce727f3aa20122d58a503e: Bug 1493276 - Statically prevent CallQueryInterface to a base class r=froydnj
Andrew McCreight <continuation@gmail.com> - Thu, 27 Sep 2018 14:59:55 +0000 - rev 438553
Push 34724 by ccoroiu@mozilla.com at Thu, 27 Sep 2018 21:36:09 +0000
Bug 1493276 - Statically prevent CallQueryInterface to a base class r=froydnj If a class A is derived from a class B, then an instance of A can be converted to an instance of class B via a static cast, so QI is not needed. QIs are slower than static casts. TestCallTemplates seems to be testing that CallQueryInterface compiles even if the first argument's class is only ambiguously castable to nsISupports, so I changed the second argument to be a class unrelated to the concrete class. I also removed some useless null checks on the return value of new. Differential Revision: https://phabricator.services.mozilla.com/D6838
fc8298adbd8aff7796184feb669284c75e804469: Bug 1494337 - Do not display the 'triggers refresh' note if there's no option needing it r=ochameau
Julien Wajsberg <felash@gmail.com> - Thu, 27 Sep 2018 14:33:41 +0000 - rev 438552
Push 34724 by ccoroiu@mozilla.com at Thu, 27 Sep 2018 21:36:09 +0000
Bug 1494337 - Do not display the 'triggers refresh' note if there's no option needing it r=ochameau Depends on D6923 Differential Revision: https://phabricator.services.mozilla.com/D6920
0a76f7bedb472286df1ce291c2a892993407f88f: Bug 1494337 - Move the 'tool not supported' label to the right place r=ochameau
Julien Wajsberg <felash@gmail.com> - Thu, 27 Sep 2018 14:33:39 +0000 - rev 438551
Push 34724 by ccoroiu@mozilla.com at Thu, 27 Sep 2018 21:36:09 +0000
Bug 1494337 - Move the 'tool not supported' label to the right place r=ochameau Depends on D6922 Differential Revision: https://phabricator.services.mozilla.com/D6923
56bf518927fae43610d344c84988309b0070f183: Bug 1494337 - Insert the settings for nightly before the 'reloads the page' indication r=ochameau
Julien Wajsberg <felash@gmail.com> - Thu, 27 Sep 2018 14:33:38 +0000 - rev 438550
Push 34724 by ccoroiu@mozilla.com at Thu, 27 Sep 2018 21:36:09 +0000
Bug 1494337 - Insert the settings for nightly before the 'reloads the page' indication r=ochameau Differential Revision: https://phabricator.services.mozilla.com/D6922
e2f7985ef41dc4d5a4f088f49b74152c5323f95d: Bug 1470168 - Add tooltip beside 'Save to Firefox' checkbox. r=MattN
Jared Wein <jwein@mozilla.com> - Thu, 27 Sep 2018 14:11:39 +0000 - rev 438549
Push 34724 by ccoroiu@mozilla.com at Thu, 27 Sep 2018 21:36:09 +0000
Bug 1470168 - Add tooltip beside 'Save to Firefox' checkbox. r=MattN I had to move the tooltip to appear above the help icon to make sure that it cause scrollbars to appear on the address form. Differential Revision: https://phabricator.services.mozilla.com/D6912
24bc7799209725693fca6b3833acea40d650edd8: Bug 1494622 - Simplify CSSValue and co a bit more. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 27 Sep 2018 00:25:20 +0200 - rev 438548
Push 34724 by ccoroiu@mozilla.com at Thu, 27 Sep 2018 21:36:09 +0000
Bug 1494622 - Simplify CSSValue and co a bit more. r=xidorn Just remove the useless stuff. Differential Revision: https://phabricator.services.mozilla.com/D7071
da3603d0fef2ec5c212e252403636b223603ed43: Bug 1494622 - Remove nsDOMCSSRect. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 26 Sep 2018 23:50:01 +0200 - rev 438547
Push 34724 by ccoroiu@mozilla.com at Thu, 27 Sep 2018 21:36:09 +0000
Bug 1494622 - Remove nsDOMCSSRect. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D7070
fb7be8b4ae804709379c35f190708636c49606b1: Bug 1494622 - Serialize -moz-image-region and clip with Servo. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 26 Sep 2018 23:43:22 +0200 - rev 438546
Push 34724 by ccoroiu@mozilla.com at Thu, 27 Sep 2018 21:36:09 +0000
Bug 1494622 - Serialize -moz-image-region and clip with Servo. r=xidorn This changes the serialization of -moz-image-region to be consistent with that of clip(), but it's an internal property and the specified value is already serialized by servo so I think it's the right thing to do. There are also no internal callers of the getter. Differential Revision: https://phabricator.services.mozilla.com/D7069
f3bfb76e088a2cbdd944bda1fc4724d18eca2ae4: Bug 1494622 - Remove nsDOMCSSRGBColor. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 26 Sep 2018 23:06:24 +0200 - rev 438545
Push 34724 by ccoroiu@mozilla.com at Thu, 27 Sep 2018 21:36:09 +0000
Bug 1494622 - Remove nsDOMCSSRGBColor. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D7068
31d61c73ab751904374d1bdc81c594add80b4cde: Bug 1494332 - Avoid setting the has-first-letter child bit on a first-line. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 27 Sep 2018 13:16:00 +0000 - rev 438544
Push 34724 by ccoroiu@mozilla.com at Thu, 27 Sep 2018 21:36:09 +0000
Bug 1494332 - Avoid setting the has-first-letter child bit on a first-line. r=bzbarsky We rely on the bit being on the block to restyle them in the right order. Differential Revision: https://phabricator.services.mozilla.com/D7086
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip