5081a75fbe8ccff1139853dbea6aeb92bd6fdc9d: Bug 1245748 - Add a Move constructor to Keyframe; r=heycam
Brian Birtles <birtles@gmail.com> - Thu, 24 Mar 2016 10:39:29 +0900 - rev 290216
Push 30114 by cbook@mozilla.com at Thu, 24 Mar 2016 15:15:54 +0000
Bug 1245748 - Add a Move constructor to Keyframe; r=heycam I have confirmed that by adding this, we end up calling SwapElements() on the mPropertyValues member when we build up the nsTArray<Keyframe> result in GetKeyframeListFromPropertyIndexedKeyframe. Without this explicit move constructor (i.e. with only the default move constructor) the copy-constructor for mPropertyValues is called. MozReview-Commit-ID: 6IWkP97RFUr
5dbdbe3e4655a385663f25b7e16f85fbcf5f9207: Bug 1245748 - Remove no-longer-needed code for directly setting up properties in KeyframeEffect(ReadOnly) constructor; r=heycam
Brian Birtles <birtles@gmail.com> - Tue, 22 Mar 2016 16:36:45 +0900 - rev 290215
Push 30114 by cbook@mozilla.com at Thu, 24 Mar 2016 15:15:54 +0000
Bug 1245748 - Remove no-longer-needed code for directly setting up properties in KeyframeEffect(ReadOnly) constructor; r=heycam MozReview-Commit-ID: 4V3LMByas9Q
88795391fe8b748c6aa1d7493733aa8c49a9c5c7: Bug 1245748 - Use Keyframe-based utility functions when constructing KeyframeEffect(ReadOnly); r=heycam
Brian Birtles <birtles@gmail.com> - Tue, 22 Mar 2016 16:35:53 +0900 - rev 290214
Push 30114 by cbook@mozilla.com at Thu, 24 Mar 2016 15:15:54 +0000
Bug 1245748 - Use Keyframe-based utility functions when constructing KeyframeEffect(ReadOnly); r=heycam MozReview-Commit-ID: 72vLatkFqMq
d2939b503235e1c077b014139c26b9d617f2bfb0: Bug 1245748 - Add ApplyDistributeSpacing for Keyframe objects; r=heycam
Brian Birtles <birtles@gmail.com> - Tue, 22 Mar 2016 16:35:53 +0900 - rev 290213
Push 30114 by cbook@mozilla.com at Thu, 24 Mar 2016 15:15:54 +0000
Bug 1245748 - Add ApplyDistributeSpacing for Keyframe objects; r=heycam MozReview-Commit-ID: 8KNERsl8tea
0ea9096a60d242edf82ecf3d6ebfcd933988ec65: Bug 1245748 - Add GetAnimationPropertiesFromKeyframes; r=heycam
Brian Birtles <birtles@gmail.com> - Tue, 22 Mar 2016 16:34:14 +0900 - rev 290212
Push 30114 by cbook@mozilla.com at Thu, 24 Mar 2016 15:15:54 +0000
Bug 1245748 - Add GetAnimationPropertiesFromKeyframes; r=heycam MozReview-Commit-ID: GUnogloqViS
2d6642da5c506cbe5f210af3103dbebb8299be05: Bug 1245748 - Add PropertyPriorityIterator; r=heycam
Brian Birtles <birtles@gmail.com> - Tue, 22 Mar 2016 16:33:16 +0900 - rev 290211
Push 30114 by cbook@mozilla.com at Thu, 24 Mar 2016 15:15:54 +0000
Bug 1245748 - Add PropertyPriorityIterator; r=heycam MozReview-Commit-ID: JjBWcyEG3f6
a292ea900280e9f1fd743c5bcddfe06435fea5a8: Bug 1245748 - Split PropertyPriorityComparator into a separate (reusable) class; r=heycam
Brian Birtles <birtles@gmail.com> - Tue, 22 Mar 2016 16:33:11 +0900 - rev 290210
Push 30114 by cbook@mozilla.com at Thu, 24 Mar 2016 15:15:54 +0000
Bug 1245748 - Split PropertyPriorityComparator into a separate (reusable) class; r=heycam MozReview-Commit-ID: Gq5VylZoS2q
47f2d102202f8e4d2afd14b8ad2d51b0b4b27474: Bug 1245748 - Add a variant of StyleAnimationValue::ComputeValues that takes an nsCSSValue; r=heycam
Brian Birtles <birtles@gmail.com> - Tue, 22 Mar 2016 16:31:16 +0900 - rev 290209
Push 30114 by cbook@mozilla.com at Thu, 24 Mar 2016 15:15:54 +0000
Bug 1245748 - Add a variant of StyleAnimationValue::ComputeValues that takes an nsCSSValue; r=heycam MozReview-Commit-ID: 83popM8E0Q4
20252fc7d044ec2b8b7e402d19e8b0d52f97e773: Bug 1245748 - Add nsStyleContext parameter to StyleAnimationValue::ComputeValue(s); r=heycam
Brian Birtles <birtles@gmail.com> - Tue, 22 Mar 2016 16:31:09 +0900 - rev 290208
Push 30114 by cbook@mozilla.com at Thu, 24 Mar 2016 15:15:54 +0000
Bug 1245748 - Add nsStyleContext parameter to StyleAnimationValue::ComputeValue(s); r=heycam StyleAnimationValue::ComputeValue(s) will automatically look up the style context of the supplied element. This is mostly fine, but when we start using this method in scenarios where we are building the initial style context (as happens later in this patch series) it can easily land us in a situation where we iterate indefinitely. It would be better, instead, to just explicitly pass in the style context we want to use, as we already do for StyleAnimationValue::ExtractComputedValue. MozReview-Commit-ID: ZoVBlBRRBI
bb43b0b51db3c76af8448173e6aa71b710b76398: Bug 1245748 - Add KeyframeUtils::GetKeyframesFromObject; r=heycam
Brian Birtles <birtles@gmail.com> - Tue, 22 Mar 2016 16:25:38 +0900 - rev 290207
Push 30114 by cbook@mozilla.com at Thu, 24 Mar 2016 15:15:54 +0000
Bug 1245748 - Add KeyframeUtils::GetKeyframesFromObject; r=heycam MozReview-Commit-ID: 2cl8NIMApSy
3fd3083eaf4c059ccb7b7857705b7520b87e5705: Bug 1245748 - Move keyframe handling code to a separate KeyframeUtils class; r=heycam
Brian Birtles <birtles@gmail.com> - Tue, 22 Mar 2016 16:20:37 +0900 - rev 290206
Push 30114 by cbook@mozilla.com at Thu, 24 Mar 2016 15:15:54 +0000
Bug 1245748 - Move keyframe handling code to a separate KeyframeUtils class; r=heycam MozReview-Commit-ID: 2r27vCLcOhs
a2fc06886cf5e27493fc2e1bc1b0528878f9085f: Bug 1245748 - Add missing includes to TimingParams.{cpp,h}; r=heycam
Brian Birtles <birtles@gmail.com> - Tue, 22 Mar 2016 16:20:31 +0900 - rev 290205
Push 30114 by cbook@mozilla.com at Thu, 24 Mar 2016 15:15:54 +0000
Bug 1245748 - Add missing includes to TimingParams.{cpp,h}; r=heycam Once we tweak moz.build in the next patch, the grouping in the unified build will change and expose these missing includes so we fix them here, first. MozReview-Commit-ID: GebEEociwTo
e5b7f120513e6f98ae9db9e0daaa07204eb8f3d4: Bug 1245748 - Define the Keyframe type for storing specified keyframes; r=heycam
Brian Birtles <birtles@gmail.com> - Tue, 22 Mar 2016 16:19:43 +0900 - rev 290204
Push 30114 by cbook@mozilla.com at Thu, 24 Mar 2016 15:15:54 +0000
Bug 1245748 - Define the Keyframe type for storing specified keyframes; r=heycam MozReview-Commit-ID: rejtrG0U1A
b692d554f9319cbdf9b9174e3eef54dce411a4a9: Bug 1245748 - Update handling of 'composite' dictionary members to match changes to the spec; r=heycam, r=bz
Brian Birtles <birtles@gmail.com> - Tue, 22 Mar 2016 16:18:22 +0900 - rev 290203
Push 30114 by cbook@mozilla.com at Thu, 24 Mar 2016 15:15:54 +0000
Bug 1245748 - Update handling of 'composite' dictionary members to match changes to the spec; r=heycam, r=bz Specifically, for the 'composite' member on keyframes, we now indicate "use the composite value specified on the effect" using a missing/undefined 'composite' member as opposed to a null value. MozReview-Commit-ID: ZH45GvCTlP
b66be52a688f020717a886deb3905c64bc2a5142: Bug 1245748 - Rename Keyframe-related IDL types to match changes to Web Animations spec; r=heycam, r=bz
Brian Birtles <birtles@gmail.com> - Tue, 22 Mar 2016 16:16:39 +0900 - rev 290202
Push 30114 by cbook@mozilla.com at Thu, 24 Mar 2016 15:15:54 +0000
Bug 1245748 - Rename Keyframe-related IDL types to match changes to Web Animations spec; r=heycam, r=bz In particular, the spec no longer has Keyframe and PropertyIndexedKeyframes types but rather deals with objects. The algorithms for processing these objects, however, define various Base* types: https://w3c.github.io/web-animations/#dictdef-basepropertyindexedkeyframe https://w3c.github.io/web-animations/#dictdef-basekeyframe https://w3c.github.io/web-animations/#dictdef-basecomputedkeyframe MozReview-Commit-ID: 3RqoEO66kJ
68c978a14bbcec031f298d0a62b7fe2288e07a40: Bug 1245748 - Move ComputedTiming to a separate file; r=heycam
Brian Birtles <birtles@gmail.com> - Tue, 22 Mar 2016 08:11:05 +0900 - rev 290201
Push 30114 by cbook@mozilla.com at Thu, 24 Mar 2016 15:15:54 +0000
Bug 1245748 - Move ComputedTiming to a separate file; r=heycam Before we begin re-arranging KeyframeEffect.h we move ComputedTiming aside since putting it in a separate file should make navigating the source easier. MozReview-Commit-ID: L5GTFAo00sh
406c780a3817d283d9a65ab2a037f1131e96f7c9: Bug 1253590, part 4 - Follow-up to return the correct type. r=bustage
Jonathan Watt <jwatt@jwatt.org> - Sat, 12 Mar 2016 18:43:40 +0000 - rev 290200
Push 30114 by cbook@mozilla.com at Thu, 24 Mar 2016 15:15:54 +0000
Bug 1253590, part 4 - Follow-up to return the correct type. r=bustage
ad88856cdfdc498bf299d5ac074699a4061b5ada: Bug 1253590, part 3 - Crashtest for long clipPath reference chains. r=longsonr
Jonathan Watt <jwatt@jwatt.org> - Sat, 12 Mar 2016 18:22:33 +0000 - rev 290199
Push 30114 by cbook@mozilla.com at Thu, 24 Mar 2016 15:15:54 +0000
Bug 1253590, part 3 - Crashtest for long clipPath reference chains. r=longsonr
d6e3295ba91596dece2b32f76526433a16ad39cd: Bug 1253590, part 2 - Use the new AutoReferenceLimiter helper to limit clip path reference chain lengths. r=longsonr
Jonathan Watt <jwatt@jwatt.org> - Wed, 09 Mar 2016 10:26:48 +0000 - rev 290198
Push 30114 by cbook@mozilla.com at Thu, 24 Mar 2016 15:15:54 +0000
Bug 1253590, part 2 - Use the new AutoReferenceLimiter helper to limit clip path reference chain lengths. r=longsonr
1ec19ec66b5dbf8224a0f3a5dbf1ca890d64cf6f: Bug 1253590, part 1 - Generalize AutoReferenceLoopDetector to allow it to be used to limit reference chain lengths. r=longsonr
Jonathan Watt <jwatt@jwatt.org> - Wed, 09 Mar 2016 10:26:48 +0000 - rev 290197
Push 30114 by cbook@mozilla.com at Thu, 24 Mar 2016 15:15:54 +0000
Bug 1253590, part 1 - Generalize AutoReferenceLoopDetector to allow it to be used to limit reference chain lengths. r=longsonr
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip