4e0e46d3ef07a672fbd2eff8093d42a0530bee95: Bug 1426710 - The telemetry on how often a backup connection wins should be histogram. r=mayhemer
Dragana Damjanovic <dd.mozilla@gmail.com> - Mon, 08 Jan 2018 19:28:10 +0100 - rev 398318
Push 33214 by ebalazs@mozilla.com at Tue, 09 Jan 2018 09:53:28 +0000
Bug 1426710 - The telemetry on how often a backup connection wins should be histogram. r=mayhemer
4248602674ff589f368a4b868fa4743a033640e4: Bug 1428950 - Unbreak build on BSDs after bug 1297740. r=gcp
Jan Beich <jbeich@FreeBSD.org> - Tue, 09 Jan 2018 02:13:20 +0000 - rev 398317
Push 33213 by ebalazs@mozilla.com at Tue, 09 Jan 2018 09:51:47 +0000
Bug 1428950 - Unbreak build on BSDs after bug 1297740. r=gcp
afb1b6f44c253a47fb896c0509aa0c2c95c53522: Bug 1428684 - reduce the chance of UAF when changing states of MDSM. r=kaku
JW Wang <jwwang@mozilla.com> - Mon, 08 Jan 2018 11:41:59 +0800 - rev 398316
Push 33213 by ebalazs@mozilla.com at Tue, 09 Jan 2018 09:51:47 +0000
Bug 1428684 - reduce the chance of UAF when changing states of MDSM. r=kaku SetState() will delete the current state object and UAF will happen if members are accessed after this call. However, sometimes it is not obvious if SetState() is called indirectly as we do in MaybeFinishSeek(). To make it less error-prone, we will keep the old state object alive for a bit longer and set mMaster to null to catch potential UAF. MozReview-Commit-ID: Aqxj92ETjti
d46a837e1cfa68cbeb9722e05eaa6cc7d44ab83f: Bug 1425091 - Part 4. EditorBase::MoveNode should check valid node that has parent node. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 15 Dec 2017 10:56:45 -0600 - rev 398315
Push 33213 by ebalazs@mozilla.com at Tue, 09 Jan 2018 09:51:47 +0000
Bug 1425091 - Part 4. EditorBase::MoveNode should check valid node that has parent node. r=masayuki AutoMoveNodeSelNotify doesn't allow container is null. So we should reject that parent of moving node is null. MozReview-Commit-ID: DGNCicLJxuK
d05e5fbf2956b9868cd7b66300d0d68d55df6bcf: Bug 1425091 - Part 3. SelAdjCreateNode and SelAdjInsertNode should check whether valid point. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 15 Dec 2017 10:49:53 -0600 - rev 398314
Push 33213 by ebalazs@mozilla.com at Tue, 09 Jan 2018 09:51:47 +0000
Bug 1425091 - Part 3. SelAdjCreateNode and SelAdjInsertNode should check whether valid point. r=masayuki This crashtest case hits assertion in SelAdjInsertNode due to invalid offset point. So we check whether this is valid. Also, SelAdjCreateNode and SelAdjInsertNode should use EditorRawDOMPoint to avoid offset calculation and check valid offset. MozReview-Commit-ID: A1kaKEzc36e
6301157475d85ea69fcbbfaa21e5b13cfb375346: Bug 1425091 - Part 2. Add crashtest. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 15 Dec 2017 10:51:53 -0600 - rev 398313
Push 33213 by ebalazs@mozilla.com at Tue, 09 Jan 2018 09:51:47 +0000
Bug 1425091 - Part 2. Add crashtest. r=masayuki MozReview-Commit-ID: APqtZUv1q6y
5a346a696bc7c3cb7b19ea0de7c2791f4e969551: Bug 1425091 - Part 1. Should check whether CreateNode is failure. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 15 Dec 2017 11:01:58 -0600 - rev 398312
Push 33213 by ebalazs@mozilla.com at Tue, 09 Jan 2018 09:51:47 +0000
Bug 1425091 - Part 1. Should check whether CreateNode is failure. r=masayuki This crash occurs when CreateNode returns nullptr that is error. So we should check whether this method is failure. MozReview-Commit-ID: 9jDOnEYSurG
1b9c11ccbd5e73ff030f3ec1070674f05c08fed6: Bug 1428960 - Use universal selector for -moz-dropdown-list r=heycam
KuoE0 <kuoe0.tw@gmail.com> - Tue, 09 Jan 2018 11:48:29 +0800 - rev 398311
Push 33213 by ebalazs@mozilla.com at Tue, 09 Jan 2018 09:51:47 +0000
Bug 1428960 - Use universal selector for -moz-dropdown-list r=heycam -moz-dropdown-list is only allowed to use universal selector, so change it back to universal selector. MozReview-Commit-ID: 5E9Z98xIadh
afaef5996b4cbf0fb1307fdbd37ffc7c8f1c5855: servo: Merge #19724 - Remove out of date FIXME comments from domimplementation (from hindenbug:19723-remove-fixme-comments); r=metajack
Manoj <manoj.mk27@gmail.com> - Mon, 08 Jan 2018 19:28:49 -0600 - rev 398310
Push 33213 by ebalazs@mozilla.com at Tue, 09 Jan 2018 09:51:47 +0000
servo: Merge #19724 - Remove out of date FIXME comments from domimplementation (from hindenbug:19723-remove-fixme-comments); r=metajack <!-- Please describe your changes on the following line: --> This removes out of date FIXME comments from `domimplementation.rs` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #19723 <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because this is a comment cleanup <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: aa199307c86051e13b17a5feb77722ddcdeed5ce
75edc4a8cbc37016ec33bcb513a0b6a7859879f1: Bug 1425088 - (Part 3) Put the dropdown frame's placeholder into the principal child list of the combobox frame when content-select is enabled. r=mats
KuoE0 <kuoe0.tw@gmail.com> - Fri, 05 Jan 2018 17:50:38 +0800 - rev 398309
Push 33213 by ebalazs@mozilla.com at Tue, 09 Jan 2018 09:51:47 +0000
Bug 1425088 - (Part 3) Put the dropdown frame's placeholder into the principal child list of the combobox frame when content-select is enabled. r=mats MozReview-Commit-ID: HJrltVmJCOj
a395a065bdd3bdb47b54a9e4848392d7eb6f98e1: Bug 1425088 - (Part 2) Change the dropdown frame to a top-level absolute frame when content-select is enabled. r=mats
KuoE0 <kuoe0.tw@gmail.com> - Wed, 13 Dec 2017 17:59:29 -0600 - rev 398308
Push 33213 by ebalazs@mozilla.com at Tue, 09 Jan 2018 09:51:47 +0000
Bug 1425088 - (Part 2) Change the dropdown frame to a top-level absolute frame when content-select is enabled. r=mats MozReview-Commit-ID: E77XdiELqhm
f0fc447f97238c68f4482cdf9f02a3ca9e96c1ee: Bug 1425088 - (Part 1) Add new pref to enable content-select. r=mats
KuoE0 <kuoe0.tw@gmail.com> - Wed, 13 Dec 2017 15:38:18 -0600 - rev 398307
Push 33213 by ebalazs@mozilla.com at Tue, 09 Jan 2018 09:51:47 +0000
Bug 1425088 - (Part 1) Add new pref to enable content-select. r=mats MozReview-Commit-ID: 4laoXMgNqnq
b3f26bc2b5a90ca8f913ebee3b1e130901287fa6: Bug 1407879 - Add testcase for login reputation service. r=francois
DimiL <dlee@mozilla.com> - Thu, 04 Jan 2018 09:14:15 +0800 - rev 398306
Push 33213 by ebalazs@mozilla.com at Tue, 09 Jan 2018 09:51:47 +0000
Bug 1407879 - Add testcase for login reputation service. r=francois MozReview-Commit-ID: HhvPqTTz7pg
bb521dc27954a4d583f1407a0fdd269e7ae15560: Bug 1407879 - Check password field url against the local whitelist. r=francois
DimiL <dlee@mozilla.com> - Tue, 19 Dec 2017 14:16:23 +0800 - rev 398305
Push 33213 by ebalazs@mozilla.com at Tue, 09 Jan 2018 09:51:47 +0000
Bug 1407879 - Check password field url against the local whitelist. r=francois MozReview-Commit-ID: 1OqpeWeU1s1
66429a3ae434ca926625fb2fcba7221843d5d00f: Bug 1428488 - Fix Linux drag-n-drop, placeholder edit and bug fixes to Activity Stream. r=dmose
Ed Lee <edilee@mozilla.com> - Fri, 05 Jan 2018 15:32:58 -0800 - rev 398304
Push 33213 by ebalazs@mozilla.com at Tue, 09 Jan 2018 09:51:47 +0000
Bug 1428488 - Fix Linux drag-n-drop, placeholder edit and bug fixes to Activity Stream. r=dmose MozReview-Commit-ID: 5sEe4SM3gTx
bf64f49f19aabfe55a90865fb69a7c9ae240912b: Bug 1417639 move tests out of mochitest-chrome, r=rpl
Shane Caraveo <scaraveo@mozilla.com> - Mon, 08 Jan 2018 14:50:43 -0800 - rev 398303
Push 33213 by ebalazs@mozilla.com at Tue, 09 Jan 2018 09:51:47 +0000
Bug 1417639 move tests out of mochitest-chrome, r=rpl MozReview-Commit-ID: CUYe2WNyzHj
6e1f415d09e80e1914b649d5780c580f3e038423: Bug 1417639 fix background page alert and test, r=rpl
Shane Caraveo <scaraveo@mozilla.com> - Mon, 08 Jan 2018 14:50:20 -0800 - rev 398302
Push 33213 by ebalazs@mozilla.com at Tue, 09 Jan 2018 09:51:47 +0000
Bug 1417639 fix background page alert and test, r=rpl MozReview-Commit-ID: Kirm9EbzpVO
54015b4eb2ed3b79d5513c0a7547bae586dc6715: Bug 1424171: Allow passing defines to compare-locales; r=Pike,ted
Tom Prince <mozilla@hocat.ca> - Mon, 11 Dec 2017 14:53:03 -0700 - rev 398301
Push 33213 by ebalazs@mozilla.com at Tue, 09 Jan 2018 09:51:47 +0000
Bug 1424171: Allow passing defines to compare-locales; r=Pike,ted MozReview-Commit-ID: DforOC6WFoL
bd11f296e5ed66413b24d091dd78bbf49a352b29: Bug 1424171: Allow controlling the base a relative directories used for looking up localized files; r=ted
Tom Prince <mozilla@hocat.ca> - Mon, 11 Dec 2017 10:02:49 -0700 - rev 398300
Push 33213 by ebalazs@mozilla.com at Tue, 09 Jan 2018 09:51:47 +0000
Bug 1424171: Allow controlling the base a relative directories used for looking up localized files; r=ted MozReview-Commit-ID: J0A2iD5PkD6
67ab725f9d508ce8a27f2d15520a41b2704dc58e: Bug 1426255: combine Files:SCHEDULES correctly; r=gps
Dustin J. Mitchell <dustin@mozilla.com> - Tue, 19 Dec 2017 23:58:17 +0000 - rev 398299
Push 33213 by ebalazs@mozilla.com at Tue, 09 Jan 2018 09:51:47 +0000
Bug 1426255: combine Files:SCHEDULES correctly; r=gps When multiple SCHEDULES are set for the same file (for example in different files), combine them in a sensible way: the union of inclusive components, and whichever has set its exclusive components. Two conflicting assignments to SCHEDULES.exclusive is considered an error. We might relax this situation later if a sensible answer can be determined. Note that this error will only be detected when a reader consults the relevant file. MozReview-Commit-ID: A49L9ISZXOE
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip