4d0a8420647e268146af6e7e21b6572f1257443b: Bug 1639756 - Address some nits that I missed.
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 25 May 2020 10:32:48 +0000 - rev 531875
Push 37447 by nbeleuzu@mozilla.com at Mon, 25 May 2020 15:42:48 +0000
Bug 1639756 - Address some nits that I missed. Differential Revision: https://phabricator.services.mozilla.com/D76678
5e78c6238e348639fdbd0bd47eb2151aadd66bee: Backed out 2 changesets (bug 1639111) for mochitest failures on test_preference.html . CLOSED TREE
Narcis Beleuzu <nbeleuzu@mozilla.com> - Mon, 25 May 2020 13:54:06 +0300 - rev 531874
Push 37447 by nbeleuzu@mozilla.com at Mon, 25 May 2020 15:42:48 +0000
Backed out 2 changesets (bug 1639111) for mochitest failures on test_preference.html . CLOSED TREE Backed out changeset 7ca3266213e7 (bug 1639111) Backed out changeset 55df4479027c (bug 1639111)
90b6e0e32402202184bd54e196262d4d99c6f1e8: Backed out changeset 2b4796470c0b (bug 1638826) for wpt failure on form-action-src-javascript-blocked.sub.html . CLOSED TREE
Narcis Beleuzu <nbeleuzu@mozilla.com> - Mon, 25 May 2020 13:52:24 +0300 - rev 531873
Push 37447 by nbeleuzu@mozilla.com at Mon, 25 May 2020 15:42:48 +0000
Backed out changeset 2b4796470c0b (bug 1638826) for wpt failure on form-action-src-javascript-blocked.sub.html . CLOSED TREE
9b5d151a83b7d94170f1d094f4a1959bad9d8c91: Backed out changeset 82df6f70ec60 (bug 1635675) for lint failure on file-chooser-button-001.tentative.html . CLOSED TREE
Narcis Beleuzu <nbeleuzu@mozilla.com> - Mon, 25 May 2020 13:49:39 +0300 - rev 531872
Push 37447 by nbeleuzu@mozilla.com at Mon, 25 May 2020 15:42:48 +0000
Backed out changeset 82df6f70ec60 (bug 1635675) for lint failure on file-chooser-button-001.tentative.html . CLOSED TREE
82df6f70ec60b3b63bca95f2dfe170e336d84c0c: Bug 1635675 - Implement the ::file-chooser-button pseudo-element. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 21 May 2020 12:27:54 +0000 - rev 531871
Push 37447 by nbeleuzu@mozilla.com at Mon, 25 May 2020 15:42:48 +0000
Bug 1635675 - Implement the ::file-chooser-button pseudo-element. r=jwatt As per https://github.com/w3c/csswg-drafts/issues/5049. Don't enable it unconditionally just yet, as the name may change. I had to move some rules in forms.css because otherwise you get specificity conflicts. Differential Revision: https://phabricator.services.mozilla.com/D76214
9d8f9a2cd37f88c72c7990d2a5a60d978ea2263b: Bug 1639756 - Clean up quirks.css using :is(). r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 21 May 2020 13:28:53 +0000 - rev 531870
Push 37447 by nbeleuzu@mozilla.com at Mon, 25 May 2020 15:42:48 +0000
Bug 1639756 - Clean up quirks.css using :is(). r=jwatt This one I went all-in with :is(). Because even if we have to do some more selector-matching for each element, we need to check the more expensive selectors and the combinators less often, so I don't think we end up worse than before, and the difference is massive. Differential Revision: https://phabricator.services.mozilla.com/D76266
ff407bdf357e75aa51b10623a2d249a4dc57e863: Bug 1639756 - Cleanup html.css using :is(). r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 21 May 2020 13:24:40 +0000 - rev 531869
Push 37447 by nbeleuzu@mozilla.com at Mon, 25 May 2020 15:42:48 +0000
Bug 1639756 - Cleanup html.css using :is(). r=jwatt There's some lists code that I could technically clean up a bit more, but I erred in the side of making the selectors as fast as possible with our current infrastructure. For example, this selector list: :is(ul, ol, dir, menu, dl) ul, :is(ul, ol, dir, menu, dl) ol, :is(ul, ol, dir, menu, dl) dir, :is(ul, ol, dir, menu, dl) menu, :is(ul, ol, dir, menu, dl) dl Could be reduced to: :is(ul, ol, dir, menu, dl) :is(ul, ol, dir, menu, dl) But that means that for `dl` elements we'll selector-match all the selectors inside the :is() instead of just `dl`. Maybe it doesn't matter compared with the work of going up all the parent chain, but I erred in the side of caution for most of these. Differential Revision: https://phabricator.services.mozilla.com/D76265
b8e3a5d241c9461def0cde60d778b429bd0fecc6: Bug 1639756 - Cleanup ua.css by using :is(). r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 21 May 2020 12:27:31 +0000 - rev 531868
Push 37447 by nbeleuzu@mozilla.com at Mon, 25 May 2020 15:42:48 +0000
Bug 1639756 - Cleanup ua.css by using :is(). r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D76264
c161d7a53845bad9e2bebc9f76af9e6633507efb: Bug 1639756 - Clean-up forms.css by using :is(). r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 21 May 2020 12:27:24 +0000 - rev 531867
Push 37447 by nbeleuzu@mozilla.com at Mon, 25 May 2020 15:42:48 +0000
Bug 1639756 - Clean-up forms.css by using :is(). r=jwatt I also removed some unneeded specific selectors for ::placeholder / ::-moz-text-control-editing-root / etc. We only query them for textarea / input elements, so it is more of a pesimization than an optimization. Differential Revision: https://phabricator.services.mozilla.com/D76263
67dcbffe8b5b4873ed8719089c6dddc5e2c9060d: Bug 1639756 - Enable :is() and :where() in UA sheets. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 21 May 2020 12:10:34 +0000 - rev 531866
Push 37447 by nbeleuzu@mozilla.com at Mon, 25 May 2020 15:42:48 +0000
Bug 1639756 - Enable :is() and :where() in UA sheets. r=jwatt This will allow us to clean them up. Differential Revision: https://phabricator.services.mozilla.com/D76262
f60ba533e3943462c9d75e4475a0b1ee6317682f: Bug 1639852 - Don't collect pseudo-element rules for pseudo-elements that cannot apply. r=rcaliman
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 25 May 2020 10:17:05 +0000 - rev 531865
Push 37447 by nbeleuzu@mozilla.com at Mon, 25 May 2020 15:42:48 +0000
Bug 1639852 - Don't collect pseudo-element rules for pseudo-elements that cannot apply. r=rcaliman This prevents showing e.g. ::cue pseudo-elements for elements that are not videos, and such. This is useful on its own, but it's going to be even more useful because I'm making some rules in the UA sheets less specific in the blocking bugs. For example, after my patches, the number of expected rules in test_styles-applied was 24 (instead of 9 with this patch). That's just too much noise. Differential Revision: https://phabricator.services.mozilla.com/D76308
0439b276d366e71bec4626873a19f54057342210: Bug 1624969 - Update monitor card in the protections dashboard. r=ewright,fluent-reviewers,flod
prathiksha <prathikshaprasadsuman@gmail.com> - Mon, 25 May 2020 08:26:57 +0000 - rev 531864
Push 37447 by nbeleuzu@mozilla.com at Mon, 25 May 2020 15:42:48 +0000
Bug 1624969 - Update monitor card in the protections dashboard. r=ewright,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D75970
1d1482c8d52cb8ad8491f3c699e0f92a5401561f: Bug 1626842 - migrate the browser window title to fluent, r=zbraniecki,fluent-reviewers
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 25 May 2020 10:01:42 +0000 - rev 531863
Push 37447 by nbeleuzu@mozilla.com at Mon, 25 May 2020 15:42:48 +0000
Bug 1626842 - migrate the browser window title to fluent, r=zbraniecki,fluent-reviewers Differential Revision: https://phabricator.services.mozilla.com/D75854
9b3266bb0f915f1a033ef91cc50433ded0764efe: Bug 1640158 - Remove useless principal-passing in the CSS loader. r=ckerschb
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 25 May 2020 09:42:01 +0000 - rev 531862
Push 37447 by nbeleuzu@mozilla.com at Mon, 25 May 2020 15:42:48 +0000
Bug 1640158 - Remove useless principal-passing in the CSS loader. r=ckerschb The only caller that passes that principal is the only caller that calls into LoadSheet with a loader that has a document anyway. And the principal we're passing is Document::NodePrincipal(), which is what we'd end up using anyway, so the new code is exactly equivalent, as far as I can tell. Differential Revision: https://phabricator.services.mozilla.com/D76469
d2221f584b0f93afef0256306f12cc43b720627f: Bug 1617369 - Reformat recent rust changes with rustfmt r=webdriver-reviewers,whimboo
Sylvestre Ledru <sledru@mozilla.com> - Mon, 25 May 2020 09:07:45 +0000 - rev 531861
Push 37447 by nbeleuzu@mozilla.com at Mon, 25 May 2020 15:42:48 +0000
Bug 1617369 - Reformat recent rust changes with rustfmt r=webdriver-reviewers,whimboo # ignore-this-changeset Depends on D76451 Differential Revision: https://phabricator.services.mozilla.com/D76663
2b0a2fb2193fda248af69ace6f5c12223023993e: Bug 1519636 - follow up - Reformat recent changes to the Google coding style r=andi
Sylvestre Ledru <sledru@mozilla.com> - Mon, 25 May 2020 09:55:23 +0000 - rev 531860
Push 37447 by nbeleuzu@mozilla.com at Mon, 25 May 2020 15:42:48 +0000
Bug 1519636 - follow up - Reformat recent changes to the Google coding style r=andi # ignore-this-changeset Differential Revision: https://phabricator.services.mozilla.com/D76675
7ca3266213e7198f0c59df5f9ed841ab8d5ceca6: Bug 1639111 - Show the filename, line and column for DevTools actor errors r=davidwalsh,ochameau
Julian Descottes <jdescottes@mozilla.com> - Mon, 25 May 2020 09:47:23 +0000 - rev 531859
Push 37447 by nbeleuzu@mozilla.com at Mon, 25 May 2020 15:42:48 +0000
Bug 1639111 - Show the filename, line and column for DevTools actor errors r=davidwalsh,ochameau Depends on D75902 Differential Revision: https://phabricator.services.mozilla.com/D75904
55df4479027c3aeb8ef4be555b9475df5d82d0d3: Bug 1639111 - Fallback on error.name in DevTools actor error handling r=davidwalsh,ochameau
Julian Descottes <jdescottes@mozilla.com> - Mon, 25 May 2020 09:46:57 +0000 - rev 531858
Push 37447 by nbeleuzu@mozilla.com at Mon, 25 May 2020 15:42:48 +0000
Bug 1639111 - Fallback on error.name in DevTools actor error handling r=davidwalsh,ochameau Differential Revision: https://phabricator.services.mozilla.com/D75902
8c5496bf0b81291f5c850aae52c951c6fcaca571: Bug 1639845 - Fix SIMD link errors for beta sim. r=bbouvier
Lars T Hansen <lhansen@mozilla.com> - Mon, 25 May 2020 09:37:06 +0000 - rev 531857
Push 37447 by nbeleuzu@mozilla.com at Mon, 25 May 2020 15:42:48 +0000
Bug 1639845 - Fix SIMD link errors for beta sim. r=bbouvier An annoying fact is that MIR and LIR nodes cannot be conditional on ifdefs, because the preprocessors that generate code from the node definitions are not ifdef-aware. In the case of SIMD, which has new MIR and LIR nodes, there are stub definitions in Lowering-shared.cpp for the ifndef ENABLE_WASM_SIMD case to implement stub lowering methods on non-SIMD platforms, including x64 when SIMD is disabled. (The stubs all MOZ_CRASH.) But we additionally need to have stub definitions for the x64 code generation methods for builds on x64 when SIMD is disabled. Here I've implemented those by moving the ifdefs inside the function bodies, which seemed like the simplest fix for now. Only x64 is affected as the new LIR nodes are x64-specific. Differential Revision: https://phabricator.services.mozilla.com/D76381
bbdb24994926399f92c25cfe9fc389fca9705778: Bug 1639135: Add test for uniqueness of default browsers. r=rcaliman
Daisuke Akatsuka <daisuke@birchill.co.jp> - Mon, 25 May 2020 09:35:34 +0000 - rev 531856
Push 37447 by nbeleuzu@mozilla.com at Mon, 25 May 2020 15:42:48 +0000
Bug 1639135: Add test for uniqueness of default browsers. r=rcaliman Depends on D76645 Differential Revision: https://phabricator.services.mozilla.com/D76646
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip