4b43bf648efd94389b5829516ce5d8eb8db70e68: Bug 1581874 - Prevent React error for missing keys r=jlast
David Walsh <dwalsh@mozilla.com> - Fri, 27 Sep 2019 21:28:11 +0000 - rev 495501
Push 36632 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:53:43 +0000
Bug 1581874 - Prevent React error for missing keys r=jlast Differential Revision: https://phabricator.services.mozilla.com/D47503
de4a32bbbe50d2a21e38eab7a4042378cc435aa8: Backed out changeset 43ac974f69db (bug 1582645) for increasing the crash volume a=backout
Coroiu Cristina <ccoroiu@mozilla.com> - Mon, 30 Sep 2019 12:51:23 +0300 - rev 495500
Push 36631 by ccoroiu@mozilla.com at Mon, 30 Sep 2019 09:52:03 +0000
Backed out changeset 43ac974f69db (bug 1582645) for increasing the crash volume a=backout
ca257801d86f5d4e9c1768722c7131216c07d38f: Bug 1536747 - [Linux] PictureInPicture window - open window manager menu on right mouse click, r=jhorak
Martin Stransky <stransky@redhat.com> - Fri, 27 Sep 2019 15:14:23 +0000 - rev 495499
Push 36630 by btara@mozilla.com at Sun, 29 Sep 2019 21:35:08 +0000
Bug 1536747 - [Linux] PictureInPicture window - open window manager menu on right mouse click, r=jhorak This patch depends on Bug 1584492. Differential Revision: https://phabricator.services.mozilla.com/D47424
8286374dbff379a172f77cd1ee0d997a2d1a4448: Bug 1583852 - [Linux] Disable round corners/alpha blending for PictureInPicture windows, r=jhorak
Martin Stransky <stransky@redhat.com> - Fri, 27 Sep 2019 15:13:52 +0000 - rev 495498
Push 36630 by btara@mozilla.com at Sun, 29 Sep 2019 21:35:08 +0000
Bug 1583852 - [Linux] Disable round corners/alpha blending for PictureInPicture windows, r=jhorak This bug depends on Bug 1584492. Differential Revision: https://phabricator.services.mozilla.com/D47415
f43fd233453d0ffdf1a866e0d4061a2c5a9e7f46: Backed out 10 changesets (bug 1550108) for causing build bustages on StartupCache.cpp.
Cosmin Sabou <csabou@mozilla.com> - Sun, 29 Sep 2019 01:14:31 +0300 - rev 495497
Push 36630 by btara@mozilla.com at Sun, 29 Sep 2019 21:35:08 +0000
Backed out 10 changesets (bug 1550108) for causing build bustages on StartupCache.cpp. Backed out changeset cbadfa2bbd7e (bug 1550108) Backed out changeset 2560f0ab6ebf (bug 1550108) Backed out changeset 0a1fa8d8bb3c (bug 1550108) Backed out changeset 62416909cf67 (bug 1550108) Backed out changeset 60991713b1e2 (bug 1550108) Backed out changeset f950e30afd90 (bug 1550108) Backed out changeset e63d0a1fec38 (bug 1550108) Backed out changeset 7a009d42e7e7 (bug 1550108) Backed out changeset 395affa4c205 (bug 1550108) Backed out changeset 0fd41e9dbd2a (bug 1550108)
cbadfa2bbd7edefab2596c2fa7661fe04cc65ad6: Bug 1550108 - Reduce stack size on StartupCache threads r=froydnj
Doug Thayer <dothayer@mozilla.com> - Fri, 27 Sep 2019 18:17:23 +0000 - rev 495496
Push 36630 by btara@mozilla.com at Sun, 29 Sep 2019 21:35:08 +0000
Bug 1550108 - Reduce stack size on StartupCache threads r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D46225
2560f0ab6ebf9571ffa50de8688bcaf3b7cf4fa5: Bug 1550108 - Prefetch StartupCache off main thread r=froydnj
Doug Thayer <dothayer@mozilla.com> - Fri, 27 Sep 2019 18:17:21 +0000 - rev 495495
Push 36630 by btara@mozilla.com at Sun, 29 Sep 2019 21:35:08 +0000
Bug 1550108 - Prefetch StartupCache off main thread r=froydnj Does what it says on the tin. Once we have a central scheduling system this should likely just consume that. Differential Revision: https://phabricator.services.mozilla.com/D35454
0a1fa8d8bb3cec2e7fff4b5a5147abb9733b8524: Bug 1550108 - Compact the StartupCache if it is bloated r=froydnj
Doug Thayer <dothayer@mozilla.com> - Fri, 27 Sep 2019 18:17:17 +0000 - rev 495494
Push 36630 by btara@mozilla.com at Sun, 29 Sep 2019 21:35:08 +0000
Bug 1550108 - Compact the StartupCache if it is bloated r=froydnj The first run loads more things into the StartupCache than are used on the second and subsequent runs. This just ensures that if the StartupCache diverges too far from its actual use that we will rebuild it. Differential Revision: https://phabricator.services.mozilla.com/D34654
62416909cf674974dde12b94b85de0286e5e6378: Bug 1550108 - Eliminate large buffer copies from StartupCache r=froydnj
Doug Thayer <dothayer@mozilla.com> - Fri, 27 Sep 2019 18:17:13 +0000 - rev 495493
Push 36630 by btara@mozilla.com at Sun, 29 Sep 2019 21:35:08 +0000
Bug 1550108 - Eliminate large buffer copies from StartupCache r=froydnj The signatures were updated in the previous patch to hand us the raw, uncopied buffers. This just adjusts the callsites to match. Differential Revision: https://phabricator.services.mozilla.com/D34653
60991713b1e23ba3470da8d0a16e3c43539bb0b2: Bug 1550108 - Change StartupCache format from zip to custom r=froydnj
Doug Thayer <dothayer@mozilla.com> - Fri, 27 Sep 2019 22:15:35 +0000 - rev 495492
Push 36630 by btara@mozilla.com at Sun, 29 Sep 2019 21:35:08 +0000
Bug 1550108 - Change StartupCache format from zip to custom r=froydnj I am not aware of anything that depends on StartupCache being a zip file, and since I want to use lz4 compression because inflate is showing up quite a lot in profiles, it's simplest to just use a custom format. This loosely mimicks the ScriptPreloader code, with a few diversions: - Obviously the contents of the cache are compressed. I used lz4 for this as I hit the same file size as deflate at a compression level of 1, which is what the StartupCache was using previously, while decompressing an order of magnitude faster. Seemed like the most conservative change to make. I think it's worth investigating what the impact of slower algs with higher ratios would be, but for right now I settled on this. We'd probably want to look at zstd next. - I use streaming compression for this via lz4frame. This is not strictly necessary, but has the benefit of not requiring as much memory for large buffers, as well as giving us a built-in checksum, rather than relying on the much slower CRC that we were doing with the zip-based approach. - I coded the serialization of the headers inline, since I had to jump back to add the offset and compressed size, which would make the nice Code(...) method for the ScriptPreloader stuff rather more complex. Open to cleaner solutions, but moving it out just felt like extra hoops for the reader to jump through to understand without the benefit of being more concise. Differential Revision: https://phabricator.services.mozilla.com/D34652
f950e30afd90617bfe284e7b239858c72666244c: Bug 1550108 - Add mapErr method to Result r=froydnj
Doug Thayer <dothayer@mozilla.com> - Fri, 27 Sep 2019 22:15:35 +0000 - rev 495491
Push 36630 by btara@mozilla.com at Sun, 29 Sep 2019 21:35:08 +0000
Bug 1550108 - Add mapErr method to Result r=froydnj Adds an explicit error mapping function to Result, to simplify using MOZ_TRY... macros. Differential Revision: https://phabricator.services.mozilla.com/D47466
e63d0a1fec3858ec00e7ba14998a1369be161f78: Bug 1550108 - Split out Input/OutputBuffer into their own file r=froydnj
Doug Thayer <dothayer@mozilla.com> - Fri, 27 Sep 2019 22:15:35 +0000 - rev 495490
Push 36630 by btara@mozilla.com at Sun, 29 Sep 2019 21:35:08 +0000
Bug 1550108 - Split out Input/OutputBuffer into their own file r=froydnj This just splits out the InputBuffer and OutputBuffer helper classes to make it cleaner for the StartupCache to include them. Differential Revision: https://phabricator.services.mozilla.com/D34651
7a009d42e7e7bc23ab3dac2eea5edf6dfb00ed16: Bug 1550108 - Avoid decompressing entries just to check if they exist r=kmag
Doug Thayer <dothayer@mozilla.com> - Fri, 27 Sep 2019 22:15:01 +0000 - rev 495489
Push 36630 by btara@mozilla.com at Sun, 29 Sep 2019 21:35:08 +0000
Bug 1550108 - Avoid decompressing entries just to check if they exist r=kmag This will not behave exactly the same if we had previously written bad data for the entry that would fail to decompress. I imagine this is rare enough, and the consequences are not severe enough, that this should be fine. Differential Revision: https://phabricator.services.mozilla.com/D30643
395affa4c2053c6ac1dfd0bc25227f2c590c620e: Bug 1550108 - Don't read from app/gre caches in StartupCache r=kmag
Doug Thayer <dothayer@mozilla.com> - Fri, 27 Sep 2019 22:15:01 +0000 - rev 495488
Push 36630 by btara@mozilla.com at Sun, 29 Sep 2019 21:35:08 +0000
Bug 1550108 - Don't read from app/gre caches in StartupCache r=kmag I thought I had already written out the patch to remove these, but apparently not. Per discussion in the startup cache telemetry bug, there should be no reason for doing this. Differential Revision: https://phabricator.services.mozilla.com/D31491
0fd41e9dbd2a56e544d6b836e066fbbbd9f78b84: Bug 1550108 - Pull in secondary lz4 libraries r=glandium
Doug Thayer <dothayer@mozilla.com> - Fri, 27 Sep 2019 22:15:01 +0000 - rev 495487
Push 36630 by btara@mozilla.com at Sun, 29 Sep 2019 21:35:08 +0000
Bug 1550108 - Pull in secondary lz4 libraries r=glandium I opted to go with what I perceived as the more expedient route of leaving lz4 roughly where it is and just adding to that. The biggest complication was xxhash, which is included elsewhere. I'm not generally proficient with build-related things though so my solution may be wrong and not just ugly. Differential Revision: https://phabricator.services.mozilla.com/D30640
ca5c8cdce0c9af1ccc1afe0a0cec0a5ed97d4b78: Bug 1583424 - Watch for missing threads in source tree, r=jlast.
Brian Hackett <bhackett1024@gmail.com> - Sat, 28 Sep 2019 13:42:54 +0000 - rev 495486
Push 36629 by nerli@mozilla.com at Sat, 28 Sep 2019 21:17:35 +0000
Bug 1583424 - Watch for missing threads in source tree, r=jlast. Differential Revision: https://phabricator.services.mozilla.com/D47289
6601ef3019e2afba06dc22206c5e85cf50447d94: Bug 1583174 - Watch for exceptions being thrown while getting a script's breakpoint positions, r=jlast.
Brian Hackett <bhackett1024@gmail.com> - Fri, 27 Sep 2019 21:57:28 +0000 - rev 495485
Push 36629 by nerli@mozilla.com at Sat, 28 Sep 2019 21:17:35 +0000
Bug 1583174 - Watch for exceptions being thrown while getting a script's breakpoint positions, r=jlast. Differential Revision: https://phabricator.services.mozilla.com/D47269
1af599d7363344c641466df65ae4391596b42431: Bug 1582353 - P3. Promisify RDD/GPU remote decoder. r=mattwoodrow,mjf
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 28 Sep 2019 12:17:44 +0000 - rev 495484
Push 36629 by nerli@mozilla.com at Sat, 28 Sep 2019 21:17:35 +0000
Bug 1582353 - P3. Promisify RDD/GPU remote decoder. r=mattwoodrow,mjf Differential Revision: https://phabricator.services.mozilla.com/D47040
385f51415b32696bce95aac9ac1a9c15c2a09115: Bug 1582353 - P2. Remove unused variable. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 25 Sep 2019 08:36:30 +0000 - rev 495483
Push 36629 by nerli@mozilla.com at Sat, 28 Sep 2019 21:17:35 +0000
Bug 1582353 - P2. Remove unused variable. r=mattwoodrow The MediaResult object isn't used; no need to set a crash timestamp on it. Differential Revision: https://phabricator.services.mozilla.com/D47039
e1fb5cfcff24f5f4aad12dffd9a487f1da9fc475: Bug 1582353 - P1. Add MediaResult serializer. r=mjf
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 26 Sep 2019 14:51:56 +0000 - rev 495482
Push 36629 by nerli@mozilla.com at Sat, 28 Sep 2019 21:17:35 +0000
Bug 1582353 - P1. Add MediaResult serializer. r=mjf Differential Revision: https://phabricator.services.mozilla.com/D47038
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip