4aff3495ccd4034a378bd1f43b9e093708acff17: Bug 1565001 - Part 20: Replace remaining `toSource` calls in jstests. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 13 Dec 2019 19:22:42 +0000 - rev 507150
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 20: Replace remaining `toSource` calls in jstests. r=evilpie RegExp/regress-yarr-regexp.js - Compare arrays using `assertEqArray` instead of using `Array.prototype.toSource`. TypedObject/scalar_types.js TypedObject/size_and_alignment.js - Use the new `describeType` helper (see changes in TypedObject/shell.js) to get a descriptive name for a TypedObject type. TypedObject/shell.js - Add `describeType` helper to mimic the output of `toSource` for TypedObject types. - And use `JSON.stringify` to stringify TypedObject instances. class/superPropBasicCalls.js - Use `toString` instead of `toSource` for class property lookup tests. - Interestingly the test class is already named `toStringTest`. expressions/regress-96526-delelem.js - Call `formatArray` to get the expected output, because the `formatArray` helper generates a slightly different ouput (`"[3, , ]"`) than `Array.prototype.toSource`. extensions/clone-v1-typed-array.js - Use `toString` instead of `toSource` for the `print` output of an `Error` object. extensions/dataview.js - Use `JSON.stringify` to generate a source-like representation of an array of number values. extensions/regress-314874.js - Directly use `expect` and `actual` for the comparison call. extensions/regress-459606.js - Directly use the `toFixed` result for the comparison call. extensions/regress-476414-01.js extensions/regress-476414-02.js - Remove jsfunfuzz clean-up code. jit/regress-452498-01.js - Use `JSON.stringify` to generate a source-like representation of an array of number values. - Additionally fixup the ouput to match the expected string. reflect-parse/Match.js - Use `JSON.stringify` to get a string-representation for error messages. Depends on D56935 Differential Revision: https://phabricator.services.mozilla.com/D56936
82706c3dffc688e55e75cdcfa13541fa21ec22d0: Bug 1565001 - Part 19: Make tests for `toSource` conditional where necessary. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 13 Dec 2019 19:19:12 +0000 - rev 507149
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 19: Make tests for `toSource` conditional where necessary. r=evilpie Allow these `toSource` specific tests to run even when `toSource` is not defined. Depends on D56934 Differential Revision: https://phabricator.services.mozilla.com/D56935
c75989dc9b7159d008f86238e6b1c0ffebf55d35: Bug 1565001 - Part 18: Add skip-if annotation to `toSource`-only tests. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 13 Dec 2019 19:16:23 +0000 - rev 507148
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 18: Add skip-if annotation to `toSource`-only tests. r=evilpie These tests can be removed when `toSource` itself is removed. Depends on D56933 Differential Revision: https://phabricator.services.mozilla.com/D56934
d3b05632992ceb50b3e3140dff5d7d8ad61a32c9: Bug 1565001 - Part 17: Move tests which are no longer our extensions into the main test file. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 13 Dec 2019 19:13:27 +0000 - rev 507147
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 17: Move tests which are no longer our extensions into the main test file. r=evilpie And additionally remove tests for deleted extensions like `Object.prototype.watch`. Depends on D56932 Differential Revision: https://phabricator.services.mozilla.com/D56933
9b54bce9a504a917678a92a8c4c929b59c8331b2: Bug 1565001 - Part 16: Remove e4x test case. r=evilpie
André Bargull <andre.bargull@gmail.com> - Thu, 12 Dec 2019 18:35:55 +0000 - rev 507146
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 16: Remove e4x test case. r=evilpie This test was added for an e4x bug and originally contained `<e4x>{x}</e4x>;` after `print(x.length);`. When e4x was removed, `<e4x>{x}</e4x>;` was deleted from the test file instead of directly deleting the whole file. Depends on D56931 Differential Revision: https://phabricator.services.mozilla.com/D56932
b026488acb2e3b08ece3e78f88631bee23776665: Bug 1565001 - Part 15: Remove obsolete tests for `Script` function. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 13 Dec 2019 19:09:50 +0000 - rev 507145
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 15: Remove obsolete tests for `Script` function. r=evilpie The `Script` constructor has been removed in bug 543057. Depends on D56930 Differential Revision: https://phabricator.services.mozilla.com/D56931
76085e7c6e81947f32718d7a427cf021383e3492: Bug 1565001 - Part 14: Replace `uneval` in jit-test lib files. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 13 Dec 2019 19:07:35 +0000 - rev 507144
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 14: Replace `uneval` in jit-test lib files. r=evilpie lib/*.js - Replace `uneval` with `JSON.stringify`, because the result is only used for `print` output or error messages. etc/generate-nosuchproperty-tests.js - Use normal Function.p.toString representation instead of `uneval`. Depends on D56928 Differential Revision: https://phabricator.services.mozilla.com/D56930
1a0ca03f6491c93f51e699c348bf8c11e157a7d5: Bug 1565001 - Part 13: Replace `uneval` in remaining jit-tests. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 13 Dec 2019 11:37:26 +0000 - rev 507143
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 13: Replace `uneval` in remaining jit-tests. r=evilpie asm.js/testBug1057248.js collections/Map-iterator-remove-1.js gc/bug-1075546.js heap-analysis/findPath.js profiler/AutoEntryMonitor-01.js proxy/testDirectProxySetReceiverLookup.js saved-stacks/principals-01.js saved-stacks/principals-02.js - Use `JSON.stringify` here, too. (The exact result isn't relevant for theses tests.) baseline/bug845331.js - Use `Function.p.toString` instead of `uneval` to get the source reprensentation. - `toString` is implicitly called through `String` to keep the test structure the same, in case that's important for this test. fields/bug1540798.js - Directly call `Function.p.toString` instead of implicitly through `uneval(global)`. - This ensures the test semantics are kept intact. for-of/decompiler.js - Use `JSON.stringify` to get a quoted string. gc/bug-1259490.js heap-analysis/byteSize-of-scripts.js saved-stacks/async-max-frame-count.js - Use `String` to get the string representation of a number value. gc/bug-832103.js - Use `String` here, too. (The exact result isn't relevant for theses tests.) gc/bug-886630.js - Remove jsfunfuzz clean-up code referencing `uneval`. saved-stacks/1438121-async-function.js saved-stacks/1438121-generator.js - Use `JSON.stringify` to get a source-like representation of an object. - And also use `JSON.stringify` to quote a string value. Depends on D56927 Differential Revision: https://phabricator.services.mozilla.com/D56928
a2601cc45eb1785cb1daa40c0459a611e6cae7f8: Bug 1565001 - Part 12: Replace `uneval` in jit-tests/tests/debug. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 13 Dec 2019 11:32:05 +0000 - rev 507142
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 12: Replace `uneval` in jit-tests/tests/debug. r=evilpie debug/Environment-variables.js - Use `String` instead of `uneval` for the string representation of a number value. debug/*.js - Replace `uneval` with `JSON.stringify`. - The exact result isn't relevant, because it's only used in `print` calls. Depends on D56926 Differential Revision: https://phabricator.services.mozilla.com/D56927
ee19f22e8f2ae26cd7dec4ba3ec128643c2649a2: Bug 1565001 - Part 11: Replace `uneval` in jit-tests/tests/auto-regress. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 13 Dec 2019 11:31:20 +0000 - rev 507141
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 11: Replace `uneval` in jit-tests/tests/auto-regress. r=evilpie auto-regress/bug486139.js auto-regress/bug522624.js auto-regress/bug562028.js auto-regress/bug584423.js - Mark `uneval`-only tests accordingly. auto-regress/bug580694.js auto-regress/bug736609.js - Replace `uneval()` with `String()`, because the result isn't observed anyway. auto-regress/bug605011.js auto-regress/bug745452.js - Use `JSON.stringify` to traverse the global object instead of `uneval`. Depends on D56925 Differential Revision: https://phabricator.services.mozilla.com/D56926
4c184d3ba9d6ddf8c48421f7e79a7dd484477515: Bug 1565001 - Part 10: Replace `uneval` in jit-tests/tests/basic. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 13 Dec 2019 11:30:58 +0000 - rev 507140
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 10: Replace `uneval` in jit-tests/tests/basic. r=evilpie basic/array-copyWithin.js basic/bug951346.js basic/shell-principals.js basic/testNEWINIT.js - Use `JSON.stringify` to get the source-like representation of an object. basic/bug1001090-3.js basic/bug1001090-4.js basic/bug1078871.js basic/testDenseArrayProp.js basic/testGCWhileRecording.js - Use `JSON.stringify` here, too. (The exact result isn't relevant for theses tests.) basic/bug699166.js basic/bug744285.js - Replace `uneval()` with `String()`, because it doesn't matter if "(void 0)" or "" is used. basic/bug913445.js - Mark `uneval`-only test accordingly. basic/parseIntTests.js - Replace `uneval` on number values with `String`, plus special-casing `-0`. basic/truthies.js - Add a simple replacement function for `uneval` here. Depends on D56924 Differential Revision: https://phabricator.services.mozilla.com/D56925
923158e6335867bab32145b0b9447f8299c8e876: Bug 1565001 - Part 9: Replace `uneval` in jit-tests/tests/ion. r=evilpie
André Bargull <andre.bargull@gmail.com> - Mon, 16 Dec 2019 14:21:24 +0000 - rev 507139
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 9: Replace `uneval` in jit-tests/tests/ion. r=evilpie ion/bug1057598.js ion/dce-with-rinstructions.js ion/recover-arrays.js ion/recover-cow-arrays.js ion/recover-lambdas.js ion/recover-objects.js ion/rinstructions-no-sse4.js ion/test-scalar-replacement-float32.js - `uceFault` is a function expression, so the manually adding parentheses around the toString representation gives the same string as calling `uneval`. - Same goes for the other calls to `uneval` in these files. ion/bug1071879.js - `uneval` is called on number values in a `print` call, replace it with `String`. ion/bug1314438.js ion/bug1538083.js - Replace `uneval` with `Object.is` to test for negative zero. ion/bug743099.js - `uneval` isn't called, replace it with another native function ion/bug913749.js - Replace `uneval` with `JSON.stringify` to compute the string representation of an array. - Replace `uneval` with `String` to convert the `.message` property (which is most likely already a string) Depends on D56923 Differential Revision: https://phabricator.services.mozilla.com/D56924
34f1b35bd87af4da751bd143626debb2dc3e25b2: Bug 1565001 - Part 8: Replace `uneval` usage in `assertDeepEq`. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 13 Dec 2019 10:59:21 +0000 - rev 507138
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 8: Replace `uneval` usage in `assertDeepEq`. r=evilpie - Use `String` to generate the string representation of primitive values, including symbols. - Use `JSON.stringify` to generate the string representation of object values. - Add a new helper to distinguish "similar-symbols". Depends on D56922 Differential Revision: https://phabricator.services.mozilla.com/D56923
f4361789fb6735030454a4b2803a2b05038753e2: Bug 1565001 - Part 7: Split tests using `uneval`. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 13 Dec 2019 10:57:40 +0000 - rev 507137
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 7: Split tests using `uneval`. r=evilpie Move the `uneval` tests into new test files. Depends on D56921 Differential Revision: https://phabricator.services.mozilla.com/D56922
10b1dbc9b2178d84e44e7f41cf372e34480d27d2: Bug 1565001 - Part 6: Replace various `uneval` calls. r=evilpie
André Bargull <andre.bargull@gmail.com> - Mon, 16 Dec 2019 14:12:58 +0000 - rev 507136
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 6: Replace various `uneval` calls. r=evilpie extensions/regress-311792-01.js - Replace `uneval` with `join` to trigger array traversal and stringification per the original test case. extensions/regress-363040-01.js extensions/regress-363040-02.js - `a` and `frac` are Array objects which can stringified implicitly in these `print` calls. - The `print` calls itself weren't removed, because the both "test" files are actually only example code and don't contain any proper assertions. extensions/regress-476414-01.js extensions/regress-476414-02.js - `uneval` only referenced in jsfunfuzz clean-up code. extensions/regress-465453.js - Replace `uneval` on array with calling `Array.prototype.toString`. extensions/regress-465337.js extensions/regress-465276.js - Replace `uneval` with `assertEqArray` to ensure the array contains the expected values. extensions/regress-407501.js - Replace `uneval` on array with calling `Array.prototype.toString`. extensions/regress-363988.js - Replace `uneval` with `JSON.stringify` to build JS source string. regress/regress-477234.js - Remove references to `uneval` and `toSource`. - Deleting and re-adding these properties may have been necessary to trigger the bug in TraceMonkey, but it isn't worth the trouble to validate this now. extensions/clone-errors.js extensions/shell.js reflect-parse/Match.js reflect-parse/PatternAsserts.js regress/regress-418641.js - Use `JSON.stringify` instead of `uneval` to generate a source-like representation for error messages. extensions/regress-226078.js statements/for-in-with-assignments.js - Call `dis` instead of `uneval` to disassemble a function. extensions/regress-476653.js - Remove a reference to `uneval`, which may have only be necessary to trigger a bug in TraceMonkey. Depends on D56920 Differential Revision: https://phabricator.services.mozilla.com/D56921
b8a987e0ca3353cf3a273ff5c4eeef3d7409a837: Bug 1565001 - Part 5: Remove a Rhino test using `uneval`. r=evilpie
André Bargull <andre.bargull@gmail.com> - Thu, 12 Dec 2019 15:36:43 +0000 - rev 507135
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 5: Remove a Rhino test using `uneval`. r=evilpie Depends on D56919 Differential Revision: https://phabricator.services.mozilla.com/D56920
76e1d3524ade07dbf5a5aee6a973ce46c2725188: Bug 1565001 - Part 4: Add skip-if annotation to `uneval` tests. r=evilpie
André Bargull <andre.bargull@gmail.com> - Thu, 12 Dec 2019 18:35:02 +0000 - rev 507134
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 4: Add skip-if annotation to `uneval` tests. r=evilpie These tests can be removed when `uneval` itself is removed. Depends on D56918 Differential Revision: https://phabricator.services.mozilla.com/D56919
f4d9184defcfcf8061133cf1e1eb21fc28540677: Bug 1565001 - Part 3: Remove `uneval` calls when the argument is expected to be convertible to a string. r=evilpie
André Bargull <andre.bargull@gmail.com> - Thu, 12 Dec 2019 15:24:43 +0000 - rev 507133
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 3: Remove `uneval` calls when the argument is expected to be convertible to a string. r=evilpie extensions/clone-complex-object.js - `pa[i][0]` is `propname`, which is earlier asserted to be a string. Error/regress-465377.js - `tmp` is expected to be a String value, but also add an explicit `String` call to handle symbols. - Drive-by fix: Move `tmp` definition before first use. Symbol/enumeration.js - `x` is required to be a string by the spec, add explicit `String` call in case this ever changes. object/getOwnPropertySymbols-proxy.js - `key` is required to be a string by the spec, add explicit `String` call in case this ever changes. object/toPrimitive.js - `trapName` is required to be a string by the spec, add explicit `String` call in case this ever changes. regress/regress-407024.js - Test function `f` should either return `1` or `undefined`, both are convertible to a string. reflect-parse/Match.js - `uneval` for only used to quote the string value, so replace by manually quoting `key`. extensions/shell.js - `pa[i][0]` is earlier asserted to be a string. Depends on D56917 Differential Revision: https://phabricator.services.mozilla.com/D56918
861dc1bd9471c82e62de4b8594676aae64f8944c: Bug 1565001 - Part 2: Remove `uneval` calls in test debug calls. r=evilpie
André Bargull <andre.bargull@gmail.com> - Thu, 12 Dec 2019 15:17:41 +0000 - rev 507132
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 2: Remove `uneval` calls in test debug calls. r=evilpie Remove calls to `uneval` when only used to help debugging the test code, e.g. in `print(uneval(foo))`. Depends on D56916 Differential Revision: https://phabricator.services.mozilla.com/D56917
9694344d9e20b434648481825b1ab7c37a4e9ec7: Bug 1565001 - Part 1: Move remaining ReadableStream test from js/src/tests/whatwg to js/src/tests/non262/ReadableStream. r=evilpie
André Bargull <andre.bargull@gmail.com> - Fri, 13 Dec 2019 10:47:30 +0000 - rev 507131
Push 36923 by ccoroiu@mozilla.com at Mon, 16 Dec 2019 21:47:33 +0000
Bug 1565001 - Part 1: Move remaining ReadableStream test from js/src/tests/whatwg to js/src/tests/non262/ReadableStream. r=evilpie Differential Revision: https://phabricator.services.mozilla.com/D56916
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip