48f153341af6a1cb47ff1387944b36198c8c5819: Bug 1675349: Update tests under dom/security/test for the removal of plugins. r=jmathies
David Parks <daparks@mozilla.com> - Wed, 18 Nov 2020 02:45:35 +0000 - rev 557710
Push 37961 by ccoroiu@mozilla.com at Wed, 18 Nov 2020 16:05:35 +0000
Bug 1675349: Update tests under dom/security/test for the removal of plugins. r=jmathies UPDATED ------- dom/security/test/mixedcontentblocker/file_main.html Bug 62178 Test "insecure requests from a secure context". Switch to use image/png instead of application/x-test (test plugin) when testing <object> Differential Revision: https://phabricator.services.mozilla.com/D95911
7fc67a9b2932dc3fe748932e5245d8ec5b10b4e1: Bug 1675349: Update tests under dom/plugins/test for the removal of plugins. r=jmathies
David Parks <daparks@mozilla.com> - Wed, 18 Nov 2020 02:45:23 +0000 - rev 557709
Push 37961 by ccoroiu@mozilla.com at Wed, 18 Nov 2020 16:05:35 +0000
Bug 1675349: Update tests under dom/plugins/test for the removal of plugins. r=jmathies ADDED/UPDATED ------- dom/plugins/test/mochitest/browser_blockallplugins.js Make sure that all plugin elements use the fallback for removed plugins. dom/plugins/test/mochitest/test_mixed_case_mime.html Bug 206659 Test MIME-type case sensitivity using "application/x-Second-Test" Change to test "image/png". dom/plugins/test/mochitest/test_plugin_fallback_focus.html Test that (denying) object/embed focus and focusability are properly maintained when those elements change type to/from plugins. REMOVED ------- dom/plugins/test/unit/test_nice_plugin_name.js bug 838290 Plugin permission string is "nicely" based on plugin lib name. dom/plugins/test/unit/test_bug471245.js bug 471245 Something to do with disabled plugins being enabled under some weird condition. dom/plugins/test/unit/test_bug813245.js bug 813245 Plugin registry file doesn't cause crash or incorrectly represent real plugin. dom/plugins/test/unit/test_bug854467.js bug 854467 PluginTag correctly controls click-to-play behavior. dom/plugins/test/unit/test_plugin_default_state.js bug 866390 Click-to-play abides plugin.default.state setting. dom/plugins/test/unit/test_persist_in_prefs.js Bug 830267 CTP state is maintained in settings (not pluginreg.dat) and persists regardless of plugin removal dom/plugins/test/mochitest/test_NPNVdocumentOrigin.html Bug 622199 Test NPNV connection to DOM properly handles documentOrigin. dom/plugins/test/mochitest/test_NPPVpluginWantsAllNetworkStreams.html Test NPPV connection to JS when plugin requests all HTTP stream <body>s (including failed requests) dom/plugins/test/mochitest/test_bug1028200-*.html Properly handle fullscreen wrt plugins doing things (like crashing) dom/plugins/test/unit/test_bug471245.js Bug 471245 Extensions should not enable inadvertently enable plugins when they consult PluginHost. dom/plugins/test/unit/test_bug813245.js Bug 813245 Do not crash when we read a corrupt pluginreg.dat dom/plugins/test/unit/test_bug854467.js Bug 854467 Should be able to unset CTP setting in chrome JS. dom/plugins/test/unit/test_nice_plugin_name.js Bug 838290 Permission string names for plugins should be pretty and not just based on plugin filename. dom/plugins/test/unit/test_persist_in_prefs.js Bug 830267 Persist plugin prefs in user prefs, not pluginreg.dat dom/plugins/test/unit/test_plugin_default_state.js Bug 866390 Plugins that use default CTP state should follow changes to the default. Others should not be affected by changes. dom/plugins/test/mochitest/test_bug1092842.html bug 1092842 Plugin clipping around specific HTML element attributes. dom/plugins/test/mochitest/test_bug1165981.html bug 1165981 Test non-Flash plugins are blocked dom/plugins/test/mochitest/test_bug1245545.html bug 1245545 Test unloading plugins based on `dom.ipc.plugins.unloadTimeoutSecs` dom/plugins/test/mochitest/test_bug1307694.html bug 1307694 Test scale and salign attributes musst be processed in an order dependent way. But salign is no longer supported. The test uses special testplugin behavior. dom/plugins/test/mochitest/test_bug532208.html bug 532208 Test that plugins can handle large streams, using special testplugin behavior. dom/plugins/test/mochitest/test_bug539565-1.html dom/plugins/test/mochitest/test_bug539565-2.html bug 539565 Plugins should get proper mouse coords in the face of CSS transformations dom/plugins/test/mochitest/test_bug771202.html bug 771202 Use JS-exported plugin functions after plugin is moved to a subdocument. dom/plugins/test/mochitest/test_bug777098.html bug 777098 Test that plugin is properly deleted and a JS exception is thrown when an invalid NPObject (from a dead instance) is passed to a plugin. dom/plugins/test/mochitest/test_bug784131.html bug 784131 Plugins should properly stop when they lose their frames (via e.g. `display:none`) dom/plugins/test/mochitest/test_bug813906.html bug 813906 Make sure plugins can't access chrome-privileged pages dom/plugins/test/mochitest/test_bug852315.html bug 852315 Tests a specific case where JS code that added an element in response to an <embed> event handler would alter a hash table in the midst of iteration, causing a crash. dom/plugins/test/mochitest/test_bug854082.html bug 854082 Tests that destroying the plugin's frame inside NPP_New does not cause a crash dom/plugins/test/mochitest/test_bug863792.htm bug 863792 Do not leak when a plugin removes itself from the document and inactivates the document in its NPP_New dom/plugins/test/mochitest/test_bug967694.html bug 967694 CTP dialog should not spawn plugin inside CTP dialog event. dom/plugins/test/mochitest/test_bug985859.html bug 985859 navigator.mimetypes should work as case-insensitive hashmap (there don't seem to be any legal mimetypes left now). dom/plugins/test/mochitest/test_bug986930.html bug 986930 Properly handle plugin with non-ASCII mime type. dom/plugins/test/mochitest/test_copyText.html Plugins should be able to use the clipboard. dom/plugins/test/mochitest/test_crash_nested_loop.html Plugins resulting in a call to PluginCrashed while still on the stack causing a browser crash (non-oop plugins). So this is ancient (11 years). dom/plugins/test/mochitest/test_crashing.html Bug 560213 Test that plugin crashes generate exceptions and do not lead to heap corruption when using JS to call methods on the crashed plugin. dom/plugins/test/mochitest/test_CrashService_crash.html dom/plugins/test/mochitest/test_CrashService_hang.html dom/plugins/test/mochitest/test_x11_error_crash.html Bug 983313 and bug 1331320 Check that CrashService (which is currently only used by plugin tests) properly detects plugin crash, hang and crashes from X11 errors. dom/plugins/test/mochitest/test_crashing2.html Reloading should restore crashed plugin. Test was already completely disabled. dom/plugins/test/mochitest/test_defaultValue.html Bug 679509 Make NPObjects ok to use as a primitve [[DefaultValue]], instead of calling valueOf on the NPObject itself. dom/plugins/test/mochitest/test_bug751809.html Bug 751809 Plugin CTP broke plugin input (ancient). dom/plugins/test/mochitest/browser_bug1335475.js bug 1335475 Test that plugins aren't available in chrome-privilege, null-principal, and file:// content but are available to http:// and about:blank content dom/plugins/test/mochitest/browser_data_url_plugin.js Bug 1381755 Test that data URIs inside iframes can't use plugins dom/plugins/test/mochitest/browser_bug1196539.js Test that plugin repaints when it should (and not more than that, modulo OS repaints) dom/plugins/test/mochitest/test_hidden_plugin.html Test navigator.plugins, including that disabling plugins removes them from navigator.plugins dom/plugins/test/mochitest/test_enumerate.html Test PluginHost's ability to expose plugin's JS API (looks for TestPlugin's SetColor) dom/plugins/test/mochitest/test_clear_site_data.html Directly test PluginHost's clearSiteData API. dom/plugins/test/mochitest/test_instance_re-parent.html Bug 90268 Test that reparenting plugin instance in DOM before spinning event loop does not destroy or restart it. dom/plugins/test/mochitest/test_instance_unparent1.html dom/plugins/test/mochitest/test_instance_unparent2.html dom/plugins/test/mochitest/test_instance_unparent3.html Bug 90268 Test that removing plugin from DOM destroys it (1) normally, (2) if reparented and removed in the same event cycle and (3) when its parent is the element that gets removed. dom/plugins/test/mochitest/test_instantiation.html Create that plugin is loaded when element is programmatically created (using createElement). dom/plugins/test/mochitest/test_multipleinstanceobjects.html Test NPObject access from multiple plugin instances dom/plugins/test/mochitest/test_newstreamondestroy.html Test calling NPN_GetURL from NPP_Destroy dom/plugins/test/mochitest/test_npn_timers.html Test NPN_Timer dom/plugins/test/mochitest/test_npobject_getters.html Test `pluginFoundElement` and `pluginFoundWindow` JS properties set on plugin instance by `NPP_New`. dom/plugins/test/mochitest/test_npruntime_construct.html Test that NP plugin JS method `constructObject` properly configures prototype chain dom/plugins/test/mochitest/test_npruntime_identifiers.html Test various ways the plugin JS reflection method can convert "identifiers" to JS values. dom/plugins/test/mochitest/test_npruntime_npnevaluate.html Test NPN_Evaluate (i.e. plugin executing JS code) dom/plugins/test/mochitest/test_npruntime_npninvoke.html Test NPN_Invoke (i.e. plugin calling JS method) dom/plugins/test/mochitest/test_npruntime_npninvokedefault.html Test NPN_InvokeDefault (i.e. plugin calling default JS method) dom/plugins/test/mochitest/test_painting.html Test invalidation and repaint requests for clipped plugins. dom/plugins/test/mochitest/test_pluginstream_err.html Bug 517078 Test that plugin streaming error reporting works dom/plugins/test/mochitest/test_pluginstream_post.html dom/plugins/test/mochitest/test_pluginstream_poststream.html Test NPN_PostURL responds (1) by inserting response into given element or (2) by sending response to plugin with NPN_NewStream. dom/plugins/test/mochitest/test_bug479979.xhtml Bug 479979 NPN_SetValue should return error for unknown variables. dom/plugins/test/mochitest/test_crash_notify.xhtml dom/plugins/test/mochitest/test_crash_notify_no_report.xhtml Check event data, crash report/minidump (or not using MOZ_CRASHREPORTER_NO_REPORT), etc for `plugin-crash` event. dom/plugins/test/mochitest/test_crash_submit.xhtml dom/plugins/test/mochitest/test_hang_submit.xhtml Test plugin crash/hang report submission using mock server from toolkit. dom/plugins/test/mochitest/test_pluginstream_referer.html Bugs 410904 and 724465 Test NPN_PostURLNotify and NPN_GetURLNotify. dom/plugins/test/mochitest/test_pluginstream_src.html Test NPP_NewStream and NPP_DestroyStream using embed tag streammode/streamchunksize parameters. dom/plugins/test/mochitest/test_pluginstream_src_dynamic.html Bug 90268 Like test_pluginstream_src.html but using dynamic HTML elements. dom/plugins/test/mochitest/test_pluginstream_src_referer.html Bug 737433 Make sure plugin stream data includes the correct referrer (taken from its content) dom/plugins/test/mochitest/test_propertyAndMethod.html Test NPObject with property and method with the same name dom/plugins/test/mochitest/test_queryCSSZoomFactor.htm Bug 1171182 Test CSS zoom with plugins (handled with NPNVcontentsScaleFactor) dom/plugins/test/mochitest/test_redirect_handling.html Test NPN_PostURLNotify and NPN_GetURLNotify URL redirect support. dom/plugins/test/mochitest/test_secondPlugin.html Bug 749257 Test navigator.plugins and navigator.mimeTypes (via index and iteration) for proper behavior WRT active, CTP and disabled plugins. dom/plugins/test/mochitest/test_src_url_change.html Bug 726734 Changing embed src tag should destroy/restart plugin. dom/plugins/test/mochitest/test_streamNotify.html Test that plugin streams properly handle all URLs, including proper errors for malformed URLs. dom/plugins/test/mochitest/test_streamatclose.html Any open streams should be notified before NPP_Destroy. dom/plugins/test/mochitest/test_stringHandling.html Bug 1106552 Properly handle 0 bytes in strings passed to plugins as NPVariants. dom/plugins/test/mochitest/test_visibility.html Make sure plugins respect visibility attribute and issue the correct number of paints. dom/plugins/test/mochitest/test_zero_opacity.html Windowed plugins should use clip rect to avoid drawing opacity:0 displays. dom/plugins/test/mochitest/test_cocoa_window_focus.htm Test that NPCocoaEventWindowFocusChanged is properly sent for plugin's window dom/plugins/test/mochitest/test_cocoa_focus.htm Test that NPCocoaEventFocusChanged is properly sent for plugin's element dom/plugins/test/mochitest/test_windowed_invalidate.html Test NPN_Invalidate for windowed plugins dom/plugins/test/mochitest/test_windowless_flash.htm Make sure Flash always runs in windowless mode dom/plugins/test/mochitest/test_windowless_ime.html Test (windowless) plugins with IME dom/plugins/test/mochitest/test_busy_hang.xhtml dom/plugins/test/mochitest/test_idle_hang.xhtml Test plugin busy/idle detection observers and events dom/plugins/test/mochitest/test_object.html Bug 783059 Test plugin "instantiation", mostly by stressing behavior when the plugin's element tags are programmatically updated. dom/plugins/test/mochitest/test_convertpoint.xhtml Test coordinate space transformations via NPN_ConvertPoint. dom/plugins/test/mochitest/test_hangui.xhtml Test the _plugin hung_ UI. dom/plugins/test/mochitest/test_npruntime.xhtml Simple test that npruntime (the JS/plugin bridge) works. dom/plugins/test/mochitest/test_plugin_tag_clicktoplay.html Make sure nsIPluginTags click-to-play state properly matches enabledState of plugin (in chrome code) dom/plugins/test/mochitest/test_privatemode_perwindowpb.xhtml Check that plugins can properly determine when run in private mode with NPNVprivateModeBool. dom/plugins/test/mochitest/test_wmode.xhtml Bad test that ends up checking the constant boolean in testplugin returned by pluginSupportsWindowMode() and "confirming" that mac and Linux don't support windowed mode but Windows does. dom/plugins/test/mochitest/test_xulbrowser_plugin_visibility.xhtml Tests that plugins properly get visibility and invalidate messages when in the current or not-current tab. Differential Revision: https://phabricator.services.mozilla.com/D95910
1cee4d97f80175df888b348ef6bdf286cfa17a6b: Bug 1675349: Update tests under dom/html/test for the removal of plugins. r=jmathies
David Parks <daparks@mozilla.com> - Wed, 18 Nov 2020 03:12:41 +0000 - rev 557708
Push 37961 by ccoroiu@mozilla.com at Wed, 18 Nov 2020 16:05:35 +0000
Bug 1675349: Update tests under dom/html/test for the removal of plugins. r=jmathies UPDATED ------- dom/html/test/test_object_plugin_nav.html Test focus behavior around <object> element. Rename to test_object_nav.html and switch to use image/png instead of application/x-test (test plugin) dom/html/test/test_fullscreen-api.html Test fullscreen, including in the context of a plugin. Remove plugin portion of test and the "skip" list that was added to allow headless/linux tests to skip only the plugin part due to bugs 1409805 and 1330553. REMOVED ------- dom/html/test/test_iframe_sandbox_plugins.html Test that `sandbox` attribute on iframe blocks/loads plugins correctly Differential Revision: https://phabricator.services.mozilla.com/D95909
59a0cb79c7c13b7435abb867a6b2c23d4ee816f7: Bug 1675349: Update tests under dom/base for the removal of plugins. r=jmathies
David Parks <daparks@mozilla.com> - Wed, 18 Nov 2020 03:17:14 +0000 - rev 557707
Push 37961 by ccoroiu@mozilla.com at Wed, 18 Nov 2020 16:05:35 +0000
Bug 1675349: Update tests under dom/base for the removal of plugins. r=jmathies UPDATED ------- dom/base/test/browser_timeout_throttling_with_audio_playback.js Test background tab audio throttling Remove plugin portion Differential Revision: https://phabricator.services.mozilla.com/D95908
43d349fa37b14b2784b68dc7acca5481f3dd7647: Bug 1675349: Update tests under browser/components for the removal of plugins. r=jmathies,mixedpuppy
David Parks <daparks@mozilla.com> - Wed, 18 Nov 2020 03:11:46 +0000 - rev 557706
Push 37961 by ccoroiu@mozilla.com at Wed, 18 Nov 2020 16:05:35 +0000
Bug 1675349: Update tests under browser/components for the removal of plugins. r=jmathies,mixedpuppy UPDATED ------- browser/components/extensions/test/browser/browser_ext_browsingData_pluginData.js Test plugindata part of the browsingData extension's use of nsIClearDataService. Have test attempt to clear non-existent data. Test that browsingData APIs do not cause exceptions. REMOVED ------- browser/components/enterprisepolicies/tests/browser/browser_policy_disable_flash_plugin.js Bug 1429169 Flash ctp/disabled by enterprise policy. Differential Revision: https://phabricator.services.mozilla.com/D95907
c84bfb6eae59accd8d99a5a41be310d266f2c800: Bug 1675349: Update tests under browser/base/content/test for the removal of plugins. r=jmathies
David Parks <daparks@mozilla.com> - Wed, 18 Nov 2020 03:17:34 +0000 - rev 557705
Push 37961 by ccoroiu@mozilla.com at Wed, 18 Nov 2020 16:05:35 +0000
Bug 1675349: Update tests under browser/base/content/test for the removal of plugins. r=jmathies UPDATED ------- browser/base/content/test/plugins/browser_CTP_favorfallback.js Test that plugin fallback behavior is correct. Updated to reflect that plugins always show "alternate" content, which is either the user fallback of the browser's transparent fallback, regardless of the HTML. browser/base/content/test/plugins/browser_CTP_outsideScrollArea.js Test that overlay is visible (in layout sense) only if plugin is partially or completely visible. Changed to test new fallback behavior where overlay is a hidden element with "blockall" atribute. browser/base/content/test/plugins/browser_CTP_zoom.js Test that overlay is present and visible at multiple zoom levels. Adjusted to work with hidden overlay. browser/base/content/test/performance/browser_startup_mainthreadio.js Track IO done at browser startup Removed `UserPlugins.parent` from list since we no longer scan for plugins. browser/base/content/test/plugins/browser_bug797677.js bug 797677 Test that plugin instantiation fails (with PLUGIN_UNSUPPORTED and no console error) when MIME type missing. Removed the cleanup of (unused) test plugin. browser/base/content/test/contextMenu/browser_contextmenu.js Test context menu for many types of elements Removed plugin element portion. REMOVED ------- browser/base/content/test/plugins/browser_CTP_contextmenu.js Test that the CTP activate action in content menus for plugins works browser/base/content/test/plugins/browser_CTP_crashreporting.js Test that plugin crash submissions still work properly after click-to-play activation. browser/base/content/test/plugins/browser_CTP_drag_drop.js Test that plugin CTP dialog behaves correctly when dragging tab out of/into a window browser/base/content/test/plugins/browser_CTP_hide_overlay.js Test ability to close plugin "overlay" placeholder (the grey lego element) browser/base/content/test/plugins/browser_CTP_iframe.js Test that overlay can be interacted with (closed) when in an iframe browser/base/content/test/plugins/browser_CTP_nonplugins.js Bug 926605 Says it tests that non-plugin <object> elements don't show CTP but it doesn't. It tests that removing a CTP plugin from a page does not remove CTP dialog (in case, for example, page shows, then quickly removes plugin). browser/base/content/test/plugins/browser_CTP_overlay_styles.js Verify that styling on overlay elements, based on sizing, is correct. browser/base/content/test/plugins/browser_CTP_resize.js Test that a resize properly updates the overlay styling, which is only visible when large enough. browser/base/content/test/plugins/browser_CTP_shouldShowOverlay.js Test that partially obscured plugins show the overlay, properly styled (when they should). browser/base/content/test/plugins/browser_blocking.js bug 1129040 Test CTP behavior -- overlay dialog behavior, vulnerable plugin user approval, plugin's infoURL, etc. browser/base/content/test/plugins/browser_blocklist_content.js bug 1129040 Test (plugin) blocklist, including attempt to "hack" it in a content process. browser/base/content/test/plugins/browser_bug743421.js Test CTP approval persists for new plugin instances in page. browser/base/content/test/plugins/browser_bug744745.js Test that CTP notification correctly appears despite plugin with opacity: 0 !important browser/base/content/test/plugins/browser_bug787619.js bug 787619 Make sure CTP works for plugins nested inside <a></a> elements. browser/base/content/test/plugins/browser_bug812562.js bug 812562 Navigating away from, then back to a page should restore its CTP status. browser/base/content/test/plugins/browser_bug818118.js bug 818118 Test that CTP plugin and "unknown" plugin type work correctly on same page. browser/base/content/test/plugins/browser_clearplugindata.js Test clearing plugin data using Sanitizer.jsm browser/base/content/test/plugins/browser_iterate_hidden_plugins.js Bug 1318383 Test `plugins.navigator.hidden_ctp_plugin`, which hides CTP plugins from `navigator.plugins`. browser/base/content/test/plugins/browser_pluginCrashCommentAndURL.js Test plugin crash detection and reporting browser/base/content/test/plugins/browser_pluginCrashReportNonDeterminism.js Bug 1110887 Test both "plugin process crash notification" orders -- content proc before main proc and vice-versa. browser/base/content/test/plugins/browser_plugin_reloading.js Bug 1129040 Re-instantiating plugin (using `plugin.src = new_value`) should retain CTP approval. browser/base/content/test/plugins/browser_plugin_framed_domain.js Plugin CTP prompts should adopt top-level page's principal for instead of closest frame's principal. browser/base/content/test/plugins/browser_pluginnotification.js Tests many CTP interface behavior cases -- doorhangers, overlays, multiple plugin instances, CTP choices (always, allow, never) browser/base/content/test/plugins/browser_private_clicktoplay.js Make sure CTP interface works in private windows browser/base/content/test/plugins/browser_subframe_access_hidden_plugins.js Allow navigator.plugins to list plugin after CTP approval, even if it listed in `plugins.navigator.hidden_ctp_plugin` Differential Revision: https://phabricator.services.mozilla.com/D95906
38e9af69ae57041d64a3eeb3380b6eab25a93311: Bug 1675349: Update tests under accessible/tests/mochitest to reflect the removal of plugins. r=jmathies
David Parks <daparks@mozilla.com> - Wed, 18 Nov 2020 03:07:37 +0000 - rev 557704
Push 37961 by ccoroiu@mozilla.com at Wed, 18 Nov 2020 16:05:35 +0000
Bug 1675349: Update tests under accessible/tests/mochitest to reflect the removal of plugins. r=jmathies UPDATED ------- accessible/tests/mochitest/elm/test_HTMLSpec.html Bug 905215 Test that a11y shadow DOM gets objects of the right type and state from HTML dom. Changed <object> and <embed> plugin tests to find no accessible. accessible/tests/mochitest/elm/test_MathMLSpec.html Bug 1001634 Basic MathML a11y tests. Didn't use plugin, just initializes it. Remove plugin initialization. accessible/tests/mochitest/elm/test_plugin.html Test that a11y shadow tree gets proper type/state for plugin objects and their subtrees, even if there is an HTML fallback provided. Removed. accessible/tests/mochitest/focus/test_takeFocus.html Bug 677467 Test that a11y shadow tree focus follows DOM focus Remove plugin init but keep plugin test. Differential Revision: https://phabricator.services.mozilla.com/D95905
3255c1ab30593bf8f70ce1f6133042fa534b3b7a: Bug 1675349: Remove unused files following removing plugin support r=jmathies,extension-reviewers,geckoview-reviewers,agi,mixedpuppy
David Parks <daparks@mozilla.com> - Wed, 18 Nov 2020 03:12:08 +0000 - rev 557703
Push 37961 by ccoroiu@mozilla.com at Wed, 18 Nov 2020 16:05:35 +0000
Bug 1675349: Remove unused files following removing plugin support r=jmathies,extension-reviewers,geckoview-reviewers,agi,mixedpuppy Remove some support files for plugin features and stop building TestPlugins. Differential Revision: https://phabricator.services.mozilla.com/D95904
2f3eaf9c342cd7ad71050728ec564b8c854633a4: Bug 1675349: Forbid elements representing blocked plugins from accepting focus r=jmathies
David Parks <daparks@mozilla.com> - Wed, 18 Nov 2020 03:04:02 +0000 - rev 557702
Push 37961 by ccoroiu@mozilla.com at Wed, 18 Nov 2020 16:05:35 +0000
Bug 1675349: Forbid elements representing blocked plugins from accepting focus r=jmathies As part of the fallback for unsupported plugin elements, we deny them focus. Since elements can be programmatically changed, and object/embed elements can change internal "type" by updating their data/src attributes, and because that type is decided asynchronously, we may need to give up focus if our element has it. Differential Revision: https://phabricator.services.mozilla.com/D95903
769e5c0db4c25097698aa8e9be51f196caa3fb69: Bug 1675349: Replace plugin behavior with a basic fallback r=jmathies,mixedpuppy
David Parks <daparks@mozilla.com> - Wed, 18 Nov 2020 03:08:29 +0000 - rev 557701
Push 37961 by ccoroiu@mozilla.com at Wed, 18 Nov 2020 16:05:35 +0000
Bug 1675349: Replace plugin behavior with a basic fallback r=jmathies,mixedpuppy The browser currently only enables plugin behavior for Flash and our internal test plugins. This patch replaces support for those plugins with a simple fallback that shows a transparent region where the plugin would have been. It removes the file system search(es) for the plugin dynamic libraries and short-circuits the logic to determine if plugins should do something special -- all implementations now behave the same in the presence of plugin elements. The new behavior is: 1. If the <object> or <embed> element lists a type of something other than "x-shockwave-flash" or "x-test" then the behavior is unchanged. This means that non-plugin types behave properly and unknown types (for example, typos) are also unaffected (they reduce to 0x0 elements). 2. If the <object> element has an HTML fallback in the DOM (see spec for <object> elements) then the fallback is always shown. 3. Otherwise, the element is shown as a transparent region with the size specified in attributes. Differential Revision: https://phabricator.services.mozilla.com/D95902
b276c591ea2dd7b2db87ff35504b55df3515931d: Bug 1675376 - Lift IsBidiEnabled check up to the caller. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 18 Nov 2020 03:08:31 +0000 - rev 557700
Push 37961 by ccoroiu@mozilla.com at Wed, 18 Nov 2020 16:05:35 +0000
Bug 1675376 - Lift IsBidiEnabled check up to the caller. r=mats That avoids going all the way to the first continuation to call ResolveBidi on it. This shaves a bunch of time when there are a lot of pages. This is more problematic than it seems specially when there's no bidi, because in the "bidi not enabled" case we never remove the flag, which is bad. When bidi is actually enabled we usually have done the resolution already. Differential Revision: https://phabricator.services.mozilla.com/D97358
20d5c721730414c5404c3919a3e9cf5e0c505a8b: Bug 1675376 - Cache consumed BSize in a frame property for non-first continuations. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 18 Nov 2020 03:08:13 +0000 - rev 557699
Push 37961 by ccoroiu@mozilla.com at Wed, 18 Nov 2020 16:05:35 +0000
Bug 1675376 - Cache consumed BSize in a frame property for non-first continuations. r=mats This removes virtually all the time under ConsumedBSize. See the comment for what ensures the correctness of the cache: Basically, we refresh the cache for a frame continuation every time we reflow it, which means that when next continuations go look for it it should be up-to-date (we rely on that already because we're looking at the content rect). Differential Revision: https://phabricator.services.mozilla.com/D97357
e3aa6fb624220ba465b77dfdcb998b07fa040f07: Bug 1675376 - Pass consumed bsize to ApplySkipSides when during reflow. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 18 Nov 2020 03:08:06 +0000 - rev 557698
Push 37961 by ccoroiu@mozilla.com at Wed, 18 Nov 2020 16:05:35 +0000
Bug 1675376 - Pass consumed bsize to ApplySkipSides when during reflow. r=mats The caller has it, so let's pass it down so that we don't need to compute it on demand. Differential Revision: https://phabricator.services.mozilla.com/D97356
2991f291f95fce56c0ada33d96091d5553c9bca5: Bug 1677293 - Enable Software WebRender on Linux nightly for small/medium screens. r=jrmuizel
Andrew Osmond <aosmond@mozilla.com> - Wed, 18 Nov 2020 00:42:24 +0000 - rev 557697
Push 37961 by ccoroiu@mozilla.com at Wed, 18 Nov 2020 16:05:35 +0000
Bug 1677293 - Enable Software WebRender on Linux nightly for small/medium screens. r=jrmuizel This patch enables Software WebRender for all Linux users. If their configuration is also allowlisted for (accelerated) WebRender, then they will default to that over Software WebRender. Differential Revision: https://phabricator.services.mozilla.com/D97156
e485903cd8c420d47fd094e59734ff3060590de8: Bug 1676913 - Restrict a caller of GetDependentModulePaths to xul.dll. r=mhowell
Toshihito Kikuchi <tkikuchi@mozilla.com> - Wed, 18 Nov 2020 01:03:02 +0000 - rev 557696
Push 37961 by ccoroiu@mozilla.com at Wed, 18 Nov 2020 16:05:35 +0000
Bug 1676913 - Restrict a caller of GetDependentModulePaths to xul.dll. r=mhowell Bug 1659438 introduced an exported function `GetDependentModulePaths` in firefox.exe so that our sandboxBroker can easily access the shared section whose handle is owned by firefox.exe. This patch disallows `GetDependentModulePaths` to be called from someone other than xul.dll in order to harden the attack to tamper our shared section. This cannot prevent all possible attacks, but it's better than nothing. Differential Revision: https://phabricator.services.mozilla.com/D97377
630eb9c351166a98884068bbdecb7e3c14de1886: Bug 1677526 - Simplify isLoading property in gViewController. r=rpl
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 18 Nov 2020 01:26:58 +0000 - rev 557695
Push 37961 by ccoroiu@mozilla.com at Wed, 18 Nov 2020 16:05:35 +0000
Bug 1677526 - Simplify isLoading property in gViewController. r=rpl Differential Revision: https://phabricator.services.mozilla.com/D97176
6d6c8a5f614e48e8fe8a916c642bc312093145dc: Bug 1677839 - Re-allow new pass manager on aarch64-windows builds r=firefox-build-system-reviewers,mhentges
David Major <dmajor@mozilla.com> - Tue, 17 Nov 2020 22:25:32 +0000 - rev 557694
Push 37961 by ccoroiu@mozilla.com at Wed, 18 Nov 2020 16:05:35 +0000
Bug 1677839 - Re-allow new pass manager on aarch64-windows builds r=firefox-build-system-reviewers,mhentges The SEH unwind info problem no longer happens because nowadays bug 1631929 prevents the code pattern that led to it. I've confirmed that bug 1626951's bustage doesn't come back, both in regular and beta-simulation builds. This cleanup will allow me to reverse the dependency in bug 1677742 and have `lto` depend on `new_pass_manager_flags`. Differential Revision: https://phabricator.services.mozilla.com/D97362
7553f5dc03da0699155b6422ab25d788a7ab64c9: Backed out changeset 0a8c4664555a (bug 1649615) for mRawPtr assertion failures CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Wed, 18 Nov 2020 04:58:09 +0200 - rev 557693
Push 37961 by ccoroiu@mozilla.com at Wed, 18 Nov 2020 16:05:35 +0000
Backed out changeset 0a8c4664555a (bug 1649615) for mRawPtr assertion failures CLOSED TREE
1e2b1c9b9c9e9283c22055cb5dfd003a061b878e: Backed out 3 changesets (bug 1676771) for TouchResampler.cpp linux debug bustage CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Wed, 18 Nov 2020 04:54:03 +0200 - rev 557692
Push 37961 by ccoroiu@mozilla.com at Wed, 18 Nov 2020 16:05:35 +0000
Backed out 3 changesets (bug 1676771) for TouchResampler.cpp linux debug bustage CLOSED TREE Backed out changeset c01032316a72 (bug 1676771) Backed out changeset 45736914b063 (bug 1676771) Backed out changeset 8700eb46bb8b (bug 1676771)
f8d523ae0c5c8b6dd4b7be94149584a5c35292b7: Backed out changeset 3d61ae105362 (bug 1649590) for browser_startup_mainthreadio & mRawPtr assertion failures CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Wed, 18 Nov 2020 04:51:58 +0200 - rev 557691
Push 37961 by ccoroiu@mozilla.com at Wed, 18 Nov 2020 16:05:35 +0000
Backed out changeset 3d61ae105362 (bug 1649590) for browser_startup_mainthreadio & mRawPtr assertion failures CLOSED TREE
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip