475874efad984c2141afd6818007f48846999d46: Bug 1248534 (part 2) - Remove unused XPT flags. r=khuey.
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 16 Feb 2016 19:04:18 +1100 - rev 285519
Push 30030 by cbook@mozilla.com at Thu, 25 Feb 2016 10:58:04 +0000
Bug 1248534 (part 2) - Remove unused XPT flags. r=khuey.
56f75a8f44915a4468fbedaf3beb9767b73eb343: Bug 1248534 (part 1) - Remove XPT encoding support. r=khuey.
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 16 Feb 2016 19:02:51 +1100 - rev 285518
Push 30030 by cbook@mozilla.com at Thu, 25 Feb 2016 10:58:04 +0000
Bug 1248534 (part 1) - Remove XPT encoding support. r=khuey. Currently XPT can both encode and decode, but encoding has been handled by Python code since bug 643817, so the encoding support can be removed. This results in many simplifications. Some notable changes: - All the XPTHashTable code (including XPTDatapool::offset_map) is no longer necessary. - PrimitiveTest.cpp and SimpleTypeLib.cpp both don't make much sense without encoding support, so I removed them. - A lot of the version code was already unused, e.g. XPT_VERSION_*, XPT_TYPELIB_VERSIONS_STRUCT, XPT_TYPELIB_VERSIONS. XPT_MAJOR_INCOMPATIBLE_VERSION is the only thing actually used in version checks. - The patch also removes some code that was dead even before encoding removal, such as XPT_ParseVersionString().
38a98d3afba1fc744952eb7bd99f4b98750f1153: Bug 1244913 followup, disable test_peerConnection_scaleResolution.html on Android 4.3 opt, too
Phil Ringnalda <philringnalda@gmail.com> - Wed, 24 Feb 2016 19:07:38 -0800 - rev 285517
Push 30030 by cbook@mozilla.com at Thu, 25 Feb 2016 10:58:04 +0000
Bug 1244913 followup, disable test_peerConnection_scaleResolution.html on Android 4.3 opt, too
c5153ecb53ba4c2a484a17f93d701881f280bfc8: Bug 1239945 part 5 - Use MayHaveAnimations() to return early in CommonAnimationManager::GetAnimationCollection; r=dholbert
Brian Birtles <birtles@gmail.com> - Wed, 24 Feb 2016 16:09:31 +0900 - rev 285516
Push 30030 by cbook@mozilla.com at Thu, 25 Feb 2016 10:58:04 +0000
Bug 1239945 part 5 - Use MayHaveAnimations() to return early in CommonAnimationManager::GetAnimationCollection; r=dholbert Currently, CommonAnimationManager::GetAnimationCollection returns early when the referenced list of animation collections is empty. So, for example, if we try to get the collection of CSS animations on an element on a page with no CSS animations, we will quickly return null without possibly expensive property lookup. However, if there is just one CSS animation on the page, we will do the property lookup for every element in the page where this method is called. In this bug, we would like to remove the linked list of animation collections since this is now the only place where it is used. So, in place if this optimization, we introduce quite a different one based on the changes from bug 1226091 which makes MayHaveAnimations() apply to animations on the element itself as well as pseudo elements. Using this, we can return early for any element that has never had any kind of animation on it. The page may have dozens of other animations but we will still return early. However, if the element has ever had any kind of animation on it, we will not return early. It is expected that this optimization is at least as good as the one it replaces.
f0a24d67478b23e1f7f2e51e9f9938f2fb0f57b3: Bug 1239945 part 4 - Remove the pointer from an AnimationCollection to its manager since it is no longer used; r=dholbert
Brian Birtles <birtles@gmail.com> - Wed, 24 Feb 2016 16:08:56 +0900 - rev 285515
Push 30030 by cbook@mozilla.com at Thu, 25 Feb 2016 10:58:04 +0000
Bug 1239945 part 4 - Remove the pointer from an AnimationCollection to its manager since it is no longer used; r=dholbert
4e3a832dbdba397425a226050a6195b54fd95393: Bug 1239945 part 3 - Move AnimationCollection to a separate file; r=dholbert
Brian Birtles <birtles@gmail.com> - Wed, 24 Feb 2016 16:08:20 +0900 - rev 285514
Push 30030 by cbook@mozilla.com at Thu, 25 Feb 2016 10:58:04 +0000
Bug 1239945 part 3 - Move AnimationCollection to a separate file; r=dholbert In this bug we will trim off unnecessary functionality from the animation managers and make AnimationCollection into an independent data type so in this patch we separate it into its own file. It is also generally easier to navigate the source code and eliminate cyclic dependencies between header files when there is a rough correspondance between class names and file names (e.g. rather than having #include "AnimationCommon.h" // For mozilla::AnimationCollection). This patch also makes a few simplifications to include dependencies since they're a bit of a mess (making it hard to move code around). The changes to IncrementalClearCOMRuleArray.cpp are due to the changes to the unified build introduced by adding AnimationCollection.cpp exposing a missing include from that file.
1f552b246eb40e792ad456cff0642f85a01da04b: Bug 1239945 part 2 - Drop CommonAnimationManager::ContentOrAncestorHasAnimation; r=dholbert
Brian Birtles <birtles@gmail.com> - Wed, 24 Feb 2016 15:42:33 +0900 - rev 285513
Push 30030 by cbook@mozilla.com at Thu, 25 Feb 2016 10:58:04 +0000
Bug 1239945 part 2 - Drop CommonAnimationManager::ContentOrAncestorHasAnimation; r=dholbert This was added in bug 780692 to work around assertions that arose due to the inconsistent state introduced by mini-flushes. However, that workaround no longer seems necessary. In particular, the crashtest for bug 813372 no longer reports failed assertions when we remove this method and nor do any other tests. I'm not sure exactly what changed about how we do mini-flushes but I suspect it was bug 960465 or one of the related follow-ups.
c98725a7f74ec0dd9a641065e94f10fa30653f54: Bug 1239945 part 1 - Drop a number of animation manager/collection-related methods that are unused (and in some cases undefined); r=dholbert
Brian Birtles <birtles@gmail.com> - Wed, 24 Feb 2016 13:41:16 +0900 - rev 285512
Push 30030 by cbook@mozilla.com at Thu, 25 Feb 2016 10:58:04 +0000
Bug 1239945 part 1 - Drop a number of animation manager/collection-related methods that are unused (and in some cases undefined); r=dholbert
14163554db509ebc3ad5735c83392849d2b8ee88: Bug 1239945 part 0 - Fix unified build
Brian Birtles <birtles@gmail.com> - Thu, 25 Feb 2016 12:00:46 +0900 - rev 285511
Push 30030 by cbook@mozilla.com at Thu, 25 Feb 2016 10:58:04 +0000
Bug 1239945 part 0 - Fix unified build
b274118f154c3e4b743443e66c96556824e40247: Bug 1242872 - Part 9: Should not assume any order of animations in MurationObserver. r=pbrosset
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Fri, 19 Feb 2016 16:43:08 +0900 - rev 285510
Push 30030 by cbook@mozilla.com at Thu, 25 Feb 2016 10:58:04 +0000
Bug 1242872 - Part 9: Should not assume any order of animations in MurationObserver. r=pbrosset After patch 7, the order of animations in MutationObserver has been reversed. When we want to use the animations ordering by something, we need to sort it first. MozReview-Commit-ID: 7xOYNsuSbvA
fe65342f14bc086b9e4dbf122418c568fd4a3ff3: Bug 1242872 - Part 8: ElementPropertyTransition::ToValue(). r=birtles
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Fri, 19 Feb 2016 16:43:06 +0900 - rev 285509
Push 30030 by cbook@mozilla.com at Thu, 25 Feb 2016 10:58:04 +0000
Bug 1242872 - Part 8: ElementPropertyTransition::ToValue(). r=birtles MozReview-Commit-ID: 2zSAG6zcoYc
c920a4fb46644dd158e58988e311ecdf8094a52e: Bug 1242872 - Part 7: Eliminate creation of temporary animations. r=dbaron
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Fri, 19 Feb 2016 14:10:43 +0900 - rev 285508
Push 30030 by cbook@mozilla.com at Thu, 25 Feb 2016 10:58:04 +0000
Bug 1242872 - Part 7: Eliminate creation of temporary animations. r=dbaron This patch removes a loop for the new temporary animation collection in CheckAnimationRule. The old collection is passed to CSSAnimationBuilder, and CSSAnimationBuilder removes each animation which matches to new animation name in it. :birtles took care of storing animations in AnimationCollection in reverse order. Thanks so much! MozReview-Commit-ID: KmlnjFptKdv
564a81e686f005d113a78b322d105a88b69754a9: Bug 1242872 - Part 6: Trigger a layer update explicitly when copying animation properties. r=birtles
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Fri, 19 Feb 2016 09:16:15 +0900 - rev 285507
Push 30030 by cbook@mozilla.com at Thu, 25 Feb 2016 10:58:04 +0000
Bug 1242872 - Part 6: Trigger a layer update explicitly when copying animation properties. r=birtles MozReview-Commit-ID: AWL43ypqLPT
d2459a786eef36c202b12635040e761eef1eebe1: Bug 1242872 - Part 5: Change CopyPropertiesFrom to UpdateProperties. r=birtles
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Fri, 19 Feb 2016 09:16:15 +0900 - rev 285506
Push 30030 by cbook@mozilla.com at Thu, 25 Feb 2016 10:58:04 +0000
Bug 1242872 - Part 5: Change CopyPropertiesFrom to UpdateProperties. r=birtles Once we don't create any temporary effect, we do not need to pass the effect to CopyPropertiesFrom. MozReview-Commit-ID: HczU5IU6Ggp
b257d647614093c646e718b679dfe6b282c5b33c: Bug 1242872 - Part 4: Factor updating animation properties process out. r=dbaron
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Fri, 19 Feb 2016 09:16:15 +0900 - rev 285505
Push 30030 by cbook@mozilla.com at Thu, 25 Feb 2016 10:58:04 +0000
Bug 1242872 - Part 4: Factor updating animation properties process out. r=dbaron MozReview-Commit-ID: 8VWdC3wFRZX
f50864e2c30de5b3dee4b1e5689d04c8d803692d: Bug 1242872 - Part 3: Factor finding old animations process out. r=dbaron
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Fri, 19 Feb 2016 09:16:15 +0900 - rev 285504
Push 30030 by cbook@mozilla.com at Thu, 25 Feb 2016 10:58:04 +0000
Bug 1242872 - Part 3: Factor finding old animations process out. r=dbaron MozReview-Commit-ID: H4bFKGpnhpX
152e7142f5db0e4ebb935abb0370259e4b252b87: Bug 1242872 - Part 2: Set timeline in CSSAnimationBuilder::Build. r=dbaron
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Fri, 19 Feb 2016 09:16:15 +0900 - rev 285503
Push 30030 by cbook@mozilla.com at Thu, 25 Feb 2016 10:58:04 +0000
Bug 1242872 - Part 2: Set timeline in CSSAnimationBuilder::Build. r=dbaron MozReview-Commit-ID: 6bisME1VK0d
ba0463bb2058fb05855fa68d0104f5329322e676: Bug 1242872 - Part 1.1: Move AnimationManager::BuildAnimations. r=dbaron
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Fri, 19 Feb 2016 09:16:15 +0900 - rev 285502
Push 30030 by cbook@mozilla.com at Thu, 25 Feb 2016 10:58:04 +0000
Bug 1242872 - Part 1.1: Move AnimationManager::BuildAnimations. r=dbaron MozReview-Commit-ID: ENfBlECSiDP
761e73e8ca9a4da5667f8f4288ecfa4e34df53e8: Bug 1242872 - Part 1: Introduce CSSAnimationBuilder to factor a bunch of stuff in BuildAnimations and CheckAnimationRule out. r=dbaron
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Fri, 19 Feb 2016 09:16:15 +0900 - rev 285501
Push 30030 by cbook@mozilla.com at Thu, 25 Feb 2016 10:58:04 +0000
Bug 1242872 - Part 1: Introduce CSSAnimationBuilder to factor a bunch of stuff in BuildAnimations and CheckAnimationRule out. r=dbaron MozReview-Commit-ID: 7921De3IVA6
43f67d61062ac9e7d4202ef49a89d30f18583f84: Bug 1249469 - Followup: missing #include on a CLOSED TREE.
Shu-yu Guo <shu@rfrn.org> - Wed, 24 Feb 2016 18:45:47 -0800 - rev 285500
Push 30030 by cbook@mozilla.com at Thu, 25 Feb 2016 10:58:04 +0000
Bug 1249469 - Followup: missing #include on a CLOSED TREE.
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip