47242d5db87afa496ec1c597dc31d8b91b78f99d: Bug 1227662 - Fix code and add tests for fetching video mimetypes r=margaret
Mark Finkle <mfinkle@mozilla.com> - Thu, 04 Feb 2016 18:19:59 -0500 - rev 283158
Push 29975 by philringnalda@gmail.com at Sat, 06 Feb 2016 02:27:56 +0000
Bug 1227662 - Fix code and add tests for fetching video mimetypes r=margaret
10dfe5e3ded1621a7ef777ddbc54e5f80696c3d6: Bug 1242213 - Part 3: Use android:packageName="org.mozilla.gecko" and --rename-manifest-package. r=mfinkle
Nick Alexander <nalexander@mozilla.com> - Sun, 24 Jan 2016 22:00:30 -0800 - rev 283157
Push 29975 by philringnalda@gmail.com at Sat, 06 Feb 2016 02:27:56 +0000
Bug 1242213 - Part 3: Use android:packageName="org.mozilla.gecko" and --rename-manifest-package. r=mfinkle ON A CLOSED TREE I have manually verified that this results in a byte-identical gecko.ap_. This is because after the earlier patches there are no definitions (or aliases) that are package-local (like .App or .Webapp), which are the only things (other than the Android package name) that get rewritten by --rename-manifest-package.
92227c8d185ba25e540d7f3ecd82c6d9203e6e54: Bug 1242213 - Part 2: Fold App <activity-alias> into BrowserApp <activity>. r=mfinkle
Nick Alexander <nalexander@mozilla.com> - Sun, 24 Jan 2016 22:00:29 -0800 - rev 283156
Push 29975 by philringnalda@gmail.com at Sat, 06 Feb 2016 02:27:56 +0000
Bug 1242213 - Part 2: Fold App <activity-alias> into BrowserApp <activity>. r=mfinkle Way back in Fennec 33 (Bug 929865, see https://hg.mozilla.org/mozilla-central/rev/a4f39c9db1d9) we replaced org.mozilla.gecko.App with org.mozilla.gecko.BrowserApp and introduced the .App <activity-alias>. Per the entry for android:name of http://developer.android.com/guide/topics/manifest/activity-element.html, .App translates to $ANDROID_PACKAGE_NAME.App. We haven't referenced an Activity qualified with a non-org.mozilla.gecko *class* name (for example, from bookmark shortcuts) since well before Fennec 33, so this probably never did what it was intended to do: we wanted to redirect org.mozilla.gecko.App to org.mozilla.gecko.BrowserApp, but it instead has been redirecting org.mozilla.fennec.App to org.mozilla.gecko.BrowserApp. I don't think we've been referring to $ANDROID_PACKAGE_NAME.App since well before Fennec 29, if ever. The <activity-alias> has been servicing essentially all <intent-filter> invocations of Fennec by passing them directly to org.mozilla.gecko.BrowserApp. This pushes a long programme of simplification forward. Fallout might look like very old homescreen shortcuts failing to launch, but I'm quite confident that won't actually happen.
b517a7f4296a430ac91f704eaa8f728f639e6e40: Bug 1242213 - Part 1: Remove old-style Webapp entry-point. r=mfinkle f=myk
Nick Alexander <nalexander@mozilla.com> - Sun, 24 Jan 2016 22:00:29 -0800 - rev 283155
Push 29975 by philringnalda@gmail.com at Sat, 06 Feb 2016 02:27:56 +0000
Bug 1242213 - Part 1: Remove old-style Webapp entry-point. r=mfinkle f=myk This <activity> and <activity-alias> support old-style homescreen shortcuts to old-style Webapps. Such shortcuts must have been produced at least 18 months ago, and pre-date the new-style synthetic APK Webapps entirely. New-style APK Webapps are slated to be removed from the product entirely, and there's no reason to keep their even less viable predecessor around. Telemetry from http://mzl.la/23kXGV5 shows that there were no launches of webapps (old-style or new-style) for Fennec 43 release. Telemetry from http://mzl.la/23kXFAs shows that there were 40.7k launches of webapps (again, old-style or new-style) for Fennec 44 beta (of 39.0M total -- for 0.1% total). We cannot distinguish old-style from new-style, but it is safe to assume it's a tiny proportion. Users with such homescreen shortcuts will see a bogus "App isn't installed" message and need to delete and re-create their shortcut in some way. The org.mozilla.gecko.Webapp class cannot be removed until new-style APK Webapps are removed.
2b77aa9048009d076e4dd54a6890657815432b03: Bug 1242213 - Part 0: Use org.mozilla.gecko.BrowserApp instead of .App. r=me,gbrown,bc
Nick Alexander <nalexander@mozilla.com> - Wed, 27 Jan 2016 12:15:19 -0800 - rev 283154
Push 29975 by philringnalda@gmail.com at Sat, 06 Feb 2016 02:27:56 +0000
Bug 1242213 - Part 0: Use org.mozilla.gecko.BrowserApp instead of .App. r=me,gbrown,bc This approach lets us get rid of the .App <activity-alias> definitions, at least. In Bug 1237755, I tried pretty hard to use real intent filters, rather than a different hard-code path name, but ran into significant issues, and finally into the hard reality that Android 2.3 doesn't support bare package names. (It only supports package/class component names.) Android 2.3 can't die fast enough. Sadly, this approach doesn't address the issues I see loading URLs that prompted Bug 1237755. This is the path of least resistance. Onwards! Tested via: nalexander@chocho ~/M/gecko> ./mach run Starting: Intent { act=android.activity.MAIN cmp=org.mozilla.fennec_nalexander/org.mozilla.gecko.BrowserApp } Warning: Activity not started, its current task has been brought to the front nalexander@chocho ~/M/gecko> ./mach run https://mozilla.org Starting: Intent { act=android.activity.MAIN dat=https://mozilla.org cmp=org.mozilla.fennec_nalexander/org.mozilla.gecko.BrowserApp } nalexander@chocho ~/M/gecko> ./mach run file:///mnt/sdcard/test.html Starting: Intent { act=android.activity.MAIN dat=file:///mnt/sdcard/test.html cmp=org.mozilla.fennec_nalexander/org.mozilla.gecko.BrowserApp }
21ff9b18942e1ef3572de8eed08efd2ee92202b2: Bug 1245516 - Don't shadow originHost, so we can process appOrigin correctly r=margaret
Andrzej Hunt <ahunt@mozilla.com> - Wed, 03 Feb 2016 15:27:35 -0800 - rev 283153
Push 29975 by philringnalda@gmail.com at Sat, 06 Feb 2016 02:27:56 +0000
Bug 1245516 - Don't shadow originHost, so we can process appOrigin correctly r=margaret
c79f4a8c3e86aa0c1c693f637b9d5ac053a6fd2f: Bug 1234629 - Post: Add simple bouncer APK docs. r=me
Nick Alexander <nalexander@mozilla.com> - Thu, 04 Feb 2016 11:23:27 -0800 - rev 283152
Push 29975 by philringnalda@gmail.com at Sat, 06 Feb 2016 02:27:56 +0000
Bug 1234629 - Post: Add simple bouncer APK docs. r=me
400c030d3c01d8818fe07d4547e0c145e19f099e: Bug 1234629 - Post: Make bouncer APK Java package org.mozilla.gecko, like the main APK. r=me
Nick Alexander <nalexander@mozilla.com> - Wed, 27 Jan 2016 15:28:12 -0800 - rev 283151
Push 29975 by philringnalda@gmail.com at Sat, 06 Feb 2016 02:27:56 +0000
Bug 1234629 - Post: Make bouncer APK Java package org.mozilla.gecko, like the main APK. r=me This small change is a follow-up to Bug 1242213, which did the same for the main package. This is a nod to the future and Gradle, which cleanly splits the internal Java package (org.mozilla.gecko) from the external Android package (org.mozilla.fennec and friends).
54a3d0851bc60d26fb4744c605787031070052c8: Bug 1234629 - Post: Add Gradle support for bouncer. r=me
Nick Alexander <nalexander@mozilla.com> - Tue, 26 Jan 2016 11:54:00 -0800 - rev 283150
Push 29975 by philringnalda@gmail.com at Sat, 06 Feb 2016 02:27:56 +0000
Bug 1234629 - Post: Add Gradle support for bouncer. r=me
f80912ecfa87584394d22e28ed09e68c182d1b35: Bug 1234629 - Part 3: Make bouncer's <intent-filter> set a larger subset of Fennec's <intent-filter> set. r=margaret
Nick Alexander <nalexander@mozilla.com> - Wed, 27 Jan 2016 15:44:29 -0800 - rev 283149
Push 29975 by philringnalda@gmail.com at Sat, 06 Feb 2016 02:27:56 +0000
Bug 1234629 - Part 3: Make bouncer's <intent-filter> set a larger subset of Fennec's <intent-filter> set. r=margaret
50bcadca213183aaa64e39632892b8f00957dcfc: Bug 1234629 - Part 2: Fail packaging if bouncer APK and main APK have different permissions. r=gps
Nick Alexander <nalexander@mozilla.com> - Wed, 27 Jan 2016 14:34:46 -0800 - rev 283148
Push 29975 by philringnalda@gmail.com at Sat, 06 Feb 2016 02:27:56 +0000
Bug 1234629 - Part 2: Fail packaging if bouncer APK and main APK have different permissions. r=gps This isn't sensible for b2gdroid, but that project should never enable the bouncer APK anyway.
aaa420ed66d754ecc17b19f5a12297d24371f1ca: Bug 1234629 - Part 1: Create bouncer APK for OTA distribution installs. r=margaret,gps
Nick Alexander <nalexander@mozilla.com> - Wed, 27 Jan 2016 15:28:31 -0800 - rev 283147
Push 29975 by philringnalda@gmail.com at Sat, 06 Feb 2016 02:27:56 +0000
Bug 1234629 - Part 1: Create bouncer APK for OTA distribution installs. r=margaret,gps This commit produces an "install bouncer" APK which is a "hollow shell" that looks like the main Fennec APK. In particular, both APKs have: * the same Android package name (application id); and * the same set of <permission>, <uses-permission>, and <uses-feature> blocks in their manifests. The bouncer APK must always have an android:versionCode smaller than the main Fennec APK; for now, we will just bump that manually mobile/android/bouncer/moz.build.
7a62e97f07c2c90d9f34c2c7de40f3cb193f6312: Bug 1234629 - Pre: Make Distribution look in /data/data/$PACKAGE/distribution last. r=rnewman
Nick Alexander <nalexander@mozilla.com> - Tue, 26 Jan 2016 17:06:27 -0800 - rev 283146
Push 29975 by philringnalda@gmail.com at Sat, 06 Feb 2016 02:27:56 +0000
Bug 1234629 - Pre: Make Distribution look in /data/data/$PACKAGE/distribution last. r=rnewman Call a distribution in /data/data/$PACKAGE/distribution a "data distribution". Right now we read data distributions only in response to writing them via another code path (extracting from APK, or downloading). We don't recognize a data distribution in the same way that we recognize a system distribution (in /system/.../distribution) in the Java code, simply because we don't look for it; and I haven't investigated, but I think that Gecko may in fact recognize a data distribution in this case. This patch simply recognizes data distributions after looking for other distributions. That way data distributions written by the bouncer APK are recognized and initialized, but not given precedence over other distribution channels.
edfca1614182aa60d23d763a3a2142dbdf966e6f: Bug 1168175 - Turn on screen and disable keyboard before running each test. r=gbrown
Nick Alexander <nalexander@mozilla.com> - Thu, 04 Feb 2016 09:54:12 -0800 - rev 283145
Push 29975 by philringnalda@gmail.com at Sat, 06 Feb 2016 02:27:56 +0000
Bug 1168175 - Turn on screen and disable keyboard before running each test. r=gbrown
926d1440ce98c618194236956342a627fdec4a93: Bug 1163082 - Part 2: Extract Android distribution from packaged assets rather than APK root. r=rnewman
Nick Alexander <nalexander@mozilla.com> - Tue, 26 Jan 2016 10:36:09 -0800 - rev 283144
Push 29975 by philringnalda@gmail.com at Sat, 06 Feb 2016 02:27:56 +0000
Bug 1163082 - Part 2: Extract Android distribution from packaged assets rather than APK root. r=rnewman This reads from "assets/distribution/**" in the APK and writes to "distribution/**" in the data directory. That output is the same, but the input used to read from "distribution/**", which is not really supported by modern build tooling (Gradle), which doesn't allow to write files directly into the APK root. I manually tested this without issue. I see no way to add meaningful tests to our current Robocop test suite; the long term testing approach is to develop a new test for this functionality and only run it against the "distribution" build type that was added in Bug 1163080. However, that's a larger project than I have time for now.
489b15a7dce6b8d26dddc26387ea0d02d057c298: Bug 1163082 - Part 1: Add --with-android-distribution-directory. r=gps
Nick Alexander <nalexander@mozilla.com> - Wed, 27 Jan 2016 12:25:04 -0800 - rev 283143
Push 29975 by philringnalda@gmail.com at Sat, 06 Feb 2016 02:27:56 +0000
Bug 1163082 - Part 1: Add --with-android-distribution-directory. r=gps This simply packs the assets/ subdirectory of the distribution directory into the assets/ directory of the Android APK using existing mechanisms. It also removes the older method of manually pushing files into dist/bin/distribution, from where they would be packaged into the APK under distribution/.
1dbe350b57b17ec1ce2887441b79c6f51b429378: Backed out changeset 0d358cdf1ce4 (bug 1237458) for bustage
Carsten "Tomcat" Book <cbook@mozilla.com> - Fri, 05 Feb 2016 08:13:50 +0100 - rev 283142
Push 29974 by cbook@mozilla.com at Fri, 05 Feb 2016 10:53:43 +0000
Backed out changeset 0d358cdf1ce4 (bug 1237458) for bustage
91b300b43f10c1b5c4e46002f02ff69d383ec4f5: Bug 1210099 - Fix structured clone of expanded principal (r=bholley)
Bill McCloskey <billm@mozilla.com> - Thu, 04 Feb 2016 15:12:52 -0800 - rev 283141
Push 29974 by cbook@mozilla.com at Fri, 05 Feb 2016 10:53:43 +0000
Bug 1210099 - Fix structured clone of expanded principal (r=bholley)
0e54a3a870e9abbb39d85620204e05f33341c475: Bug 1210099 - Use diagnostic assert for union discriminator checks (r=jld)
Bill McCloskey <billm@mozilla.com> - Thu, 04 Feb 2016 15:12:39 -0800 - rev 283140
Push 29974 by cbook@mozilla.com at Fri, 05 Feb 2016 10:53:43 +0000
Bug 1210099 - Use diagnostic assert for union discriminator checks (r=jld)
0d358cdf1ce4cec60ada9f70ef18ede566098237: Bug 1237458 - Use MOZ_RELEASE_ASSERT for IPC assertions (r=jld)
Bill McCloskey <billm@mozilla.com> - Thu, 04 Feb 2016 16:09:11 -0800 - rev 283139
Push 29974 by cbook@mozilla.com at Fri, 05 Feb 2016 10:53:43 +0000
Bug 1237458 - Use MOZ_RELEASE_ASSERT for IPC assertions (r=jld)
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip