45a1c42118f242f2b0aa020d967b7b34647a84fd: Bug 1596918: Part 4g - Misc cleanup/fixes. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Tue, 10 Dec 2019 23:07:41 +0000 - rev 506334
Push 36903 by ncsoregi@mozilla.com at Wed, 11 Dec 2019 09:46:40 +0000
Bug 1596918: Part 4g - Misc cleanup/fixes. r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D53748
db09910ffa56e73564470c4692a63c8df053601a: Bug 1596918: Part 4f - Fix callers which have timing issues. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Tue, 10 Dec 2019 23:07:31 +0000 - rev 506333
Push 36903 by ncsoregi@mozilla.com at Wed, 11 Dec 2019 09:46:40 +0000
Bug 1596918: Part 4f - Fix callers which have timing issues. r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D53747
5c9d9f141c1041aebf4075c0e68a96660f7c36b6: Bug 1596918: Part 4e - Fix callers which rely on frame message manager globals. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Tue, 10 Dec 2019 23:07:28 +0000 - rev 506332
Push 36903 by ncsoregi@mozilla.com at Wed, 11 Dec 2019 09:46:40 +0000
Bug 1596918: Part 4e - Fix callers which rely on frame message manager globals. r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D53746
6a135670d60356c1266f06fb78a56822064dc293: Bug 1596918: Part 4d - Fix callers which try to return non-clonable values. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Tue, 10 Dec 2019 23:07:34 +0000 - rev 506331
Push 36903 by ncsoregi@mozilla.com at Wed, 11 Dec 2019 09:46:40 +0000
Bug 1596918: Part 4d - Fix callers which try to return non-clonable values. r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D53745
3a0184e0df72f01ec3e4d2b794b747a82a8a0ef5: Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Tue, 10 Dec 2019 23:07:22 +0000 - rev 506330
Push 36903 by ncsoregi@mozilla.com at Wed, 11 Dec 2019 09:46:40 +0000
Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8 ContentTask tasks have a different lifetime than SpecialPowers tasks, with the former being tied to the lifetime of a message manager and the latter tied to the lifetime of a window global. That means that existing ContentTask callers which expect to be able to register load listeners before the creation of a window global, or which expect to persist after a page has navigated, won't work as SpecialPowers tasks. Since those sorts of tasks are not really resilient in the face of Fission, they should really be written to work differently, but this patch mostly just reverts them to using ContentTask for the time being. Differential Revision: https://phabricator.services.mozilla.com/D53744
2f00364868236e9256150f5fcce21d54adf84116: Bug 1596918: Part 4b - Fix more ESLint issues after rewrite. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Tue, 10 Dec 2019 23:07:20 +0000 - rev 506329
Push 36903 by ncsoregi@mozilla.com at Wed, 11 Dec 2019 09:46:40 +0000
Bug 1596918: Part 4b - Fix more ESLint issues after rewrite. r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D53743
a770c6d08d52971e96b36782d8808e371d956585: Bug 1596918: Part 4a - Re-add eslint-disable comments removed by rewrite. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Tue, 10 Dec 2019 23:07:17 +0000 - rev 506328
Push 36903 by ncsoregi@mozilla.com at Wed, 11 Dec 2019 09:46:40 +0000
Bug 1596918: Part 4a - Re-add eslint-disable comments removed by rewrite. r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D53742
ef062eb7a6eebd7e36f1a1400fc9240b844b21c0: Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato
Kris Maglione <maglione.k@gmail.com> - Tue, 10 Dec 2019 23:07:21 +0000 - rev 506327
Push 36903 by ncsoregi@mozilla.com at Wed, 11 Dec 2019 09:46:40 +0000
Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato Differential Revision: https://phabricator.services.mozilla.com/D53741
a6ea596e98db270da0b7669ffce4baedf19b27b3: Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
Kris Maglione <maglione.k@gmail.com> - Tue, 10 Dec 2019 23:07:13 +0000 - rev 506326
Push 36903 by ncsoregi@mozilla.com at Wed, 11 Dec 2019 09:46:40 +0000
Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato This is generally pretty straightforward, and rewrites nearly all calls. It skips the ones that it can detect using frame script globals like `sendAsyncMessage`, though. Differential Revision: https://phabricator.services.mozilla.com/D53740
9638ed4641baa7a6182686f393b04537dc1cab78: Bug 1598738 - Remove using namespace std from OnlineSpeechRecognitionService. r=andrenatal
Eric Rahm <erahm@mozilla.com> - Tue, 26 Nov 2019 05:59:18 +0000 - rev 506325
Push 36903 by ncsoregi@mozilla.com at Wed, 11 Dec 2019 09:46:40 +0000
Bug 1598738 - Remove using namespace std from OnlineSpeechRecognitionService. r=andrenatal Differential Revision: https://phabricator.services.mozilla.com/D54349
65d69ba8d88ab562557bb61139fca09381ac25d3: Bug 1602568 - Enable Rust PGO on linux32 and Windows r=firefox-build-system-reviewers,chmanchester
David Major <dmajor@mozilla.com> - Tue, 10 Dec 2019 19:48:04 +0000 - rev 506324
Push 36903 by ncsoregi@mozilla.com at Wed, 11 Dec 2019 09:46:40 +0000
Bug 1602568 - Enable Rust PGO on linux32 and Windows r=firefox-build-system-reviewers,chmanchester Differential Revision: https://phabricator.services.mozilla.com/D56584
611a2b145da227e02aeacd256bad64058b040cff: Bug 1602568 - Remove NO_PGO from osclientcerts library r=keeler
David Major <dmajor@mozilla.com> - Tue, 10 Dec 2019 19:48:04 +0000 - rev 506323
Push 36903 by ncsoregi@mozilla.com at Wed, 11 Dec 2019 09:46:40 +0000
Bug 1602568 - Remove NO_PGO from osclientcerts library r=keeler If we turn on Rust PGO, the build system can't deal with the mixture of this NO_PGO library along with its PGO'ed Rust dependency. It seems that this NO_PGO might have been a copy/paste artifact anyway, so let's go ahead and remove it. Differential Revision: https://phabricator.services.mozilla.com/D56587
3c8aebdfc742a2037cfaeef067c03d720e3440f5: Bug 1584311 - Remove XUL grid from pluginPrefs.xul and make it an HTML page. r=mstriemer
Tim Nguyen <ntim.bugs@gmail.com> - Tue, 10 Dec 2019 22:50:48 +0000 - rev 506322
Push 36903 by ncsoregi@mozilla.com at Wed, 11 Dec 2019 09:46:40 +0000
Bug 1584311 - Remove XUL grid from pluginPrefs.xul and make it an HTML page. r=mstriemer Differential Revision: https://phabricator.services.mozilla.com/D56234
b0ce0ed033e6ed37358f10468c2bd11d7aa3b935: Bug 1602905 - Enable low priority thread pool on Windows r=jrmuizel
Bert Peers <bpeers@mozilla.com> - Tue, 10 Dec 2019 21:42:37 +0000 - rev 506321
Push 36903 by ncsoregi@mozilla.com at Wed, 11 Dec 2019 09:46:40 +0000
Bug 1602905 - Enable low priority thread pool on Windows r=jrmuizel Differential Revision: https://phabricator.services.mozilla.com/D56610
7635669b8d722e90ffd93fea712b60da64085653: Bug 1602608: Reject DOM Fullscreen promises with reasonable messages. r=smaug
Kris Maglione <maglione.k@gmail.com> - Tue, 10 Dec 2019 22:26:23 +0000 - rev 506320
Push 36902 by aciure@mozilla.com at Wed, 11 Dec 2019 03:34:51 +0000
Bug 1602608: Reject DOM Fullscreen promises with reasonable messages. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D56599
0480e575877faf68d5042fa0b7ca45badf1855a5: Bug 1602062, update data collection link in about:preferences#privacy r=Gijs
Emma Malysz <emalysz@mozilla.com> - Tue, 10 Dec 2019 22:06:24 +0000 - rev 506319
Push 36902 by aciure@mozilla.com at Wed, 11 Dec 2019 03:34:51 +0000
Bug 1602062, update data collection link in about:preferences#privacy r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D56591
b59b9185d64944fc6e671b75ea5eba515397e30f: Bug 1602882 - Move AutoValueArray and HandleValueArray to a new ValueArray.h header. r=sfink
Jeff Walden <jwalden@mit.edu> - Tue, 10 Dec 2019 19:54:44 +0000 - rev 506318
Push 36902 by aciure@mozilla.com at Wed, 11 Dec 2019 03:34:51 +0000
Bug 1602882 - Move AutoValueArray and HandleValueArray to a new ValueArray.h header. r=sfink Depends on D56593 Differential Revision: https://phabricator.services.mozilla.com/D56594
9c2d6b0f339415fa1d085073dc43b912ec8a638e: Bug 1602882 - Don't mark |JSContext::sizeOfExcludingThis| as a friend API. r=sfink
Jeff Walden <jwalden@mit.edu> - Tue, 10 Dec 2019 19:54:44 +0000 - rev 506317
Push 36902 by aciure@mozilla.com at Wed, 11 Dec 2019 03:34:51 +0000
Bug 1602882 - Don't mark |JSContext::sizeOfExcludingThis| as a friend API. r=sfink Depends on D56592 Differential Revision: https://phabricator.services.mozilla.com/D56593
8b88919d7bd105f01caeab317698e21aeac707b6: Bug 1602882 - Remove |JSContext::checkMallocGCPressure| as unused and undefined. r=sfink
Jeff Walden <jwalden@mit.edu> - Tue, 10 Dec 2019 19:54:44 +0000 - rev 506316
Push 36902 by aciure@mozilla.com at Wed, 11 Dec 2019 03:34:51 +0000
Bug 1602882 - Remove |JSContext::checkMallocGCPressure| as unused and undefined. r=sfink Differential Revision: https://phabricator.services.mozilla.com/D56592
160a1414094801bf8bad94166d5aa6ac14a6ca3a: Bug 1584346 - Make RDM UI's getViewportBrowser return the browser tab if fission-enabled r=mconley,bradwerth
Micah Tigley <mtigley@mozilla.com> - Tue, 10 Dec 2019 22:05:03 +0000 - rev 506315
Push 36902 by aciure@mozilla.com at Wed, 11 Dec 2019 03:34:51 +0000
Bug 1584346 - Make RDM UI's getViewportBrowser return the browser tab if fission-enabled r=mconley,bradwerth This revision modifies RDM UI’s `getViewportBrowser` to return the tab’s <browser> instead of the <mozbrowser> this.toolWindow’s [getViewportBrowser method](https://searchfox.org/mozilla-central/source/devtools/client/responsive/index.js#176) returns. If the pref `devtools.responsive.browserUI.enabled` is set to true, this will cause this.toolWindow to be null because this object is set during the [swap step when RDM is initialized](https://searchfox.org/mozilla-central/source/devtools/client/responsive/ui.js#150). Since we're not doing away with swap/tunnel until work on RDM fission is complete, we should still preserve the toolWindow property on RDM UI. For context, this.toolWindow is a reference to the RDM UI’s window, which also happens to be populated with other properties such as `getViewportBrowser` (the function causing the issue), `getViewportSize`, `addInitialViewport`, etc… It’s responsible for holding the RDM UI chrome:// document which is also where the <mozbrowser> iframe is contained. Please see: https://searchfox.org/mozilla-central/source/devtools/client/responsive/index.js for reference on where these properties are added. Also, now that the RDM fission work requires the removal of <mozbrowser>, this.toolWindow won't be needed to get access to the toolbar UI. The RDM toolbar will be embedded into the browser UI and can be referenced with `this.rdmFrame`. So this means toolWindow along with any parts of the code using it should be removed when fission work is complete. I believe [Bug 1585096](https://bugzilla.mozilla.org/show_bug.cgi?id=1585096) would be the correct place to do this. Differential Revision: https://phabricator.services.mozilla.com/D56602
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip