4477d849b72a0cf15159b1f99a8530a250575365: Bug 1572895 - Update some XPConnect mochitests to work under Fission. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Fri, 09 Aug 2019 17:44:48 -0700 - rev 488072
Push 36435 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:46:49 +0000
Bug 1572895 - Update some XPConnect mochitests to work under Fission. r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D41469
0fae715f6c26e75f825c7c6cbd694d19522ebf27: Bug 1562292: Follow-up: Fix bustage in GetWindowByName after dropping removal patch. r=bustage CLOSED TREE
Kris Maglione <maglione.k@gmail.com> - Wed, 14 Aug 2019 12:08:05 -0700 - rev 488071
Push 36435 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:46:49 +0000
Bug 1562292: Follow-up: Fix bustage in GetWindowByName after dropping removal patch. r=bustage CLOSED TREE MANUAL PUSH: Bustage fix.
de2caa18324b6dab0f75b760e3abdaa96bc381cd: Bug 1562292: Part 3 - Update test annotations. r=nika
Kris Maglione <maglione.k@gmail.com> - Thu, 01 Aug 2019 23:02:01 -0700 - rev 488070
Push 36435 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:46:49 +0000
Bug 1562292: Part 3 - Update test annotations. r=nika MANUAL PUSH: Partial landing. Differential Revision: https://phabricator.services.mozilla.com/D40502
8303383dd95b60e0b23d961bc397f670b2fd0383: Bug 1562292: Part 2d - Operate on BrowsingContext in most of OpenWindowInternal. r=nika
Kris Maglione <maglione.k@gmail.com> - Thu, 01 Aug 2019 17:08:54 -0700 - rev 488069
Push 36435 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:46:49 +0000
Bug 1562292: Part 2d - Operate on BrowsingContext in most of OpenWindowInternal. r=nika This allows us to actually correctly load URIs into and return BCs for cross-process named targets. It still leaves a lot of code which needs to operate directly on DocShells, but it only applies to new windows, which always start out same-process. The one exception is the logic to change the opener of an existing cross-process window targeted by an open() operation, which can't currently be accomplished outside of the BC's owner process. This will need a follow-up. Differential Revision: https://phabricator.services.mozilla.com/D40501
b47a29dc541a8cefda7c14274581e9c868944400: Bug 1562292: Part 2c - Use BrowserContext rather than DocShell to resolve named targets. r=nika
Kris Maglione <maglione.k@gmail.com> - Fri, 28 Jun 2019 14:34:58 -0700 - rev 488068
Push 36435 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:46:49 +0000
Bug 1562292: Part 2c - Use BrowserContext rather than DocShell to resolve named targets. r=nika This lets us lookup cross-process targets, but does not yet allow returning or loading anything into them. Differential Revision: https://phabricator.services.mozilla.com/D40500
ce60426d7e3152c92c9df31e1657bee4dc928d1b: Bug 1562292: Part 2b - Remove unused nsPIWindowWatcher::FindItemWithName method. r=nika
Kris Maglione <maglione.k@gmail.com> - Fri, 28 Jun 2019 12:32:49 -0700 - rev 488067
Push 36435 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:46:49 +0000
Bug 1562292: Part 2b - Remove unused nsPIWindowWatcher::FindItemWithName method. r=nika Differential Revision: https://phabricator.services.mozilla.com/D40499
40b61344f0da14f9700a75a8a1c67458e440b68a: Bug 1562292: Part 1f - Implement BrowsingContext::LoadURI. r=nika
Kris Maglione <maglione.k@gmail.com> - Thu, 01 Aug 2019 18:00:32 -0700 - rev 488066
Push 36435 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:46:49 +0000
Bug 1562292: Part 1f - Implement BrowsingContext::LoadURI. r=nika In order to do cross-process targeted window.open() and link click operations, we need a way to load URIs in the current DocShell of a BrowsingContext, whichever process it lives in. This patch does this in the simplest possible way, bouncing the URL, along with the target and accessor contexts, up to the parent and down to the current owning child process. It does some basic sanity checks in the parent, which should probably be expanded in the future, and should really ideally try to initiate the load in the parent as soon as possible. But for now, it does what we need. Differential Revision: https://phabricator.services.mozilla.com/D40497
3bffe760e2db5ff009f0d798cbb63b83a68de51b: Bug 1562292: Part 1e - Use BrowsingContext as target in IsSandboxedFrom(). r=nika
Kris Maglione <maglione.k@gmail.com> - Thu, 01 Aug 2019 16:36:32 -0700 - rev 488065
Push 36435 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:46:49 +0000
Bug 1562292: Part 1e - Use BrowsingContext as target in IsSandboxedFrom(). r=nika This check always has access to an in-process DocShell which is attempting to perform a load, but its target may often be cross-process, and have no in-process DocShell. This patch changes the target checks to use a BrowsingContext in a Fission-compatible way. Differential Revision: https://phabricator.services.mozilla.com/D40496
ba987e21b5329d07c3606a65ee0cb76e7bc99a74: Bug 1562292: Part 1d - Move OnePermittedSandboxedNavigator to BrowsingContext. r=nika
Kris Maglione <maglione.k@gmail.com> - Thu, 01 Aug 2019 16:22:52 -0700 - rev 488064
Push 36435 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:46:49 +0000
Bug 1562292: Part 1d - Move OnePermittedSandboxedNavigator to BrowsingContext. r=nika We need to be able to check the one-permitted-sandboxed-navigator from potentially-cross-process access checks in DocShell, which means it needs to live on BrowsingContext rather than DocShell. Differential Revision: https://phabricator.services.mozilla.com/D40495
a50f085eb3e6c506fd8e17acb669ef91b6f31390: Bug 1562292: Part 1c - Set BrowsingContext Closed flag at the same time as outer window's. r=nika
Kris Maglione <maglione.k@gmail.com> - Thu, 01 Aug 2019 19:46:32 -0700 - rev 488063
Push 36435 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:46:49 +0000
Bug 1562292: Part 1c - Set BrowsingContext Closed flag at the same time as outer window's. r=nika We rely on the Closed flag to avoid targeting named window open operations to windows which have already closed. The DocShell's lookup logic checks the Closed flag of the outer window, while BrowsingContext's checks the flag of the context. The latter, however, is only set when the window's DocShell is destroyed, which happens much later, and leaves closed windows returning true from IsTargetable() for much longer than they should. This patch immediately sets the BrowsingContext's closed flag at the same time as we set the same flag on the outer window, and leaves the existing setters in case of any corner cases. Differential Revision: https://phabricator.services.mozilla.com/D40494
a8ac7bcafc270b5be3eca84efebcde672fe8fba5: Bug 1562292: Part 1b.2 - Don't fall back to named lookup for inaccessible special name. r=nika
Kris Maglione <maglione.k@gmail.com> - Thu, 08 Aug 2019 11:43:38 -0700 - rev 488062
Push 36435 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:46:49 +0000
Bug 1562292: Part 1b.2 - Don't fall back to named lookup for inaccessible special name. r=nika Currently, if a window with a special name is inaccessible to the caller, we fall back to ordinary named lookup, which is not desirable. This patch changes that behavior so that we never attempt fallback for special names. Differential Revision: https://phabricator.services.mozilla.com/D41260
f1fc2382346d163fe18a8fe5d323aafa759e1317: Bug 1562292: Part 1b.1 - Fix FindWithSpecialName with inaccessible "_parent". r=nika
Kris Maglione <maglione.k@gmail.com> - Thu, 01 Aug 2019 18:45:47 -0700 - rev 488061
Push 36435 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:46:49 +0000
Bug 1562292: Part 1b.1 - Fix FindWithSpecialName with inaccessible "_parent". r=nika The special name "_parent" resolves to the parent window when one exists, or the current target window if it does not. Either way, it returns null if the target is inaccessible. The current logic, however, treats inaccessible the same as nonexistent, and returns the current window if it is has a parent from which it is sandboxed. This differs from the corresponding DocShell logic, which returns null in that case. This patch aligns the BrowsingContext behavior with the DocShell behavior. Differential Revision: https://phabricator.services.mozilla.com/D40493
d513683e1fdbfdb79f5112e9745f2fc0fb4e92fe: Bug 1562292: Part 1a - Consider requesting context in BrowsingContext lookup methods. r=farre
Kris Maglione <maglione.k@gmail.com> - Tue, 30 Jul 2019 17:30:55 -0700 - rev 488060
Push 36435 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:46:49 +0000
Bug 1562292: Part 1a - Consider requesting context in BrowsingContext lookup methods. r=farre Access to a particular named browsing context depends on the caller who is attempting the access. For a call to `parent.open(..., name)`, for instance, it's the privileges of the sub-frame making the open() call that matter, even though the name resolution happens relative to the parent. The current BrowsingContext FindWithName logic always considers only the access of the BrowsingContext it's searching relative to, regardless of the caller, while the corresponding DocShell logic correctly takes the caller into account. This patch updates the APIs to allow passing a specific accessing BrowsingContext, and falls back to the target when one isn't passed (e.g., by WebIDL callers, to which the new parameter is not exposed). Differential Revision: https://phabricator.services.mozilla.com/D40492
99d4d3837b3ba32d26ece9fe77e337b968199283: Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE
Ciure Andrei <aciure@mozilla.com> - Wed, 14 Aug 2019 19:37:05 +0300 - rev 488059
Push 36435 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:46:49 +0000
Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE
b18e834a1dafe9e1b8e36585239027030e3d07e3: bug 1569875: remote: fix link to Prefs.html; r=me a=doc
Andreas Tolfsen <ato@sny.no> - Wed, 14 Aug 2019 14:42:21 +0100 - rev 488058
Push 36435 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:46:49 +0000
bug 1569875: remote: fix link to Prefs.html; r=me a=doc MANUAL PUSH: doc change DONTBUILD
144fbfb409b72b5849ace2a1e3c199c259f7c1d3: Merge autoland to mozilla-central. a=merge
Brindusan Cristian <cbrindusan@mozilla.com> - Thu, 15 Aug 2019 12:43:29 +0300 - rev 488057
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Merge autoland to mozilla-central. a=merge
26094588b48e14bb39fb838196e8d489b1a4c3ee: Bug 1573886 - Fix backdrop-filter blur errors due to incorrect scaling r=kvark
Connor Brewster <cbrewster@mozilla.com> - Wed, 14 Aug 2019 20:13:06 +0000 - rev 488056
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1573886 - Fix backdrop-filter blur errors due to incorrect scaling r=kvark Differential Revision: https://phabricator.services.mozilla.com/D42013
ed066ea4b64cf7ec8253027ad11bf0f90d12c27b: Bug 1573946 - Remove unused FxA toolbar menu strings r=flod
Vijay Budhram <vbudhram@mozilla.com> - Wed, 14 Aug 2019 19:28:02 +0000 - rev 488055
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1573946 - Remove unused FxA toolbar menu strings r=flod Differential Revision: https://phabricator.services.mozilla.com/D42017
d8ac382b5f1790a5da7e2da12e4e1c92c39bb22b: Bug 1479960 - Add unit tests for shared memory freezing. r=froydnj
Jed Davis <jld@mozilla.com> - Wed, 14 Aug 2019 22:48:52 +0000 - rev 488054
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1479960 - Add unit tests for shared memory freezing. r=froydnj Also refactor SharedMemoryBasic::SystemProtect to allow testing cases that are expected to fail. Depends on D26748 Differential Revision: https://phabricator.services.mozilla.com/D26749
86cb672b7000844c4802bc890e7b759e42e0e722: Bug 1536697 - Fix error handling in base::SharedMemory::Map. r=froydnj
Jed Davis <jld@mozilla.com> - Wed, 14 Aug 2019 22:48:51 +0000 - rev 488053
Push 36434 by cbrindusan@mozilla.com at Thu, 15 Aug 2019 09:44:30 +0000
Bug 1536697 - Fix error handling in base::SharedMemory::Map. r=froydnj If mmap failed, we'd leave the memory_ member variable set to MAP_FAILED, but everything else in this file checks for nullptr (and only nullptr) to test if the pointer is valid. Also, this removes the debug assertion that the mmap succeeded, to allow writing unit tests where we expect it to fail (e.g., for insufficient permissions). Depends on D26747 Differential Revision: https://phabricator.services.mozilla.com/D26748
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 tip