42c76408a8bdeea672dc5144c103cb34fe850b5f: Bug 1544198 - Test cases for the root element. r=jfkthame
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 23 Apr 2019 01:14:37 +0000 - rev 470432
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1544198 - Test cases for the root element. r=jfkthame These test cases intentionally check only Y-axis scroll position since horizontal scroll on the root element has been broken, e.g. bug 1102175 or bug 1260054. Differential Revision: https://phabricator.services.mozilla.com/D27988
52410914b543300394f6b98c8dd6e3d73fb84780: Bug 1544198 - Use the proper frame to get scroll-snap-type value on the root element. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 23 Apr 2019 01:16:02 +0000 - rev 470431
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1544198 - Use the proper frame to get scroll-snap-type value on the root element. r=botond Now scroll-snap-type property on body element doesn't affect scroll position so that scrollTo-scrollBy-snaps.html is needed to be modified to specify scroll-snap-type on html. Differential Revision: https://phabricator.services.mozilla.com/D27987
5b413410d2c5f93ca4240a3c4608a1182d53a2d2: Bug 1544198 - Split ScrolLFrameHelper::ComputeScrollSnapInto into two functions. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 23 Apr 2019 01:12:38 +0000 - rev 470430
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1544198 - Split ScrolLFrameHelper::ComputeScrollSnapInto into two functions. r=botond The one is for the scroll snap module v1 implementation, the other is for the old scroll snap implementation. Now both functions have the same pieces of code to get scroll-snap-type values, but for v1 implemention in the next commit we will use GetFrameForScrollSnap() to get the value instead. Differential Revision: https://phabricator.services.mozilla.com/D27986
530a3f39ecbd096436a8cf38d1d73068ff1fbcb8: Bug 1544198 - Factor out the function to get the frame for scroll-snap-type and scroll-padding. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 23 Apr 2019 01:12:24 +0000 - rev 470429
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1544198 - Factor out the function to get the frame for scroll-snap-type and scroll-padding. r=botond Differential Revision: https://phabricator.services.mozilla.com/D27985
f413cb36905d980cccb30577f827938f80cbe913: Bug 1544198 - Use the proper writing-mode for scroll-snap for viewport. r=jfkthame
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 23 Apr 2019 01:12:09 +0000 - rev 470428
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1544198 - Use the proper writing-mode for scroll-snap for viewport. r=jfkthame In the CSS writing mode spec [1], the writing mode for the document should be taken from body, GetFrameForDir() is the function to get the corresponding frame for writing-mode. A web platform test for this case will be added at the last of this commit series. Unfortunately as of this commit, we can't introduce proper test cases since there is another issue on scroll-snap-type which will be fixed in subsequent commits. [1] https://drafts.csswg.org/css-writing-modes-4/#principal-flow Differential Revision: https://phabricator.services.mozilla.com/D27984
181f8519792032d158f03d2757724df99955cd44: Bug 1544961 - comment on gtests that are disabled, disable ThreadUtils.IdleRunnableMethod and Timers.FindExpirationTime for windows10-aarch64 r=jmaher,gbrown,dmajor
Edwin Gao <egao@mozilla.com> - Tue, 23 Apr 2019 00:21:37 +0000 - rev 470427
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1544961 - comment on gtests that are disabled, disable ThreadUtils.IdleRunnableMethod and Timers.FindExpirationTime for windows10-aarch64 r=jmaher,gbrown,dmajor Changes: - added comments for tests being disabled - disabled two additional tests in order to green the run Differential Revision: https://phabricator.services.mozilla.com/D28085
09240f7397c12707cc0a8ff63051d28568be40e9: Bug 1542958 - fix code section adjustments in elfhack; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Mon, 22 Apr 2019 23:44:28 +0000 - rev 470426
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1542958 - fix code section adjustments in elfhack; r=glandium We were never adjusting `last` in this loop, so we were computing the wrong addresses for all sections beyond the first. Which in turn meant that we would compute the wrong size for the section data we needed to allocate. Differential Revision: https://phabricator.services.mozilla.com/D28195
8858cc62fe60eab511ed28bdf7f46bd718cdd417: Bug 1519514 - make xul/mac-tab-toolbar.xul test running under chrome privileges r=bgrins
Alexander Surkov <surkov.alexander@gmail.com> - Mon, 22 Apr 2019 21:24:24 +0000 - rev 470425
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1519514 - make xul/mac-tab-toolbar.xul test running under chrome privileges r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D28367
54bfe0a47b678837214f7b46978d98b225fdfd2e: Backed out changeset 9509ae2baf1c (bug 1470880) for components/customizableui/test/browser* failures CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Tue, 23 Apr 2019 03:28:13 +0300 - rev 470424
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Backed out changeset 9509ae2baf1c (bug 1470880) for components/customizableui/test/browser* failures CLOSED TREE
6fea732af7666d74602f9ed66b71c742648f5389: Bug 1539984 - pass along whether a focus change was tripped by a keypress to ensure :-moz-focusring works as designed, r=Jamie
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 22 Apr 2019 23:41:56 +0000 - rev 470423
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1539984 - pass along whether a focus change was tripped by a keypress to ensure :-moz-focusring works as designed, r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D27874
8b552b0169ac49cab72e9aebeb15a2b87d35055b: Bug 1545890 - Depth textures are filterable like RED textures. r=lsalzman
Jeff Gilbert <jgilbert@mozilla.com> - Mon, 22 Apr 2019 20:57:57 +0000 - rev 470422
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1545890 - Depth textures are filterable like RED textures. r=lsalzman Differential Revision: https://phabricator.services.mozilla.com/D28267
8ce092764f601dc1d02c2f7a779ff405796b1b03: Bug 1545962 - Use <template> instead of CDATA for about:preferences r=Gijs
Brian Grinstead <bgrinstead@mozilla.com> - Mon, 22 Apr 2019 22:38:57 +0000 - rev 470421
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1545962 - Use <template> instead of CDATA for about:preferences r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28280
496a04e97a17f481899ea873155294cd3da55ea2: Bug 1545592 - Make SanitizeOnShutdown policy more granular. r=Felipe,flod
Michael Kaply <mozilla@kaply.com> - Fri, 19 Apr 2019 18:32:15 +0000 - rev 470420
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1545592 - Make SanitizeOnShutdown policy more granular. r=Felipe,flod Differential Revision: https://phabricator.services.mozilla.com/D28145
bd2261f7465814875436e794313a4fa525d8e69d: Bug 1544136 - Ship the scroll snap snap on betas and releases. r=botond
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 22 Apr 2019 22:38:18 +0000 - rev 470419
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1544136 - Ship the scroll snap snap on betas and releases. r=botond Differential Revision: https://phabricator.services.mozilla.com/D27989
e85cb54e594431e3b60f2e32cc6222872ba64f55: Bug 1546046 - Remove support for XBL resources. r=TYLin
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 22 Apr 2019 21:57:22 +0000 - rev 470418
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1546046 - Remove support for XBL resources. r=TYLin So much unsound code going away :-) Differential Revision: https://phabricator.services.mozilla.com/D28380
fc479e4e17f208520ccfa4fd29bacc1a90ba4bfa: Bug 1519514 - make sure document.l10n is initialized before triggering conext menu over a tab in browser_ext_menus_activeTab.js test r=Gijs
Alexander Surkov <surkov.alexander@gmail.com> - Mon, 22 Apr 2019 20:18:02 +0000 - rev 470417
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1519514 - make sure document.l10n is initialized before triggering conext menu over a tab in browser_ext_menus_activeTab.js test r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D28366
89f6237ef760987f550fa6a96d92268152cbbe0c: Merge mozilla-central to autoland. a=merge CLOSED TREE
Oana Pop Rus <opoprus@mozilla.com> - Tue, 23 Apr 2019 01:15:48 +0300 - rev 470416
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Merge mozilla-central to autoland. a=merge CLOSED TREE
73e8dcb8be078f4d66058019f70c2cd0e4526a6b: Backed out 9 changesets (bug 1542454, bug 1533562) for failing at /browser/browser_ext_webNavigation_onCreatedNavigationTarget_contextmenu.js on a CLOSED TREE.
Gurzau Raul <rgurzau@mozilla.com> - Tue, 23 Apr 2019 01:09:12 +0300 - rev 470415
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Backed out 9 changesets (bug 1542454, bug 1533562) for failing at /browser/browser_ext_webNavigation_onCreatedNavigationTarget_contextmenu.js on a CLOSED TREE. Backed out changeset 88756a309968 (bug 1542454) Backed out changeset 37bd2819d3a7 (bug 1542454) Backed out changeset 19f0462bb47a (bug 1542454) Backed out changeset b4440b1833ec (bug 1533562) Backed out changeset 8970cdb3c04a (bug 1533562) Backed out changeset 498cd34eea78 (bug 1533562) Backed out changeset 3a3b4d52e10a (bug 1533562) Backed out changeset 5fae2f233aa0 (bug 1533562) Backed out changeset e3fc54ebcd15 (bug 1533562)
9509ae2baf1cecd227c949c74bc4022b79e89459: Bug 1470880 - Simplify arrowpanel selectors in order to remove last usage of xbl resources. r=bgrins
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 22 Apr 2019 21:41:29 +0000 - rev 470414
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1470880 - Simplify arrowpanel selectors in order to remove last usage of xbl resources. r=bgrins The reason why this fixes it is a bit subtle, let me try to explain. XBL has this mechanism where all attributes in the binding `<content>` element get auto-propagated to the bound element (the `<panel>` in this case). This doesn't seem to be a very used feature looking at: https://searchfox.org/mozilla-central/search?q=%3Ccontent&case=false&regexp=false&path=xml The panel binding uses it to add the `side` attribute: https://searchfox.org/mozilla-central/rev/d80f0a570736dce76a2eb184fb65517462089e8a/toolkit/content/widgets/popup.xml#264 The key here is that this attribute addition is silent (`aNotify=false`): https://searchfox.org/mozilla-central/rev/d80f0a570736dce76a2eb184fb65517462089e8a/dom/xbl/nsXBLBinding.cpp#341 This means that the presence of this attribute is not supposed to change the rendering of the page. It'd also be unsafe to notify at the point at which we create XBL bindings. So the way this happens is: * We compute the initial style of the `<panel>` element (which doesn't have a `side` attribute, and thus doesn't match the rules, and has a computed opacity of 1). * The XBL service _silently_ sets the `side` attribute. This should cause a style change, but it doesn't since it's silent, so we remain with the opacity of 1. * We open the popup, and the XBL binding listens for the `popupshowing` event and adds the `animate` attribute. The style system notices, and eventually we compute the new style. Issue is, it has again an opacity of 1, so we don't fire the transition. Same with transform and such of course. So far so good, but then, why does it work if there's a `<resources>` element with an empty stylesheet? Fun that you ask! We explicitly re-resolve the style of the element if there are any stylesheets: https://searchfox.org/mozilla-central/rev/d80f0a570736dce76a2eb184fb65517462089e8a/dom/xbl/nsXBLService.cpp#551 And thus grab the correct initial opacity of zero, and trigger the transition. Given arrow panels always have a `side` attribute (and same for the bookmarks thing), making their style not depend on the silent attribute additions from `<content>` fixes the bug. We could fix the bug with an alternative patch (re-resolving style if there's a `<content>` element with attributes in the binding). This wouldn't be completely sound anyway in presence of combinators, and given that it'd remain being unsound anyway, we should probably just remove that feature. Also, the simplification of the stylesheets seems worth it anyway. I'll follow-up removing the `<resources>` implementation, and we should probably investigate removing the `<content>` attribute propagation, since it's the really unsound thing here. Differential Revision: https://phabricator.services.mozilla.com/D28310
8ff5048f2b90c941edb72bd671f3f728a4cdd15b: Bug 1546190 - Add sharper images, collapsible devtools and bug fixes to Activity Stream r=r1cky
Ed Lee <edilee@mozilla.com> - Mon, 22 Apr 2019 20:43:46 +0000 - rev 470413
Push 35905 by dvarga@mozilla.com at Tue, 23 Apr 2019 09:53:27 +0000
Bug 1546190 - Add sharper images, collapsible devtools and bug fixes to Activity Stream r=r1cky Differential Revision: https://phabricator.services.mozilla.com/D28398
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 tip