4267d07cfc2175b7127724c38952de74c0d88ce2: Bug 1453396 - Tests splitted into two to fix intermittent test timed out. r=ckerschb
Vinothkumar Nagasayanan <cegvinoth@gmail.com> - Fri, 25 May 2018 16:20:32 +0300 - rev 419888
Push
34052 by ccoroiu@mozilla.com at Fri, 25 May 2018 17:52:14 +0000
Bug 1453396 - Tests splitted into two to fix intermittent test timed out. r=ckerschb
7ab29553438948a56f096ed727ba3577a6fdfebd: Bug 1462650 - Improve imgTools::EncodeScaledImage performance. r=lsalzman
Andrew Osmond <aosmond@mozilla.com> - Fri, 25 May 2018 09:02:20 -0400 - rev 419887
Push
34052 by ccoroiu@mozilla.com at Fri, 25 May 2018 17:52:14 +0000
Bug 1462650 - Improve imgTools::EncodeScaledImage performance. r=lsalzman
We should avoiding creating a DrawTarget to create a new
DataSourceSurface when the original surface produced by
RasterImage::GetFrameAtSize matches our requirements in
imgTools::EncodeScaledImage. We should also be using Skia instead of
Cairo.
This patch also fixes a few error conditions where we would not have
unmapped the surface properly.
109d4f846f31e2263598fb40786f325bc26b9e20: Bug 1463767 - ReleasingTimerHolder should expose nsINamed::GetName only if MOZ_COLLECTING_RUNNABLE_TELEMETRY is defined, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 25 May 2018 14:46:44 +0200 - rev 419886
Push
34052 by ccoroiu@mozilla.com at Fri, 25 May 2018 17:52:14 +0000
Bug 1463767 - ReleasingTimerHolder should expose nsINamed::GetName only if MOZ_COLLECTING_RUNNABLE_TELEMETRY is defined, r=smaug
998c04fd7948e070c3ffbe456d98a0d876911c72: Bug 1461727 - The name of the type field in the type descriptor for WebAssembly.Global shall be "value". r=lth.
Julian Seward <jseward@acm.org> - Fri, 25 May 2018 13:31:46 +0200 - rev 419885
Push
34052 by ccoroiu@mozilla.com at Fri, 25 May 2018 17:52:14 +0000
Bug 1461727 - The name of the type field in the type descriptor for WebAssembly.Global shall be "value". r=lth.
The current name is "type". Henceforth it shall be known as "value", per CG
decision of 15 May 2018.
e5a47fceeee0bf002f521c9e35242769887cdeb0: No bug - Fix some bogus indentation. r=me
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 25 May 2018 14:18:29 +0200 - rev 419884
Push
34052 by ccoroiu@mozilla.com at Fri, 25 May 2018 17:52:14 +0000
No bug - Fix some bogus indentation. r=me
MozReview-Commit-ID: 6G7oS6MkJ0Y
f1901407d4fae48934787c62dcb699f75ad0c60d: No bug - Use a static atom instead of a dynamic one. r=me
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 25 May 2018 14:12:44 +0200 - rev 419883
Push
34052 by ccoroiu@mozilla.com at Fri, 25 May 2018 17:52:14 +0000
No bug - Use a static atom instead of a dynamic one. r=me
MozReview-Commit-ID: CUTwfsCrovQ
b479a3309609c69098ab05bf46e0e6c0b04d2a4e: Backed out changeset 5bb547481faf (bug 1451973) for testChild failures on a CLOSED TREE
Gurzau Raul <rgurzau@mozilla.com> - Fri, 25 May 2018 14:16:34 +0300 - rev 419882
Push
34052 by ccoroiu@mozilla.com at Fri, 25 May 2018 17:52:14 +0000
Backed out changeset 5bb547481faf (
bug 1451973) for testChild failures on a CLOSED TREE
4c4a74e7bdfd99a091d0f29498dae6d0f0213466: Bug 1265584 - Update wpt metadata, r=maja_zf
James Graham <james@hoppipolla.co.uk> - Tue, 15 May 2018 16:02:51 +0100 - rev 419881
Push
34052 by ccoroiu@mozilla.com at Fri, 25 May 2018 17:52:14 +0000
Bug 1265584 - Update wpt metadata, r=maja_zf
MozReview-Commit-ID: F0KYHBJ8nIh
b021a8615326a99919fe62b493874ac9d49441da: Bug 1265584 - Add a test for wpttest metadata, r=maja_zf
James Graham <james@hoppipolla.co.uk> - Tue, 15 May 2018 14:25:58 +0100 - rev 419880
Push
34052 by ccoroiu@mozilla.com at Fri, 25 May 2018 17:52:14 +0000
Bug 1265584 - Add a test for wpttest metadata, r=maja_zf
MozReview-Commit-ID: Jme9GND8ihS
b7716dedbf5a24e0e9a940a907225f7b3dd7d35c: Bug 1265584 - Output asserts to wptreport.json, r=maja_zf
James Graham <james@hoppipolla.co.uk> - Thu, 10 May 2018 15:43:30 +0100 - rev 419879
Push
34052 by ccoroiu@mozilla.com at Fri, 25 May 2018 17:52:14 +0000
Bug 1265584 - Output asserts to wptreport.json, r=maja_zf
In the future we want to update metadata using the wptreport.json data, since
that's much much smaller and easier to parse. In addition, this is
required to determine if a test fully passed, so it makes sense to
store it here.
MozReview-Commit-ID: ErYT33BhqGg
605324b9d70e822a9d25e1c6ff7ca2bcbff6085c: Bug 1265584 - Use ujson where possible for faster metadata update, r=maja_zf
James Graham <james@hoppipolla.co.uk> - Thu, 10 May 2018 15:39:14 +0100 - rev 419878
Push
34052 by ccoroiu@mozilla.com at Fri, 25 May 2018 17:52:14 +0000
Bug 1265584 - Use ujson where possible for faster metadata update, r=maja_zf
Profiling shows that switching to this library means we no longer
spend most of the update time parsing json (vs 80% or so before),
making other optimisations worthwhile. This is never used in
automation (except wptsync) so availability of the library in the
internal pypi isn't a problem.
MozReview-Commit-ID: U5gabb5lz8
cc9b28394533a30a6ae33def5ce1117882653134: Bug 1265584 - Support updating asserts with wpt-update, r=maja_zf
James Graham <james@hoppipolla.co.uk> - Thu, 10 May 2018 15:38:16 +0100 - rev 419877
Push
34052 by ccoroiu@mozilla.com at Fri, 25 May 2018 17:52:14 +0000
Bug 1265584 - Support updating asserts with wpt-update, r=maja_zf
With support for asserts, it's also necessary to be able to update the
expected number of asserts automatically using
wpt-update. Unfortunately asserts don't work quite like test statuses,
so this involves a reasonable amount of refactoring.
For asserts the desired behaviour is that the max asserts is either
one plus the highest recorded number of asserts, or the current
value, whichever is higher, and for the minimm asserts, it's the
minumum of the current value and one lower than the lowest recorded
value (clamped at zero). Instead of creating per-platform
expectations, the code only updates the defaults (or any existing
conditional that happens to match). It's not clear that we have enough
information to meaningfully make per-platform expectations, and we
want to reduce the risk of intermittents.
MozReview-Commit-ID: HuTpbAZYGzo
cc1d47bf0aa7efe3e770316c9ea5d895beafcaba: Bug 1265584 - Reverse the order of metadata iteration, r=maja_zf
James Graham <james@hoppipolla.co.uk> - Mon, 14 May 2018 22:25:48 +0100 - rev 419876
Push
34052 by ccoroiu@mozilla.com at Fri, 25 May 2018 17:52:14 +0000
Bug 1265584 - Reverse the order of metadata iteration, r=maja_zf
wptrunner previously iterated over properties from least significant
to most significant. However this was broken since it caused
per-directory properties to override per-test properties, which wasn't
expected. Therefore we reverse the order of iteration from most
significant to least.
MozReview-Commit-ID: 5Rh6EGNtnUS
bc43ae3ccc9f203268a2b495b99515c617306c88: Bug 1265584 - Add support for recording asserts in wptrunner, r=ato, maja_zf
James Graham <james@hoppipolla.co.uk> - Tue, 08 May 2018 13:32:02 +0100 - rev 419875
Push
34052 by ccoroiu@mozilla.com at Fri, 25 May 2018 17:52:14 +0000
Bug 1265584 - Add support for recording asserts in wptrunner, r=ato, maja_zf
Gecko has an API for producing a non-fatal "assert". For quality
control, it should be possible to annotate the range of possible
numbers of these asserts produced during a test execution, and fail if
the actual number of asserts falls outside this range.
This patch adds assert checking by default in debug builds. It adds
two metadata properties; max-asserts and min-asserts for specifying
the range of possible asserts produced in a test.
MozReview-Commit-ID: BFiIfYKuB9L
b99661f1fcc56bca0176bd813c166525a4ebf2e4: Bug 1265584 - Make base_executor_kwargs arguments match executor_kwargs, r=ato
James Graham <james@hoppipolla.co.uk> - Tue, 08 May 2018 16:24:49 +0100 - rev 419874
Push
34052 by ccoroiu@mozilla.com at Fri, 25 May 2018 17:52:14 +0000
Bug 1265584 - Make base_executor_kwargs arguments match executor_kwargs, r=ato
MozReview-Commit-ID: IS7KwuRjmc6
9b8539a9a2a6c20220cdcb07e19b7bf3a91c7436: Bug 1265584 - Move wptrunner marionette usage onto a single thread, r=ato
James Graham <james@hoppipolla.co.uk> - Mon, 14 May 2018 16:57:19 +0100 - rev 419873
Push
34052 by ccoroiu@mozilla.com at Fri, 25 May 2018 17:52:14 +0000
Bug 1265584 - Move wptrunner marionette usage onto a single thread, r=ato
Running marionette on a background thread is problematic in the case
that a test times out. In this case the background thread is not
terminated. If we then call into marionette again on the main thread
we may race with something that happens on the runner thread. The
marionette client isn't threadsafe, so this leads to buggy behaviour.
The simplest fx for the problem is just to move all the marionette
calls onto the main thread and instead of waiting on the main thread,
spin up a thread with a timer.
MozReview-Commit-ID: 3vVlMcwPHSx
a6f3af165d488712c31c2e2f43214c0820c27ace: Bug 1265584 - Fix logging of unexpected assertions with mach formatter, r=ahal
James Graham <james@hoppipolla.co.uk> - Tue, 08 May 2018 16:23:00 +0100 - rev 419872
Push
34052 by ccoroiu@mozilla.com at Fri, 25 May 2018 17:52:14 +0000
Bug 1265584 - Fix logging of unexpected assertions with mach formatter, r=ahal
MozReview-Commit-ID: Dk1ahUYyYIm
b37bf166ab83f54292e6a566cd642893d7b45b6b: Bug 1382683 - Part 3. Add gtests for SurfaceFilter/Pipe::WritePixelBlocks. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Fri, 25 May 2018 06:52:05 -0400 - rev 419871
Push
34052 by ccoroiu@mozilla.com at Fri, 25 May 2018 17:52:14 +0000
Bug 1382683 - Part 3. Add gtests for SurfaceFilter/Pipe::WritePixelBlocks. r=tnikkel
1f1623675fdcd6a61dbbfb2341e0ba02022a3086: Bug 1382683 - Part 2. Switch nsGIFDecoder2 to write pixels in blocks instead of individually. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Fri, 25 May 2018 06:52:03 -0400 - rev 419870
Push
34052 by ccoroiu@mozilla.com at Fri, 25 May 2018 17:52:14 +0000
Bug 1382683 - Part 2. Switch nsGIFDecoder2 to write pixels in blocks instead of individually. r=tnikkel
nsGIFDecoder2::YieldPixel is sufficiently complex that the optimizer
does not appear to inline it with the rest of the templated methods. As
such there is a high cost to calling it. This patch modifies it to yield
a requested number of pixels before exiting, allowing us to amortize the
cost of calling across a row instead of a pixel. Based on profiling,
this will significantly reduce the time require to decode a frame.
3b84413763f8b9afe41aa9546430adebeb872e4d: Bug 1382683 - Part 1. Implement SurfacePipe::WritePixelBlocks for faster writing of pixels. r=tnikkel
Andrew Osmond <aosmond@mozilla.com> - Fri, 25 May 2018 06:52:01 -0400 - rev 419869
Push
34052 by ccoroiu@mozilla.com at Fri, 25 May 2018 17:52:14 +0000
Bug 1382683 - Part 1. Implement SurfacePipe::WritePixelBlocks for faster writing of pixels. r=tnikkel
It has been observed in profiling that the templated methods that write
pixels to an image buffer do not always inline methods properly, leading
to a high cost of writing a single pixel if it is less than trivial. As
such, there is a new SurfacePipe method, WritePixelBlocks, which
requests pixels in blocks. The provided lambda will write up to the
requested number of pixels into the given buffer. WritePixelBlocks
itself will request enough pixels to fill the row, advance the row if
complete and iterate until it is complete or we need more data.