3f6b4aa35bcb235196bf4ef3ab612defb4fccc60: Bug 1706463 - Make misc. devtools client tests work with native context menus. r=mac-reviewers,mstange
Harry Twyford <htwyford@mozilla.com> - Tue, 20 Apr 2021 20:43:27 +0000 - rev 576833
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1706463 - Make misc. devtools client tests work with native context menus. r=mac-reviewers,mstange Differential Revision: https://phabricator.services.mozilla.com/D112819
8d70c907558b9f70098f59abd5e41871e0e458dc: Bug 1701512 - Add a separate pref for clipboard.read(). r=nika
Tom Schuster <evilpies@gmail.com> - Tue, 20 Apr 2021 20:40:08 +0000 - rev 576832
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1701512 - Add a separate pref for clipboard.read(). r=nika Differential Revision: https://phabricator.services.mozilla.com/D110043
413d7137661b4948e85ef6bfffe4108ff0861169: Bug 1689835 - clipboard.write: Sanitize HTML. r=nika
Tom Schuster <evilpies@gmail.com> - Tue, 20 Apr 2021 20:40:08 +0000 - rev 576831
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1689835 - clipboard.write: Sanitize HTML. r=nika Differential Revision: https://phabricator.services.mozilla.com/D110042
2ffd7c73377a3c5364fc1375199bc56dfbf09ebc: Bug 1689835 - Clipboard.write: Disable SVG support. r=nika
Tom Schuster <evilpies@gmail.com> - Tue, 20 Apr 2021 20:40:07 +0000 - rev 576830
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1689835 - Clipboard.write: Disable SVG support. r=nika Adding SVG sanitization would require a fair bit of new code. Disable this for now, considering that Chrome doesn't seem to be shipping this. Differential Revision: https://phabricator.services.mozilla.com/D110041
bbe3b06f69b840d5014d5f03424f1037f1f0de7f: Bug 1705769 - [devtools] Remove get/set/removeAttribute helpers on test-actor r=nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Tue, 20 Apr 2021 20:24:43 +0000 - rev 576829
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1705769 - [devtools] Remove get/set/removeAttribute helpers on test-actor r=nchevobbe Depends on D112380 Differential Revision: https://phabricator.services.mozilla.com/D112381
baa176aba8be2573273b9d5f066b0e9c9c1d0562: Bug 1705753 - [devtools] Stop using testActor for alternate setStyleInFrame helpers in boxmodel test suite r=nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Tue, 20 Apr 2021 20:24:43 +0000 - rev 576828
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1705753 - [devtools] Stop using testActor for alternate setStyleInFrame helpers in boxmodel test suite r=nchevobbe Depends on D112379 Differential Revision: https://phabricator.services.mozilla.com/D112380
1646211b46b855880e8f3a706f1737cec54a9672: Bug 1705753 - [devtools] Stop using testActor for setStyle/getStyle helpers in boxmodel test suite r=nchevobbe
Julian Descottes <jdescottes@mozilla.com> - Tue, 20 Apr 2021 20:24:42 +0000 - rev 576827
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1705753 - [devtools] Stop using testActor for setStyle/getStyle helpers in boxmodel test suite r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D112379
b5cda8aeefddb281d09efeb8055993d41b91cb5f: Bug 1705744 - Removes myshots from screenshots. r=emalysz
Kajal Sah <kajalsah107@gmail.com> - Tue, 20 Apr 2021 20:22:42 +0000 - rev 576826
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1705744 - Removes myshots from screenshots. r=emalysz Differential Revision: https://phabricator.services.mozilla.com/D112418
f2abde6197570fcf0ab4d806fcf605751210fb86: Bug 1706454 - Use openMenu and activateItem in browser_context_menu_iframe.js and head.js. r=mac-reviewers,spohl
Markus Stange <mstange.moz@gmail.com> - Tue, 20 Apr 2021 20:13:41 +0000 - rev 576825
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1706454 - Use openMenu and activateItem in browser_context_menu_iframe.js and head.js. r=mac-reviewers,spohl Differential Revision: https://phabricator.services.mozilla.com/D112818
267e8925453b55cb1976318a44ae2ec2b80035f9: Bug 1637259 - Dispatch touch event for WM_POINTER r=edgar,aklotz
Kagami Sascha Rosylight <krosylight@mozilla.com> - Tue, 20 Apr 2021 20:13:41 +0000 - rev 576824
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1637259 - Dispatch touch event for WM_POINTER r=edgar,aklotz Differential Revision: https://phabricator.services.mozilla.com/D111513
8a0a264d20c54414e4afd1ade2da39caf0b00829: Bug 1699298 - Ensure MatchPattern::Init throws and AtomSet::Get returns NS_ERROR_ILLEGAL_DURING_SHUTDOWN if called late on shutdown. r=mccr8
Luca Greco <lgreco@mozilla.com> - Tue, 20 Apr 2021 19:43:33 +0000 - rev 576823
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1699298 - Ensure MatchPattern::Init throws and AtomSet::Get returns NS_ERROR_ILLEGAL_DURING_SHUTDOWN if called late on shutdown. r=mccr8 By looking a bit more into the pernosco session attached to this bug, I did notice that MatchPattern::Init is being called late in the xpcom shutdown (seems to be triggered by some pending Promise jobs related to loading the builtin search extension, which in that run got scheduled during the late shutdown). Under these conditions, AtomSet::Get does allocate again the static RefPtr (because the previous one was already destroyed as part of the xpcom shutdown), but it gets destroyed by ClearOnShutdown before the RefPtr gets to the caller: - https://searchfox.org/mozilla-central/rev/a8b75e4ba3f8ddf0e76b42681d0a7b7e78e67730/xpcom/base/ClearOnShutdown.cpp#19-24 This patch does: - check explicitly in MatchPattern::Init if we are get past the XPCOMShutdownFinal phase, and throws an explicit NS_ERROR_ILLEGAL_DURING_SHUTDOWN error if that is the case - change the signature for AtomSet::Get static method, to have an explicit non discardable nsresult as its result value, to track down other similar AtomSet::Get calls that may have to take this scenario into account (and to make it a bit more clear from the method signature that it can actually fail and the returned nsresult should be checked before actually using the refptr). As an additional side note: - I've looked into existing crash reports with this signature but I didn't find any (but I won't exclude that I may have not looked enough) - I've tried to reproduce conditions similar to the ones that I observed in the pernosco session (by cheating a bit and trying to force similar conditions with some temporary changes applied locally) but I wasn't able to trigger it in the exact same way Nevertheless by looking into some past bugzilla issues it looks that - it did already happen in the past that we would be still loading search extensions late in shutdown, (e.g. Bug 1620227) and so it doesn't seem totally surprising that there are other ways that we may be still in the progress. - we did fix some other crashes due to some C++ code being triggered by the js runtime late in shutdown (e.g. Bug 1663315 is one that I did notice in the middle of the bugs I looked), and so it doesn't seem that unexpected that we may still have a call to MatchPattern::Init that late in the shutdown. And so this seems to be a legit scenario to account for, even if I wasn't able to trigger it exactly like Grizzly triggered it during a fuzzy test run. Differential Revision: https://phabricator.services.mozilla.com/D112638
a81431c752a6958cfb81a267b90fcffc31ec6671: Bug 1682719 - [meta] Enables eslint on browser/extensions/screenshots. r=emalysz
Kajal Sah <kajalsah107@gmail.com> - Tue, 20 Apr 2021 19:39:48 +0000 - rev 576822
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1682719 - [meta] Enables eslint on browser/extensions/screenshots. r=emalysz Differential Revision: https://phabricator.services.mozilla.com/D112812
630f37b668d88d30886d42c76e76ee0bef0afd0a: Bug 1602862: Add checks for invalid StringClassFlags r=jld
Randell Jesup <rjesup@wgate.com> - Tue, 20 Apr 2021 19:34:03 +0000 - rev 576821
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1602862: Add checks for invalid StringClassFlags r=jld Differential Revision: https://phabricator.services.mozilla.com/D99271
1d2b794c296b0d58bde60f0470300de34f5a10db: Bug 1696145 - Support Notification.silent and .vibrate on Android. r=smaug,droeh,aklotz
Agi Sferro <agi@sferro.dev> - Tue, 20 Apr 2021 18:35:36 +0000 - rev 576820
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1696145 - Support Notification.silent and .vibrate on Android. r=smaug,droeh,aklotz Differential Revision: https://phabricator.services.mozilla.com/D111924
0d2c300cc4639e8cf8cb02f350df08c0a5d4ac65: Bug 1696145 - Add Array::From(nsTArray) r=aklotz
Agi Sferro <agi@sferro.dev> - Tue, 20 Apr 2021 18:35:36 +0000 - rev 576819
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1696145 - Add Array::From(nsTArray) r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D111923
568884c45cf928447d9ec0290c2618912b0f57a1: Bug 1418792 Start drag operation on touch event on draggable area; r=stransky
Jan Horak <jhorak@redhat.com> - Tue, 20 Apr 2021 18:31:05 +0000 - rev 576818
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1418792 Start drag operation on touch event on draggable area; r=stransky Add support for dragging window on touch event. Differential Revision: https://phabricator.services.mozilla.com/D112370
fc8e07caa633b4190f0c917b9adb788733ed95e1: Bug 1706409 - Fix MediaManager log statement to not crash when starting media. r=ng
Jan-Ivar Bruaroey <jib@mozilla.com> - Tue, 20 Apr 2021 18:26:55 +0000 - rev 576817
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1706409 - Fix MediaManager log statement to not crash when starting media. r=ng Differential Revision: https://phabricator.services.mozilla.com/D112791
9ea44f43776980cf4e8d1b844b3cc6f16cd82afd: Bug 1705363 - Fixes to intl::NumberFormatterSkeleton; r=gregtatum
Dan Minor <dminor@mozilla.com> - Tue, 20 Apr 2021 18:16:24 +0000 - rev 576816
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1705363 - Fixes to intl::NumberFormatterSkeleton; r=gregtatum These are fixes for issues noticed with NumberFormatterSkeleton while testing this code in SpiderMonkey against the full set of intl tests there. I've added minimal test cases for the issues encountered as part of this patch. Differential Revision: https://phabricator.services.mozilla.com/D112240
788d8c4c60036cfccfe63e859730733701f9c383: Bug 1701168 - [remote] Properly wait for resize events on browser dimension changes. r=remote-protocol-reviewers,jdescottes
Henrik Skupin <mail@hskupin.info> - Tue, 20 Apr 2021 18:15:45 +0000 - rev 576815
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1701168 - [remote] Properly wait for resize events on browser dimension changes. r=remote-protocol-reviewers,jdescottes Differential Revision: https://phabricator.services.mozilla.com/D112738
fd72fcc0fa52d52635fa4a5690b2c416cdd43d3f: Bug 1704948 - Update browser.bookmarks.openInTabClosesMenu handling to keep the menu open for middle clicks. r=Gijs
Markus Stange <mstange.moz@gmail.com> - Tue, 20 Apr 2021 17:44:17 +0000 - rev 576814
Push 38392 by ncsoregi@mozilla.com at Wed, 21 Apr 2021 03:11:09 +0000
Bug 1704948 - Update browser.bookmarks.openInTabClosesMenu handling to keep the menu open for middle clicks. r=Gijs In the past, menus stayed open when an item was middle-clicked. Now that menus fire command on middle-click, they automatically close when middle-clicked. So this code now needs to handle middle clicks on menus like left clicks on menus, and manually keep the menu open (rather than rely on them staying open by default). This functionality is covered by browser_stayopenmenu.js. Differential Revision: https://phabricator.services.mozilla.com/D112683
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip