3b5ac5b97a79d8ceeafcb9de4b74c43c1b668fc6: Bug 1662411 [wpt PR 25321] - Fix wildcard host matching in CSPEE subsume algorithm, a=testonly
Antonio Sartori <antoniosartori@chromium.org> - Thu, 10 Sep 2020 15:53:11 +0000 - rev 548307
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Bug 1662411 [wpt PR 25321] - Fix wildcard host matching in CSPEE subsume algorithm, a=testonly Automatic update from web-platform-tests Fix wildcard host matching in CSPEE subsume algorithm The previous implementation returned `true` for `*.example.com` subsumes `example.com`. However, since `*.example.com` does not match `example.com`, this should not be the case. And indeed according to 2.3.3 in https://w3c.github.io/webappsec-cspee/#subsume-source-expressions in this case the subsume algorithm should return `false`. Bug: 1086857 Change-Id: I449f72d2db0a918478fc1ba4250335ae57a4ae2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210463 Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#805286} -- wpt-commits: 4d8bfc649f692738a27b35468b7984b6061ab485 wpt-pr: 25321
b7d28f2119a1cb8b7ac9c982d6745e73b4e53216: Bug 1663389 [wpt PR 25421] - WPT: Refactor contacts tests to use test-only-api.js, a=testonly
Arnaud Mandy <arnaud.mandy@intel.com> - Thu, 10 Sep 2020 15:53:02 +0000 - rev 548306
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Bug 1663389 [wpt PR 25421] - WPT: Refactor contacts tests to use test-only-api.js, a=testonly Automatic update from web-platform-tests WPT: Refactor contacts tests to use test-only-api.js use of test-only-api.js in preparation for launching official MojoJS support in WPT. This would not change the test results on Chromium waterfall (everything should continue to pass) or upstream WPT (tests currently fail because MojoJS isn't enabled). Bug: 1123989 Change-Id: Ib7fed092b37243b82fbbf38d871bb75728cb7744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395395 Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#805272} -- wpt-commits: 226f994feca843b12b1976e4bd4050809c4cc481 wpt-pr: 25421
34f188b4acfb552880d0af2f1b505f8375fffd1e: Bug 1664258 - Increase the default PDF resolution for non-windows platforms. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 11 Sep 2020 11:37:40 +0000 - rev 548305
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Bug 1664258 - Increase the default PDF resolution for non-windows platforms. r=jwatt I've tested both webpage printing and pdf printing, in both the new UI and the system dialog, and this gives consistently better results, specially when images are involved. I've put the exact DPI value on a pref because I think that's the sensible thing to do, and allows us to test higher resolutions too. Differential Revision: https://phabricator.services.mozilla.com/D89805
b76c123c607df6ea96958e632e8eb65b5628266f: Bug 1664402 - Support migrating browser.topsites.useRemoteSetting true to false and back to true. r=mikedeboer
Dão Gottwald <dao@mozilla.com> - Fri, 11 Sep 2020 10:52:31 +0000 - rev 548304
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Bug 1664402 - Support migrating browser.topsites.useRemoteSetting true to false and back to true. r=mikedeboer Differential Revision: https://phabricator.services.mozilla.com/D89891
174a622bf334e32f911e97ca76c36b0a80d51f94: Bug 1639153 - Part 6.5: Add tls dependency for WasmModD. r=lth
Dmitry Bezhetskov <dbezhetskov@igalia.com> - Fri, 11 Sep 2020 11:20:20 +0000 - rev 548303
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Bug 1639153 - Part 6.5: Add tls dependency for WasmModD. r=lth We generate builtin call for Mod operation for Double types, so we need to add a tls dependency. In this patch I've added it. Differential Revision: https://phabricator.services.mozilla.com/D89243
49039661a8071e4ab5995224c1cebc72163a5db2: Bug 1664411 - Factor out a condition to unconditionally enable clipboard events in some documents. r=masayuki
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 11 Sep 2020 11:08:35 +0000 - rev 548302
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Bug 1664411 - Factor out a condition to unconditionally enable clipboard events in some documents. r=masayuki This patch shouldn't introduce any behavior change. Differential Revision: https://phabricator.services.mozilla.com/D89834
9dd67fd23c9eb27ab2d6d0491296e82aa12a6631: Bug 1663938 - Assert that the collector doesn't trigger barriers during marking r=sfink
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 11 Sep 2020 11:13:36 +0000 - rev 548301
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Bug 1663938 - Assert that the collector doesn't trigger barriers during marking r=sfink Differential Revision: https://phabricator.services.mozilla.com/D89638
5012e5d4c2d7fc7c72c9f1eb1434b94762da15f3: Bug 1663003 [Linux/EGL] Use GLX to find X Visual for EGL as a workaround for https://gitlab.freedesktop.org/mesa/mesa/-/issues/149, r=jgilbert
stransky <stransky@redhat.com> - Fri, 11 Sep 2020 10:40:09 +0000 - rev 548300
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Bug 1663003 [Linux/EGL] Use GLX to find X Visual for EGL as a workaround for https://gitlab.freedesktop.org/mesa/mesa/-/issues/149, r=jgilbert Differential Revision: https://phabricator.services.mozilla.com/D89721
92159cd14d67e0dfbd5bca16b3c1a449ec9b0243: Bug 1663003 [Linux/EGL] When we can't find EGLConfig with actual XVisual, use the first suitable one, r=jgilbert
stransky <stransky@redhat.com> - Fri, 11 Sep 2020 10:39:56 +0000 - rev 548299
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Bug 1663003 [Linux/EGL] When we can't find EGLConfig with actual XVisual, use the first suitable one, r=jgilbert Differential Revision: https://phabricator.services.mozilla.com/D89720
a2372b6285d7871f7eb6e914583b1113da2038a1: Bug 1663718 - Don't put too much data in buffer when the data can't be written to socket r=dragana
Kershaw Chang <kershaw@mozilla.com> - Fri, 11 Sep 2020 08:44:07 +0000 - rev 548298
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Bug 1663718 - Don't put too much data in buffer when the data can't be written to socket r=dragana The main reason we used too much memory is that we ignore the `NS_BASE_STREAM_WOULD_BLOCK` returned from socket output stream. When the output stream is blocked, all the data is stored in the output queue and make the memory usage high. Differential Revision: https://phabricator.services.mozilla.com/D89563
433c4ac7d65a7ee98ae406cbc0421185a0c23021: Backed out 7 changesets (bug 1661364, bug 1660342) for making bug 1551615 perma fail CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Fri, 11 Sep 2020 14:13:46 +0300 - rev 548297
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Backed out 7 changesets (bug 1661364, bug 1660342) for making bug 1551615 perma fail CLOSED TREE Backed out changeset a56449ddacc9 (bug 1661364) Backed out changeset fc185ddca53b (bug 1661364) Backed out changeset 99234e013005 (bug 1661364) Backed out changeset eac6bfc4a98d (bug 1661364) Backed out changeset 9cb0e2dc8d8a (bug 1661364) Backed out changeset 37b78e402c23 (bug 1661364) Backed out changeset ae991d4209a7 (bug 1660342)
30cd33572b3d5c4bfa8e5883396dc3aa84a62e0b: Bug 1663537. Fix various tests for desktop zooming scrollbars. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Fri, 11 Sep 2020 10:45:28 +0000 - rev 548296
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Bug 1663537. Fix various tests for desktop zooming scrollbars. r=kats The test fixes all fell into the follow categories: A) The test uses requestAnimationFrame to wait one frame and expects scrolling to be complete. With the desktop zooming scrollbars in order for the scrolling to show up on the main thread we need to send the scroll request to the compositor and then hear back from it via an apz repaint request (apz callback helper). Waiting on requestAnimationFrame will complete the first part, but not necessarily the second part. The fix is to wait for a scroll event. B) Switching tests to wait for scroll events exposes another problem: the test can do things that cause a scroll in order to setup the test (and that may not be obvious that it causes a scroll) before actually proceeding to do the test and do something that causes a scroll and then checks for the scroll change of the second thing. Waiting for a requestAnimationFrame would include both those scrolls without desktop zooming scrollbars, but if we wait for a scroll event we will get the scroll event for the first thing which we are not interested in. So we need to make sure scroll events are cleared out before waiting for any scroll events. We do this by waiting two requestAnimationFrame's and waiting for apz to be flushed. We also use this when a test does something and it wants to test that scrolling is not performed. The main thing that causes scrolling that may not be obvious: calling node.focus(). With stacks like: from test_scroll_per_page.html ``` #01: mozilla::ScrollFrameHelper::CompleteAsyncScroll(nsRect const&, mozilla::ScrollOrigin) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x47d6cc0] #02: mozilla::ScrollFrameHelper::ScrollToWithOrigin(nsPoint, mozilla::ScrollMode, mozilla::ScrollOrigin, nsRect const*, nsIScrollbarMediator::ScrollSnapMode) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x47d7732] #03: mozilla::layout::ScrollAnchorContainer::ApplyAdjustments() [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x4742913] #04: mozilla::PresShell::FlushPendingScrollAnchorAdjustments() [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x4650069] #05: mozilla::PresShell::ProcessReflowCommands(bool) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x465742b] #06: mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x4656af8] #07: mozilla::dom::Document::FlushPendingNotifications(mozilla::ChangesToFlush) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1a87d3c] #08: mozilla::PresShell::ScrollContentIntoView(nsIContent*, mozilla::ScrollAxis, mozilla::ScrollAxis, mozilla::ScrollFlags) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x4652b96] #09: nsFocusManager::ScrollIntoView(mozilla::PresShell*, nsIContent*, unsigned int) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1bedd1c] #10: nsFocusManager::Focus(nsPIDOMWindowOuter*, mozilla::dom::Element*, unsigned int, bool, bool, bool, bool, bool, nsIContent*) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1be6be0] #11: nsFocusManager::SetFocusInner(mozilla::dom::Element*, int, bool, bool) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1be212f] #12: nsFocusManager::SetFocus(mozilla::dom::Element*, unsigned int) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1be32ba] #13: mozilla::dom::Element::Focus(mozilla::dom::FocusOptions const&, mozilla::dom::CallerType, mozilla::ErrorResult&) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1aaf283] #14: mozilla::dom::HTMLElement_Binding::focus(JSContext*, JS::Handle<JSObject*>, void*, JSJitMethodCallArgs const&) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x2d65f3b] ``` from editor/libeditor/tests/test_bug549262.html ``` #01: mozilla::ScrollFrameHelper::CompleteAsyncScroll(nsRect const&, mozilla::ScrollOrigin) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x47d6cc0] #02: mozilla::ScrollFrameHelper::ScrollToWithOrigin(nsPoint, mozilla::ScrollMode, mozilla::ScrollOrigin, nsRect const*, nsIScrollbarMediator::ScrollSnapMode) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x47d7732] #03: mozilla::PresShell::ScrollFrameRectIntoView(nsIFrame*, nsRect const&, mozilla::ScrollAxis, mozilla::ScrollAxis, mozilla::ScrollFlags) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x46541bc] #04: mozilla::PresShell::DoScrollContentIntoView() [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x4653776] #05: mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x4656b11] #06: mozilla::dom::Document::FlushPendingNotifications(mozilla::ChangesToFlush) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1a87d3c] #07: mozilla::PresShell::ScrollContentIntoView(nsIContent*, mozilla::ScrollAxis, mozilla::ScrollAxis, mozilla::ScrollFlags) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x4652b96] #08: nsFocusManager::ScrollIntoView(mozilla::PresShell*, nsIContent*, unsigned int) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1bedd1c] #09: nsFocusManager::Focus(nsPIDOMWindowOuter*, mozilla::dom::Element*, unsigned int, bool, bool, bool, bool, bool, nsIContent*) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1be6be0] #10: nsFocusManager::SetFocusInner(mozilla::dom::Element*, int, bool, bool) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1be212f] #11: nsFocusManager::SetFocus(mozilla::dom::Element*, unsigned int) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1be32ba] #12: mozilla::dom::Element::Focus(mozilla::dom::FocusOptions const&, mozilla::dom::CallerType, mozilla::ErrorResult&) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x1aaf283] #13: mozilla::dom::HTMLElement_Binding::focus(JSContext*, JS::Handle<JSObject*>, void*, JSJitMethodCallArgs const&) [/Users/tim/ffopt2/src/obj-x86_64-apple-darwin19.6.0/toolkit/library/build/XUL + 0x2d65f3b] ``` C) Several tests use nsIDOMWindowUtils advanceTimeAndRefresh/restoreNormalRefresh and expect scrolling to be done after a call to advanceTimeAndRefresh. This is basically A), advanceTimeAndRefresh does a refresh driver tick but doesn't allow a repaint request to come back to the main thread. Differential Revision: https://phabricator.services.mozilla.com/D89403
e6c6a83c4de71878ccfa1b3a39d8ace923943695: Bug 1663847 part 2 - Change Debugger.Environment.callee getter to calleeScript getter. r=tcampbell,jdescottes
Jan de Mooij <jdemooij@mozilla.com> - Fri, 11 Sep 2020 09:24:34 +0000 - rev 548295
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Bug 1663847 part 2 - Change Debugger.Environment.callee getter to calleeScript getter. r=tcampbell,jdescottes The callee getter returned |undefined| for certain functions because it's hard to recover the callee consistently for all environments (and we can't return the internal canonical function). See also bug 1414684. This patch fixes that by exposing the script instead of the callee. Devtools is only interested in the displayName and parameterNames properties and those are also available on scripts (the previous patch adds Script.parameterNames). Differential Revision: https://phabricator.services.mozilla.com/D89701
530e5373b9acdef4943c157aa580194a6a4fd4cc: Bug 1663847 part 1 - Add Debugger.Script.parameterNames getter. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Fri, 11 Sep 2020 09:21:46 +0000 - rev 548294
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Bug 1663847 part 1 - Add Debugger.Script.parameterNames getter. r=tcampbell Simplifies the implementation of Debugger.Object.parameterNames (for functions) and reuses it for scripts. The test is based on the Object-parameterNames.js test with some minor changes and the documentation is based on the Object docs. Devtools code will use this in the next patch. Differential Revision: https://phabricator.services.mozilla.com/D89700
444f4554ea9456909908f2872d1359495d9ff8d3: Bug 1639153 - Part 6.2: Establish dependency from tls for x86 callWithABI div/mod i64. r=lth
Dmitry Bezhetskov <dbezhetskov@igalia.com> - Fri, 11 Sep 2020 09:30:56 +0000 - rev 548293
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Bug 1639153 - Part 6.2: Establish dependency from tls for x86 callWithABI div/mod i64. r=lth x86 has few register so to do div/mod for i64 it call the runtime and clobber almost all gp registers including WasmTlsReg. To be able to call c++ runtime via Builtin thunk we need to set up WasmTlsReg. In this patch I create dependencies from MIR level to Codegen to be sure that WasmTlsReg is alive when we call runtime. Differential Revision: https://phabricator.services.mozilla.com/D88524
5dd737d76eada2a34f24244b30141f01033ea259: Bug 1664114 - Try to find a more usable selection for copy-paste if copying from an HTMLEditor. r=masayuki
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 11 Sep 2020 09:14:07 +0000 - rev 548292
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Bug 1664114 - Try to find a more usable selection for copy-paste if copying from an HTMLEditor. r=masayuki See the bug for the complications that made me write this slightly hacky fix... Other solutions definitely welcome. Add a test, adjusted so it would fail without the change. Differential Revision: https://phabricator.services.mozilla.com/D89835
1fc282e54b7a584087712a870dce62e0bf4c942b: Backed out 5 changesets (bug 1639153) for landing the wrong stack of patches. CLOSED TREE
Butkovits Atila <abutkovits@mozilla.com> - Fri, 11 Sep 2020 12:23:15 +0300 - rev 548291
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Backed out 5 changesets (bug 1639153) for landing the wrong stack of patches. CLOSED TREE Backed out changeset 62480de389ff (bug 1639153) Backed out changeset f2e486f1be17 (bug 1639153) Backed out changeset b79c89e6ac82 (bug 1639153) Backed out changeset ab5825b43bb5 (bug 1639153) Backed out changeset 1b94af3458ce (bug 1639153)
691a86eef68649b434b921080f5b55960b3c9f91: Bug 1664189 - Share hash computation when looking up atoms. r=djvj
Jan de Mooij <jdemooij@mozilla.com> - Fri, 11 Sep 2020 03:37:15 +0000 - rev 548290
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Bug 1664189 - Share hash computation when looking up atoms. r=djvj Differential Revision: https://phabricator.services.mozilla.com/D89731
62480de389ffba353998de24760993b2e1531232: Bug 1639153 - Part 5: Remove remaining uses of Frame::tls. r=lth. CLOSED TREE
Dmitry Bezhetskov <dbezhetskov@igalia.com> - Thu, 27 Aug 2020 10:53:04 +0000 - rev 548289
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Bug 1639153 - Part 5: Remove remaining uses of Frame::tls. r=lth. CLOSED TREE Here we remove remaining uses of Frame::tls. There are many places where we use it: in debug frames, in profiling frames, in jit activation, etc. All these places require short fixes to use our new scheme for getting tls, so I gathered them together. Differential Revision: https://phabricator.services.mozilla.com/D83051 Depends on D83045
f2e486f1be1760e1751cf50acea1ab50cb3cfa90: Bug 1639153 - Part 4: Untie frame iteration from Frame::tls. r=lth
Dmitry Bezhetskov <dbezhetskov@igalia.com> - Thu, 27 Aug 2020 10:30:46 +0000 - rev 548288
Push 37776 by btara@mozilla.com at Fri, 11 Sep 2020 15:10:42 +0000
Bug 1639153 - Part 4: Untie frame iteration from Frame::tls. r=lth Here we replace usage of Frame::tls in frame iteration with GetNearestEffectiveTls. We also maintain current tls for frame iteration object to not to call GetNearestEffectiveTls everytime. Differential Revision: https://phabricator.services.mozilla.com/D83045 Depends on D83044
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip