39df0ca8a664608014c4b03d2644ee608514b6fa: Bug 1429904 - Remove ProfileBuffer::Reset(). r=njn
Markus Stange <mstange@themasta.com> - Thu, 15 Feb 2018 21:49:05 -0500 - rev 406172
Push 33545 by aciure@mozilla.com at Fri, 02 Mar 2018 10:14:13 +0000
Bug 1429904 - Remove ProfileBuffer::Reset(). r=njn MozReview-Commit-ID: AzIyYByoesS
14627f6eefd10400b30e165da220d2f190648a88: Bug 1429904 - Remove unused arguments and return values. r=njn
Markus Stange <mstange@themasta.com> - Sat, 17 Feb 2018 19:21:05 -0500 - rev 406171
Push 33545 by aciure@mozilla.com at Fri, 02 Mar 2018 10:14:13 +0000
Bug 1429904 - Remove unused arguments and return values. r=njn MozReview-Commit-ID: 9P0TKavkwgA
0d15c7f905365c952ec5c42ef7e0f4315276ec8a: Bug 1429904 - When a JSContext for a thread is about to go away, collect enough information about any JIT entries in the buffer so that the entire buffer can be streamed to JSON. r=njn
Markus Stange <mstange@themasta.com> - Wed, 28 Feb 2018 00:17:16 -0500 - rev 406170
Push 33545 by aciure@mozilla.com at Fri, 02 Mar 2018 10:14:13 +0000
Bug 1429904 - When a JSContext for a thread is about to go away, collect enough information about any JIT entries in the buffer so that the entire buffer can be streamed to JSON. r=njn This changeset changes behavior. If the profile is streamed before any JSContext has gone away, we now iterate over the entire buffer twice (per thread): First, to collect information about JIT frames, and then again when we build the JSON for the samples. The first traversal stores small pieces of JSON for JIT fromes in individual strings, and the second iteration splices those strings into the thread JSON's frame table. When the JSContext for a thread goes away, we no longer build JSON for samples, and we don't reset the profiler buffer. We now only build the JSON for JIT frames. Once the complete profile is requested and we build samples for it, we iterate over the entire buffer, and look up the cached JIT frame information for JitReturnAddr entries from the correct range. Different parts of the buffer may correspond to the life time of different JSContexts: For each JSContext we will have one range in the JITFrameInfo, and we can look up the correct range based on the buffer position of the JitReturnAddr entry that we're processing. This new way of doing things has multiple advantages: - We no longer reset the buffer, so we no longer lose information about other threads. - All threads from a given process now always have sample data for the same time range. Before this change, the "partial profile" from a thread that lost its JSContext could extend further into the past than the other threads' profiles. - Requesting profiles multiple times now has more consistent results. Before this change, the first requested profile would include the partial profile, but then the partial profile was discarded. And the second requested profile would not contain any data for the time before the JSContext went away. - We now do less work when a thread's JSContext goes away. This should decrease the interruption time. MozReview-Commit-ID: 3KhnPtBijna
3284f277d5323ab2ea5775588b9e37d5558655f1: Bug 1429904 - Add JITFrameInfo. r=njn
Markus Stange <mstange@themasta.com> - Wed, 28 Feb 2018 00:13:51 -0500 - rev 406169
Push 33545 by aciure@mozilla.com at Fri, 02 Mar 2018 10:14:13 +0000
Bug 1429904 - Add JITFrameInfo. r=njn MozReview-Commit-ID: DashxIKyzYZ
b323ee89d4c7cc81c5d7b7a4d1e3292f074f976d: Bug 1429904 - Put mUniqueStrings into a UniquePtr. r=njn
Markus Stange <mstange@themasta.com> - Sat, 17 Feb 2018 15:50:43 -0500 - rev 406168
Push 33545 by aciure@mozilla.com at Fri, 02 Mar 2018 10:14:13 +0000
Bug 1429904 - Put mUniqueStrings into a UniquePtr. r=njn In an upcoming patch we'll want to initialize mUniqueStrings by stealing another object's UniqueJSONStrings, but UniqueJSONStrings itself is not move-constructible. But UniquePtr is. Making UniqueJSONStrings itself move-constructible would be a bit tricky because it has a SpliceableChunkedJSONWriter which is not move-constructible; and making SpliceableChunkedJSONWriter move-constructible is hard because there's no obvious "empty but valid" state that we could leave a moved-out-of SpliceableChunkedJSONWriter in; for example, it expects to have a non-null WriteFunc at all times. MozReview-Commit-ID: Q6o61HFTiD
d3a10f0b9df618edbc2758ce2f32aa926b5de906: Bug 1429904 - Give UniqueJSONStrings a copy constructor. r=njn
Markus Stange <mstange@themasta.com> - Sat, 17 Feb 2018 15:39:45 -0500 - rev 406167
Push 33545 by aciure@mozilla.com at Fri, 02 Mar 2018 10:14:13 +0000
Bug 1429904 - Give UniqueJSONStrings a copy constructor. r=njn MozReview-Commit-ID: tlh6qkYX7A
099e70b23f74d675e95df652d74a1dbaf29339e2: Bug 1429904 - Tell the ProfiledThreadData what the buffer position was when the thread received its JSContext. r=njn
Markus Stange <mstange@themasta.com> - Sat, 17 Feb 2018 15:03:30 -0500 - rev 406166
Push 33545 by aciure@mozilla.com at Fri, 02 Mar 2018 10:14:13 +0000
Bug 1429904 - Tell the ProfiledThreadData what the buffer position was when the thread received its JSContext. r=njn This also renames FlushSamplesAndMarkers to NotifyAboutToLoseJSContext. MozReview-Commit-ID: FWinMi85yDZ
5438aa8b248a59a16e14c961bb32f33d90c218d7: Bug 1429904 - Use a Variant to split the FrameKey members into two groups. r=njn
Markus Stange <mstange@themasta.com> - Tue, 27 Feb 2018 23:44:02 -0500 - rev 406165
Push 33545 by aciure@mozilla.com at Fri, 02 Mar 2018 10:14:13 +0000
Bug 1429904 - Use a Variant to split the FrameKey members into two groups. r=njn This makes it clear which combinations of fields are possible. MozReview-Commit-ID: C3PriO7nWsJ
c072bfec3cd0e6edc11c7b17ea0a73f45487d4e5: Bug 1429904 - Add 'using namespace mozilla;' to ProfileBufferEntry.cpp and remove some mozilla:: prefixes. r=njn
Markus Stange <mstange@themasta.com> - Sat, 17 Feb 2018 12:35:57 -0500 - rev 406164
Push 33545 by aciure@mozilla.com at Fri, 02 Mar 2018 10:14:13 +0000
Bug 1429904 - Add 'using namespace mozilla;' to ProfileBufferEntry.cpp and remove some mozilla:: prefixes. r=njn I think this file was picking up such a declaration from a different file already, through unified builds. MozReview-Commit-ID: 9xTB2QA86U0
0bf304822495a39b50a173fb1f62cc7602bbcab8: Bug 1429904 - Remove a comment about std::string. r=njn
Markus Stange <mstange@themasta.com> - Wed, 28 Feb 2018 00:30:55 -0500 - rev 406163
Push 33545 by aciure@mozilla.com at Fri, 02 Mar 2018 10:14:13 +0000
Bug 1429904 - Remove a comment about std::string. r=njn nsCString is the idiomatic string class we want to use anyway. There's no need to think about std::string here. MozReview-Commit-ID: 1rjZAyqp13d
b465484b85ab8a071a51d7d4a7129d0437964ac3: Bug 1429904 - Make FrameKey members const. r=njn
Markus Stange <mstange@themasta.com> - Tue, 27 Feb 2018 23:11:34 -0500 - rev 406162
Push 33545 by aciure@mozilla.com at Fri, 02 Mar 2018 10:14:13 +0000
Bug 1429904 - Make FrameKey members const. r=njn MozReview-Commit-ID: KTYmCJM9tOH
4559c0d9ff0e26246cb2f1555877431c1ab06875: Bug 1429904 - Add another constructor to FrameKey which initializes mLine and mCategory, and use it in one place. r=njn
Markus Stange <mstange@themasta.com> - Tue, 27 Feb 2018 23:10:06 -0500 - rev 406161
Push 33545 by aciure@mozilla.com at Fri, 02 Mar 2018 10:14:13 +0000
Bug 1429904 - Add another constructor to FrameKey which initializes mLine and mCategory, and use it in one place. r=njn MozReview-Commit-ID: 1LliQMGjfjx
bad1b732f5f937bdbb2c1d12f7f3f42d8a31aa7c: Bug 1429904 - Let the compiler implement the FrameKey copy constructor for us. r=njn
Markus Stange <mstange@themasta.com> - Tue, 27 Feb 2018 23:08:19 -0500 - rev 406160
Push 33545 by aciure@mozilla.com at Fri, 02 Mar 2018 10:14:13 +0000
Bug 1429904 - Let the compiler implement the FrameKey copy constructor for us. r=njn MozReview-Commit-ID: 9e9rMkEAyeL
f1408af12dfa9ab53f4da597220c32c27331375f: Bug 1429904 - Remove mHash which is now unused. It was only used by FrameKey::operator<. r=njn
Markus Stange <mstange@themasta.com> - Tue, 27 Feb 2018 23:06:31 -0500 - rev 406159
Push 33545 by aciure@mozilla.com at Fri, 02 Mar 2018 10:14:13 +0000
Bug 1429904 - Remove mHash which is now unused. It was only used by FrameKey::operator<. r=njn MozReview-Commit-ID: 5Jc6EYmoZfS
f96a75472e04d4bb37af3b6e5fbfec543eb81c16: Bug 1429904 - Remove unused operator< from StackKey and FrameKey. r=njn
Markus Stange <mstange@themasta.com> - Tue, 27 Feb 2018 22:41:35 -0500 - rev 406158
Push 33545 by aciure@mozilla.com at Fri, 02 Mar 2018 10:14:13 +0000
Bug 1429904 - Remove unused operator< from StackKey and FrameKey. r=njn nsGenericHashKey never calls this operator, as far as I can tell. MozReview-Commit-ID: NDybMI8DOA
d1a509b4cdfbec084aa5bf57f91038813f0cc645: Bug 1442370 - Change SQLITE_TEMP_FILE_PREFIX to a Mozilla unique value. r=asuth
Marco Bonardo <mbonardo@mozilla.com> - Thu, 01 Mar 2018 20:55:18 +0100 - rev 406157
Push 33545 by aciure@mozilla.com at Fri, 02 Mar 2018 10:14:13 +0000
Bug 1442370 - Change SQLITE_TEMP_FILE_PREFIX to a Mozilla unique value. r=asuth MozReview-Commit-ID: 3VRCec9QI1F
a197d5e1bce62e3bcb232975ad2afe6ed9be1dc1: Backed out changeset 885ab31f399b (bug 1441666) for xpcshell failure on browser/extensions/formautofill/test/unit/test_sync.js. CLOSED TREE
Dorel Luca <dluca@mozilla.com> - Fri, 02 Mar 2018 00:37:49 +0200 - rev 406156
Push 33545 by aciure@mozilla.com at Fri, 02 Mar 2018 10:14:13 +0000
Backed out changeset 885ab31f399b (bug 1441666) for xpcshell failure on browser/extensions/formautofill/test/unit/test_sync.js. CLOSED TREE
a1330e4089ad73ec22d89b3162bf50bfa534feb8: Merge mozilla-central to autoland. r=merge on a CLOSED TREE
Dorel Luca <dluca@mozilla.com> - Fri, 02 Mar 2018 00:17:24 +0200 - rev 406155
Push 33545 by aciure@mozilla.com at Fri, 02 Mar 2018 10:14:13 +0000
Merge mozilla-central to autoland. r=merge on a CLOSED TREE
1f32df80a818f1bc5e03ecbec5d1425c4412a59c: Backed out changeset 017d83ffe0a4 (bug 1425152) for xpcshell failure on browser/extensions/formautofill/test/unit/test_sync.js on a CLOSED TREE
Dorel Luca <dluca@mozilla.com> - Thu, 01 Mar 2018 23:58:42 +0200 - rev 406154
Push 33545 by aciure@mozilla.com at Fri, 02 Mar 2018 10:14:13 +0000
Backed out changeset 017d83ffe0a4 (bug 1425152) for xpcshell failure on browser/extensions/formautofill/test/unit/test_sync.js on a CLOSED TREE
13adabb755622b9cb85f76e2e15808e64296c412: Backed out 7 changesets (bug 1440177) for build bustages on a CLOSED TREE
arthur.iakab <aiakab@mozilla.com> - Thu, 01 Mar 2018 23:45:23 +0200 - rev 406153
Push 33545 by aciure@mozilla.com at Fri, 02 Mar 2018 10:14:13 +0000
Backed out 7 changesets (bug 1440177) for build bustages on a CLOSED TREE Backed out changeset d83a1820b2f2 (bug 1440177) Backed out changeset a77d06b2cf03 (bug 1440177) Backed out changeset 928770efc9a3 (bug 1440177) Backed out changeset 49b285030492 (bug 1440177) Backed out changeset 717a696b17e0 (bug 1440177) Backed out changeset 0840994846bf (bug 1440177) Backed out changeset b1ba6c67264b (bug 1440177)
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip