31f468c8c96073db1ab3f92b457f681d40886868: Bug 1614198 - Use cbindgen instead of nsStyleImage. r=aosmond
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 11 Feb 2020 20:56:20 +0000 - rev 513413
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1614198 - Use cbindgen instead of nsStyleImage. r=aosmond The trickier part is that we represent -moz-image-rect as a Rect() type instead of image with non-null clip-rect. So we need to add a bit of code to distinguish "image request types" from other types of images. But it's not too annoying, and we need to do the same for fancier images like image-set and such whenever we implement it, so seems nice to get rid of most explicit usages of nsStyleImage::GetType(). Differential Revision: https://phabricator.services.mozilla.com/D62164
c97286e92b25f8c63362f41bd09725c39a7a52a0: Bug 1614198 - Some preparation to start using cbindgen for shape-outside and clip-path. r=boris
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 11 Feb 2020 20:56:13 +0000 - rev 513412
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1614198 - Some preparation to start using cbindgen for shape-outside and clip-path. r=boris Tweak the ShapeSourceRepresentation so that it doesn't store Option<>s. Some renames so that GeometryBox doesn't conflict with the Gecko type, and some other usual bits / re-exports to deal with cbindgen and generics. Also, drive-by derive parsing of GeometryBox as it's trivial. Doing this unfortunately is not possible without removing nsStyleImage first, so let's do that before. This makes us serialize in the shortest form for shape-outside, but that's what we should do anyway. (aside: the shapes code is a bit too generic, maybe we should unify ClippingShape and FloatAreaShape...) Differential Revision: https://phabricator.services.mozilla.com/D62163
ae402b74010d4d8d68c78eb76fc55b9ac8be1b71: Bug 1614198 - Make CachedBorderImageData a frame property. r=aosmond
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 11 Feb 2020 20:56:05 +0000 - rev 513411
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1614198 - Make CachedBorderImageData a frame property. r=aosmond Storing it in the style value doesn't make much sense, specially since we store drawing-dependent stuff there like the svg viewport size, which clearly depends on the size of the frame. This cache may not be very useful anymore, see the linked bug, but this unblocks me with other style system cleanups and seems safer. Differential Revision: https://phabricator.services.mozilla.com/D62162
14015be7b1e59ae4996131a151f230f1ade5bf55: Bug 1614522 - Make PDF telemetry work for release. r=bdahl
Michael Kaply <mozilla@kaply.com> - Tue, 11 Feb 2020 19:37:12 +0000 - rev 513410
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1614522 - Make PDF telemetry work for release. r=bdahl Differential Revision: https://phabricator.services.mozilla.com/D62466
9574ef31b96bc5adc2c54a8cde22d8f7332ad5b8: Bug 1614629 - Fix freeSpace check in CacheFileIOManager::OverLimitEvictionInternal r=mayhemer
Michal Novotny <michal.novotny@gmail.com> - Tue, 11 Feb 2020 16:42:59 +0000 - rev 513409
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1614629 - Fix freeSpace check in CacheFileIOManager::OverLimitEvictionInternal r=mayhemer Patch fixes wrong comparison. I also noticed that in bug 979900 I fixed just one freeSpace assignment after GetDiskSpaceAvailable() failure, see https://bugzilla.mozilla.org/show_bug.cgi?id=979900#c14. This patch fixes also other occurrences. Differential Revision: https://phabricator.services.mozilla.com/D62435
2e3c469a4ee2566e69db5c939bf629f2dbc1a564: Bug 1605218 - Add telemetry for large window actor messages that we didn't send. data-review=nshadowen r=jdai
Andrew McCreight <continuation@gmail.com> - Tue, 11 Feb 2020 20:44:24 +0000 - rev 513408
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1605218 - Add telemetry for large window actor messages that we didn't send. data-review=nshadowen r=jdai Collecting this telemetry will let us fix the large messages, if they are common. Differential Revision: https://phabricator.services.mozilla.com/D57879
9b59a6a25fd9d9c0a557ed13d1a9bbde4af30286: Bug 1614309 - Update 2d.gradient.radial.outside2.html expectation on win ccov. a=test-only
Cosmin Sabou <csabou@mozilla.com> - Tue, 11 Feb 2020 22:32:35 +0200 - rev 513407
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1614309 - Update 2d.gradient.radial.outside2.html expectation on win ccov. a=test-only DONTBUILD
d46cb79a9b5504bdbb1f32ff5c6b9e68889b9812: Bug 1613143. Don't allow an empty transaction to succeed with webrender if we haven't sent a display list to the parent. r=mattwoodrow
Timothy Nikkel <tnikkel@gmail.com> - Tue, 11 Feb 2020 19:01:30 +0000 - rev 513406
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1613143. Don't allow an empty transaction to succeed with webrender if we haven't sent a display list to the parent. r=mattwoodrow I think this probably only shows up with fission oop iframes, tabs probably avoid this path. The problem occurs when we reconstruct the containing iframe for a style change, we briefly hide the child document, clearing the display list on the parent via ClearCachedResources. Then show it again, we attempt an empty transaction and this succeeds because there is nothing to stop it. (The non-wr case fails because the layer contents are missing and that causes the empty transaction to fail.) So keep track if we have sent a display list to the parent to allow/disallow an empty transaction. This fixes a couple webrender+fission reftest failures but it's also a general rendering bug in webrender+fission reproducible in a regular browser. Differential Revision: https://phabricator.services.mozilla.com/D61577
4d12f98d7eb486a28bd5aea3aa2c4adef9c59cbc: Bug 1613743 - Always use browsertime-results tarball from `MOZ_FETCHES` r=tarek,tomprince
Barret Rennie <barret@brennie.ca> - Tue, 11 Feb 2020 20:04:05 +0000 - rev 513405
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1613743 - Always use browsertime-results tarball from `MOZ_FETCHES` r=tarek,tomprince Accepting an argument to specify a tarball of browsertime results was an artifact of the previous split between the (now removed) visual-metrics and visual-metrics-dep job kinds. Now that we are always providing the browsertime results as a fetch task, can retrieve it directly from `MOZ_FETCHES` directory. Differential Revision: https://phabricator.services.mozilla.com/D62364
d9235b2ed2a2e2d1959b52d49b2ec4bff7ef02cb: Bug 1613743 - Merge application.json and jobs.json r=tarek,perftest-reviewers,sparky
Barret Rennie <barret@brennie.ca> - Tue, 11 Feb 2020 20:03:30 +0000 - rev 513404
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1613743 - Merge application.json and jobs.json r=tarek,perftest-reviewers,sparky Raptor was previously generating two artifacts for the `run-visual-metrics.py` script to consume: `jobs.json` and `application.json`. These artifacts have been merged. Differential Revision: https://phabricator.services.mozilla.com/D62363
1820ac06e54e7a5cfa75489485a4dfdfc40f9768: Bug 1613743 - Do not use the same variable name for both a path and the contents of the file at that path r=tarek
Barret Rennie <barret@brennie.ca> - Tue, 11 Feb 2020 20:03:00 +0000 - rev 513403
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1613743 - Do not use the same variable name for both a path and the contents of the file at that path r=tarek This is strictly an improvement in code clarity. Differential Revision: https://phabricator.services.mozilla.com/D62362
11216a607896b27d12035f0544428596089d0ee4: Bug 1613743 - Raise an error instead of returning 1 when failing to parse json r=tarek
Barret Rennie <barret@brennie.ca> - Tue, 11 Feb 2020 20:02:45 +0000 - rev 513402
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1613743 - Raise an error instead of returning 1 when failing to parse json r=tarek In bug 1601414, the JSON parsing and validating code was refactored into a single method. However, the `return 1` in case of error was carried over. That was correct in the previous version because that 1 was being passed to `exit()` later on. However, we were now returning 1 to callers of `read_json` when the schema did not match, resulting in an opaque unrelated error (`TypeError: 'int' object is not subscriptable`). Now `read_json` is correctly raising an exception so its callers know when it fails. Differential Revision: https://phabricator.services.mozilla.com/D62361
bcba55109a3a5c963e92f2d845f32b258afc2e06: Bug 1613743 - Remove `extraOptions` from Perfherder output in `run-visual-metrics.py` r=tarek
Barret Rennie <barret@brennie.ca> - Tue, 11 Feb 2020 20:02:43 +0000 - rev 513401
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1613743 - Remove `extraOptions` from Perfherder output in `run-visual-metrics.py` r=tarek The `extraOptions` key in the Perfherder output was only required until Bug 1593198 landed. Differential Revision: https://phabricator.services.mozilla.com/D62360
6b29fe6d32599c7a6c706fc6fdeef1121b81b7dc: Bug 1613743 - Run black on `run-visual-metrics.py` r=tarek
Barret Rennie <barret@brennie.ca> - Tue, 11 Feb 2020 20:01:29 +0000 - rev 513400
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1613743 - Run black on `run-visual-metrics.py` r=tarek Differential Revision: https://phabricator.services.mozilla.com/D62359
265dd235cf852e158cffb1f57cd08ce229d2d85a: Bug 1613743 - Remove `./mach try --visual-metrics-jobs` r=tomprince
Barret Rennie <barret@brennie.ca> - Tue, 11 Feb 2020 20:01:01 +0000 - rev 513399
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1613743 - Remove `./mach try --visual-metrics-jobs` r=tomprince Differential Revision: https://phabricator.services.mozilla.com/D62358
b4d21ca47215f561b9af0876a9d5c4bbfe97f128: Bug 1613743 - Remove visual-metrics job kind r=tomprince
Barret Rennie <barret@brennie.ca> - Tue, 11 Feb 2020 20:00:23 +0000 - rev 513398
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1613743 - Remove visual-metrics job kind r=tomprince Differential Revision: https://phabricator.services.mozilla.com/D62357
1e26514f1dc31f12c23b2144ad1fc8357d32ad0c: Bug 1612005 - Do not specifiy individual videos in jobs.json r=tarek,perftest-reviewers,sparky
Barret Rennie <barret@brennie.ca> - Tue, 11 Feb 2020 19:59:58 +0000 - rev 513397
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1612005 - Do not specifiy individual videos in jobs.json r=tarek,perftest-reviewers,sparky The `run-visual-metrics.py` script was intended to consume a `jobs.json` file containing one `browsertime.json` per video. However it was not being used as such and was continuously re-processing the first video specified in the `browsertime.json` file. If a job were submitted with a `browsertime.json` containing 15 videos and 15 different videos, only the first would be processed. This leads to us having incorrect metrics because over all runs all the metrics will be identical. Now we only specify the `browsertime.json` in the `jobs.json` file and extract the paths to videos from there. Also because we are never downloading inputs this way, we get to remove some dead code and our dependency on `requests`. Differential Revision: https://phabricator.services.mozilla.com/D62320
8a70c847dc6c4bfd9ed02deb5738924499cd965a: Bug 1613640 - Removed unneeded scrollbar in RTL display for about:welcome & editTopSites r=pdahiya
emcminn <emcminn@mozilla.com> - Tue, 11 Feb 2020 19:43:50 +0000 - rev 513396
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1613640 - Removed unneeded scrollbar in RTL display for about:welcome & editTopSites r=pdahiya Differential Revision: https://phabricator.services.mozilla.com/D62114
be916959142fc9ed315e855e2dce4b57fcac8e05: Bug 1614361 - check GetPermissions call for failure; r=Gijs
Nathan Froyd <froydnj@mozilla.com> - Mon, 10 Feb 2020 23:14:42 +0000 - rev 513395
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1614361 - check GetPermissions call for failure; r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D62267
d2c7a9b66822875ce9cd1ab769f8d90e25b437d9: Bug 1614329 - Fix the handling of the type attribute of HTMLStyleElement; r=bzbarsky
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 11 Feb 2020 19:38:26 +0000 - rev 513394
Push 37114 by ccoroiu@mozilla.com at Wed, 12 Feb 2020 09:32:01 +0000
Bug 1614329 - Fix the handling of the type attribute of HTMLStyleElement; r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D62254
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip