308412053019c9379eb899378ef575e903d64cbe: Bug 1322093 part 8 - Rename BaselineCacheIR.{cpp,h} to BaselineCacheIRCompiler.{cpp,h}. r=h4writer
Jan de Mooij <jdemooij@mozilla.com> - Wed, 21 Dec 2016 17:37:48 +0100 - rev 326953
Push 31116 by kwierso@gmail.com at Fri, 23 Dec 2016 02:37:16 +0000
Bug 1322093 part 8 - Rename BaselineCacheIR.{cpp,h} to BaselineCacheIRCompiler.{cpp,h}. r=h4writer
dec599fbdaed0b7bb59e17e122529d18212055ab: Bug 1322093 part 7 - Make restoreInputState work for Ion ICs. r=h4writer
Jan de Mooij <jdemooij@mozilla.com> - Wed, 21 Dec 2016 17:37:47 +0100 - rev 326952
Push 31116 by kwierso@gmail.com at Fri, 23 Dec 2016 02:37:16 +0000
Bug 1322093 part 7 - Make restoreInputState work for Ion ICs. r=h4writer
cc3b8d218cc7e8515312919a291fac97cc59ff01: Bug 1322093 part 6 - Add helpers for pushing/popping values. r=h4writer
Jan de Mooij <jdemooij@mozilla.com> - Wed, 21 Dec 2016 17:37:47 +0100 - rev 326951
Push 31116 by kwierso@gmail.com at Fri, 23 Dec 2016 02:37:16 +0000
Bug 1322093 part 6 - Add helpers for pushing/popping values. r=h4writer
2cb264cab3a12716b995c17915706da6665dc2ca: Bug 1322093 part 5 - Factor out restoreInputState from emitFailurePath. r=h4writer
Jan de Mooij <jdemooij@mozilla.com> - Wed, 21 Dec 2016 17:37:44 +0100 - rev 326950
Push 31116 by kwierso@gmail.com at Fri, 23 Dec 2016 02:37:16 +0000
Bug 1322093 part 5 - Factor out restoreInputState from emitFailurePath. r=h4writer
664ed8d2eaffe16894095bbe294dcb80a3774953: Merge mozilla-central to mozilla-inbound
Carsten "Tomcat" Book <cbook@mozilla.com> - Wed, 21 Dec 2016 17:05:48 +0100 - rev 326949
Push 31116 by kwierso@gmail.com at Fri, 23 Dec 2016 02:37:16 +0000
Merge mozilla-central to mozilla-inbound
fc1d94a3195dead36a75a5f203fa90b19ecd551e: Bug 1307858 - Use a copy of the list of observers to broadcast. r=froydnj
Dylan Roeh <droeh@mozilla.com> - Fri, 16 Dec 2016 14:49:25 -0600 - rev 326948
Push 31116 by kwierso@gmail.com at Fri, 23 Dec 2016 02:37:16 +0000
Bug 1307858 - Use a copy of the list of observers to broadcast. r=froydnj
11873cde7a5992d3b721abc17b35ff8f28dae0ae: Remove PLayer. (bug 1323539 part 2, r=mattwoodrow)
David Anderson <danderson@mozilla.com> - Wed, 21 Dec 2016 10:43:47 -0500 - rev 326947
Push 31116 by kwierso@gmail.com at Fri, 23 Dec 2016 02:37:16 +0000
Remove PLayer. (bug 1323539 part 2, r=mattwoodrow)
da479aa758a8e5eee2583da370bfdac2ca819999: Don't access ShadowableLayer from ClientLayer's destructor. (bug 1323539 part 1, r=mattwoodrow)
David Anderson <danderson@mozilla.com> - Wed, 21 Dec 2016 10:43:04 -0500 - rev 326946
Push 31116 by kwierso@gmail.com at Fri, 23 Dec 2016 02:37:16 +0000
Don't access ShadowableLayer from ClientLayer's destructor. (bug 1323539 part 1, r=mattwoodrow)
4e9e1f7ef5a8a6a8e88ef36e8aeb997136eb0d75: Bug 903389 - Make Make NativeGet[Getter]PureInline handle dense/typed array shapes. r=arai
Tom Schuster <evilpies@gmail.com> - Wed, 21 Dec 2016 16:17:26 +0100 - rev 326945
Push 31116 by kwierso@gmail.com at Fri, 23 Dec 2016 02:37:16 +0000
Bug 903389 - Make Make NativeGet[Getter]PureInline handle dense/typed array shapes. r=arai
78fdff5726df7f30f0780587e4eed68095ae4a22: Bug 903389 - Fix uses of ClassMethodIsNative. r=Waldo
Tom Schuster <evilpies@gmail.com> - Wed, 21 Dec 2016 16:17:19 +0100 - rev 326944
Push 31116 by kwierso@gmail.com at Fri, 23 Dec 2016 02:37:16 +0000
Bug 903389 - Fix uses of ClassMethodIsNative. r=Waldo
d8e95d80c65fa55c74b8d490fcbfd1c9a149c9df: Bug 1323303 - require building with Skia. r=glandium
Lee Salzman <lsalzman@mozilla.com> - Wed, 21 Dec 2016 09:31:13 -0500 - rev 326943
Push 31116 by kwierso@gmail.com at Fri, 23 Dec 2016 02:37:16 +0000
Bug 1323303 - require building with Skia. r=glandium MozReview-Commit-ID: 56oawitOHEP
285937702a805efa6195068ebaec4d1ca092c610: Bug 1029245 - part 2 - upgrade builds to use GCC 4.9.4; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Wed, 21 Dec 2016 04:28:08 -0500 - rev 326942
Push 31116 by kwierso@gmail.com at Fri, 23 Dec 2016 02:37:16 +0000
Bug 1029245 - part 2 - upgrade builds to use GCC 4.9.4; r=glandium
ac4575135a2a9a4cec556b9770b4878de6f4881f: Bug 1029245 - part 1 - modify build-gcc.sh to build GCC 4.9.4; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Wed, 21 Dec 2016 04:28:08 -0500 - rev 326941
Push 31116 by kwierso@gmail.com at Fri, 23 Dec 2016 02:37:16 +0000
Bug 1029245 - part 1 - modify build-gcc.sh to build GCC 4.9.4; r=glandium PR 64905 apparently never got backported to 4.9.x, so we still need the patch for that.
52741577a76d42e86d3ac351e36daae8175b78ac: Bug 1029245 - part 0 - tweak Skia's SkOnce.h header to work around issues with std::atomic::compare_exchange_strong; r=lsalzman
Nathan Froyd <froydnj@mozilla.com> - Wed, 21 Dec 2016 04:28:08 -0500 - rev 326940
Push 31116 by kwierso@gmail.com at Fri, 23 Dec 2016 02:37:16 +0000
Bug 1029245 - part 0 - tweak Skia's SkOnce.h header to work around issues with std::atomic::compare_exchange_strong; r=lsalzman Building Skia inside of mozilla-central with GCC 4.9.4 causes problems: [...]c++/4.9.4/bits/atomic_base.h:581:70: error: failure memory model cannot be stronger than success memory model for '__atomic_compare_exchange' The error stack accompanying this message points at SkEventTracer::GetInstance: SkEventTracer* SkEventTracer::GetInstance() { if (SkEventTracer* tracer = sk_atomic_load(&gUserTracer, sk_memory_order_acquire)) { return tracer; } static SkOnce once; static SkDefaultEventTracer* defaultTracer; once([] { defaultTracer = new SkDefaultEventTracer; }); return defaultTracer; } The only place that compare_exchange_strong could be called here is from SkOnce::operator(): template <typename Fn, typename... Args> void operator()(Fn&& fn, Args&&... args) { auto state = fState.load(std::memory_order_acquire); if (state == Done) { return; } // If it looks like no one has started calling fn(), try to claim that job. if (state == NotStarted && fState.compare_exchange_strong(state, Claimed, std::memory_order_relaxed)) { // Great! We'll run fn() then notify the other threads by releasing Done into fState. fn(std::forward<Args>(args)...); return fState.store(Done, std::memory_order_release); } [...code elided...] where |fState| is an atomic<uint8_t>. The three-argument form of atomic<uint8_t>::compare_exchange_strong is defined as: _GLIBCXX_ALWAYS_INLINE bool compare_exchange_strong(__int_type& __i1, __int_type __i2, memory_order __m = memory_order_seq_cst) noexcept { return compare_exchange_strong(__i1, __i2, __m, __cmpexch_failure_order(__m)); } __cmpexch_failure_order relaxes the given memory_order: // Drop release ordering as per [atomics.types.operations.req]/21 constexpr memory_order __cmpexch_failure_order2(memory_order __m) noexcept { return __m == memory_order_acq_rel ? memory_order_acquire : __m == memory_order_release ? memory_order_relaxed : __m; } constexpr memory_order __cmpexch_failure_order(memory_order __m) noexcept { return memory_order(__cmpexch_failure_order2(__m & __memory_order_mask) | (__m & __memory_order_modifier_mask)); } which then gets us to the four-argument version of compare_exchange_strong: _GLIBCXX_ALWAYS_INLINE bool compare_exchange_strong(__int_type& __i1, __int_type __i2, memory_order __m1, memory_order __m2) noexcept { memory_order __b2 = __m2 & __memory_order_mask; memory_order __b1 = __m1 & __memory_order_mask; __glibcxx_assert(__b2 != memory_order_release); __glibcxx_assert(__b2 != memory_order_acq_rel); __glibcxx_assert(__b2 <= __b1); return __atomic_compare_exchange_n(&_M_i, &__i1, __i2, 0, __m1, __m2); } Despite the constexpr annotation on __cmpexch_failure_order and friends, which ought to imply that they get constant-folded, I think what is happening is that GCC doesn't see |memory_order_relaxed| when it examines __m2. Instead, it seems some internal tree representation for the call to __cmpexch_failure_order. Since this is not an integer constant, GCC treats __m2 as being equivalent to memory_order_seq_cst (see gcc/builtins.c:get_memmodel). And since memory_order_seq_cst is stronger than memory_order_relaxed, we get the above error. In any event, the easiest fix is to simply use the four-argument form of compare_exchange_strong directly, explicitly specifying the failure memory order.
73c80c1709a3ac2a8f085ce297d880cb92c6f7f5: Backed out changeset 28c47fbedac4 (bug 1323303) for bustage
Carsten "Tomcat" Book <cbook@mozilla.com> - Wed, 21 Dec 2016 15:12:31 +0100 - rev 326939
Push 31116 by kwierso@gmail.com at Fri, 23 Dec 2016 02:37:16 +0000
Backed out changeset 28c47fbedac4 (bug 1323303) for bustage
473bef59dcfa065110ec044a8326a3ccd78affaa: Bug 1315906 - Add test coverage. r=gfritzsche
Alessio Placitelli <alessio.placitelli@gmail.com> - Wed, 21 Dec 2016 01:13:00 +0100 - rev 326938
Push 31116 by kwierso@gmail.com at Fri, 23 Dec 2016 02:37:16 +0000
Bug 1315906 - Add test coverage. r=gfritzsche MozReview-Commit-ID: FFskMOrwvLO
02d37af6e76fc7f8b13f62f9a7ddf82ccb8c5d45: Bug 1315906 - Change JS histogram add functions so that it doesn't throw. r=gfritzsche
Alessio Placitelli <alessio.placitelli@gmail.com> - Tue, 20 Dec 2016 08:32:00 +0100 - rev 326937
Push 31116 by kwierso@gmail.com at Fri, 23 Dec 2016 02:37:16 +0000
Bug 1315906 - Change JS histogram add functions so that it doesn't throw. r=gfritzsche
28c47fbedac4b808eb93a05fe55a80317336bc40: Bug 1323303 - require building with Skia. r=glandium
Lee Salzman <lsalzman@mozilla.com> - Wed, 21 Dec 2016 08:23:48 -0500 - rev 326936
Push 31116 by kwierso@gmail.com at Fri, 23 Dec 2016 02:37:16 +0000
Bug 1323303 - require building with Skia. r=glandium MozReview-Commit-ID: 56oawitOHEP
82574d098a94527588b6be7d800785ccb11df961: Backed out changeset d539253e91ae (bug 1313276) for failing own test paint-on-maskLayer-1c.html on Android debug. r=backout
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 22 Dec 2016 20:16:20 +0100 - rev 326935
Push 31115 by kwierso@gmail.com at Fri, 23 Dec 2016 02:24:00 +0000
Backed out changeset d539253e91ae (bug 1313276) for failing own test paint-on-maskLayer-1c.html on Android debug. r=backout
602d599c0efc58c43bdaa469846458e320b306d1: Backed out changeset d90a8fc45b74 (bug 1313276)
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 22 Dec 2016 20:15:40 +0100 - rev 326934
Push 31115 by kwierso@gmail.com at Fri, 23 Dec 2016 02:24:00 +0000
Backed out changeset d90a8fc45b74 (bug 1313276)
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip