307481f32d4403dae943b9ff26cd7a7e2eadf083: Bug 1601599 part 1 - Fix assert in IonBuilder::setStaticName to account for loop phis. r=tcampbell
Jan de Mooij <jdemooij@mozilla.com> - Sun, 15 Dec 2019 11:32:25 +0000 - rev 507021
Push 36920 by dluca@mozilla.com at Sun, 15 Dec 2019 21:49:48 +0000
Bug 1601599 part 1 - Fix assert in IonBuilder::setStaticName to account for loop phis. r=tcampbell This is necessary once we support OSR for spread expressions. Differential Revision: https://phabricator.services.mozilla.com/D56698
273abf200022ad239b277942149e6268c4fec8b2: Bug 1604011 - Remove dead assignment from StreamLoader::OnStopRequest. r=emilio,xidorn
Alex Henrie <alexhenrie24@gmail.com> - Sun, 15 Dec 2019 10:22:50 +0000 - rev 507020
Push 36920 by dluca@mozilla.com at Sun, 15 Dec 2019 21:49:48 +0000
Bug 1604011 - Remove dead assignment from StreamLoader::OnStopRequest. r=emilio,xidorn Differential Revision: https://phabricator.services.mozilla.com/D57235
9b7cd94eaf0a2385f53791c982e2210bd6b96818: Bug 1603995 - Remove dead assignments from nsFrame::BoxReflow. r=dbaron
Alex Henrie <alexhenrie24@gmail.com> - Sun, 15 Dec 2019 06:23:01 +0000 - rev 507019
Push 36919 by malexandru@mozilla.com at Sun, 15 Dec 2019 09:48:38 +0000
Bug 1603995 - Remove dead assignments from nsFrame::BoxReflow. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D57233
a39d3ce80dff1f5993a4ce9de64ee02b4a49b16b: Bug 1602845 - Enable 'return' UBSan check. r=froydnj
Tyson Smith <twsmith@mozilla.com> - Sun, 15 Dec 2019 05:13:34 +0000 - rev 507018
Push 36919 by malexandru@mozilla.com at Sun, 15 Dec 2019 09:48:38 +0000
Bug 1602845 - Enable 'return' UBSan check. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D56626
6b7701e0ec158dee86d2aff4695bcac28d2f1b0b: Bug 1603615 - [Clamp] and [EnforceRange] should only appear on integer types; r=bzbarsky
Edgar Chen <echen@mozilla.com> - Sat, 14 Dec 2019 04:40:14 +0000 - rev 507017
Push 36919 by malexandru@mozilla.com at Sun, 15 Dec 2019 09:48:38 +0000
Bug 1603615 - [Clamp] and [EnforceRange] should only appear on integer types; r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D57018
7626f9316348903fc563cc41596a081b82fd0a1d: Bug 1543315 - part 20: Mark `PresShell::ContentStateChanged()` as `MOZ_CAN_RUN_SCRIPT_BOUNDARY` r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 11 Dec 2019 12:18:33 +0000 - rev 507016
Push 36919 by malexandru@mozilla.com at Sun, 15 Dec 2019 09:48:38 +0000
Bug 1543315 - part 20: Mark `PresShell::ContentStateChanged()` as `MOZ_CAN_RUN_SCRIPT_BOUNDARY` r=smaug While it calls `RestyleManager::ContentStateChanged()`, it blocks script with `nsAutoCauseReflowNotifier`. Therefore, it should be marked as `MOZ_CAN_RUN_SCRIPT_BOUNDARY` at least (looks like the other override, `DocAccessible::ContentStateChanged()` does not run script). There is a concern about the lifetime of `RestyleManager`. It's destroyed when `nsPresContext::DetachPresShell()` is called. It's called by `PresShell::Destroy()` and destructor of `nsPresContext`. The latter is safe since `PresShell` owns `mPresContext` and it's never cleared. However, I'm not sure about the former. It might be better to create blocker of synchronous handling of `PresShell::Destroy()`. And also this does not make `Document::ContentStateChanged()` use `RefPtr<PresShell>` at calling it because it might cause performance regression, but it does not do anything after destroying `nsAutoCauseReflowNotifier`. Finally, for guaranteeing that the lifetime of `PresShell::mPresContext` is longer than `PresShell`, this makes it to `RefPtr<nsPresContext> const`. However, initializing it in constructor breaks other objects' initialization process since they assume that `PresShell::GetPresContext()` won't return valid pointer until the `nsPresContext` is attached. For solving this issue safe, this patch keeps setting `mPresContext` in `Init()` with `const_cast` hack. Differential Revision: https://phabricator.services.mozilla.com/D55804
3b3c8d649109f9b86521190b63557471e160183e: Bug 1543650 - Improve error message when using incompatible typed (BigInt) arrays. r=arai
Tom Schuster <evilpies@gmail.com> - Sun, 15 Dec 2019 00:23:42 +0000 - rev 507015
Push 36919 by malexandru@mozilla.com at Sun, 15 Dec 2019 09:48:38 +0000
Bug 1543650 - Improve error message when using incompatible typed (BigInt) arrays. r=arai I am open to wording improvements for the error message. Right now we get: js> new BigInt64Array(new Float32Array(4)) TypeError: Float32Array array elements are incompatible with BigInt64Array and js> x = new Float32Array(4); x.set(new BigInt64Array(2)) TypeError: BigInt64Array array elements are incompatible with Float32Array Differential Revision: https://phabricator.services.mozilla.com/D57208
9980078d96a3fd058cf744053f59e3d0c2ba8a24: Bug 1543650 - Throw better error message in ToBigInt. r=arai
Tom Schuster <evilpies@gmail.com> - Sun, 15 Dec 2019 00:23:27 +0000 - rev 507014
Push 36919 by malexandru@mozilla.com at Sun, 15 Dec 2019 09:48:38 +0000
Bug 1543650 - Throw better error message in ToBigInt. r=arai Differential Revision: https://phabricator.services.mozilla.com/D57199
91b4e153366b36c0e748f57044f18e0845a857ce: Bug 1595134 - Port AboutLoginsChild and AboutLoginsParent to JSWindowActors r=Gijs
Carson Greene <green114@msu.edu> - Sun, 15 Dec 2019 00:21:13 +0000 - rev 507013
Push 36919 by malexandru@mozilla.com at Sun, 15 Dec 2019 09:48:38 +0000
Bug 1595134 - Port AboutLoginsChild and AboutLoginsParent to JSWindowActors r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D52787
8bd0989df6b285db776212f8798ba571b94c6db0: Bug 1599783 - Fix shifting of content blocking radiogroup when switching options. r=Gijs
Tim Nguyen <ntim.bugs@gmail.com> - Sat, 14 Dec 2019 23:30:44 +0000 - rev 507012
Push 36919 by malexandru@mozilla.com at Sun, 15 Dec 2019 09:48:38 +0000
Bug 1599783 - Fix shifting of content blocking radiogroup when switching options. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D57181
4de974a596ef9cdf6b49739c54fd4793820988db: Bug 1603933 - Use Date.now() instead of DocumentTimeline.currentTime. r=tnikkel
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Sat, 14 Dec 2019 22:34:19 +0000 - rev 507011
Push 36919 by malexandru@mozilla.com at Sun, 15 Dec 2019 09:48:38 +0000
Bug 1603933 - Use Date.now() instead of DocumentTimeline.currentTime. r=tnikkel Differential Revision: https://phabricator.services.mozilla.com/D57213
73e3c93400685b35afaa980751c5c9137d2756d9: Merge mozilla-central to autoland. a=merge CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Sun, 15 Dec 2019 00:06:18 +0200 - rev 507010
Push 36919 by malexandru@mozilla.com at Sun, 15 Dec 2019 09:48:38 +0000
Merge mozilla-central to autoland. a=merge CLOSED TREE
f13b550aabf245e14cdee95bfd8b8d2b4307b8c3: Bug 1590450 - Remove the contextual tip API. r=adw
Harry Twyford <htwyford@mozilla.com> - Fri, 13 Dec 2019 22:58:21 +0000 - rev 507009
Push 36919 by malexandru@mozilla.com at Sun, 15 Dec 2019 09:48:38 +0000
Bug 1590450 - Remove the contextual tip API. r=adw Differential Revision: https://phabricator.services.mozilla.com/D57133
8855bff16ed6b9a414fc4d9c387db9ac8a505a2a: Merge autoland to mozilla-central. a=merge
Bogdan Tara <btara@mozilla.com> - Sat, 14 Dec 2019 23:58:14 +0200 - rev 507008
Push 36918 by btara@mozilla.com at Sat, 14 Dec 2019 21:58:37 +0000
Merge autoland to mozilla-central. a=merge
4478cd379335a7e46d158929fa5de72c045f4680: Bug 1595092 Part 2: Update an existing RDM content size test to test against the new RDM UI. r=mtigley
Brad Werth <bwerth@mozilla.com> - Fri, 13 Dec 2019 19:25:43 +0000 - rev 507007
Push 36918 by btara@mozilla.com at Sat, 14 Dec 2019 21:58:37 +0000
Bug 1595092 Part 2: Update an existing RDM content size test to test against the new RDM UI. r=mtigley Depends on D56979 Differential Revision: https://phabricator.services.mozilla.com/D57144
a15cffa9611c5845bc73c249f8804270a930dfb2: Bug 1595092 Part 1: Make new RDM UI size the content pane with content-box. r=mtigley
Brad Werth <bwerth@mozilla.com> - Fri, 13 Dec 2019 19:22:02 +0000 - rev 507006
Push 36918 by btara@mozilla.com at Sat, 14 Dec 2019 21:58:37 +0000
Bug 1595092 Part 1: Make new RDM UI size the content pane with content-box. r=mtigley Differential Revision: https://phabricator.services.mozilla.com/D56979
fa86e495e683df6a1b75b55233cbb293f7e74a60: Backed out changeset fd383a15ed4e (bug 1552966) for causing browser_printpreview.js to permafail CLOSED TREE
Ciure Andrei <aciure@mozilla.com> - Sat, 14 Dec 2019 17:45:23 +0200 - rev 507005
Push 36918 by btara@mozilla.com at Sat, 14 Dec 2019 21:58:37 +0000
Backed out changeset fd383a15ed4e (bug 1552966) for causing browser_printpreview.js to permafail CLOSED TREE
fd383a15ed4e6a4570bc29765ed3dbc47616f1c0: Bug 1552966. Convert the printing code to stop using DocShellTree* classes. r=farre
Jonathan Watt <jwatt@jwatt.org> - Fri, 13 Dec 2019 14:16:15 +0000 - rev 507004
Push 36918 by btara@mozilla.com at Sat, 14 Dec 2019 21:58:37 +0000
Bug 1552966. Convert the printing code to stop using DocShellTree* classes. r=farre Differential Revision: https://phabricator.services.mozilla.com/D56830
9ffd4ecbfc2b3b9255e66588111a0af2140d0559: Bug 1428705 - fix manifestparser/manifestparser for python3 and enable test_convert_directory.py r=ahal
Edwin Takahashi <egao@mozilla.com> - Sat, 14 Dec 2019 03:10:45 +0000 - rev 507003
Push 36918 by btara@mozilla.com at Sat, 14 Dec 2019 21:58:37 +0000
Bug 1428705 - fix manifestparser/manifestparser for python3 and enable test_convert_directory.py r=ahal Changes: Import the appropriate version of `StringIO` instead of `BytesIO` depending on the version of python, and use it in `manifestparser.py`. This is required for `test_convert_directory.py` to pass on both python versions. Changes to the test was not required. Differential Revision: https://phabricator.services.mozilla.com/D56865
18449a6756ee3744f99d8856471fa34e1187171f: Bug 1603373 part 6 - Don't handle complicated magic type cases in TypeSet::mightBeMIRType. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Sat, 14 Dec 2019 08:14:58 +0000 - rev 507002
Push 36918 by btara@mozilla.com at Sat, 14 Dec 2019 21:58:37 +0000
Bug 1603373 part 6 - Don't handle complicated magic type cases in TypeSet::mightBeMIRType. r=iain The explanation for why the code was correct is subtle and not super convincing. Fortunately TypeSet::mightBeMIRType and MDefinition::mightBeType callers are easy to audit because they're mostly called with a constant MIRType. The patch fixes these callers: * ArgumentTypesMatch: surprisingly, the calleeTypes->unknown() check was missing. If the callee has unknown types then it's definitely OK to pass any Value to it without checking. If not unknown, don't bother handling untracked magic types as it's uncommon. * ObjectOrSimplePrimitive and SimpleArithOperand: changed to mightBeMagicType. * MPhi::typeIncludes: I'm not sure if magic types are possible but I changed the single caller, TypeAnalyzer::adjustPhiInputs, to not handle them. Differential Revision: https://phabricator.services.mozilla.com/D57088
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip