3032f8adbcf177c75cb7ddacaade47e23e1ed88f: Bug 1265342 Part 13: Add two new WPT tests of shape-outside: inset with shape-margin, and update manifests. r=dholbert
Brad Werth <bwerth@mozilla.com> - Mon, 23 Apr 2018 15:13:17 -0700 - rev 415571
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1265342 Part 13: Add two new WPT tests of shape-outside: inset with shape-margin, and update manifests. r=dholbert MozReview-Commit-ID: EDJZHW89AT6
d5a9b0478b9317f263a7f208d4c1b76a628d9818: Bug 1265342 Part 12: Change almost all non-polygon shape-outside web-platform tests to expected pass. r=dholbert
Brad Werth <bwerth@mozilla.com> - Wed, 14 Mar 2018 13:09:47 -0700 - rev 415570
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1265342 Part 12: Change almost all non-polygon shape-outside web-platform tests to expected pass. r=dholbert MozReview-Commit-ID: EPGiDlrxInY
26ca0097fff71a32c600459265a4b1f65438bde9: Bug 1265342 Part 11: Update a shape-outside: image test to supply a correct shape-image-threshold. r=dholbert
Brad Werth <bwerth@mozilla.com> - Tue, 17 Apr 2018 13:48:26 -0700 - rev 415569
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1265342 Part 11: Update a shape-outside: image test to supply a correct shape-image-threshold. r=dholbert The PNG data generated in this test creates a 100x100 image with opaque green pixels in the left 50px and fully transparent pixels in the right 49px. The 1px vertical strip of pixels at pixel column 50 are green pixels with .66 alpha. The test was failing because it supplied a shape-image-threshold of .25, and thus was floating by 51px instead of the intended 50px. This change modifies the test to use a shape-image-threshold of .7, generating the intended 50px float area. MozReview-Commit-ID: GJtym0p95yk
185cc5b7b93f95135e28a8e1df6fd19310695acc: Bug 1265342 Part 10: Update a shape-outside circle test to make it more precise and correct. r=dholbert
Brad Werth <bwerth@mozilla.com> - Tue, 17 Apr 2018 13:19:36 -0700 - rev 415568
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1265342 Part 10: Update a shape-outside circle test to make it more precise and correct. r=dholbert The test shape-outside-circle-027.html has two issues that prevent it from matching the reference image. For that test to pass, the text must be floated right by 75 pixels. The two issues are: 1) The circle is defined as 35% of 170 pixels, which calculates to 59.5px. Since the shape-margin is 15px, this makes the total offset less than the target of 75px. 2) The circle is offset upwards by 10 pixels, which introduces a slight angle between the block start of the text and the center of the circle. The cosine of this small angle is slightly less than 1, which reduces the offset by some amount. The changes made here specify the circle radius in whole pixels, and move the center of the circle such that it is between the block start and block end of the floated text, ensuring that the full width of the circle + shape-margin will be used for calculating the float area. MozReview-Commit-ID: JQ9Mc3GU4tW
36bf72f6946dbbe896a52456af4b7fd33ba8a1c2: Bug 1265342 Part 9: Update shape-outside ellipse tests to correct invalid use of only one radius parameter. r=dholbert
Brad Werth <bwerth@mozilla.com> - Wed, 14 Mar 2018 14:21:12 -0700 - rev 415567
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1265342 Part 9: Update shape-outside ellipse tests to correct invalid use of only one radius parameter. r=dholbert https://www.w3.org/TR/css-shapes-1/#funcdef-ellipse states that the grammar for ellipse is: ellipse() = ellipse( [<shape-radius>{2}]? [at <position>]? ) This permits either 0 or 2 shape-radius tokens, but not 1. These two tests use 1 shape-radius token and do not parse correctly. https://www.w3.org/TR/css-shapes-1/#typedef-shape-radius states that omitted shape-radius values default to closest-side. This change updates these two tests to add the closest-side value for the missing shape-radius tokens. MozReview-Commit-ID: 9UKxJel1b50
581d1a27f4eff370799aef05a2375d69f423f4b7: Bug 1265342 Part 8: Update shape-outside inset tests to explicitly set a line-height of 1, and not rely on a UA-specific value. r=dholbert
Brad Werth <bwerth@mozilla.com> - Wed, 14 Mar 2018 14:49:57 -0700 - rev 415566
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1265342 Part 8: Update shape-outside inset tests to explicitly set a line-height of 1, and not rely on a UA-specific value. r=dholbert https://www.w3.org/TR/CSS2/visudet.html#propdef-line-height specifies that line-height is given an initial value of normal, which is defined: Tells user agents to set the used value to a "reasonable" value based on the font of the element. The value has the same meaning as <number>. We recommend a used value for 'normal' between 1.0 to 1.2. The computed value is 'normal'. These tests are designed to work correctly if and only if the line-height is 1. This change specifies line-height: 1 explicitly. MozReview-Commit-ID: 3Ueassok0f
0cb6c9f7c6dbf71e5143b901de1dd3aa128f949d: Bug 1265342 Part 7: Implement shape-margin for shape-outside: shape-box. r=dholbert
Brad Werth <bwerth@mozilla.com> - Mon, 26 Feb 2018 14:47:31 -0800 - rev 415565
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1265342 Part 7: Implement shape-margin for shape-outside: shape-box. r=dholbert MozReview-Commit-ID: 67vq9Gcr8qJ
93dacd65e0093ba69fc376f0859a54be4e325388: Bug 1265342 Part 6b: Implement shape-margin for shape-outside: inset, for general case of shape-margin > 0. r=dholbert
Brad Werth <bwerth@mozilla.com> - Tue, 17 Apr 2018 11:39:50 -0700 - rev 415564
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1265342 Part 6b: Implement shape-margin for shape-outside: inset, for general case of shape-margin > 0. r=dholbert MozReview-Commit-ID: 4pjALPSIBhI
8d8361873abe44ec51e097db1f463bb179e75684: Bug 1265342 Part 6a: Implement shape-margin for shape-outside: inset, for some special cases with shape-margin > 0. r=dholbert
Brad Werth <bwerth@mozilla.com> - Fri, 13 Apr 2018 11:29:14 -0700 - rev 415563
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1265342 Part 6a: Implement shape-margin for shape-outside: inset, for some special cases with shape-margin > 0. r=dholbert MozReview-Commit-ID: AEOksiuM0GJ
64161554cd20cac22690c5e05962bcb06132896b: Bug 1265342 Part 5d: Move EllipseShapeInfo class definition ahead of RoundedBoxShapeInfo so it can be referenced by rounded boxes. r=dholbert
Brad Werth <bwerth@mozilla.com> - Tue, 17 Apr 2018 11:59:11 -0700 - rev 415562
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1265342 Part 5d: Move EllipseShapeInfo class definition ahead of RoundedBoxShapeInfo so it can be referenced by rounded boxes. r=dholbert MozReview-Commit-ID: G8qdPlnh8kY
29c3c172caa00b1db0d3ba28ec5200f85ca4cddc: Bug 1265342 Part 5c: Add some asserts to ensure ellipse distance field index values are in-bounds. r=dholbert
Brad Werth <bwerth@mozilla.com> - Fri, 20 Apr 2018 13:43:36 -0700 - rev 415561
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1265342 Part 5c: Add some asserts to ensure ellipse distance field index values are in-bounds. r=dholbert MozReview-Commit-ID: CpuWWaLh1CX
a672de34a369105c2d453d34146fb877911abd61: Bug 1265342 Part 5b: Complete the implementation of shape-margin for ellipse (handling shape-margin: > 0). r=dholbert
Brad Werth <bwerth@mozilla.com> - Wed, 11 Apr 2018 15:18:32 -0700 - rev 415560
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1265342 Part 5b: Complete the implementation of shape-margin for ellipse (handling shape-margin: > 0). r=dholbert MozReview-Commit-ID: CovCfk5ryEn
c24818678398ed0d911a9d20958673e17a6b8899: Bug 1265342 Part 5a: Implement shape-margin for shape-outside: circle and ellipse (ellipse only for shape-margin: 0). r=dholbert
Brad Werth <bwerth@mozilla.com> - Mon, 26 Feb 2018 13:13:03 -0800 - rev 415559
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1265342 Part 5a: Implement shape-margin for shape-outside: circle and ellipse (ellipse only for shape-margin: 0). r=dholbert MozReview-Commit-ID: HeipoUTkqUE
546464551e6411c46b85203a43375ad205827bbb: Bug 1265342 Part 4b: Add some logic and asserts to ensure distance field index values and image index values are in-bounds. r=dholbert
Brad Werth <bwerth@mozilla.com> - Fri, 20 Apr 2018 14:04:15 -0700 - rev 415558
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1265342 Part 4b: Add some logic and asserts to ensure distance field index values and image index values are in-bounds. r=dholbert MozReview-Commit-ID: 1C9vB14Qhyj
e5c0631408b2159c4e7ccba4998b2dc35e00eacf: Bug 1265342 Part 4a: Complete the implementation of shape-margin for shape-outside: image (handling shape-margin: > 0). r=dholbert
Brad Werth <bwerth@mozilla.com> - Thu, 22 Feb 2018 11:11:03 -0800 - rev 415557
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1265342 Part 4a: Complete the implementation of shape-margin for shape-outside: image (handling shape-margin: > 0). r=dholbert MozReview-Commit-ID: 4xqfqWB78Oh
3b2ffd07d8e669327b56864f71e77d7b1eaa4be9: Bug 1265342 Part 3: Stub in shape-margin for shape-outside: image, by implementing only for shape-margin: 0. r=dholbert
Brad Werth <bwerth@mozilla.com> - Mon, 12 Mar 2018 17:04:34 -0700 - rev 415556
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1265342 Part 3: Stub in shape-margin for shape-outside: image, by implementing only for shape-margin: 0. r=dholbert MozReview-Commit-ID: 2gVRyQtd7Io
ab95312a3db6120612753eb41dc2fe1783a5f8ea: Bug 1265342 Part 2b: Refactor interval creation for shape-outside:image. r=dholbert
Brad Werth <bwerth@mozilla.com> - Wed, 28 Feb 2018 10:43:43 -0800 - rev 415555
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1265342 Part 2b: Refactor interval creation for shape-outside:image. r=dholbert MozReview-Commit-ID: LnzQPsSBVqY
9a192430ce296e8e5d157387d19447d55b59be5e: Bug 1265342 Part 2a: Move interval binary search method into ShapeInfo. r=dholbert
Brad Werth <bwerth@mozilla.com> - Wed, 11 Apr 2018 14:05:06 -0700 - rev 415554
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1265342 Part 2a: Move interval binary search method into ShapeInfo. r=dholbert MozReview-Commit-ID: BxJxIU0RVAo
a4d6eb03796303107898d02a9e9d5c658d3b63b4: Bug 1265342 Part 1: Add shape-margin to style system (Gecko bindings). r=xidorn
Brad Werth <bwerth@mozilla.com> - Wed, 07 Feb 2018 17:27:04 -0800 - rev 415553
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1265342 Part 1: Add shape-margin to style system (Gecko bindings). r=xidorn MozReview-Commit-ID: 3G0ZpWDrumg
7674c13b14dedb251180a4700d2f53b8c7093200: Bug 1265342 Part 0: Servo changes to add shape-margin. r=xidorn
Brad Werth <bwerth@mozilla.com> - Thu, 08 Feb 2018 11:00:56 -0800 - rev 415552
Push 33900 by dluca@mozilla.com at Thu, 26 Apr 2018 04:51:04 +0000
Bug 1265342 Part 0: Servo changes to add shape-margin. r=xidorn MozReview-Commit-ID: 99pLZsFA9mj
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip