2fc4f931f041ebab1d02fe3433fdaba6f9a49fdf: Bug 1564594 - Add an Enhanced Search webcompat site patch r=nalexander,denschub
Thomas Wisniewski <twisniewski@mozilla.com> - Wed, 21 Aug 2019 20:32:27 +0000 - rev 489431
Push 36474 by malexandru@mozilla.com at Thu, 22 Aug 2019 21:54:53 +0000
Bug 1564594 - Add an Enhanced Search webcompat site patch r=nalexander,denschub This patch ultimately overrides the user-agent which Fennec users send to Google Search pages, choosing a phone- or tablet-specific UA as appropriate. It involves adding four new metadata keys to the webcompat addon's metadata for user-agent overrides: blocks, permanentPref, experiment, telemetryKey: - "blocks" specifies URLs for which any requests should be aborted. This allows us to block the Google service worker for now, as it has caused "content corrupted" issues in the past with other enhanced search addons (see https://github.com/wisniewskit/google-search-fixer/issues/1). - "permanentPref" specifies an about:config preference, which dictates whether the injection is used. Users may set this to `false` to disable the injection outright, and permanently; `true` or `undefined` values allow the injection to function normally. - "experiment" specifies the name of the experiment this feature is optionally gated behind. Only a Fennec-specific implementation is provided in this patch. The implementation simply queries Switchboard to determine if the experiment is active. - "telemetryKey" specifies which telemetry key should be flipped to "true" when this injection runs. We will use this to note whether enhanced search has actually been enabled for this profile. Only a Fennec-specific implementation is given in this patch, which actually just sets a Fennec Shared Preference, which Fennec's core telemetry ping later reads in Java to know what the ping should contain. Differential Revision: https://phabricator.services.mozilla.com/D41074
a54dd9741b8db58e2a9de5a90e79125d0e7fb52d: Bug 1575544 - make scalar info constructors constexpr; r=chutten
Nathan Froyd <froydnj@mozilla.com> - Wed, 21 Aug 2019 17:49:02 +0000 - rev 489430
Push 36474 by malexandru@mozilla.com at Thu, 22 Aug 2019 21:54:53 +0000
Bug 1575544 - make scalar info constructors constexpr; r=chutten Marking these constructors as `constexpr` encourages the compiler to constant-initialize most of the `gScalars` array, rather than generating a giant glob of code to move the (constant) values into the array at runtime. Differential Revision: https://phabricator.services.mozilla.com/D42842
8192923fd123fa9af45c5a7ad57ddb367b0d4df3: Bug 1563023 - Part 1: Implement per client usage tracking; r=asuth
Jan Varga <jan.varga@gmail.com> - Thu, 22 Aug 2019 13:06:48 +0000 - rev 489429
Push 36474 by malexandru@mozilla.com at Thu, 22 Aug 2019 21:54:53 +0000
Bug 1563023 - Part 1: Implement per client usage tracking; r=asuth This patch adds a fixed-size array of client usages to OriginInfo and modifies quota tracking APIs to require the client type to be passed in. A new method ResetUsageForClient is implemented. The method is used during client-specific origin clearing. ResetUsageForClient is much faster than calling GetUsageForOrigin and calling DecreaseUsageForOrigin after that. LockedUsage now has an assertion that verifies that the total sum of client usages matches total origin usage. This method should be called instead of touching mUsage directly. A new assertion is added to GetQuotaObject which verifies that passed file belongs to the given persistence type, origin, and client. Differential Revision: https://phabricator.services.mozilla.com/D38028
6ba35efeddf6851cea089763577596bf54fde7ee: Bug 1575055 - Avoid duplicating CompileOptions constructor code. r=jandem
Ted Campbell <tcampbell@mozilla.com> - Thu, 22 Aug 2019 13:08:03 +0000 - rev 489428
Push 36474 by malexandru@mozilla.com at Thu, 22 Aug 2019 21:54:53 +0000
Bug 1575055 - Avoid duplicating CompileOptions constructor code. r=jandem Differential Revision: https://phabricator.services.mozilla.com/D42562
6039cf3a63f0ffdde73fb92de5d2d7ebf76c5e85: Bug 1575055 - Remove redundant overrides in ReadOnlyCompileOptions. r=jandem
Ted Campbell <tcampbell@mozilla.com> - Thu, 22 Aug 2019 13:08:01 +0000 - rev 489427
Push 36474 by malexandru@mozilla.com at Thu, 22 Aug 2019 21:54:53 +0000
Bug 1575055 - Remove redundant overrides in ReadOnlyCompileOptions. r=jandem Differential Revision: https://phabricator.services.mozilla.com/D42561
aa3a237d49d864c1cd6fb436b8fa80dea2f2d782: Bug 1575055 - Unify JS::CompileOptions::canLazilyParse and forceFullParse_. r=jandem
Ted Campbell <tcampbell@mozilla.com> - Thu, 22 Aug 2019 13:07:57 +0000 - rev 489426
Push 36474 by malexandru@mozilla.com at Thu, 22 Aug 2019 21:54:53 +0000
Bug 1575055 - Unify JS::CompileOptions::canLazilyParse and forceFullParse_. r=jandem If either the Realm or the request needs full-parsing, we disable lazy parsing. Differential Revision: https://phabricator.services.mozilla.com/D42560
aa9f3f8f1f2c53e69e150dd3cf5b6ceb361c2d31: Bug 1575055 - Privatize js::CompileOptions::strictMode. r=jandem
Ted Campbell <tcampbell@mozilla.com> - Thu, 22 Aug 2019 13:08:10 +0000 - rev 489425
Push 36474 by malexandru@mozilla.com at Thu, 22 Aug 2019 21:54:53 +0000
Bug 1575055 - Privatize js::CompileOptions::strictMode. r=jandem We already have an accessor to make sure this is can only be set but not cleared so hide the underlying storage. Differential Revision: https://phabricator.services.mozilla.com/D42559
400ea400fba24cbd3a550897368bf788def82119: Bug 1575055 - Cleanup CompileOptions::setIntroductionInfo. r=jandem
Ted Campbell <tcampbell@mozilla.com> - Thu, 22 Aug 2019 13:07:53 +0000 - rev 489424
Push 36474 by malexandru@mozilla.com at Thu, 22 Aug 2019 21:54:53 +0000
Bug 1575055 - Cleanup CompileOptions::setIntroductionInfo. r=jandem The hasIntroductionInfo flag is equivalent to checking for the existance introducerFilename so use that instead. Also remove unused setter for the introducer script. Differential Revision: https://phabricator.services.mozilla.com/D42558
43bfa576a15ea02c33ac14fbad8495f7c0b6923b: Bug 1574852 - part 8: Move `HTMLEditRules::WillInsert()` to `HTMLEditor` r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 22 Aug 2019 07:08:19 +0000 - rev 489423
Push 36474 by malexandru@mozilla.com at Thu, 22 Aug 2019 21:54:53 +0000
Bug 1574852 - part 8: Move `HTMLEditRules::WillInsert()` to `HTMLEditor` r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D42778
50acfb005a80d12d78a367bcd4e1d903b779f63e: Bug 1572271 - Part 2: Increase the timeout of mochitest-browser-chrome on Windows debug to 90 minutes; r=gbrown
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 22 Aug 2019 01:58:38 +0000 - rev 489422
Push 36474 by malexandru@mozilla.com at Thu, 22 Aug 2019 21:54:53 +0000
Bug 1572271 - Part 2: Increase the timeout of mochitest-browser-chrome on Windows debug to 90 minutes; r=gbrown Differential Revision: https://phabricator.services.mozilla.com/D42988
460503a15d9df6e30ef9ee1d7b75539c47837a92: Bug 1572271 - Part 1: Force a GC during the cleanup of antitracking tests since there is not enough idle time between these tests for GCs to kick in naturally; r=baku
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 22 Aug 2019 00:32:24 +0000 - rev 489421
Push 36474 by malexandru@mozilla.com at Thu, 22 Aug 2019 21:54:53 +0000
Bug 1572271 - Part 1: Force a GC during the cleanup of antitracking tests since there is not enough idle time between these tests for GCs to kick in naturally; r=baku This prevents a whole host of OOM issues from occurring intermittently when running these tests. Differential Revision: https://phabricator.services.mozilla.com/D42654
b02a7e1826286962103fcbed98b894dcabb19f94: Bug 1574431 - Preserve installTelemetryInfo when rebuilding the DB from the addons manifest files. r=kmag
Luca Greco <lgreco@mozilla.com> - Thu, 22 Aug 2019 12:22:31 +0000 - rev 489420
Push 36474 by malexandru@mozilla.com at Thu, 22 Aug 2019 21:54:53 +0000
Bug 1574431 - Preserve installTelemetryInfo when rebuilding the DB from the addons manifest files. r=kmag Differential Revision: https://phabricator.services.mozilla.com/D42281
e8359e1f941ee7256c0f5c815d4711466fb5bbdf: Backed out 5 changesets (bug 1575055) for causing build bustages in mozJSComponentLoader.cpp CLOSED TREE
Noemi Erli <nerli@mozilla.com> - Thu, 22 Aug 2019 15:15:16 +0300 - rev 489419
Push 36474 by malexandru@mozilla.com at Thu, 22 Aug 2019 21:54:53 +0000
Backed out 5 changesets (bug 1575055) for causing build bustages in mozJSComponentLoader.cpp CLOSED TREE Backed out changeset e29819477913 (bug 1575055) Backed out changeset f770e1398276 (bug 1575055) Backed out changeset 3ee4fd0e20e0 (bug 1575055) Backed out changeset 51f0929a5c8d (bug 1575055) Backed out changeset 45f0e989e56e (bug 1575055)
e29819477913ecb57908cbe35af267000bb0a509: Bug 1575055 - Avoid duplicating CompileOptions constructor code. r=jandem
Ted Campbell <tcampbell@mozilla.com> - Thu, 22 Aug 2019 11:59:42 +0000 - rev 489418
Push 36474 by malexandru@mozilla.com at Thu, 22 Aug 2019 21:54:53 +0000
Bug 1575055 - Avoid duplicating CompileOptions constructor code. r=jandem Differential Revision: https://phabricator.services.mozilla.com/D42562
f770e1398276e774d20362ac61bcef148ecc9130: Bug 1575055 - Remove redundant overrides in ReadOnlyCompileOptions. r=jandem
Ted Campbell <tcampbell@mozilla.com> - Wed, 21 Aug 2019 16:17:03 +0000 - rev 489417
Push 36474 by malexandru@mozilla.com at Thu, 22 Aug 2019 21:54:53 +0000
Bug 1575055 - Remove redundant overrides in ReadOnlyCompileOptions. r=jandem Differential Revision: https://phabricator.services.mozilla.com/D42561
3ee4fd0e20e0ae555e707984e4a51e0393d62afc: Bug 1575055 - Unify JS::CompileOptions::canLazilyParse and forceFullParse_. r=jandem
Ted Campbell <tcampbell@mozilla.com> - Thu, 22 Aug 2019 08:25:09 +0000 - rev 489416
Push 36474 by malexandru@mozilla.com at Thu, 22 Aug 2019 21:54:53 +0000
Bug 1575055 - Unify JS::CompileOptions::canLazilyParse and forceFullParse_. r=jandem If either the Realm or the request needs full-parsing, we disable lazy parsing. Differential Revision: https://phabricator.services.mozilla.com/D42560
51f0929a5c8d33300faaeddef33201db3802ca58: Bug 1575055 - Privatize js::CompileOptions::strictMode. r=jandem
Ted Campbell <tcampbell@mozilla.com> - Thu, 22 Aug 2019 11:58:13 +0000 - rev 489415
Push 36474 by malexandru@mozilla.com at Thu, 22 Aug 2019 21:54:53 +0000
Bug 1575055 - Privatize js::CompileOptions::strictMode. r=jandem We already have an accessor to make sure this is can only be set but not cleared so hide the underlying storage. Differential Revision: https://phabricator.services.mozilla.com/D42559
45f0e989e56eb48ce15325869777855b47e8941c: Bug 1575055 - Cleanup CompileOptions::setIntroductionInfo. r=jandem
Ted Campbell <tcampbell@mozilla.com> - Wed, 21 Aug 2019 16:16:41 +0000 - rev 489414
Push 36474 by malexandru@mozilla.com at Thu, 22 Aug 2019 21:54:53 +0000
Bug 1575055 - Cleanup CompileOptions::setIntroductionInfo. r=jandem The hasIntroductionInfo flag is equivalent to checking for the existance introducerFilename so use that instead. Also remove unused setter for the introducer script. Differential Revision: https://phabricator.services.mozilla.com/D42558
5dbac06bc222985e95f30d6b372c64fcac8b817d: Bug 1574930 - Part 3: Add a test case for making sure that the track counter displays properly and fix an issue for BrowserTestUtils.waitForAttribute(). r=nhnt11,johannh
Tim Huang <tihuang@mozilla.com> - Thu, 22 Aug 2019 09:48:59 +0000 - rev 489413
Push 36474 by malexandru@mozilla.com at Thu, 22 Aug 2019 21:54:53 +0000
Bug 1574930 - Part 3: Add a test case for making sure that the track counter displays properly and fix an issue for BrowserTestUtils.waitForAttribute(). r=nhnt11,johannh This patch adds a test case to check the visibility of the track counter is correct in different situations, including zero tracker, one tracker and multiple trackers. Also, this patch fixes an issue that the BrowserTestUtils.waitForAttributes() won't work if the waiting attributes doesn't have a value or has an empty string as its value. We check the value of the observing attribute to verify if it is existing, however an empty string will be treated as a false, so it won't pass the check if the attribute doesn't have a value. Hence, we should use hasAttribute() instead of getAttribute() to check the existence of the attribute. Differential Revision: https://phabricator.services.mozilla.com/D42718
96854f5ed90d2bb723f76e5234da7d9961b1e327: Bug 1574930 - Part 2: Fix the issue the the number of blocked trackers is still shown if the count is zero. r=nhnt11
Tim Huang <tihuang@mozilla.com> - Thu, 22 Aug 2019 09:34:21 +0000 - rev 489412
Push 36474 by malexandru@mozilla.com at Thu, 22 Aug 2019 21:54:53 +0000
Bug 1574930 - Part 2: Fix the issue the the number of blocked trackers is still shown if the count is zero. r=nhnt11 By only hiding the tracker counter when the tracker counter is zero and show the counter always other than that. By doing so, the counter would be shown properly according the tracker number. Differential Revision: https://phabricator.services.mozilla.com/D42717
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip