290c72f07e0ca171c3fb52d12c59dfe042961b42: Bug 1654679 - Add selected text marker range to text selection changed events. r=morgan
Eitan Isaacson <eitan@monotonous.org> - Thu, 23 Jul 2020 04:52:00 +0000 - rev 541724
Push 37631 by btara@mozilla.com at Thu, 23 Jul 2020 16:21:22 +0000
Bug 1654679 - Add selected text marker range to text selection changed events. r=morgan Differential Revision: https://phabricator.services.mozilla.com/D84616
138e7b575614cbfc1e45576a15825f51cb6e6614: Bug 1651332. Use purely relative scroll offset updates for many scrollbar initiated scrolls. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Sun, 19 Jul 2020 14:56:24 +0000 - rev 541723
Push 37630 by csabou@mozilla.com at Thu, 23 Jul 2020 09:56:57 +0000
Bug 1651332. Use purely relative scroll offset updates for many scrollbar initiated scrolls. r=kats This patch basically attempts to make clicking in the scrollbar track outside of the scrollthumb "work". Clicking in the scrollbar track usually does a page scroll via nsSliderFrame::PageScroll. This eventually ends up in ScrollFrameHelper::ScrollBy where we turn the request from a relative one ("scroll by a page") into an absolute one ("scroll to this position"). This page scroll is typically a smooth scroll and is currently done on the main thread/layout side. Once we start scrolling the visual viewport offset with the scrollbars we can no longer do this purely on the layout side, we at least need the help of the compositor side. I think the simplest way to do this is to hand the scroll request off to the compositor and have it handle the whole thing. Now we need to consider the following situation: user clicks scrollbar track to page scroll, smooth scroll gets partway complete on the compositor, user clicks again on scrollbar track for a further page scroll. The main thread can't send an absolute scroll offset update request to the compositor at this point because it has outdated information (it needs a 'starting position' to add the page scroll offset amount) so it'll end up scrolling to the wrong place. It has to send a relative scroll offset update. We already have a mechanism to send relative scroll offset updates. It is implemented by sending a base scroll offset and the desired scroll offset, and then on the compositor send the difference between those two is computed and then added to the scroll offset. This patch creates a new mechanism (so called "pure relative") that just sends a relative offset update without any absolute scroll positions. The reason I did this is because the existing relative scroll offset update mechanism is not aware of visual viewport offsets, but rather only layout scroll position. For example, here https://searchfox.org/mozilla-central/rev/8d55e18875b89cdf2a22a7cba60dc40999c18356/layout/generic/nsGfxScrollFrame.h#446 the value we use for the base scroll offset (mApzScrollPos) is set to the layout scroll position. It may be entirely reasonable to make this existing mechanism vv offset aware, but I wanted to implement something to get it working with a smaller chance of regressions to things that already exist and work. Ideally these two mechanims would be merged. Differential Revision: https://phabricator.services.mozilla.com/D82688
8309d62060f015ef83c67da5b6cee8e2a000840f: Bug 1651332. Update scrollbar position when the visual viewport offset changes. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Sun, 19 Jul 2020 10:04:42 +0000 - rev 541722
Push 37630 by csabou@mozilla.com at Thu, 23 Jul 2020 09:56:57 +0000
Bug 1651332. Update scrollbar position when the visual viewport offset changes. r=kats The scrollbar is now positioned using the visual viewport offset, so we need to update when that changes. Differential Revision: https://phabricator.services.mozilla.com/D82687
251aa3acc01fba6521c5d03cedf7ae120b2923c2: Bug 1651332. Update how the compositor adjust scroll thumbs. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Sun, 19 Jul 2020 10:04:24 +0000 - rev 541721
Push 37630 by csabou@mozilla.com at Thu, 23 Jul 2020 09:56:57 +0000
Bug 1651332. Update how the compositor adjust scroll thumbs. r=kats Now that layout places the scroll thumbs at the visual viewport offset instead of the layout scroll position we need to update how the compositor adjusts them. Differential Revision: https://phabricator.services.mozilla.com/D82686
c99841ff8519642bdacdcde978e72712900e020a: Bug 1651332. Update scrollbar attrs to use visual viewport offset. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Sun, 19 Jul 2020 10:04:17 +0000 - rev 541720
Push 37630 by csabou@mozilla.com at Thu, 23 Jul 2020 09:56:57 +0000
Bug 1651332. Update scrollbar attrs to use visual viewport offset. r=kats Differential Revision: https://phabricator.services.mozilla.com/D82685
d71765b6908fa8d8caa9d0b9c2e3422195504cd5: Bug 1651332. Create a pref to gate the new scrollbar code on. r=kats
Timothy Nikkel <tnikkel@gmail.com> - Sun, 19 Jul 2020 10:04:04 +0000 - rev 541719
Push 37630 by csabou@mozilla.com at Thu, 23 Jul 2020 09:56:57 +0000
Bug 1651332. Create a pref to gate the new scrollbar code on. r=kats I could have use apz.allow_zooming but using a separate pref means we can flip the pref to check if the new scrollbar code is the source of a regression. Also I haven't tested the code on Fenix at all, so we can disable it there for now. Differential Revision: https://phabricator.services.mozilla.com/D82684
76bbb83349bb0cb72b599611d5559707fd9a8d48: Bug 1654099 - Look to the correct frame when determining root element styles for "potentially scrollable" check. r=emilio
Cameron McCormack <cam@mcc.id.au> - Thu, 23 Jul 2020 00:59:16 +0000 - rev 541718
Push 37630 by csabou@mozilla.com at Thu, 23 Jul 2020 09:56:57 +0000
Bug 1654099 - Look to the correct frame when determining root element styles for "potentially scrollable" check. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D84280
dad0301e55affb9e6077009906c690a6f4d98ea0: Bug 1620467 - Avoid breaking update-built-tests.
Cameron McCormack <cam@mcc.id.au> - Thu, 23 Jul 2020 01:38:06 +0000 - rev 541717
Push 37630 by csabou@mozilla.com at Thu, 23 Jul 2020 09:56:57 +0000
Bug 1620467 - Avoid breaking update-built-tests. Differential Revision: https://phabricator.services.mozilla.com/D84633
1d453dfc3a6dfecdb42ea8cccbfba5f24677dea6: Bug 1654705 - Add a reftest to ensure that scroll frames can be defined and used in any order. r=jrmuizel
Glenn Watson <git@intuitionlibrary.com> - Thu, 23 Jul 2020 01:02:24 +0000 - rev 541716
Push 37630 by csabou@mozilla.com at Thu, 23 Jul 2020 09:56:57 +0000
Bug 1654705 - Add a reftest to ensure that scroll frames can be defined and used in any order. r=jrmuizel Differential Revision: https://phabricator.services.mozilla.com/D84628
de6e53cc788967b7082d0abc4dbe41b1fb9ea6c8: Backed out changeset 0650d1a61f16 (bug 1653950) for bustages on gversionmacros.h CLOSED TREE
Butkovits Atila <abutkovits@mozilla.com> - Thu, 23 Jul 2020 03:42:33 +0300 - rev 541715
Push 37629 by nbeleuzu@mozilla.com at Thu, 23 Jul 2020 03:20:25 +0000
Backed out changeset 0650d1a61f16 (bug 1653950) for bustages on gversionmacros.h CLOSED TREE
0650d1a61f169558c9f63219a57bd50ef7984936: Bug 1653950 - Bump glib version requirement. r=karlt
Robert Mader <robert.mader@posteo.de> - Thu, 23 Jul 2020 00:07:47 +0000 - rev 541714
Push 37629 by nbeleuzu@mozilla.com at Thu, 23 Jul 2020 03:20:25 +0000
Bug 1653950 - Bump glib version requirement. r=karlt We already inherit a minimum version of 2.41.2 through GTK 3.14. This silences some build warnings. Differential Revision: https://phabricator.services.mozilla.com/D84578
646a1a717d2b906196ae35155d98412b7d0a26d6: Bug 1654353 - Nudge the transform matrix to integers before checking for integer axis alignment. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 22 Jul 2020 23:35:10 +0000 - rev 541713
Push 37629 by nbeleuzu@mozilla.com at Thu, 23 Jul 2020 03:20:25 +0000
Bug 1654353 - Nudge the transform matrix to integers before checking for integer axis alignment. r=mattwoodrow This avoids creating temporary surfaces in cases where we get a transform matrix that's not axis-aligned integers but only because of floating point inaccuracy. Differential Revision: https://phabricator.services.mozilla.com/D84410
cdb7526878065a5a846ccc22880790ad716ccd99: Bug 1654673 - Build dump_syms with linux64-clang-9 r=froydnj
David Major <dmajor@mozilla.com> - Thu, 23 Jul 2020 00:02:57 +0000 - rev 541712
Push 37629 by nbeleuzu@mozilla.com at Thu, 23 Jul 2020 03:20:25 +0000
Bug 1654673 - Build dump_syms with linux64-clang-9 r=froydnj Using the generic moving target linux64-clang adds an extra dependency that slows down clang-trunk builds. Differential Revision: https://phabricator.services.mozilla.com/D84608
7928e37f973a0cef2467e442af0b493ba8b67078: Bug 1654674 - Make revert-r362047-and-r362065.patch work with clang-12 r=froydnj
David Major <dmajor@mozilla.com> - Wed, 22 Jul 2020 23:34:43 +0000 - rev 541711
Push 37629 by nbeleuzu@mozilla.com at Thu, 23 Jul 2020 03:20:25 +0000
Bug 1654674 - Make revert-r362047-and-r362065.patch work with clang-12 r=froydnj https://github.com/llvm/llvm-project/commit/afa1afd4108d973e059e5f5ad68cf01efe7985da changed a line at the edge of the context of this patch. I'm really not keen to fork this patch into a separate clang-12 version, so I'd prefer to just shrink the context a little. Differential Revision: https://phabricator.services.mozilla.com/D84609
909001ac06d8b3982116a0b0f753ae365b1cea22: Bug 1652270. Convert nsFrameLoader::Print to return a Promise. r=farre,remote-protocol-reviewers,marionette-reviewers,jgraham,whimboo,mixedpuppy
Jonathan Watt <jwatt@jwatt.org> - Wed, 22 Jul 2020 23:17:45 +0000 - rev 541710
Push 37629 by nbeleuzu@mozilla.com at Thu, 23 Jul 2020 03:20:25 +0000
Bug 1652270. Convert nsFrameLoader::Print to return a Promise. r=farre,remote-protocol-reviewers,marionette-reviewers,jgraham,whimboo,mixedpuppy (Instead of requiring callers to pass an nsIWebProgressListener.) Differential Revision: https://phabricator.services.mozilla.com/D83249
8cfbd5213d0487638348ed32cf92d6b701e6dc99: Backed out changeset 5df50fa24cca (bug 1653950) for bustages on gversionmacros.h . CLOSED TREE
Narcis Beleuzu <nbeleuzu@mozilla.com> - Thu, 23 Jul 2020 02:01:54 +0300 - rev 541709
Push 37629 by nbeleuzu@mozilla.com at Thu, 23 Jul 2020 03:20:25 +0000
Backed out changeset 5df50fa24cca (bug 1653950) for bustages on gversionmacros.h . CLOSED TREE
5df50fa24cca69046ef5bead0c1e73875ba83007: Bug 1653950 - Bump glib version requirement. r=karlt
Robert Mader <robert.mader@posteo.de> - Wed, 22 Jul 2020 22:32:07 +0000 - rev 541708
Push 37629 by nbeleuzu@mozilla.com at Thu, 23 Jul 2020 03:20:25 +0000
Bug 1653950 - Bump glib version requirement. r=karlt We already inherit a minimum version of 2.41.2 through GTK 3.14. This silences some build warnings. Differential Revision: https://phabricator.services.mozilla.com/D84578
42b8c852164df58e6a586f0223b6340870dd87f2: Bug 1612308 - Add a test. r=bzbarsky
Jeff Walden <jwalden@mit.edu> - Fri, 05 Jun 2020 07:38:11 +0000 - rev 541707
Push 37629 by nbeleuzu@mozilla.com at Thu, 23 Jul 2020 03:20:25 +0000
Bug 1612308 - Add a test. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D62151
6b32769bb661afe85b2c94e5f4aa022471adb5f0: Bug 1612308 - Add a comment to BodyStream explaining why an expected state can't be asserted in a particular place. r=bzbarsky
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 22 Jul 2020 22:26:34 +0000 - rev 541706
Push 37629 by nbeleuzu@mozilla.com at Thu, 23 Jul 2020 03:20:25 +0000
Bug 1612308 - Add a comment to BodyStream explaining why an expected state can't be asserted in a particular place. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D62409
2040724e8c685f758dcf69e4fe3851cc8cd5c28a: Bug 1653483 - do not dim the reader mode toolbar while focus is inside it, r=ntim
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 22 Jul 2020 08:03:33 +0000 - rev 541705
Push 37629 by nbeleuzu@mozilla.com at Thu, 23 Jul 2020 03:20:25 +0000
Bug 1653483 - do not dim the reader mode toolbar while focus is inside it, r=ntim Differential Revision: https://phabricator.services.mozilla.com/D84445
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip