2721d70f1b6a6d8d6809751ddc2bb719dff6268d: Bug 1517080 Part 2 - Replace nsFrameItems::AddChild() with nsFrameList::AppendFrame() in FinishBuildingScrollFrame(). r=mats
Ting-Yu Lin <tlin@mozilla.com> - Sat, 30 Mar 2019 02:56:27 +0000 - rev 466933
Push 35787 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:44:18 +0000
Bug 1517080 Part 2 - Replace nsFrameItems::AddChild() with nsFrameList::AppendFrame() in FinishBuildingScrollFrame(). r=mats Differential Revision: https://phabricator.services.mozilla.com/D25336
ae2fe9b13897d3ca5438f7aeff718640a1b2a426: Bug 1517080 Part 1 - Do not adjust table captions' parent when they're created. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Sat, 30 Mar 2019 02:59:25 +0000 - rev 466932
Push 35787 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:44:18 +0000
Bug 1517080 Part 1 - Do not adjust table captions' parent when they're created. r=mats In order to get rid of nsFrameItems::AddChild() and use nsFrameList::AppendFrame() instead, we need to keep table captions' parent to be nsTableFrame when they're created (no adjust in ConstructFramesFromItem) so that their parent remain the same as other frames in the table when appending into the temporary aFrameItems. We then adjust captions' parent right before we call SetInitialChildList()/AppendFrames/InsertFrames(). Also, pass nullptr to AppendFrames() in nsTableWrapperFrame::AppendFrames() because callers should already set captions' parent frame properly. No need to reparent them again. Differential Revision: https://phabricator.services.mozilla.com/D25335
ac91a1c2e3f530dad623df6983ace85d6ba40a77: Bug 1538081 - Part 4: Tests. r=froydnj,gerald
Cameron McCormack <cam@mcc.id.au> - Sat, 30 Mar 2019 04:24:34 +0000 - rev 466931
Push 35787 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:44:18 +0000
Bug 1538081 - Part 4: Tests. r=froydnj,gerald Depends on D25024 Differential Revision: https://phabricator.services.mozilla.com/D25025
a01e770ef4f534b9ab9989be2080be0c59e6cbda: Bug 1538081 - Part 3: Add operator<<(ostream&) definitions for a few common types. r=froydnj,gerald
Cameron McCormack <cam@mcc.id.au> - Sat, 30 Mar 2019 04:26:26 +0000 - rev 466930
Push 35787 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:44:18 +0000
Bug 1538081 - Part 3: Add operator<<(ostream&) definitions for a few common types. r=froydnj,gerald Depends on D25023 Differential Revision: https://phabricator.services.mozilla.com/D25024
3ae52b39cf6fa20b0ca827dad49610e6b154997c: Bug 1538081 - Part 2: Add MOZ_DEFINE_DBG. r=froydnj,gerald
Cameron McCormack <cam@mcc.id.au> - Sat, 30 Mar 2019 04:25:15 +0000 - rev 466929
Push 35787 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:44:18 +0000
Bug 1538081 - Part 2: Add MOZ_DEFINE_DBG. r=froydnj,gerald Depends on D24583 Differential Revision: https://phabricator.services.mozilla.com/D25023
b9e91906edae1ca73ce9f69aa8ad26b9e588deef: Bug 1538081 - Part 1: Add MOZ_DBG macro. r=froydnj,gerald
Cameron McCormack <cam@mcc.id.au> - Sat, 30 Mar 2019 04:25:13 +0000 - rev 466928
Push 35787 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:44:18 +0000
Bug 1538081 - Part 1: Add MOZ_DBG macro. r=froydnj,gerald Differential Revision: https://phabricator.services.mozilla.com/D24583
03cf8c67770c88d26912bd7f948188724cd053f7: Bug 1538952 - Don't automatically open the password autocomplete popup when we only have the footer to show. r=jaws,mak
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Sat, 30 Mar 2019 04:20:20 +0000 - rev 466927
Push 35787 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:44:18 +0000
Bug 1538952 - Don't automatically open the password autocomplete popup when we only have the footer to show. r=jaws,mak Normally autocomplete results are cached based upon the search string but to get the desired behaviour we want two different sets of results for the same search string depending on how the autocomplete search was started: a) Via automatically focusing a password field. b) Every other method of starting an autocomplete search. In order to not have cached results used, the result code for case (a) [an empty result] will be `RESULT_FAILURE` and I've updated the autocomplete code to not re-use an error result. In the coming months we may be rewriting our content autocomplete code but that would be too risky to uplift to 67 so for now I'm tracking when satchel automatically opens the popup upon focus and then using that state in the autocomplete result creation code to know whether to include the footer. Differential Revision: https://phabricator.services.mozilla.com/D25173
8acf628be0368eebd5b06b1480de6cad8deb0ca4: Bug 1529492 - Disable caret clamping if transforms are present. r=dholbert
Cameron McCormack <cam@mcc.id.au> - Sat, 30 Mar 2019 04:19:02 +0000 - rev 466926
Push 35787 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:44:18 +0000
Bug 1529492 - Disable caret clamping if transforms are present. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D25194
d5836acadff957f68bbac51a82d9bcded0af5f56: Bug 1479145 - Handle arbitrary strides for WebGL-to-SharedSurface readback on platforms that support it. r=jgilbert
Markus Stange <mstange@themasta.com> - Fri, 29 Mar 2019 20:18:53 +0000 - rev 466925
Push 35787 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:44:18 +0000
Bug 1479145 - Handle arbitrary strides for WebGL-to-SharedSurface readback on platforms that support it. r=jgilbert The only platforms that do not support GL_PACK_ROW_LENGTH are platforms with GLES 2. So on those platforms, trying to read back into buffers whose stride is not width * 4 will assert. That's fine because we usually don't encounter buffers with such large strides on GLES 2 platforms. The only platform that really needs to handle the large strides is macOS, and it always supports GL_PACK_ROW_LENGTH. On macOS, we often run into large strides on surfaces that we intend to upload as textures at some point, because large stride alignments are required for efficient upload performance on some drivers. Bug 1540209 tracks fixing the general case. Differential Revision: https://phabricator.services.mozilla.com/D25464
0ea914bf03b719cd0821564b551dbb384ba95ff5: Bug 1479145 - Give RGB textures a 32-byte aligned stride on macOS in order to improve texture upload efficiency on certain drivers. r=mattwoodrow
Markus Stange <mstange@themasta.com> - Fri, 29 Mar 2019 20:11:12 +0000 - rev 466924
Push 35787 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:44:18 +0000
Bug 1479145 - Give RGB textures a 32-byte aligned stride on macOS in order to improve texture upload efficiency on certain drivers. r=mattwoodrow In particular, it looks like this alignment is required by the Intel driver on macOS if you want to avoid CPU copies. It was already known that the efficiency gains from client storage only materialize if you follow certain restrictions: - The textures need to use the TEXTURE_RECTANGLE_ARB texture target. - The textures' format, internalFormat and type need to be chosen from a small list of supported configurations. Unsupported configurations will trigger format conversions on the CPU. - The GL_TEXTURE_STORAGE_HINT_APPLE may need to be set to shared or cached. - glTextureRangeAPPLE may or may not make a difference. It now appears that the stride alignment is another requirement: When uploading textures which otherwise comply with the above requirements, the Intel driver will still make copies using the CPU if the texture's stride is not 32-byte aligned. These CPU copies are reflected in a high CPU usage (as observed in Activity Monitor) and they show up in profiles as time spent inside _platform_memmove under glrUpdateTexture. However, when uploading 32-byte stride aligned textures which comply with the above requirements, this CPU usage goes away. There might still be hardware copies behind the scenes, but they no longer take up CPU time. Differential Revision: https://phabricator.services.mozilla.com/D25316
9d74f5279e4f223d07fdfddbbe2340f39c6f7a53: Bug 1393681: Drop unnecessary arguments in Cocoa nsFilePicker functions. r=mstange
Josh Aas <jaas> - Sat, 30 Mar 2019 11:32:42 -0400 - rev 466923
Push 35786 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:43:04 +0000
Bug 1393681: Drop unnecessary arguments in Cocoa nsFilePicker functions. r=mstange
73ebc8384c0f3790b23bad2a133ba4338a7a8816: Bug 1540166, avoid some useless ForgetSkippable handling while we're already dealing with snow-white objects, r=mccr8
Olli Pettay <Olli.Pettay@helsinki.fi> - Fri, 29 Mar 2019 17:52:14 +0200 - rev 466922
Push 35786 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:43:04 +0000
Bug 1540166, avoid some useless ForgetSkippable handling while we're already dealing with snow-white objects, r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D25414
c361028992135d4a14cf9d39900ca41d3a86c7fc: Bug 1540198 - [DEBUG] Assert that the child frames have the correct parent pointer in SetInitialChildList. r=TYLin
Mats Palmgren <mats@mozilla.com> - Fri, 29 Mar 2019 18:34:17 +0100 - rev 466921
Push 35786 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:43:04 +0000
Bug 1540198 - [DEBUG] Assert that the child frames have the correct parent pointer in SetInitialChildList. r=TYLin Differential Revision: https://phabricator.services.mozilla.com/D25434
6a982b0e6dfbdb7a5008c56b983ff5ce3d26f4ab: Bug 1540195 - Call InitAndRestoreFrame to ensure we have the parent setup correctly before calling SetInitialSingleChild. r=TYLin
Mats Palmgren <mats@mozilla.com> - Fri, 29 Mar 2019 18:23:36 +0100 - rev 466920
Push 35786 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:43:04 +0000
Bug 1540195 - Call InitAndRestoreFrame to ensure we have the parent setup correctly before calling SetInitialSingleChild. r=TYLin Differential Revision: https://phabricator.services.mozilla.com/D25430
7c3183c56eb6aed1ab2dd3ed5db7c751c0320d7c: Merge mozilla-central to inbound. a=merge CLOSED TREE
Noemi Erli <nerli@mozilla.com> - Sat, 30 Mar 2019 11:35:28 +0200 - rev 466919
Push 35786 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:43:04 +0000
Merge mozilla-central to inbound. a=merge CLOSED TREE
65196a35a72b533acde99e56b03ae98101b7043f: No bug - clang-format -p mfbt
Jeff Gilbert <jgilbert@mozilla.com> - Fri, 29 Mar 2019 23:42:40 -0700 - rev 466918
Push 35786 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:43:04 +0000
No bug - clang-format -p mfbt
99e6a9b7d780b82f0c24125362881414baa2a316: No bug - clang-format -p dom/canvas
Jeff Gilbert <jgilbert@mozilla.com> - Fri, 29 Mar 2019 23:42:18 -0700 - rev 466917
Push 35786 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:43:04 +0000
No bug - clang-format -p dom/canvas
b645038e4049109df97ee887a0bec28900069de6: No bug - clang-format -p gfx
Jeff Gilbert <jgilbert@mozilla.com> - Fri, 29 Mar 2019 23:41:48 -0700 - rev 466916
Push 35786 by nbeleuzu@mozilla.com at Sat, 30 Mar 2019 21:43:04 +0000
No bug - clang-format -p gfx
5f519306c8bdf77c3236abcb626eacfe44c5e1f0: Merge inbound to mozilla-central. a=merge
Noemi Erli <nerli@mozilla.com> - Sat, 30 Mar 2019 11:32:42 +0200 - rev 466915
Push 35785 by nerli@mozilla.com at Sat, 30 Mar 2019 09:33:31 +0000
Merge inbound to mozilla-central. a=merge
35a116fe36f5da37aa770d1a5b6deb7a0446c200: Bug 1537667. Remove stray semicolon.
Timothy Nikkel <tnikkel@gmail.com> - Fri, 29 Mar 2019 20:03:19 -0500 - rev 466914
Push 35785 by nerli@mozilla.com at Sat, 30 Mar 2019 09:33:31 +0000
Bug 1537667. Remove stray semicolon.
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip