25825439eae1f9e5ea671e45f087d2f51ef49a65: Bug 1589102 - Part 9: Update annotation for iframe-inheritance-about-blank.html test, r=mattwoodrow
Anny Gakhokidze <agakhokidze@mozilla.com> - Fri, 28 Aug 2020 17:21:01 +0000 - rev 546853
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1589102 - Part 9: Update annotation for iframe-inheritance-about-blank.html test, r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D85087
a8992824e237c51ed536d53ccdf9a538373d7ce4: Bug 1589102 - Part 8: Add a crashtest for navigating remote page to about:blank, r=mattwoodrow
Anny Gakhokidze <agakhokidze@mozilla.com> - Fri, 28 Aug 2020 17:20:59 +0000 - rev 546852
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1589102 - Part 8: Add a crashtest for navigating remote page to about:blank, r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D49427
79d25a5c49983a2786a4bd6d2dcec713f70177ad: Bug 1589102 - Part 7: Fix test_browsing_context_structured_clone.js to instead schedule precise gc, r=kmag
Anny Gakhokidze <agakhokidze@mozilla.com> - Fri, 28 Aug 2020 17:20:57 +0000 - rev 546851
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1589102 - Part 7: Fix test_browsing_context_structured_clone.js to instead schedule precise gc, r=kmag Differential Revision: https://phabricator.services.mozilla.com/D85086
60305abadb0ba7c50ddc906d242bce553e4e49f9: Bug 1589102 - Part 6: Do not load more than 2 nested frames in browser_browsingContext-01.js test, r=farre
Anny Gakhokidze <agakhokidze@mozilla.com> - Fri, 28 Aug 2020 17:20:52 +0000 - rev 546850
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1589102 - Part 6: Do not load more than 2 nested frames in browser_browsingContext-01.js test, r=farre Creating more than 2 nested iframes is not allowed and is now enforced for about:blank loads because they now take place via DocumentChannel. Differential Revision: https://phabricator.services.mozilla.com/D85084
baebe0172124f0ba757439933bac0c6b56dc74b7: Bug 1589102 - Part 5: Fix tests that relied on about:blank loads happening instantenously, r=mattwoodrow
Anny Gakhokidze <agakhokidze@mozilla.com> - Fri, 28 Aug 2020 17:20:45 +0000 - rev 546849
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1589102 - Part 5: Fix tests that relied on about:blank loads happening instantenously, r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D85083
e3be5dbce78da7c5e79fa76d0def38e079ae7984: Bug 1589102 - Part 4: Allow (de)serialization of nested about: uris, r=kmag
Anny Gakhokidze <agakhokidze@mozilla.com> - Fri, 28 Aug 2020 17:20:43 +0000 - rev 546848
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1589102 - Part 4: Allow (de)serialization of nested about: uris, r=kmag Differential Revision: https://phabricator.services.mozilla.com/D85082
20664562b914af6ffac4a9059ef2eae9ffdd3504: Bug 1589102 - Part 3: Enable about:blank loads to take place via DocumentChannel, r=mattwoodrow
Anny Gakhokidze <agakhokidze@mozilla.com> - Fri, 28 Aug 2020 17:20:40 +0000 - rev 546847
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1589102 - Part 3: Enable about:blank loads to take place via DocumentChannel, r=mattwoodrow In process selection logic, ensure that we don't use the original URI for about:blank and instead use the result principal. If the about:blank load has a null principal, then revert to using the original URI. Also, remove an extra about:blank load when an nsFrameLoaderOwner is changing remoteness to prevent races. Differential Revision: https://phabricator.services.mozilla.com/D85081
cc5151920b083086b3bd7aff906c4fc8ebd57be2: Bug 1589102 - Part 2: Fix tests that were broken as a result of about:srcdoc going via DocumentChannel, r=mattwoodrow
Anny Gakhokidze <agakhokidze@mozilla.com> - Fri, 28 Aug 2020 17:20:33 +0000 - rev 546846
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1589102 - Part 2: Fix tests that were broken as a result of about:srcdoc going via DocumentChannel, r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D85080
6064f8676546dabb489adb40fb4690be209cf1f8: Bug 1589102 - Part 1: Enable about:srcdoc loads via DocumentChannel, r=mattwoodrow
Anny Gakhokidze <agakhokidze@mozilla.com> - Fri, 28 Aug 2020 17:20:30 +0000 - rev 546845
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1589102 - Part 1: Enable about:srcdoc loads via DocumentChannel, r=mattwoodrow This patch enables sandboxed srcdoc loads to take place via DocumentChannel, and adds mechanisms for enabling unsandboxed ones. Both unsandboxed srcdoc, and in subsequent patches, about:blank, loads require that the triggering principal and the principal to inherit point to the same instance if the load takes place in the same process as where we are inheriting those principals from. We save those principals on a target browsing context before we load the URI, and later, when we are deserializing LoadInfoArgs into LoadInfo in the content process, we retrieve the saved principals if the current load identifier of the target BC matches the load identifier saved along with the principals. We also need to make sure that during a process switch for about:srcdoc load, we don't use the original URI for about:srcdoc to determine the remote type and instead we use channel's result principal. Differential Revision: https://phabricator.services.mozilla.com/D85079
26510fca112eff4a2f8a714f4c2a6079103fc6a7: Bug 1655784 - Return correct collapsed selection range on inputs. r=morgan
Eitan Isaacson <eitan@monotonous.org> - Fri, 28 Aug 2020 17:22:32 +0000 - rev 546844
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1655784 - Return correct collapsed selection range on inputs. r=morgan Differential Revision: https://phabricator.services.mozilla.com/D88502
a4da39c09a2fb094324424be1038d2e46e1f25e7: Bug 1660538 - Add SMDOC for async function and async generator. r=jorendorff DONTBUILD
Tooru Fujisawa <arai_a@mac.com> - Fri, 28 Aug 2020 16:57:38 +0000 - rev 546843
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1660538 - Add SMDOC for async function and async generator. r=jorendorff DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D87896
7fd32a3fb6e750ba944b7d1db9d688cc7cdcdfc7: Bug 1651705: Part 7 - Update MediaSessionSupport to work with NativeWeakPtr; r=geckoview-reviewers,agi
Aaron Klotz <aklotz@mozilla.com> - Thu, 27 Aug 2020 20:14:56 +0000 - rev 546842
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1651705: Part 7 - Update MediaSessionSupport to work with NativeWeakPtr; r=geckoview-reviewers,agi This patch is similar to part 4 but for MediaSessionSupport. Conversions over to `NativeWeakPtr` are pretty straight forward thanks to the type system. Basically we take a `NativeWeakPtr`, call `Access()` on it, and if the accessor is truthy, then we call whatever methods we need to call. Creation of new pointers is done using `NativeWeakPtrHolder::Attach()` and detaching of strong references is done by `NativeWeakPtr::Detach()`. Differential Revision: https://phabricator.services.mozilla.com/D88088
de4edbcb15c112562aa6a2556791f1b112842570: Bug 1651705: Part 6 - Update Android a11y to work with `NativeWeakPtr`; r=eeejay
Aaron Klotz <aklotz@mozilla.com> - Thu, 27 Aug 2020 20:14:50 +0000 - rev 546841
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1651705: Part 6 - Update Android a11y to work with `NativeWeakPtr`; r=eeejay This patch is similar to part 4 but for Android a11y. Conversions over to `NativeWeakPtr` are pretty straight forward thanks to the type system. Basically we take a `NativeWeakPtr`, call `Access()` on it, and if the accessor is truthy, then we call whatever methods we need to call. Creation of new pointers is done using `NativeWeakPtrHolder::Attach()` and detaching of strong references is done by `NativeWeakPtr::Detach()`. Differential Revision: https://phabricator.services.mozilla.com/D87365
531e71369f6842f64adbf4f89a070312ba497401: Bug 1651705: Part 5 - GeckoEditableSupport updates to support `NativeWeakPtr`; r=m_kato,geckoview-reviewers
Aaron Klotz <aklotz@mozilla.com> - Thu, 27 Aug 2020 20:14:45 +0000 - rev 546840
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1651705: Part 5 - GeckoEditableSupport updates to support `NativeWeakPtr`; r=m_kato,geckoview-reviewers This patch is similar to part 4 but for `GeckoEditableSupport`. Conversions over to `NativeWeakPtr` are pretty straight forward thanks to the type system. Basically we take a `NativeWeakPtr`, call `Access()` on it, and if the accessor is truthy, then we call whatever methods we need to call. Creation of new pointers is done using `NativeWeakPtrHolder::Attach()` and detaching of strong references is done by `NativeWeakPtr::Detach()`. Differential Revision: https://phabricator.services.mozilla.com/D87364
84590e96de88128ecd3308e92c47da0cf979bb7c: Bug 1651705: Part 4 - Convert nsWindow to use NativeWeakPtr; r=geckoview-reviewers,agi
Aaron Klotz <aklotz@mozilla.com> - Thu, 27 Aug 2020 20:14:34 +0000 - rev 546839
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1651705: Part 4 - Convert nsWindow to use NativeWeakPtr; r=geckoview-reviewers,agi These conversions are pretty straight forward thanks to the type system. Basically we take a `NativeWeakPtr`, call `Access()` on it, and if the accessor is truthy, then we call whatever methods we need to call. Creation of new pointers is done using `NativeWeakPtrHolder::Attach()` and detaching of strong references is done by `NativeWeakPtr::Detach()`. Differential Revision: https://phabricator.services.mozilla.com/D87363
7d9d2d44b2ee2274eb11e59901f77a7df3b3e2ab: Bug 1651705: Part 3 - Move nested classes out of nsWindow, switch over to NativeWeakPtr in those class definitions; r=geckoview-reviewers,agi
Aaron Klotz <aklotz@mozilla.com> - Thu, 27 Aug 2020 20:14:18 +0000 - rev 546838
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1651705: Part 3 - Move nested classes out of nsWindow, switch over to NativeWeakPtr in those class definitions; r=geckoview-reviewers,agi * Having `AndroidView` and `GeckoViewSupport` as nested classes inside of `nsWindow` make it impossible to forward declare them. We move those classes into their own headers. We also move `WindowEvent` into its own header. * We remove the old `NativePtr` and `WindowPtr` implementations from `nsWindow` and convert the class definitions in this patch to use the new `NativeWeakPtr`. * `GeckoViewSupport` had a unique quirk where it was owned by `nsWindow` instead of its Java counterpart. To make `GeckoViewSupport`'s ownership work like the other classes that use `NativeWeakPtr` (and to substantially simplify the implementation of `NativeWeakPtr` itself), I have reversed that: now `nsWindow` holds a `NativeWeakPtr` to `GeckoViewSupport`, while `GeckoViewSupport` is owned by its Java counterpart and holds a strong ref to the `nsWindow`. * `GeckoViewSupport` no longer inherits from `SupportsWeakPtr`, since using it with `NativeWeakPtr` provides stronger and safer guarantees. Differential Revision: https://phabricator.services.mozilla.com/D87362
9ffca762753ccc17d8f00baa394a9176f2c728ae: Bug 1651705: Part 2 - Create NativeWeakPtr to safely access native objects owned by Java objects across multiple threads; r=geckoview-reviewers,agi
Aaron Klotz <aklotz@mozilla.com> - Thu, 27 Aug 2020 20:14:06 +0000 - rev 546837
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1651705: Part 2 - Create NativeWeakPtr to safely access native objects owned by Java objects across multiple threads; r=geckoview-reviewers,agi * We rename the existing `NativePtr` struct to `NativePtrTraits`, as that is more descriptive of what that code actually does; * We introduce `NativeWeakPtr` as a smart pointer type that holds a pointer to an object and allows its access in a thread-safe way. See comments. * We replace some explicit uses of template types with type deduction via `auto` and `decltype(auto)`. This allows for more use of forward declarations. Differential Revision: https://phabricator.services.mozilla.com/D87361
2d79f4348b36f4d6f7117b4ca2eedfc5cefdf35d: Bug 1651705: Part 1 - Make JNIObject.mHandle volatile; r=geckoview-reviewers,snorp
Aaron Klotz <aklotz@mozilla.com> - Thu, 27 Aug 2020 20:13:56 +0000 - rev 546836
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1651705: Part 1 - Make JNIObject.mHandle volatile; r=geckoview-reviewers,snorp Given the access patterns involved on the native side, I think it is safest to ensure that this field is access atomically by the VM. Differential Revision: https://phabricator.services.mozilla.com/D87360
0eb5fc0d189528cbdf56bddd989509c3b4f2f326: Bug 1661406 - Allow artifact builds without an NDK when working around Android-Gradle plugin bug substituting GeckoView. r=agi,geckoview-reviewers
Nick Alexander <nalexander@mozilla.com> - Fri, 28 Aug 2020 16:51:52 +0000 - rev 546835
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1661406 - Allow artifact builds without an NDK when working around Android-Gradle plugin bug substituting GeckoView. r=agi,geckoview-reviewers Differential Revision: https://phabricator.services.mozilla.com/D88501
078aa6cbb980f024fd5c641235005e9f102b113e: Bug 1661331 - Update wasmparser to version 3.1.1 r=bomsy
Yury Delendik <ydelendik@mozilla.com> - Fri, 28 Aug 2020 16:47:51 +0000 - rev 546834
Push 37737 by csabou@mozilla.com at Sat, 29 Aug 2020 09:12:26 +0000
Bug 1661331 - Update wasmparser to version 3.1.1 r=bomsy Differential Revision: https://phabricator.services.mozilla.com/D88325
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip