1f9a6ce59a5636364d3a07a03a8640eb16bfa12c: Bug 1346623 - Part 3: Test. r=bholley
Cameron McCormack <cam@mcc.id.au> - Thu, 16 Mar 2017 22:47:05 +0800 - rev 348098
Push 31512 by cbook@mozilla.com at Fri, 17 Mar 2017 13:28:24 +0000
Bug 1346623 - Part 3: Test. r=bholley MozReview-Commit-ID: 8LOxAPDEuBW
39ee9556d4a065ba77c11980dc6d814fe79865dc: Bug 1346623 - Part 2: Add an API to get computed style values through an AnonymousContent object. r=bholley
Cameron McCormack <cam@mcc.id.au> - Thu, 16 Mar 2017 22:46:43 +0800 - rev 348097
Push 31512 by cbook@mozilla.com at Fri, 17 Mar 2017 13:28:24 +0000
Bug 1346623 - Part 2: Add an API to get computed style values through an AnonymousContent object. r=bholley MozReview-Commit-ID: Dbvuk16CjFT
9e40bc33e62091e96d33b4a8264e962b3653a8a5: Bug 1346623 - Part 1: Prevent canvas custom content from becoming NAC when reframing the root element. r=bholley
Cameron McCormack <cam@mcc.id.au> - Thu, 16 Mar 2017 17:43:44 +0800 - rev 348096
Push 31512 by cbook@mozilla.com at Fri, 17 Mar 2017 13:28:24 +0000
Bug 1346623 - Part 1: Prevent canvas custom content from becoming NAC when reframing the root element. r=bholley MozReview-Commit-ID: K7jcUuz6KI4
7e4f8900fa8c64eb61eac673fa6480d6a9fe0d7d: Bug 1329111 - Update devtools users of nsIProfiler.getSharedLibraryInformation. r=gregtatum
Markus Stange <mstange@themasta.com> - Tue, 14 Mar 2017 19:20:21 -0400 - rev 348095
Push 31512 by cbook@mozilla.com at Fri, 17 Mar 2017 13:28:24 +0000
Bug 1329111 - Update devtools users of nsIProfiler.getSharedLibraryInformation. r=gregtatum This actor message is not used by the devtools themselves, it's only exposed so that the add-on can use it. See bug 1131397. MozReview-Commit-ID: F1dm0U4rkEd
fd8fc09c82291d5ed77b02826d5f773d5bdda030: Bug 1329111 - Make talos profiling symbolication compatible with the new profile format. r=jmaher
Markus Stange <mstange@themasta.com> - Mon, 13 Mar 2017 17:31:39 -0400 - rev 348094
Push 31512 by cbook@mozilla.com at Fri, 17 Mar 2017 13:28:24 +0000
Bug 1329111 - Make talos profiling symbolication compatible with the new profile format. r=jmaher This also removes compatibility code for other formats, because since talos is now in mozilla-central, it will only run on Firefox builds of the same revision, so we just need to be compatible with the current version of the format. MozReview-Commit-ID: 6MT9pw4BVzU *** make talos only compatible with the current version MozReview-Commit-ID: I7O58kIObQW
33aa51a338b16e076061c1713ad72ec6c570a9ef: Bug 1329111 - Change the nsIProfiler shared library information API. r=njn
Markus Stange <mstange@themasta.com> - Tue, 14 Mar 2017 18:59:20 -0400 - rev 348093
Push 31512 by cbook@mozilla.com at Fri, 17 Mar 2017 13:28:24 +0000
Bug 1329111 - Change the nsIProfiler shared library information API. r=njn API before this change: - nsIProfiler::getSharedLibraryInformation() returns a string containing a JSON array of libraries. - The profile format is at version 3. - Every profile has a "libs" field that contains the same JSON string as the return value of nsIProfiler::getSharedLibraryInformation. - The array of libraries is not sorted. - Each library has a "name" field that contains: - The module's debug name on Windows - The full path to the binary on Mac + Linux API after this change: - nsIProfiler::getSharedLibraryInformation() is removed. - nsIProfiler has a readonly property called sharedLibraries. - The profile format is at version 4. - Every profile has a "libs" field that contains the same array as nsIProfiler.sharedLibraries, no longer as a JSON string but as a regular array. - The array of libraries is sorted by start address. - Each library has a "name" field that contains the binary file's basename, on all platforms. - Each library has a "path" field that contains the full path to the binary, on all platforms. - Each library has a "debugName" field that contains the library's debug name, on all platforms. On Windows, the debug name is the filename (basename) of the pdb file for that binary. On other platforms, debugName is the same as |name|. - Each library has a "debugPath" field that contains the absolute path library's pdb file on Windows; on non-Windows, debugPath and path are the same. - Each library has an "arch" field that is either an empty string (Linux + Windows) or the library's architecture; it'll differentiate between the architectures "x86_64" and "x86_64h". (x86_64h is used for binaries that contain instructions that are specific to the Intel Haswell microarchitecture.) MozReview-Commit-ID: 8Nrs4dyHhDS
6cb351c611e35f8f4ee5e18072469485a8f45ff5: Bug 1329111 - Use JSONWriter when generating the GetSharedLibraryInfo() JSON. r=njn
Markus Stange <mstange@themasta.com> - Mon, 13 Mar 2017 17:08:38 -0400 - rev 348092
Push 31512 by cbook@mozilla.com at Fri, 17 Mar 2017 13:28:24 +0000
Bug 1329111 - Use JSONWriter when generating the GetSharedLibraryInfo() JSON. r=njn MozReview-Commit-ID: LZalkkFreym
cdff9dc4a8ba63be253c3360357071ed0d308545: Bug 1329111 - Record shared library architecture on Mac. r=glandium,njn
Markus Stange <mstange@themasta.com> - Mon, 13 Mar 2017 17:51:41 -0400 - rev 348091
Push 31512 by cbook@mozilla.com at Fri, 17 Mar 2017 13:28:24 +0000
Bug 1329111 - Record shared library architecture on Mac. r=glandium,njn This is interesting information on Mac because some system libraries come in two 64 bit versions: a regular one, and one that contains Haswell-specific instructions. The former 'architecture' is called x86_64 and the latter is called x86_64h (h for Haswell). We set arch to the empty string on non-Mac platforms. It's not all that interesting on those platforms because there will be only one architecture in the binary at the given path, unlike on Mac where you can have fat binaries with multiple architectures. MozReview-Commit-ID: Dgnslv0D3Ug
8a238c780c4724ebdaea8181715f6c71c08d06d5: Bug 1329111 - Supply SharedLibraryInfo with the absolute module path and debug path on all platforms. r=marco
Markus Stange <mstange@themasta.com> - Tue, 14 Mar 2017 18:26:50 -0400 - rev 348090
Push 31512 by cbook@mozilla.com at Fri, 17 Mar 2017 13:28:24 +0000
Bug 1329111 - Supply SharedLibraryInfo with the absolute module path and debug path on all platforms. r=marco MozReview-Commit-ID: 9R3ecPxGoMr
4d074b176f371ae88e20950b48b1b55e632c0f1b: Bug 1329111 - Rename SharedLibraryInfo::mName to mModuleName, and consistently cut off the path on all platforms. r=marco
Markus Stange <mstange@themasta.com> - Tue, 14 Mar 2017 17:07:43 -0400 - rev 348089
Push 31512 by cbook@mozilla.com at Fri, 17 Mar 2017 13:28:24 +0000
Bug 1329111 - Rename SharedLibraryInfo::mName to mModuleName, and consistently cut off the path on all platforms. r=marco MozReview-Commit-ID: 8gqqVjTjy1Z
c679469b5b875be9c9174de840c0f9a7d9ef97d2: servo: Merge #15993 - Remove rust-encoding from geckolib (from servo:utf84eva); r=Manishearth
Simon Sapin <simon.sapin@exyr.org> - Thu, 16 Mar 2017 20:07:37 -0700 - rev 348088
Push 31512 by cbook@mozilla.com at Fri, 17 Mar 2017 13:28:24 +0000
servo: Merge #15993 - Remove rust-encoding from geckolib (from servo:utf84eva); r=Manishearth It wasn’t used, gecko always passes UTF-8 for parsing stylesheets. Source-Repo: https://github.com/servo/servo Source-Revision: f53692cd03e19c30a2a6a3e0775798ed50d481e9
cfd64c2b49705b799236cc960150c2b36ed09a96: Bug 1347809 Set Selection::mCalledByJS to false before moving focus in NotifySelectionListeners() because non-*JS() methods don't set it to false r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 16 Mar 2017 17:15:20 +0900 - rev 348087
Push 31512 by cbook@mozilla.com at Fri, 17 Mar 2017 13:28:24 +0000
Bug 1347809 Set Selection::mCalledByJS to false before moving focus in NotifySelectionListeners() because non-*JS() methods don't set it to false r=smaug Currently, Selection::NotifySelectionListeners() moves focus before setting mCalledByJS to false. Therefore, if moving focus causes some calls of internal Selection methods, it may cause moving focus due to mCalledByJS being still true. So, mCalledByJS should be set to false before moving focus in NotifySelectionListeners(). MozReview-Commit-ID: F879bOmhZlv
7a7f0db97af07ebe55a04f932ec826cc32863bc2: Bug 1341102 - Update stylo mochitest expectation for caret-color.
Xidorn Quan <me@upsuper.org> - Fri, 17 Mar 2017 14:22:18 +1100 - rev 348086
Push 31512 by cbook@mozilla.com at Fri, 17 Mar 2017 13:28:24 +0000
Bug 1341102 - Update stylo mochitest expectation for caret-color.
adc82cb137bf8d69598e646c8241ffd7f90fb340: Bug 1347399 - Use a thread-safe URI comparison in CalcStyleDifference. r=heycam
Bobby Holley <bobbyholley@gmail.com> - Thu, 16 Mar 2017 15:57:04 -0700 - rev 348085
Push 31512 by cbook@mozilla.com at Fri, 17 Mar 2017 13:28:24 +0000
Bug 1347399 - Use a thread-safe URI comparison in CalcStyleDifference. r=heycam MozReview-Commit-ID: Fpb1guCxXUZ
af90f70b05df8c81f440b222728ae48c2e2bf5f8: servo: Merge #15992 - Rewrite PropertyDeclaration::id to help the optimizer (from servo:id-table); r=bholley
Simon Sapin <simon.sapin@exyr.org> - Thu, 16 Mar 2017 19:13:37 -0700 - rev 348084
Push 31512 by cbook@mozilla.com at Fri, 17 Mar 2017 13:28:24 +0000
servo: Merge #15992 - Rewrite PropertyDeclaration::id to help the optimizer (from servo:id-table); r=bholley If I’m reading the release-mode assembly correctly, before this change `PropertyDeclaration::id` is implemented with a computed jump: ```assembly lea rcx, [rip + .LJTI117_0] movsxd rax, dword ptr [rcx + 4*rax] add rax, rcx jmp rax .LBB117_3: mov dword ptr [rdi], 65536 mov rax, rdi ret .LBB117_2: mov dword ptr [rdi], 0 mov rax, rdi ret .LBB117_4: mov dword ptr [rdi], 131072 mov rax, rdi ret .LBB117_6: mov dword ptr [rdi], 262144 mov rax, rdi ret .LBB117_7: mov dword ptr [rdi], 327680 mov rax, rdi ret ; Four similar lines repeated for each of the few hundred variants... ``` With Rust 1.15 (currently used for geckolib) this doesn’t change significantly. In Nightly 1.17 however, the compiled code uses a lookup table, possibly thanks to https://github.com/rust-lang/rust/pull/39456. ```assembly movq (%rsi), %rax cmpq $171, %rax jne .LBB23_1 addq $8, %rsi movq %rsi, 8(%rdi) movb $1, %al jmp .LBB23_3 .LBB23_1: xorq $128, %rax leaq .Lswitch.table.6(%rip), %rcx movb (%rax,%rcx), %al movb %al, 1(%rdi) xorl %eax, %eax .LBB23_3: movb %al, (%rdi) movq %rdi, %rax retq ``` Source-Repo: https://github.com/servo/servo Source-Revision: 9e8e1a47241c6906b4f5777da0d04e3655982fae
2d4a86ef46e9b45b516165ff624068fbcc4493ce: Bug 1347657 - Use array entry as value instead of reference to avoid being invalidated by realloc. r=francois
Henry Chang <hchang@mozilla.com> - Thu, 16 Mar 2017 15:19:45 +0800 - rev 348083
Push 31512 by cbook@mozilla.com at Fri, 17 Mar 2017 13:28:24 +0000
Bug 1347657 - Use array entry as value instead of reference to avoid being invalidated by realloc. r=francois nsTArray::AppendElement may cause memory reallocation if out of capacity. In nsUrlClassifierStreamUpdater::FetchNextRequest(), we take the reference of the first element of mPendingRequests and pass its member as reference to DownloadUpdate(), where mPendingRequests.AppendElement will be called. If the AppendElement in DownloadUpdate() causes realloc, the reference becomes dangling. The most efficient fix is to "move" the reference's (i.e. request) member variables to DownloadUpdate() but I think in this case we can just take the value from the array and pass it around with no given that the array element contains simply a couple of strings and pointers. MozReview-Commit-ID: KEZ5d3l3HoI
867cf8e067a72e18a19ad777b09b39c787b34835: Bug 1347047 Part 3 - Remove pref layout.accessiblecaret.timeout_ms. r=TYLin
Astley Chen <aschen@mozilla.com> - Fri, 17 Mar 2017 08:50:39 +0800 - rev 348082
Push 31512 by cbook@mozilla.com at Fri, 17 Mar 2017 13:28:24 +0000
Bug 1347047 Part 3 - Remove pref layout.accessiblecaret.timeout_ms. r=TYLin MozReview-Commit-ID: CaHS2OlAhTq
7d31847c1d11ef94cddb95a15a08ae8c2082065d: Bug 1347047 Part 2 - Remove caret timeout control from AccessibleCaretManager. r=TYLin
Astley Chen <aschen@mozilla.com> - Fri, 17 Mar 2017 08:50:30 +0800 - rev 348081
Push 31512 by cbook@mozilla.com at Fri, 17 Mar 2017 13:28:24 +0000
Bug 1347047 Part 2 - Remove caret timeout control from AccessibleCaretManager. r=TYLin The feature is controlled by pref layout.accessiblecaret.timeout_ms, and has been disabled in bug 1268410. It's time to remove relevant code from the tree. MozReview-Commit-ID: LLu8RiQcTpm
4503ff6c5820e361c8acd497f7b93775f0a6dd74: Bug 1347047 Part 1 - Remove touch caret timeout test. r=TYLin
Astley Chen <aschen@mozilla.com> - Fri, 17 Mar 2017 08:47:02 +0800 - rev 348080
Push 31512 by cbook@mozilla.com at Fri, 17 Mar 2017 13:28:24 +0000
Bug 1347047 Part 1 - Remove touch caret timeout test. r=TYLin MozReview-Commit-ID: 5fVdwVfcxaz
8e72178c3893c377972209cccd2e561e1ec06c7d: Bug 1339331 TextEventDispatcher should replace \r in composition string with \n and TextComposition should allow to input \n with composition events r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 16 Mar 2017 16:26:43 +0900 - rev 348079
Push 31512 by cbook@mozilla.com at Fri, 17 Mar 2017 13:28:24 +0000
Bug 1339331 TextEventDispatcher should replace \r in composition string with \n and TextComposition should allow to input \n with composition events r=m_kato According to ATOK's behavior, IME may send different line breaker from its platform's standard. Therefore, we should treat \r as \n too. Additionally, currently, TextComposition doesn't allow to input \n with composition. However, this was added for preventing to see odd control characters as boxes with code point. Therefore, we should allow \n for IMEs. (It was allowed, this limitation is unexpected when I reviewed the patch to reject control characters in TextComposition.) MozReview-Commit-ID: DzGSMgp89Av
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip