1f16a2ff45ab492025e42afb8122f4d52cb24c0b: Bug 1334981 - Backed out changeset d6ca24ba3673 for regression caused by bug 887718. r=enndeakin+6102
Henrik Skupin <mail@hskupin.info> - Thu, 07 Jun 2018 15:48:48 +0200 - rev 421886
Push 34108 by aiakab@mozilla.com at Fri, 08 Jun 2018 09:54:54 +0000
Bug 1334981 - Backed out changeset d6ca24ba3673 for regression caused by bug 887718. r=enndeakin+6102 MozReview-Commit-ID: 9hIcRVRseO1
f86b968525a8a9b21abb87fc75ac28f454417fb5: Bug 1467670 - Devirtualize InsertFromDrop. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 08 Jun 2018 05:19:51 +0000 - rev 421885
Push 34108 by aiakab@mozilla.com at Fri, 08 Jun 2018 09:54:54 +0000
Bug 1467670 - Devirtualize InsertFromDrop. r=masayuki InsertFromDrop is implemented on TextEditor only, so it can do devirtualize this method. Also, this method is only called by drop event handler of EditorEventListener, so it should rename to better name (OnDrop). Differential Revision: https://phabricator.services.mozilla.com/D1592
7eb872d2f548c167e82454fef02354619cfcb754: Bug 1467619 - Track and adjust layerization on repaint triggers r=mattwoodrow
Doug Thayer <dothayer@mozilla.com> - Thu, 07 Jun 2018 11:44:03 -0700 - rev 421884
Push 34108 by aiakab@mozilla.com at Fri, 08 Jun 2018 09:54:54 +0000
Bug 1467619 - Track and adjust layerization on repaint triggers r=mattwoodrow To avoid creating a bunch of layers when we don't need to, this tracks when a frame needs to be repainted, and invalidates the IsStyleAnimated logic around mRestyleCounts if the frame is also being invalidated. MozReview-Commit-ID: 5Q96Cx6f3V0
8b1213f470f4d1081cf6afa08f49e5b16f609d9e: Bug 1461311 - Undo reftest/harness changes from bug 1437036 as they are not needed any more. r=hiro
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 07 Jun 2018 08:23:17 -0400 - rev 421883
Push 34108 by aiakab@mozilla.com at Fri, 08 Jun 2018 09:54:54 +0000
Bug 1461311 - Undo reftest/harness changes from bug 1437036 as they are not needed any more. r=hiro MozReview-Commit-ID: 3YvyZPNOCzF
b79113fa763b23bea4a94963d87be0115a68e8c9: Bug 1438752 - Summary: Wait for an APZ flush before scrolling to avoid race condition in test. r=rhunt
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 07 Jun 2018 21:01:45 +0000 - rev 421882
Push 34108 by aiakab@mozilla.com at Fri, 08 Jun 2018 09:54:54 +0000
Bug 1438752 - Summary: Wait for an APZ flush before scrolling to avoid race condition in test. r=rhunt Differential Revision: https://phabricator.services.mozilla.com/D1585
cdaaa5caac74b15e5a22339095559f71f537af25: Bug 1467605 - Disable processing of fetch dependencies; r=glandium
Gregory Szorc <gps@mozilla.com> - Thu, 07 Jun 2018 23:05:58 +0000 - rev 421881
Push 34108 by aiakab@mozilla.com at Fri, 08 Jun 2018 09:54:54 +0000
Bug 1467605 - Disable processing of fetch dependencies; r=glandium 90dca0906337 accidentally broke `mach artifact toolchain --from-build` because that code is attempting to load toolchain tasks in isolation. The new "use_fetches" transform added to toolchain tasks requires that "fetch" tasks are already processed and their references are available to toolchain tasks. This commit adds a mechanism to effectively disable the "use_fetches" transform when called by `mach artifact toolchain`. It is a hack. I suspect future planned work around artifacts/fetches will necessitate additional changes to the `mach artifact toolchain` code. But this can be deferred to a later day: this commit unbusts `mach artifact toolchain` and isn't super hacky, so it seems more reasonable than backing out fetch tasks completely. Differential Revision: https://phabricator.services.mozilla.com/D1588
267912246b07a4b224401e7b3f941c550aa55f8e: Bug 1465707 - Add addon probes for Savant Shield study; r=rhelmer
Bianca Danforth <bdanforth@mozilla.com> - Wed, 06 Jun 2018 03:34:13 -0700 - rev 421880
Push 34108 by aiakab@mozilla.com at Fri, 08 Jun 2018 09:54:54 +0000
Bug 1465707 - Add addon probes for Savant Shield study; r=rhelmer When the study preference (shield.savant.enabled) is set to true, this will record: * When an addon begins an install * When an addon finishes an install * When an addon is enabled * When an addon is disabled * When an addon begins an uninstall * When an addon finishes an uninstall MozReview-Commit-ID: J8LoBZVS5iL
5b7b36cff4fc4a74deb69b1eba18842a4912cd2a: Merge mozilla-central to autoland. a=merge CLOSED TREE
Ciure Andrei <aciure@mozilla.com> - Fri, 08 Jun 2018 00:54:06 +0300 - rev 421879
Push 34108 by aiakab@mozilla.com at Fri, 08 Jun 2018 09:54:54 +0000
Merge mozilla-central to autoland. a=merge CLOSED TREE
ada5a84764728f3d16d60f65052cf56f84aabd51: Bug 1465935 - Handle another edge case with hit-testing inside fixed-pos items. r=mstange
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 07 Jun 2018 13:06:33 -0400 - rev 421878
Push 34108 by aiakab@mozilla.com at Fri, 08 Jun 2018 09:54:54 +0000
Bug 1465935 - Handle another edge case with hit-testing inside fixed-pos items. r=mstange Transforms are containing blocks for fixed-pos items, so if a fixed-pos item is inside a scrolled transform, then it should use that scrollframe as the scroll target for hit-testing. This patch handles this case for WebRender by stashing the appropriate ASR on the nsDisplayFixedPosition item and using it instead of the presShell's root scrollframe in this scenario. The patch also adds a mochitest (which is basically a mochitested version of the reftest in fixed-pos-scrolled-clip-3.html, with a hit-test check to ensure that it's hitting the right scrollframe). MozReview-Commit-ID: 7YQAeOiMMuP
b04f4c9b15ab09b09cd38494db420f201ac8587a: Bug 1465935 - Fix hit-testing for fixed-pos items inside iframes. r=mstange
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 07 Jun 2018 13:06:33 -0400 - rev 421877
Push 34108 by aiakab@mozilla.com at Fri, 08 Jun 2018 09:54:54 +0000
Bug 1465935 - Fix hit-testing for fixed-pos items inside iframes. r=mstange Without this patch, the scrollId for display items inside a fixed-pos item end as the ASR of the item. In the case of fixed-pos items that are inside iframes, the ASR is the outer document's root scrollframe. This means that e.g. wheel-scrolling while over a fixed-pos item inside an iframe ends up scrolling the outer document's root scrollframe instead of the iframe's root scrollframe. In the non-WR codepath, there some APZ machinery that walks up in the HitTestingTreeNode tree from the hit result, looking to see if that node has a fixed-pos ancestor, and if so, uses the fixed-pos item's target APZ as the real hit result. This machinery doesn't exist in WR, because we don't use the HitTestingTreeNode tree for hit-testing in APZ. Instead, we need to make sure that the item tag for those display items already has the appropriate scrollid set. This patch accomplishes this by introducing a new RAII class that is pushed into the wr::DisplayListBuilder while we are building display items inside a nsDisplayFixedPosition, and allows the desired scroll id to be set on the hit-testing display items. This behaviour is exercised by test_group_wheelevents, which can now be enabled with this fix. MozReview-Commit-ID: L2erPVzJeql
c09d2eeb54afcab0cf2309be154ea24957cb116d: Bug 1434206 - Keep LookupResult objects in smart pointers. r=gcp
Francois Marier <francois@mozilla.com> - Tue, 05 Jun 2018 13:15:03 -0700 - rev 421876
Push 34108 by aiakab@mozilla.com at Fri, 08 Jun 2018 09:54:54 +0000
Bug 1434206 - Keep LookupResult objects in smart pointers. r=gcp Replace raw pointers to LookupResult with RefPtrs and eplace the nsAutoPtr objects + raw pointers params with UniquePtrs. Also remove unnecessarily paranoid OOM checks when creating single LookupResult objects since those are pretty small. MozReview-Commit-ID: G85RNnAat6H
78b075a48d8fb482bf02c4150f548c1fc8102f63: Bug 1434206 - Make DBSserviceWorkerProxy as const as possible. r=gcp
Francois Marier <francois@mozilla.com> - Thu, 24 May 2018 16:40:35 -0700 - rev 421875
Push 34108 by aiakab@mozilla.com at Fri, 08 Jun 2018 09:54:54 +0000
Bug 1434206 - Make DBSserviceWorkerProxy as const as possible. r=gcp MozReview-Commit-ID: KPzzmb1Jehi
2b8b83d5ce3cdcbaddc760c482c939dc29fb9efb: Bug 1434206 - Keep CacheResult objects in smart pointers. r=gcp
Francois Marier <francois@mozilla.com> - Fri, 01 Jun 2018 15:49:14 -0700 - rev 421874
Push 34108 by aiakab@mozilla.com at Fri, 08 Jun 2018 09:54:54 +0000
Bug 1434206 - Keep CacheResult objects in smart pointers. r=gcp Some of the objects were kept in UniquePtr and nsAutoPtr but that seemed unnecessary complexity given that we can simply use RefPtr everywhere. It's also possible to make all of the CacheResult arrays const since we don't ever modify the elements once they are added. MozReview-Commit-ID: 5OlcbkQLrGb
789a09ee0980514f8a3b330b5427b8a4781b662d: Bug 1434206 - Clarify when the lookupcache arrays should be cleared. r=gcp
Francois Marier <francois@mozilla.com> - Mon, 21 May 2018 15:58:12 -0700 - rev 421873
Push 34108 by aiakab@mozilla.com at Fri, 08 Jun 2018 09:54:54 +0000
Bug 1434206 - Clarify when the lookupcache arrays should be cleared. r=gcp MozReview-Commit-ID: 7smtnCC0MGT
080d38cebb99cfdd61071bc9009216734c43a7c8: Bug 1434206 - Make LookupCache objects const as much as possible. r=gcp
Francois Marier <francois@mozilla.com> - Mon, 21 May 2018 15:11:01 -0700 - rev 421872
Push 34108 by aiakab@mozilla.com at Fri, 08 Jun 2018 09:54:54 +0000
Bug 1434206 - Make LookupCache objects const as much as possible. r=gcp MozReview-Commit-ID: AqC6NUh6ifm
5d8b0206bfb4dbd9d393a11190f82a689941a6ff: Bug 1434206 - Keep LookupCache objects in smart pointers. r=gcp
Francois Marier <francois@mozilla.com> - Wed, 16 May 2018 19:13:48 -0700 - rev 421871
Push 34108 by aiakab@mozilla.com at Fri, 08 Jun 2018 09:54:54 +0000
Bug 1434206 - Keep LookupCache objects in smart pointers. r=gcp The existing mix of UniquePtr and raw pointers is confusing when trying to figure out the exact lifetime of these objects. MozReview-Commit-ID: Br4S7BXEFKs
0980a35455a042532e0a776beb4154a8f94ae1b8: Bug 1434206 - Add const to functions and members that can take it. r=gcp
Francois Marier <francois@mozilla.com> - Wed, 16 May 2018 15:39:33 -0700 - rev 421870
Push 34108 by aiakab@mozilla.com at Fri, 08 Jun 2018 09:54:54 +0000
Bug 1434206 - Add const to functions and members that can take it. r=gcp MozReview-Commit-ID: D8IQoLZkFaA
2a73d497179a3abdd9a9534ff87d5cc8ef1c9ff2: Bug 1434206 - Replace a pointer with a reference. r=gcp
Francois Marier <francois@mozilla.com> - Tue, 15 May 2018 17:18:18 -0700 - rev 421869
Push 34108 by aiakab@mozilla.com at Fri, 08 Jun 2018 09:54:54 +0000
Bug 1434206 - Replace a pointer with a reference. r=gcp This will prevent our holding on to this pointer incorrectly in the future. MozReview-Commit-ID: H8ueIOK1qAK
653f77b66d23ea6aed5a618f38eb1ffadb475278: Bug 1434206 - Make TableUpdate objects const as much as possible. r=gcp
Francois Marier <francois@mozilla.com> - Fri, 11 May 2018 16:02:37 -0700 - rev 421868
Push 34108 by aiakab@mozilla.com at Fri, 08 Jun 2018 09:54:54 +0000
Bug 1434206 - Make TableUpdate objects const as much as possible. r=gcp I tried to make TableUpdateArray point to const TableUpdate objects everywhere but there were two problems: - HashStore::ApplyUpdate() triggers a few Merge() calls which include sorting the underlying TableUpdate object first. - LookupCacheV4::ApplyUpdate() calls TableUpdateV4::NewChecksum() when the checksum is missing and that sets mChecksum. MozReview-Commit-ID: LIhJcoxo7e7
00affedf529b1aee8cf2c446787a7714db5e6841: Bug 1434206 - Keep TableUpdate objects in smart pointers. r=gcp
Francois Marier <francois@mozilla.com> - Fri, 01 Jun 2018 15:48:48 -0700 - rev 421867
Push 34108 by aiakab@mozilla.com at Fri, 08 Jun 2018 09:54:54 +0000
Bug 1434206 - Keep TableUpdate objects in smart pointers. r=gcp Manually keeping tabs on the lifetime of these objects is a pain and is the likely source of some of our crashes. I suspect we might also be leaking memory. This change creates an explicit copy of the main array into the update thread to avoid using a non-thread-safe shared data structure. This is a shallow copy. Only the pointers to the TableUpdates are copied, which means one pointer per list (e.g. 5 in total for google4 in a new profile). MozReview-Commit-ID: 221d6GkKt0M
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip