1de5e07bed6601d2647e88ed2690b3f30418d8aa: Bug 1307112 part.10 Clean up NativeKey::HandleCharMessage() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 04 Oct 2016 23:01:14 +0900 - rev 316884
Push 30785 by ryanvm@gmail.com at Fri, 07 Oct 2016 13:33:32 +0000
Bug 1307112 part.10 Clean up NativeKey::HandleCharMessage() r=m_kato Now, NativeKey::HandleCharMessage() has almost same code, one is for dispatching eKeyPress event for non-printable keys or printable keys when one of Alt or Ctrl key is pressed, the other is for printable keys when Alt or Ctrl key is pressed. The difference of them is, the former block removes Alt state and Ctrl state for handling AltGr key. When AltGr key is pressed, both Alt and Ctrl state are true. However, EditorBase treas keypress events whose altKey or ctrlKey is true as non-printable key event. Therefore, we need to set these modifier state to false when AltGr key is pressed and the key causes some text. Note that as far as we know, when a key press with AltGr doesn't cause any characters, WM_CHAR isn't generated. Therefore, we don't need to check with complicated logic if the key event is actually inputting a character. MozReview-Commit-ID: BRNWfICvkSm
99042be37c7c777ae1ef75c8e044bf4053bec8bc: Bug 1307112 part.9 Get rid of remaining hacks for KeyboardEvent.charCode when Ctrl or Alt is pressed r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 04 Oct 2016 22:21:49 +0900 - rev 316883
Push 30785 by ryanvm@gmail.com at Fri, 07 Oct 2016 13:33:32 +0000
Bug 1307112 part.9 Get rid of remaining hacks for KeyboardEvent.charCode when Ctrl or Alt is pressed r=m_kato Current shortcut key handling is really difference from what we did before struggling with "key hell". Therefore, remaining hacks for charCode in NativeKey::HandleCharMessage() are not necessary because they are for old code. MozReview-Commit-ID: 3hvsBOiJ6VV
b4b179a1d43e0d6288fee3ffa62ac8331ce11a76: Bug 1307112 part.8 NativeKey::HandleCharMessage() shouldn't dispatch eKeyPress event when its message is inputting a control character r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 05 Oct 2016 15:18:00 +0900 - rev 316882
Push 30785 by ryanvm@gmail.com at Fri, 07 Oct 2016 13:33:32 +0000
Bug 1307112 part.8 NativeKey::HandleCharMessage() shouldn't dispatch eKeyPress event when its message is inputting a control character r=m_kato This patch makes NativeKey::HandleCharMessage() stop dispatching eKeyPress event when the message is inputting a control character. NativeKey::HandleCharMessage() runs following cases: 1. WM_KEYDOWN followed by a WM_CHAR message whose wParam is not a control character causes inputting printable characters. 2. WM_CHAR message is received without WM_KEYDOWN message. So, when HandleCharMessage() is called for a control character, it's unusual case. E.g., another application sends only WM_CHAR message with a control character. On the other hand, Gecko is the only browser which dispatches "keypress" event even if pressed printable key doesn't cause inputting any characters. And such "keypress" event is used for shortcut key handling and some default action handling. So, even if we stop dispatching eKeyPress event from HandleCharMessage(), it shouldn't affect most users. Note that this patch does NOT change the behavior when the user inputs a control character with usual keyboard layout such as Ctrl+A of en-US keyboard layout because DispatchKeyPressEventsWithoutCharMessage() dispatches eKeyPress event in such cases. This patch also adds a lot of tests with Ctrl or Alt state for detecting regressions. MozReview-Commit-ID: KUNqTp7RDSc
c6dca012337bcb0a625335b3c4904ce6ae3bcf23: Bug 1307112 part.7 Get rid of Enter and Backspace key hack in NativeKey class r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 04 Oct 2016 00:21:40 +0900 - rev 316881
Push 30785 by ryanvm@gmail.com at Fri, 07 Oct 2016 13:33:32 +0000
Bug 1307112 part.7 Get rid of Enter and Backspace key hack in NativeKey class r=m_kato Currently, Enter and Backspace keys are handled without following WM_(SYS)CHAR message. However, older code needs hack for them for avoiding conflict with Ctrl+J vs. Ctrl+Enter, etc. So, we can get rid of them now. And when a keydown causes inputting a control character, NativeKey should handle it with keyboard layout (i.e., without following char message(s)). MozReview-Commit-ID: 6bVuK0BzFbx
6d50e95e5494dd263c0e98ca2d04567e47ba86df: Bug 1307112 part.6 Get rid of char message argument from public NativeKey::HandleCharMessage() method r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 03 Oct 2016 23:55:14 +0900 - rev 316880
Push 30785 by ryanvm@gmail.com at Fri, 07 Oct 2016 13:33:32 +0000
Bug 1307112 part.6 Get rid of char message argument from public NativeKey::HandleCharMessage() method r=m_kato Currently, NativeKey::HandleCharMessage() is only a public method and it takes any char message. However, when it's called outside of NativeKey, it should work only with NativeKey::mMsg. Therefore, we should make current HandleCharMessage() a private method and create new overload method which doesn't take MSG as an argument. MozReview-Commit-ID: LowV2FUmR3U
38f802fc35a0944031248d677b60e67c3adc8d78: Bug 1307112 part.5 NativeKey should skip non-printable char messages when it initializes mCommittedCharsAndModifiers with following char messages r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 03 Oct 2016 18:20:29 +0900 - rev 316879
Push 30785 by ryanvm@gmail.com at Fri, 07 Oct 2016 13:33:32 +0000
Bug 1307112 part.5 NativeKey should skip non-printable char messages when it initializes mCommittedCharsAndModifiers with following char messages r=m_kato NativeKey shouldn't include characters which are provided by WM_SYSCHAR message or WM_DEADCHAR message into mCommittedCharsAndModifiers. MozReview-Commit-ID: Ax1BmO5wTy0
a041e03e326859f84aa68dac9541b1890d8e2722: Bug 1307112 part.4 Rename NativeKey::IsFollowedByNonControlCharMessage() to IsFollowedByPrintableCharMessage() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 03 Oct 2016 18:07:33 +0900 - rev 316878
Push 30785 by ryanvm@gmail.com at Fri, 07 Oct 2016 13:33:32 +0000
Bug 1307112 part.4 Rename NativeKey::IsFollowedByNonControlCharMessage() to IsFollowedByPrintableCharMessage() r=m_kato For consistency with IsPrintableCharMessage(), IsFollowedByNonControlCharMessage() should be renamed to IsFollowedByPrintableCharMessage(). MozReview-Commit-ID: CBJFPO4FZej
475d07b93930b5a85e92bee20eb2e8a43d55c1c9: Bug 1307112 part.3 NativeKey::IsFollowedByNonControlCharMessage() should return true when one of following char messages is a printable char message r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 03 Oct 2016 18:03:46 +0900 - rev 316877
Push 30785 by ryanvm@gmail.com at Fri, 07 Oct 2016 13:33:32 +0000
Bug 1307112 part.3 NativeKey::IsFollowedByNonControlCharMessage() should return true when one of following char messages is a printable char message r=m_kato Currently, NativeKey::IsFollowedByNonControlCharMessage() returns true only when the first char message is a printable char message. Although, I don't know actual cases coming printable WM_CHAR message after non-printable char message, i.e., 1. WM_SYSCHAR or WM_DEADCHAR 2. WM_CHAR for a printable character or 1. WM_CHAR with a non-printable character (a control character) 2. WM_CHAR with a printable character , we should make it return true because when one or more characters are being inputted, we should ignore non-printable char messages and handle printable char messages in the path handling text input. MozReview-Commit-ID: 1v7v5mCRFCP
b67296e037c61f8a66f8db7b9ce7724b61dbb978: Bug 1307112 part.2 Create NativeKey::IsPrintableCharMessage() which returns true when given message is WM_CHAR and inputting a printable character r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 03 Oct 2016 17:52:41 +0900 - rev 316876
Push 30785 by ryanvm@gmail.com at Fri, 07 Oct 2016 13:33:32 +0000
Bug 1307112 part.2 Create NativeKey::IsPrintableCharMessage() which returns true when given message is WM_CHAR and inputting a printable character r=m_kato MozReview-Commit-ID: 7f74273Ogo5
b618a5db1f09e2b167466cc93c5911d99be013d3: Bug 1307112 part.1 Rename NativeKey::IsPrintableCharMessage() to IsCharOrSysCharMessage() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 03 Oct 2016 17:45:03 +0900 - rev 316875
Push 30785 by ryanvm@gmail.com at Fri, 07 Oct 2016 13:33:32 +0000
Bug 1307112 part.1 Rename NativeKey::IsPrintableCharMessage() to IsCharOrSysCharMessage() r=m_kato Currently, NativeKey::IsPrintableCharMessage() returns true if given message is WM_CHAR or WM_SYSCHAR. However, WM_SYSCHAR never causes inputting any character and even if WM_CHAR has a control character (i.e., non-printable character), it returns true. MozReview-Commit-ID: IoU5F06WImz
14a91d6bf939456e05812d822ecbded60bf5e2b6: Bug 1285848 - Part 2: Request and parse RICE encoded prefix by default. r=francois
Henry Chang <hchang@mozilla.com> - Wed, 05 Oct 2016 14:59:53 +0800 - rev 316874
Push 30785 by ryanvm@gmail.com at Fri, 07 Oct 2016 13:33:32 +0000
Bug 1285848 - Part 2: Request and parse RICE encoded prefix by default. r=francois MozReview-Commit-ID: Cd0lT5VTM7t
e7410bc7e06868cf97ed0c571229bfb3994fb104: Bug 1285848 - Part 1: Implement Rice Delta Decoding. r=francois.
Henry Chang <hchang@mozilla.com> - Wed, 05 Oct 2016 14:59:43 +0800 - rev 316873
Push 30785 by ryanvm@gmail.com at Fri, 07 Oct 2016 13:33:32 +0000
Bug 1285848 - Part 1: Implement Rice Delta Decoding. r=francois. MozReview-Commit-ID: 2GR51CRFBDL
04bbd8b53f9ddd08b0580e5f8428dfff9aa39f09: Bug 1293324 - Release widgets from a runnable instead of from an objective C 'performAfterDelay' timer. r=Ehsan
Markus Stange <mstange@themasta.com> - Thu, 06 Oct 2016 23:34:14 -0400 - rev 316872
Push 30785 by ryanvm@gmail.com at Fri, 07 Oct 2016 13:33:32 +0000
Bug 1293324 - Release widgets from a runnable instead of from an objective C 'performAfterDelay' timer. r=Ehsan This guarantees that the runnable will be processed before shutdown leak checking. MozReview-Commit-ID: B89AcDUWb3y
7affb66131bb766fab016f554ab1d0b97da72d41: Merge m-c to autoland
Phil Ringnalda <philringnalda@gmail.com> - Thu, 06 Oct 2016 20:24:09 -0700 - rev 316871
Push 30785 by ryanvm@gmail.com at Fri, 07 Oct 2016 13:33:32 +0000
Merge m-c to autoland
e4333cfe24b97169233450f9010474464eeaff85: Bug 1308119 - replace nsIAudioChannelAgent with AudioChannelAgent. r=baku
Alastor Wu <alwu@mozilla.com> - Fri, 07 Oct 2016 10:35:01 +0800 - rev 316870
Push 30785 by ryanvm@gmail.com at Fri, 07 Oct 2016 13:33:32 +0000
Bug 1308119 - replace nsIAudioChannelAgent with AudioChannelAgent. r=baku Since I want to use more agent's functions in MediaElement and I don't think these functions need to be exposed on IDL level. (for other languages binding) Therefore, I want to use AudioChannelAgent directly in MediaElement. MozReview-Commit-ID: 43FvDeLpZPt
90df44a1650586087d499a88cdc6a6b7f8d54c02: Bug 1302084 - the error checking should have highest priority. r=baku
Alastor Wu <alwu@mozilla.com> - Thu, 06 Oct 2016 12:07:33 +0800 - rev 316869
Push 30785 by ryanvm@gmail.com at Fri, 07 Oct 2016 13:33:32 +0000
Bug 1302084 - the error checking should have highest priority. r=baku MozReview-Commit-ID: 9QC5CG7p28M
470faafbaaa7eacffc93f2c2bc0b820ab7a9e23e: Bug 1303554 - part2 : remove the b2g specific checking in IsCurrentlyPlaying(). r=baku
Alastor Wu <alwu@mozilla.com> - Wed, 05 Oct 2016 10:07:54 +0800 - rev 316868
Push 30785 by ryanvm@gmail.com at Fri, 07 Oct 2016 13:33:32 +0000
Bug 1303554 - part2 : remove the b2g specific checking in IsCurrentlyPlaying(). r=baku MozReview-Commit-ID: 5kUJc24uEIH
54717f58b8bd972639ada01da044562150bea7c1: Bug 1303554 - part1 : notify start-playing after having enough data. r=baku
Alastor Wu <alwu@mozilla.com> - Wed, 05 Oct 2016 10:07:49 +0800 - rev 316867
Push 30785 by ryanvm@gmail.com at Fri, 07 Oct 2016 13:33:32 +0000
Bug 1303554 - part1 : notify start-playing after having enough data. r=baku Regression by bug1262053 because of removing the current playing checking. It would cause that the media control on Fennec shows too early and some media elements would also generate the media control even it doens't have available source. Therefore, I think we still need to add this checking back. MozReview-Commit-ID: 1m1ywmLmpSe
ea8ef9df3153f09d1f13141f7d2f8a253db6bec0: Bug 1308369 - Use longer duration to avoid intermittent failure. r=birtles
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Fri, 07 Oct 2016 10:48:56 +0900 - rev 316866
Push 30785 by ryanvm@gmail.com at Fri, 07 Oct 2016 13:33:32 +0000
Bug 1308369 - Use longer duration to avoid intermittent failure. r=birtles MozReview-Commit-ID: 1PVKWIPm23B
5322af204cb05bea9336b2a500cc65f6a2549575: bug 1301227 - add allowScriptsToClose option to windows.create(), r=kmag
Tomislav Jovanovic <tomica@gmail.com> - Fri, 23 Sep 2016 23:40:24 +0200 - rev 316865
Push 30785 by ryanvm@gmail.com at Fri, 07 Oct 2016 13:33:32 +0000
bug 1301227 - add allowScriptsToClose option to windows.create(), r=kmag MozReview-Commit-ID: 4p8A1y2FALX
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip