1d37ebf3d20ce8071c7482fbf7bcdc37834e950c: Bug 1653421 - Part 2: Add attributed string for range getter. r=morgan
Eitan Isaacson <eitan@monotonous.org> - Tue, 21 Jul 2020 23:02:55 +0000 - rev 541524
Push 37625 by csabou@mozilla.com at Wed, 22 Jul 2020 04:32:41 +0000
Bug 1653421 - Part 2: Add attributed string for range getter. r=morgan This doesn't actually add any attributes yet. VoiceOver uses this instead of the plain string equivalent. Differential Revision: https://phabricator.services.mozilla.com/D84054
daeda032926d1fb85aca0d9117d9e77ea677d2b4: Bug 1653421 - Part 1: Refactor AccessibleWrap event handling. r=morgan
Eitan Isaacson <eitan@monotonous.org> - Tue, 21 Jul 2020 23:02:53 +0000 - rev 541523
Push 37625 by csabou@mozilla.com at Wed, 22 Jul 2020 04:32:41 +0000
Bug 1653421 - Part 1: Refactor AccessibleWrap event handling. r=morgan I split the switch statement into two: the first switch determines the MOX target accessible. The second one does all the rest. This makes it more readable and scalable when we add more events that need to be accompanied with data. Differential Revision: https://phabricator.services.mozilla.com/D84053
978c7a6ddb55e53f9230112f5455a4970ee5d7b4: Bug 1607940 - IPC TexImage. r=lsalzman,nika,handyman
Jeff Gilbert <jgilbert@mozilla.com> - Tue, 21 Jul 2020 22:57:01 +0000 - rev 541522
Push 37625 by csabou@mozilla.com at Wed, 22 Jul 2020 04:32:41 +0000
Bug 1607940 - IPC TexImage. r=lsalzman,nika,handyman Differential Revision: https://phabricator.services.mozilla.com/D83291
9049a0173c604b87f7d4d1b4e1d7a3ef7dd2c762: Bug 1607940 - Add webgl-ipc (gli) CI variant. r=ahal,jmaher
Jeff Gilbert <jgilbert@mozilla.com> - Tue, 21 Jul 2020 22:56:54 +0000 - rev 541521
Push 37625 by csabou@mozilla.com at Wed, 22 Jul 2020 04:32:41 +0000
Bug 1607940 - Add webgl-ipc (gli) CI variant. r=ahal,jmaher Differential Revision: https://phabricator.services.mozilla.com/D83290
282eafdb9753ab010a385419bb3138ae22b56fa6: Bug 1607940 - Stand up webgl.out-of-process:true path. r=handyman,nika,froydnj
Jeff Gilbert <jgilbert@mozilla.com> - Tue, 21 Jul 2020 22:56:52 +0000 - rev 541520
Push 37625 by csabou@mozilla.com at Wed, 22 Jul 2020 04:32:41 +0000
Bug 1607940 - Stand up webgl.out-of-process:true path. r=handyman,nika,froydnj * Use clearer pref names. * Default (and only support) IPDL dispatching. * Make DispatchCommands async-only. * Sync ipdl command per sync webgl entrypoint. * Eat the boilerplate cost, since there's not too many. * Run SerializedSize off same path as Serialize. * All shmem uploads go through normal DispatchCommands. * Defer pruning of dead code for now so we can iterate quickly. * Use Read/Write(begin,end) instead of (begin,size). * This would have prevented a bug where we read/wrote N*sizeof(T)*sizeof(T). Differential Revision: https://phabricator.services.mozilla.com/D81495
6a9bd9bf58915c21660322ea675558df47956a5f: Bug 1449401 - Remove moz-math-anonymous ua-only pseudo. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 21 Jul 2020 22:35:46 +0000 - rev 541519
Push 37625 by csabou@mozilla.com at Wed, 22 Jul 2020 04:32:41 +0000
Bug 1449401 - Remove moz-math-anonymous ua-only pseudo. r=heycam We do not expose it nor ever style it. Just use the parent style all the time. This avoids problematic style resolution calls during reflow. Differential Revision: https://phabricator.services.mozilla.com/D84358
986960f3dd902342c4720980dea94b3138e3ef9a: Backed out changeset 9c69d81ccdd2 (bug 1653348) for xpcshell failures on test_amo_stats_telemetry.js. CLOSED TREE
Cosmin Sabou <csabou@mozilla.com> - Wed, 22 Jul 2020 01:58:51 +0300 - rev 541518
Push 37625 by csabou@mozilla.com at Wed, 22 Jul 2020 04:32:41 +0000
Backed out changeset 9c69d81ccdd2 (bug 1653348) for xpcshell failures on test_amo_stats_telemetry.js. CLOSED TREE
8ecbb1da91cf8c4e323873741860636f592b375d: Bug 1654182 - Fix spidermonkey bustages. r=glandium
Cosmin Sabou <csabou@mozilla.com> - Wed, 22 Jul 2020 01:54:38 +0300 - rev 541517
Push 37625 by csabou@mozilla.com at Wed, 22 Jul 2020 04:32:41 +0000
Bug 1654182 - Fix spidermonkey bustages. r=glandium
57e33fc3bce24dd10820f8c5fd47c104a2872414: Bug 1636797 - Tweak `git clean` call in `mach clobber python` r=mhentges,jgilbert,froydnj
Ricky Stewart <rstewart@mozilla.com> - Tue, 21 Jul 2020 22:27:21 +0000 - rev 541516
Push 37625 by csabou@mozilla.com at Wed, 22 Jul 2020 04:32:41 +0000
Bug 1636797 - Tweak `git clean` call in `mach clobber python` r=mhentges,jgilbert,froydnj Differential Revision: https://phabricator.services.mozilla.com/D84440
bcc1435157681e1d1830e8d18069f8ba2a97a402: Bug 1636539 - Part 4: Note remote disablement in browser default agent docs. r=agashlin,bytesized
Nick Alexander <nalexander@mozilla.com> - Tue, 21 Jul 2020 22:04:53 +0000 - rev 541515
Push 37625 by csabou@mozilla.com at Wed, 22 Jul 2020 04:32:41 +0000
Bug 1636539 - Part 4: Note remote disablement in browser default agent docs. r=agashlin,bytesized Differential Revision: https://phabricator.services.mozilla.com/D81168
0b95a5f433de2020533d3b9ca4e7ef686bb4045a: Bug 1636539 - Part 3: Use Rust remote settings client to fetch remote kill switch. r=agashlin,bytesized
Nick Alexander <nalexander@mozilla.com> - Tue, 21 Jul 2020 22:04:27 +0000 - rev 541514
Push 37625 by csabou@mozilla.com at Wed, 22 Jul 2020 04:32:41 +0000
Bug 1636539 - Part 3: Use Rust remote settings client to fetch remote kill switch. r=agashlin,bytesized Differential Revision: https://phabricator.services.mozilla.com/D80768
dd86a9c0dd70e9aaa3dadbf18282d91b1690117e: Bug 1636539 - Part 2: Add defaultagent-static Rust crate fetching remote disabled flag. r=bytesized
Nick Alexander <nalexander@mozilla.com> - Tue, 21 Jul 2020 22:17:26 +0000 - rev 541513
Push 37625 by csabou@mozilla.com at Wed, 22 Jul 2020 04:32:41 +0000
Bug 1636539 - Part 2: Add defaultagent-static Rust crate fetching remote disabled flag. r=bytesized This lays out a Rust crate and statically links it into `windows-default-agent.exe`. It declares a single-method API (which will be invoked in the next commit). Strings cross the C/C++ <-> Rust FFI boundary as null-terminated UTF-8. (This will matter more if and when we use ETag and If-None-Match to get 304 results.) Errors are reported as Windows result codes, with the "customer" bit set to encode certain classes of failure. The bulk of the work is in implementing a [Viaduct](https://github.com/mozilla/application-services/tree/master/components/viaduct) backend built on top of `wininet.dll`. The motivation is that if and when this Remote Settings Rust client grows features (say, Content-Signature: verification), then by using Viaduct there is a smooth path to consume the client inside Firefox itself, because Viaduct already has a backend on top of Necko. That makes this abstraction relatively low friction: it exists, is in-tree already, and has a path to use in Gecko proper. It is expected that the layer above this will handle "gracefully failing", either open or closed; and will mirror Remote Settings configuration to the registry so that testers can use prod/stage/dev easily. For follow-up: - Configure logging to use the Windows event logger. See [Bug 1648617](https://bugzilla.mozilla.org/show_bug.cgi?id=1648617). - Consider propagating errors into the Telemetry we send. Differential Revision: https://phabricator.services.mozilla.com/D78579
12772d5d7702542767cb103ee39f37d6105611bb: Bug 1636539 - Part 1: Mirror preferences for remote settings to Windows Default Browser Agent. r=agashlin,bytesized
Nick Alexander <nalexander@mozilla.com> - Tue, 21 Jul 2020 21:51:59 +0000 - rev 541512
Push 37625 by csabou@mozilla.com at Wed, 22 Jul 2020 04:32:41 +0000
Bug 1636539 - Part 1: Mirror preferences for remote settings to Windows Default Browser Agent. r=agashlin,bytesized The pattern within Firefox is to configure `services.settings.server` and then build URLs from that. That pattern isn't the easiest for testing -- we don't have as much control over the final URL -- but it's what's desired for production. There's really no reason to do this in native code; it could just as easily be JavaScript that runs a little after startup, which would make it lighter to modify. But this location is next to the same pattern for the launcher process. Trade offs, trade offs. Differential Revision: https://phabricator.services.mozilla.com/D80767
02560bbdfdb1c148d757d1a3f13f1e0d2f78799c: Bug 1636539 - Part 0: Expose default agent's Windows event log name. r=agashlin
Nick Alexander <nalexander@mozilla.com> - Tue, 21 Jul 2020 22:17:49 +0000 - rev 541511
Push 37625 by csabou@mozilla.com at Wed, 22 Jul 2020 04:32:41 +0000
Bug 1636539 - Part 0: Expose default agent's Windows event log name. r=agashlin This is an easy way to expose `MOZ_APP_DISPLAYNAME` to Rust code. A visibility declaration is required to expose the symbol; the `MOZ_*` macros follow the model of `/mfbt/Poison.{cpp,h}`. Differential Revision: https://phabricator.services.mozilla.com/D81408
7b973a0e7be9f8213545c3e702f759c8ab70affb: Bug 1651519: Part 2 - Also remove nsIDOMWindowUtils::outerWindowID. r=nika,geckoview-reviewers,agi
Kris Maglione <maglione.k@gmail.com> - Tue, 21 Jul 2020 22:19:19 +0000 - rev 541510
Push 37625 by csabou@mozilla.com at Wed, 22 Jul 2020 04:32:41 +0000
Bug 1651519: Part 2 - Also remove nsIDOMWindowUtils::outerWindowID. r=nika,geckoview-reviewers,agi Differential Revision: https://phabricator.services.mozilla.com/D82957
55e9184c5617f9c501f2ad2fb523d3f35ff7ead7: Bug 1651519: Remove nsIDOMWindowUtils::currentInnerWindowID. r=nika,remote-protocol-reviewers,webcompat-reviewers,whimboo
Kris Maglione <maglione.k@gmail.com> - Tue, 21 Jul 2020 19:02:27 +0000 - rev 541509
Push 37625 by csabou@mozilla.com at Wed, 22 Jul 2020 04:32:41 +0000
Bug 1651519: Remove nsIDOMWindowUtils::currentInnerWindowID. r=nika,remote-protocol-reviewers,webcompat-reviewers,whimboo It has some properties which make it footgunny, especially in the face of Fission. Callers should use WindowGlobalChild.innerWindowId instead. Differential Revision: https://phabricator.services.mozilla.com/D82801
205329cc5f3073075ad768606fa092ed81a3673c: Bug 1654182 - Only look at the dynamic symbols table for the version checks. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 21 Jul 2020 13:28:51 +0000 - rev 541508
Push 37625 by csabou@mozilla.com at Wed, 22 Jul 2020 04:32:41 +0000
Bug 1654182 - Only look at the dynamic symbols table for the version checks. r=froydnj The main reason we look at the complete symbols table is that before bug 1541792, we needed to look at that table for _NSModule symbols. In bug 1516228, we also made everything llvm-objdump to limit the differences cross-platform, but that's not necessary anymore per the previous change. llvm-objdump doesn't support getting only the dynamic symbols table, so we go back to what we were using before bug 1516228, namely readelf, while preserving a code path to use the complete symbols table for the networking test on libgkrust.a, which doesn't have a dynamic symbols table. With this change, check_binary goes from 45s to 0.2s on my machine. Differential Revision: https://phabricator.services.mozilla.com/D84305
13ab8f6d24bfb799a9553f75bd04023ebbc5309b: Bug 1654182 - Remove support for iterating symbols on non-Linux platforms. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 21 Jul 2020 21:00:50 +0000 - rev 541507
Push 37625 by csabou@mozilla.com at Wed, 22 Jul 2020 04:32:41 +0000
Bug 1654182 - Remove support for iterating symbols on non-Linux platforms. r=froydnj The way check_binary currently works is the result of many years of changes, but some of the more recent ones actually make some of the earliest ones unnecessary. For instance, bug 1541792 removed the need to use iter_symbols on non-Linux platforms. So we remove support for non-Linux (non-ELF, really) platforms in iter_symbols (and rename the function to reflect that). Differential Revision: https://phabricator.services.mozilla.com/D84304
6100f0d3c0add9ca07c93e15978ecb7a759039a6: Bug 1654182 - Reduce the amount of work done for binary compatibility check. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 21 Jul 2020 22:15:51 +0000 - rev 541506
Push 37625 by csabou@mozilla.com at Wed, 22 Jul 2020 04:32:41 +0000
Bug 1654182 - Reduce the amount of work done for binary compatibility check. r=froydnj Iterating symbols is actually expensive because of all the line splitting. So iterating over all symbols 4 times is actually a huge waste of time. Instead, iterate over them once, doing all the version checks at once for each of them. This brings down the time spent in check_binary from 2:25 to 0:45 on my machine. Differential Revision: https://phabricator.services.mozilla.com/D84303
f5417fa966f71e4002613c3b282f63c7120966c7: Bug 1602347 - When asked for the DPI from an undisplayed subdocument, try to get it from ancestor documents before giving up and returning 1.0. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 21 Jul 2020 22:01:10 +0000 - rev 541505
Push 37625 by csabou@mozilla.com at Wed, 22 Jul 2020 04:32:41 +0000
Bug 1602347 - When asked for the DPI from an undisplayed subdocument, try to get it from ancestor documents before giving up and returning 1.0. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D84437
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip