19a37953cb0de35a607aaccd0a3ba6d82a4a7f4c: Bug 1629721 - Unified runOnceLambda definition for lazy/non-lazy. r=mgaudet
Ted Campbell <tcampbell@mozilla.com> - Wed, 15 Apr 2020 22:07:27 +0000 - rev 524258
Push 37318 by cbrindusan@mozilla.com at Thu, 16 Apr 2020 09:48:46 +0000
Bug 1629721 - Unified runOnceLambda definition for lazy/non-lazy. r=mgaudet Use the same conditions for qualifying an inner function as a run-once-lambda between the lazy and non-lazy code paths. Use the FunctionBox::immutableFlags so that this works well with delazification too. Differential Revision: https://phabricator.services.mozilla.com/D70779
f7cd6b6c23346b970314da85e102957921f7c5c1: Bug 1629721 - Use the TreatAsRunOnce flag on SharedContext. r=mgaudet
Ted Campbell <tcampbell@mozilla.com> - Wed, 15 Apr 2020 22:07:25 +0000 - rev 524257
Push 37318 by cbrindusan@mozilla.com at Thu, 16 Apr 2020 09:48:46 +0000
Bug 1629721 - Use the TreatAsRunOnce flag on SharedContext. r=mgaudet In the BytecodeEmitter constructor, initialize the TreatAsRunOnce flag for top-level SharedContexts. In the future we should initialize this even earlier. For the delazification case, we initialize already directly initialize this flag from the lazy BaseScript. Differential Revision: https://phabricator.services.mozilla.com/D70778
070c9061ec534c736bef6e9a29b647b9476b634a: Bug 1630159 - Revert Oculus Quest and Focus Plus controller matrix to match WebVR. r=kip
Daosheng Mu <daoshengmu@gmail.com> - Wed, 15 Apr 2020 21:56:50 +0000 - rev 524256
Push 37318 by cbrindusan@mozilla.com at Thu, 16 Apr 2020 09:48:46 +0000
Bug 1630159 - Revert Oculus Quest and Focus Plus controller matrix to match WebVR. r=kip Differential Revision: https://phabricator.services.mozilla.com/D70979
65eade01c8c91253d2270034ef1b7d293b13f523: Bug 1629670: Tier up to compiled regexps r=mgaudet
Iain Ireland <iireland@mozilla.com> - Wed, 15 Apr 2020 20:08:21 +0000 - rev 524255
Push 37318 by cbrindusan@mozilla.com at Thu, 16 Apr 2020 09:48:46 +0000
Bug 1629670: Tier up to compiled regexps r=mgaudet The interpreter calls `TierUpTick` whenever we interpret a regexp. Once we hit the tick threshold, compileIfNecessary will compile native code for the regexp. Currently the tick threshold is hard-coded to 10. V8's tick threshold is 1, which seems unreasonably low. We can tune this later. Differential Revision: https://phabricator.services.mozilla.com/D70952
a05f70d2f0cb216c343aa6a17a0c12b8aaff2f94: Bug 1629670: Change ForceByteCode to CodeKind r=mgaudet
Iain Ireland <iireland@mozilla.com> - Wed, 15 Apr 2020 20:54:38 +0000 - rev 524254
Push 37318 by cbrindusan@mozilla.com at Thu, 16 Apr 2020 09:48:46 +0000
Bug 1629670: Change ForceByteCode to CodeKind r=mgaudet The current ForceByteCodeEnum is a glorified boolean. This patch replaces it with a three-value bytecode/jitcode/either enum, which will make our tiering-up logic slightly nicer in the next patch. Differential Revision: https://phabricator.services.mozilla.com/D70951
7a5093c6eea7127f175bacb634a29c7ae5e027c5: Bug 1628835: Unify result enum r=tcampbell
Iain Ireland <iireland@mozilla.com> - Wed, 15 Apr 2020 20:08:25 +0000 - rev 524253
Push 37318 by cbrindusan@mozilla.com at Thu, 16 Apr 2020 09:48:46 +0000
Bug 1628835: Unify result enum r=tcampbell Internally, irregexp uses -1 for errors, 0 for failure, and 1 for success. We have to use the same values in RegExpRunStatus. Ideally we would replace RegExpRunStatus with an enum defined in RegExpTypes.h, but that will have to wait until we get rid of the old import. Differential Revision: https://phabricator.services.mozilla.com/D70728
4fb151103331fb76492da54dd7230ec0b9a5a661: Bug 1628835: Add interpreter support r=tcampbell
Iain Ireland <iireland@mozilla.com> - Wed, 15 Apr 2020 20:08:25 +0000 - rev 524252
Push 37318 by cbrindusan@mozilla.com at Thu, 16 Apr 2020 09:48:46 +0000
Bug 1628835: Add interpreter support r=tcampbell The irregexp compiler takes the AST produced by the parser, compiles it down to a more efficient internal representation, then uses a 'macroassembler' to generate code. The generated code can either be bytecode (which is then fed into the interpreter) or jitcode (which can be executed directly). This patch gets the infrastructure set up and handles the former case. CompilePattern is based heavily on V8's `RegExpImpl::compile` (https://github.com/v8/v8/blob/affc364620bb4bbd77968bcc4d0a1f54d4ada5c8/src/regexp/regexp.cc#L745-L933). I am upstreaming a patch to move the code in WrapBody into regexp-compiler.cc where it fits better. V8 is about to land a patch to tweak the API for Interpret so that it allocates memory for its registers internally instead of requiring it to be passed in. When we import this change, we'll be able to pass `matches->pairsRaw()` directly into `MatchForCallFromRuntime`, and the interpreter will fill it in for us. In the old engine, we could handle interrupts in the middle of the interpreter. If we hit an urgent interrupt in compiled code, we would generate bytecode and fall back to the interpreter (see https://searchfox.org/mozilla-central/rev/9120151ddb35f2d4c37bfe613a54a4f10a9a3dc5/js/src/vm/RegExpObject.cpp#1165-1175). (This is what all the `ForceByteCode` machinery in RegExpObject.cpp is about. It was added in bug 1077514.) That won't work in the new version. V8 does allow interrupts during regexp execution, but only by jumping through some scary hoops to "manually relocate unhandlified references" afterwards. Instead, we just retry the regexp. I have no idea what a reasonable number of retries is before giving up; I've arbitrarily picked 4 for now. Differential Revision: https://phabricator.services.mozilla.com/D70695
cef25da6fa6959b12ec3d39b68781cad66e4a91e: Bug 1628835: Use RegExpShared in JSRegExp r=tcampbell
Iain Ireland <iireland@mozilla.com> - Wed, 15 Apr 2020 20:08:24 +0000 - rev 524251
Push 37318 by cbrindusan@mozilla.com at Thu, 16 Apr 2020 09:48:46 +0000
Bug 1628835: Use RegExpShared in JSRegExp r=tcampbell In preparation for actually compiling regexps in the next patch, hook up the V8 and irregexp representations of a compiled regexp. Differential Revision: https://phabricator.services.mozilla.com/D70694
fa42c3f2667a1883dec0bf1ed460f26841a65b43: Bug 1628835: Change parenCount to pairCount r=tcampbell
Iain Ireland <iireland@mozilla.com> - Wed, 15 Apr 2020 20:08:24 +0000 - rev 524250
Push 37318 by cbrindusan@mozilla.com at Thu, 16 Apr 2020 09:48:46 +0000
Bug 1628835: Change parenCount to pairCount r=tcampbell A regexp with N sets of capturing parens will have N+1 capture groups, with the extra capture containing the entire matching string. Our old implementation stored `parenCount` in the RegExpShared and then added 1 to it whenever it was used. A much simpler answer is to just add 1 when initializing the regexp. Differential Revision: https://phabricator.services.mozilla.com/D70693
0c8a5b5094b63c14c331f0cdec7c25c92b229300: Bug 1628926 - Remove the browser.urlbar.oneOffSearches pref. r=dao
Drew Willcoxon <adw@mozilla.com> - Wed, 15 Apr 2020 08:56:16 +0000 - rev 524249
Push 37318 by cbrindusan@mozilla.com at Thu, 16 Apr 2020 09:48:46 +0000
Bug 1628926 - Remove the browser.urlbar.oneOffSearches pref. r=dao Differential Revision: https://phabricator.services.mozilla.com/D70921
5caf69708b98677d4333eeebe586acbcc8639f27: Bug 1613507 - [geckodriver] Don't set `speculative-parallel-limit` to `0` but leave it on its default value. r=whimboo,marionette-reviewers
sefeng <sefeng@mozilla.com> - Wed, 15 Apr 2020 21:36:08 +0000 - rev 524248
Push 37318 by cbrindusan@mozilla.com at Thu, 16 Apr 2020 09:48:46 +0000
Bug 1613507 - [geckodriver] Don't set `speculative-parallel-limit` to `0` but leave it on its default value. r=whimboo,marionette-reviewers Differential Revision: https://phabricator.services.mozilla.com/D71071
07d0377a50021d22444b01fedd6c472d0f5e6189: Bug 1625362 Part 3 - Extract grid container's PushIncompleteChildren logic, and move it to nsContainerFrame. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Wed, 15 Apr 2020 18:31:35 +0000 - rev 524247
Push 37318 by cbrindusan@mozilla.com at Thu, 16 Apr 2020 09:48:46 +0000
Bug 1625362 Part 3 - Extract grid container's PushIncompleteChildren logic, and move it to nsContainerFrame. r=mats I left all the bits that related to grid container, such as setting aStatus, NS_STATE_GRID_DID_PUSH_ITEMS, and aState.mIter in nsGridContainerFrame::ReflowRowsInFragmentainer(). Differential Revision: https://phabricator.services.mozilla.com/D68492
49bf43d18337bac31e8965740426e3fb81008d8c: Bug 1625362 Part 2 - Move some helpers manipulating overflow lists from nsGridContainerFrame to nsContainerFrame. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Wed, 15 Apr 2020 18:31:33 +0000 - rev 524246
Push 37318 by cbrindusan@mozilla.com at Thu, 16 Apr 2020 09:48:46 +0000
Bug 1625362 Part 2 - Move some helpers manipulating overflow lists from nsGridContainerFrame to nsContainerFrame. r=mats We can utilize these helpers to implement flex item fragmentation. Differential Revision: https://phabricator.services.mozilla.com/D68491
fd847fbe1a513ce8302c2baeab07d4306ee329fa: Bug 1625362 Part 1 - Move ReparentFrame and ReparentFrames into nsContainerFrame. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Wed, 15 Apr 2020 18:31:25 +0000 - rev 524245
Push 37318 by cbrindusan@mozilla.com at Thu, 16 Apr 2020 09:48:46 +0000
Bug 1625362 Part 1 - Move ReparentFrame and ReparentFrames into nsContainerFrame. r=mats We have duplicated ReparentFrame and ReparentFrames define in both nsBlockFrame and nsGridContainerFrame. We should move them into nsContainerFrame. Differential Revision: https://phabricator.services.mozilla.com/D68490
300228102cea98e8f7de648a439c19cda71d1973: Bug 1630201 - Merge browser/themes/shared/preferences and browser/themes/shared/incontentprefs. r=jaws
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 15 Apr 2020 20:41:37 +0000 - rev 524244
Push 37317 by nerli@mozilla.com at Thu, 16 Apr 2020 03:00:04 +0000
Bug 1630201 - Merge browser/themes/shared/preferences and browser/themes/shared/incontentprefs. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D71020
fe5f1d556dc695ee7a41633494b4b6a008481365: Bug 1630201 - Rename browser/themes/shared/preferences/containers.css to browser/themes/shared/preferences/containers-dialog.css. r=jaws
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 15 Apr 2020 20:32:30 +0000 - rev 524243
Push 37317 by nerli@mozilla.com at Thu, 16 Apr 2020 03:00:04 +0000
Bug 1630201 - Rename browser/themes/shared/preferences/containers.css to browser/themes/shared/preferences/containers-dialog.css. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D71019
d8bd063d150e63c9ee3f1a21d2e38be224ffdf08: Bug 1626586 - Make history notifications do a bit less work. r=mak,lina,agi,snorp
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 15 Apr 2020 21:19:41 +0000 - rev 524242
Push 37317 by nerli@mozilla.com at Thu, 16 Apr 2020 03:00:04 +0000
Bug 1626586 - Make history notifications do a bit less work. r=mak,lina,agi,snorp And batch them when notifying child processes. This makes RegisterVisitedQuery potentially notify synchronously, but changes the code to deal with it properly. Differential Revision: https://phabricator.services.mozilla.com/D69187
e4ee3de5124eb00ec2e5d11606c50c9fa6fe81b9: Backed out changeset 130dadf64e30 (bug 658544) for failures on test_PlacesDBUtils_removeOldCorruptDBs.js. CLOSED TREE
Csoregi Natalia <ncsoregi@mozilla.com> - Thu, 16 Apr 2020 00:34:55 +0300 - rev 524241
Push 37317 by nerli@mozilla.com at Thu, 16 Apr 2020 03:00:04 +0000
Backed out changeset 130dadf64e30 (bug 658544) for failures on test_PlacesDBUtils_removeOldCorruptDBs.js. CLOSED TREE
13b5ce2ab11490930ed068213d3a50be7633cf2f: Backed out 7 changesets (bug 1625615) for multiple failures e.g. /test_windowedhistoryframes.html. CLOSED TREE
Csoregi Natalia <ncsoregi@mozilla.com> - Thu, 16 Apr 2020 00:32:16 +0300 - rev 524240
Push 37317 by nerli@mozilla.com at Thu, 16 Apr 2020 03:00:04 +0000
Backed out 7 changesets (bug 1625615) for multiple failures e.g. /test_windowedhistoryframes.html. CLOSED TREE Backed out changeset f239d24658c9 (bug 1625615) Backed out changeset acea7c78db20 (bug 1625615) Backed out changeset d709f5a72c35 (bug 1625615) Backed out changeset 4cd231b1f3fb (bug 1625615) Backed out changeset 45942c8dc380 (bug 1625615) Backed out changeset 3f03a8703a8a (bug 1625615) Backed out changeset e9299fc48796 (bug 1625615)
ba223c9eb4fdd088995bbab5087dd88a93b3b892: Bug 1627362 - Improve logging for fixed/sticky data on the WR codepath. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 15 Apr 2020 20:01:05 +0000 - rev 524239
Push 37317 by nerli@mozilla.com at Thu, 16 Apr 2020 03:00:04 +0000
Bug 1627362 - Improve logging for fixed/sticky data on the WR codepath. r=botond Differential Revision: https://phabricator.services.mozilla.com/D70912
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip