192713c16fc1f199c78f470f11c3c6f12109ec27: Bug 1467867 - Ensure we populate the event regions overrides properly. r=botond
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 08 Jun 2018 21:16:43 +0000 - rev 421991
Push 34113 by btara@mozilla.com at Sat, 09 Jun 2018 12:05:46 +0000
Bug 1467867 - Ensure we populate the event regions overrides properly. r=botond The event regions override flags are needed whenever APZ is doing hit-testing off the layer tree. This can happen even if IsBuildingLayerEventRegions() returns false, because we can instead be building nsDisplayCompositorHitTestInfo items from which we populate the layer tree's EventRegions objects. So the guard condition here is wrong, and we can just remove it to ensure the flags are always put on the layer tree. If APZ isn't enabled on this layer tree then they won't be used, and there might be a slight perf hit, but it should be negligible. Differential Revision: https://phabricator.services.mozilla.com/D1599
3a3bbb2e68ef7429368c347c53b4ac819b5db6a0: Backed out changeset 2b65a8f99622 (bug 1465562) for mochitest failures on test_cache_padding.html. CLOSED TREE
Narcis Beleuzu <nbeleuzu@mozilla.com> - Sat, 09 Jun 2018 00:14:44 +0300 - rev 421990
Push 34113 by btara@mozilla.com at Sat, 09 Jun 2018 12:05:46 +0000
Backed out changeset 2b65a8f99622 (bug 1465562) for mochitest failures on test_cache_padding.html. CLOSED TREE
e9a2d7e57f695d25448dc87fc1df99478b01034a: Bug 1306975 - Support containers in RDM. r=gl
J. Ryan Stinnett <jryans@gmail.com> - Fri, 23 Feb 2018 17:33:55 -0600 - rev 421989
Push 34113 by btara@mozilla.com at Sat, 09 Jun 2018 12:05:46 +0000
Bug 1306975 - Support containers in RDM. r=gl This adds support for container tabs / contextual identity in Responsive Design Mode. Tabs in non-default contexts can now be opened in RDM just like regular tabs. MozReview-Commit-ID: BofTgrowjGV
8ca33f3d833974f81ea8e744b4ddfc2a811f8d8c: Bug 1465685 - Add login_form probe for Savant Shield study; r=MattN
Bianca Danforth <bdanforth@mozilla.com> - Thu, 07 Jun 2018 03:24:09 -0700 - rev 421988
Push 34113 by btara@mozilla.com at Sat, 09 Jun 2018 12:05:46 +0000
Bug 1465685 - Add login_form probe for Savant Shield study; r=MattN This probe will register and record (for the duration of the study only): * When a login form is loaded * When a login form is submitted (excluding the case from unresolved bug 1287202) The login_form probe has an 'extra' field called 'flow_id'. This value associates actions that occur in the same tab. It should be noted that for several reasons, we should expect a higher than 1:1 ratio between 'load' and 'submit' events: * Some sites, like Google and Amazon, have a two-step login process, and each step fires its own 'load' event. Only the second step fires a 'submit' event. * Some sites, like Facebook and Twitter, fire multiple 'load' events on the same page. * A common pattern for unsuccessful logins is for the site to redirect to a page with a login form. This would be a 'load' --> 'submit' --> 'load' series. * Unlike 'load', the 'submit' event fires only when the Password Manager is enabled and the user is in a non-private window. 'Load' events will have a 'canRecordSubmit' key in the 'extra' field which will be true if a submit event for that form can be recorded. MozReview-Commit-ID: LOMDSN6tgRV
a8d6fa6ad40369a09ba5f7806071b0e3261d7c10: Bug 1465685 - Add Password Manager probes for Savant Shield study; r=MattN
Bianca Danforth <bdanforth@mozilla.com> - Thu, 07 Jun 2018 03:23:47 -0700 - rev 421987
Push 34113 by btara@mozilla.com at Sat, 09 Jun 2018 12:05:46 +0000
Bug 1465685 - Add Password Manager probes for Savant Shield study; r=MattN These probes will register and record (for the duration of the study only): * When the user is prompted by the Password Manager * When the user saves their login information through the Password Manager prompt * When the user updates their login information through the Password Manager prompt * When the user uses login information stored by the Password Manager Both the 'pwmgr' and 'pwmgr_use' probe have an 'extra' field called 'flow_id'. This is a tab identifier. For a given session, flow_id remains constant, even if the tab is moved to a different index within the same window. Tabs at the same index in different windows will have different flow_ids. MozReview-Commit-ID: CoBNl6lUQmH
58e58e8e3601985c88be1a279ef7813a6ba5995e: Bug 1465697 - Add menu open probes for Savant Shield study; r=jaws
Bianca Danforth <bdanforth@mozilla.com> - Wed, 06 Jun 2018 06:26:38 -0700 - rev 421986
Push 34113 by btara@mozilla.com at Sat, 09 Jun 2018 12:05:46 +0000
Bug 1465697 - Add menu open probes for Savant Shield study; r=jaws These probes will register and record (for the duration of the study only): * When the library menu opens. * When the hamburger menu opens. * When the dotdotdot menu opens. These will be captured in existing and new windows. Note: The library panel is dynamically added and removed from the document (see PanelUI.js for where the panel is created and removed), so a listener can't be added to it in advance. However, the library menu "ViewShowing" event bubbles up to the navBar in its default location. A separate listener is needed if it is moved to the overflow panel via Hamburger > Customize. MozReview-Commit-ID: EBBBgXAQnxE
8d32de5379894ef395bde70ecfa0f62e2b47a71a: Bug 1465063 - Return FP cookies from cookies.getAll even if domain/url is set r=rpl
Rob Wu <rob@robwu.nl> - Fri, 08 Jun 2018 17:20:02 +0200 - rev 421985
Push 34113 by btara@mozilla.com at Sat, 09 Jun 2018 12:05:46 +0000
Bug 1465063 - Return FP cookies from cookies.getAll even if domain/url is set r=rpl `browser.cookies.getAll(details)` is expected to return all cookies if the "details.firstPartyDomain" key is set to undefined/null. This usually works, because `getCookiesWithOriginAttributes` is used, which iterates over all cookies and only checks origin attributes that exist in the specified pattern. If a "url" or "domain" are set, then `getCookiesFromHost` was used, which uses a look-up table keyed by host and OriginAttributes, with undefined origin attributes initialized at their default value. Consequently, only non-FP cookies were returned. This commit fixes the issue by using `getCookiesWithOriginAttributes` when the `firstPartyDomain` does not have an explicit (string) value. MozReview-Commit-ID: AxHbbDeqSwr
dccf43cba794a6934858ff0e2e0a3ece92b1f443: Bug 1465063 - Add tests for get/getAll w/o firstPartyDomain r=rpl
Rob Wu <rob@robwu.nl> - Fri, 08 Jun 2018 13:36:36 +0200 - rev 421984
Push 34113 by btara@mozilla.com at Sat, 09 Jun 2018 12:05:46 +0000
Bug 1465063 - Add tests for get/getAll w/o firstPartyDomain r=rpl The test coverage for cookies.get was incomplete, as scenarios with empty, null and undefined firstPartyDomain were not checked. There is a distinction between "empty" and "w/o firstPartyDomain". MozReview-Commit-ID: 1l54nUOCneK
b3e5e1651b4929af121a87e73f1c48d7ee5ecc04: Bug 1465063 - Add await before assertRejects r=rpl
Rob Wu <rob@robwu.nl> - Fri, 08 Jun 2018 11:31:05 +0200 - rev 421983
Push 34113 by btara@mozilla.com at Sat, 09 Jun 2018 12:05:46 +0000
Bug 1465063 - Add await before assertRejects r=rpl Wait for the promise resolution before moving to the next line in the tests. MozReview-Commit-ID: Ldeiwj9vCzn
9ef848655b337e9b3da5612b83a54c4bdde99802: Bug 1438289: Implemented RsdparsaSdpMediaSection::AddCodec and ::ClearCodecs. r=dminor
Johannes Willbold <j.willbold@mozilla.com> - Mon, 04 Jun 2018 17:23:42 -0700 - rev 421982
Push 34113 by btara@mozilla.com at Sat, 09 Jun 2018 12:05:46 +0000
Bug 1438289: Implemented RsdparsaSdpMediaSection::AddCodec and ::ClearCodecs. r=dminor Implemented RsdparsaSdpMediaSection::ClearCodecs and RsdparsaSdpMediaSection::AddCodec Added sdp_media_clear_codecs Added corresponding C++/Rust glue code Added rust trait to convert StringView to rust std::String Added testcase CheckAddCodec and CheckClearCodec MozReview-Commit-ID: 5pxl8hR9iz2
af8ba448f7d31f110976160b9e4a78ebaa452d5a: Bug 1466606 - P2. Re-use code to determine NextGetSample index. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 06 Jun 2018 21:47:52 +0200 - rev 421981
Push 34113 by btara@mozilla.com at Sat, 09 Jun 2018 12:05:46 +0000
Bug 1466606 - P2. Re-use code to determine NextGetSample index. r=bryce Previous commit added SetNextGetSampleIndexIfNeeded, let's re-use it for GetSample. We continue to have an exception code as it caters for the most common code path, which is we retrieve one sample after the other. MozReview-Commit-ID: HOQ53qwZj7w
1bdee3c3ca7cc92b1dd7a6d80cb33c313d2a5e59: Bug 1466606 - P1. Calculate the current GetSample index when needed. r=bryce
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 06 Jun 2018 15:14:24 +0200 - rev 421980
Push 34113 by btara@mozilla.com at Sat, 09 Jun 2018 12:05:46 +0000
Bug 1466606 - P1. Calculate the current GetSample index when needed. r=bryce The assumption that when calling GetNextRandomAccessPoint the next GetSample index would always be known was incorrect. It assumed that the call to GetNextRandomAccessPoint would always be preceded by a call to GetSample. This is not always how the MediaSourceDemuxer called it. MozReview-Commit-ID: H1MyPpDEytk
ffd4b055fb8b33a0ac35c5526d8523e1659c8168: bug 1439383 - clean up the load loadable roots thread when we're done with it r=froydnj,jcj
David Keeler <dkeeler@mozilla.com> - Thu, 07 Jun 2018 15:11:49 -0700 - rev 421979
Push 34113 by btara@mozilla.com at Sat, 09 Jun 2018 12:05:46 +0000
bug 1439383 - clean up the load loadable roots thread when we're done with it r=froydnj,jcj MozReview-Commit-ID: J5GnpwxYguz
6b21d717e213d4d68f6ba285f88da3b0a47296d7: Bug 1467731: Prevent WinVerifyTrust from hitting the network; r=aklotz
Carl Corcoran <ccorcoran@mozilla.com> - Fri, 08 Jun 2018 12:45:09 +0200 - rev 421978
Push 34113 by btara@mozilla.com at Sat, 09 Jun 2018 12:05:46 +0000
Bug 1467731: Prevent WinVerifyTrust from hitting the network; r=aklotz MozReview-Commit-ID: DSpHXsJkeoX
d23cd52cc45bd0b657746386dca8fd77254079fc: Bug 1419297 - Don't clear mCustomElements in FreeInnerObjects. r=smaug
Blake Kaplan <mrbkap@gmail.com> - Thu, 07 Jun 2018 17:02:32 -0700 - rev 421977
Push 34113 by btara@mozilla.com at Sat, 09 Jun 2018 12:05:46 +0000
Bug 1419297 - Don't clear mCustomElements in FreeInnerObjects. r=smaug The cycle collecter should make sure the cycle here gets collected and clearing it causes us to fail a wpt test. MozReview-Commit-ID: 4kL69h0AR9q
2762fef0119bcd3e78d36e78b0b75b5448d35c85: Bug 1419297 - Call document.close, triggering onload and making the test not time out. r=smaug
Blake Kaplan <mrbkap@gmail.com> - Thu, 07 Jun 2018 16:48:51 -0700 - rev 421976
Push 34113 by btara@mozilla.com at Sat, 09 Jun 2018 12:05:46 +0000
Bug 1419297 - Call document.close, triggering onload and making the test not time out. r=smaug This fixes both uses of object-association.js. MozReview-Commit-ID: 8Fj7dC1c3U2
a3a7ac1e38f6f6e7bf0f15b6ec5d32e92c1ded87: Bug 1432934: Added sanity check for recvonly attribute. r=bwc
Johannes Willbold <j.willbold@mozilla.com> - Mon, 04 Jun 2018 14:07:28 -0700 - rev 421975
Push 34113 by btara@mozilla.com at Sat, 09 Jun 2018 12:05:46 +0000
Bug 1432934: Added sanity check for recvonly attribute. r=bwc Added a sanity check, that checks for recvonly and whether simulcast defines send options MozReview-Commit-ID: Hi5U9ZZVKY8
6ea838e51bf74679ea5bcf5ab462c08a71df75ca: Bug 1404909 - Improve performance of moving bookmarks via cut/paste or drag/drop by providing a bulk-move handling API. r=mak
Mark Banner <standard8@mozilla.com> - Tue, 24 Apr 2018 16:38:16 +0100 - rev 421974
Push 34113 by btara@mozilla.com at Sat, 09 Jun 2018 12:05:46 +0000
Bug 1404909 - Improve performance of moving bookmarks via cut/paste or drag/drop by providing a bulk-move handling API. r=mak The moveBookmark implementation is largely a simplification of the updateBookmark but with a focus on optimising for moves, and handling multiple-move cases. The performance improvements come from only having one places wrapper, and one database transaction, rather than one-per-item to be moved. There's also some minor optimisations in the flow, as it can be simplified compared to a full update. MozReview-Commit-ID: 5So28A7Dcpp
6e8579d91075af8245af42f26beb7de23997e934: Backed out changeset a5e6f8d6747c (bug 1466857) for browser-chrome failures on /browser_UpdatePingSuccess.js . CLOSED TREE
Narcis Beleuzu <nbeleuzu@mozilla.com> - Fri, 08 Jun 2018 21:23:05 +0300 - rev 421973
Push 34113 by btara@mozilla.com at Sat, 09 Jun 2018 12:05:46 +0000
Backed out changeset a5e6f8d6747c (bug 1466857) for browser-chrome failures on /browser_UpdatePingSuccess.js . CLOSED TREE
4bc90c7b3b4b595b7ff37502b589006c1bfc87dc: Bug 1465250 - Make contain:paint trigger clipping independent of the overflow property. r=mattwoodrow
Yusuf Sermet <ysermet@mozilla.com> - Wed, 30 May 2018 14:28:53 -0700 - rev 421972
Push 34113 by btara@mozilla.com at Sat, 09 Jun 2018 12:05:46 +0000
Bug 1465250 - Make contain:paint trigger clipping independent of the overflow property. r=mattwoodrow MozReview-Commit-ID: 2QbfZD1jnWX
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip