17896e16e10b4bc4643a76b7f7ff625a64d0b216: Bug 1483062 - Trivial comment fixes. r=me
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 16 Aug 2018 09:45:44 +1000 - rev 431947
Push 34456 by toros@mozilla.com at Thu, 16 Aug 2018 21:33:21 +0000
Bug 1483062 - Trivial comment fixes. r=me
da46bfc2c089ad5e79bd9387850adc37240f26cb: Bug 1483062 - Inline and remove HashTable::{over,under}loaded(). r=luke
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 16 Aug 2018 09:10:17 +1000 - rev 431946
Push 34456 by toros@mozilla.com at Thu, 16 Aug 2018 21:33:21 +0000
Bug 1483062 - Inline and remove HashTable::{over,under}loaded(). r=luke Because they each only have a single call site, and the "too many items removed?" test is already encapsulated within rehashIfOverloaded().
ca2edc3b4c1ab044694e836f3da6963c929bcf35: Bug 1483062 - Merge HashTable::wouldBeUnderloaded() into underloaded(). r=luke
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 15 Aug 2018 11:11:13 +1000 - rev 431945
Push 34456 by toros@mozilla.com at Thu, 16 Aug 2018 21:33:21 +0000
Bug 1483062 - Merge HashTable::wouldBeUnderloaded() into underloaded(). r=luke
a3bf3a494b0b7c2817e3f6f3daa9cf4ec7624435: Bug 1483062 - Inline and remove HashTable::overRemoved(). r=luke
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 15 Aug 2018 11:10:56 +1000 - rev 431944
Push 34456 by toros@mozilla.com at Thu, 16 Aug 2018 21:33:21 +0000
Bug 1483062 - Inline and remove HashTable::overRemoved(). r=luke
2d9e3360e858f6c502ae9728280efb0f12daa7e4: Bug 1483062 - Rename HashTable::rehashIfOverRemoved(). r=luke
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 14 Aug 2018 11:56:55 +1000 - rev 431943
Push 34456 by toros@mozilla.com at Thu, 16 Aug 2018 21:33:21 +0000
Bug 1483062 - Rename HashTable::rehashIfOverRemoved(). r=luke infallibleRehashIfOverloaded() actually matches what it does. Also, the patch removes the `overloaded()` test within the function, because `rehashIfOverloaded()` has the same test.
43e351bda401e80292efbde947e56d1893b95903: Bug 1483062 - Rename some HashTable methods. r=luke
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 14 Aug 2018 11:19:39 +1000 - rev 431942
Push 34456 by toros@mozilla.com at Thu, 16 Aug 2018 21:33:21 +0000
Bug 1483062 - Rename some HashTable methods. r=luke Specifically: - checkOverloaded -> rehashIfOverloaded - checkUnderloaded -> shrinkIfUnderloaded - checkOverRemoved -> rehashIfOverRemoved Because I've always found that the `check` prefix doesn't clearly explain that the table might be changed, And: - shouldCompressTable -> overRemoved Because that matches `overloaded` and `underloaded`.
f1e1cf1d42ec20c547a46cee30163a0b41fa36f4: Bug 1483062 - Rename HashTable::findFreeEntry() as findNonLiveEntry(). r=luke
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 14 Aug 2018 09:36:00 +1000 - rev 431941
Push 34456 by toros@mozilla.com at Thu, 16 Aug 2018 21:33:21 +0000
Bug 1483062 - Rename HashTable::findFreeEntry() as findNonLiveEntry(). r=luke Because that's a more accurate description of what it does -- it finds free *and* removed entries.
e483b91eafbced7dd6636139cea44240a511bb5e: Bug 1483062 - Remove HashTable::maybeCreateTable. r=luke
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 09 Aug 2018 14:19:49 +1000 - rev 431940
Push 34456 by toros@mozilla.com at Thu, 16 Aug 2018 21:33:21 +0000
Bug 1483062 - Remove HashTable::maybeCreateTable. r=luke It's dead.
417967cf69de08d624ccbc85886ce8f0e224fdd4: Bug 1482020 - Make all callers of CreateElementWithDefaults() use non-virtual method r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 10 Aug 2018 19:36:24 +0900 - rev 431939
Push 34456 by toros@mozilla.com at Thu, 16 Aug 2018 21:33:21 +0000
Bug 1482020 - Make all callers of CreateElementWithDefaults() use non-virtual method r=m_kato Fortunately, despite of becoming public method, HTMLEditor::CreateElementWithDefaults() can be used by internal methods too since it does not touch undo transactions nor the DOM tree, and does not refer mRules nor GetSelection(). So, we can make it public and make any C++ callers use it.
5a77e82d273ef9dec5752614f0bb4fd35bca45d2: Bug 1480872 - paymentDetails attributes should default to an empty arrays. r=edenchuang
Marcos Cáceres <marcos@marcosc.com> - Mon, 13 Aug 2018 17:45:00 +0300 - rev 431938
Push 34456 by toros@mozilla.com at Thu, 16 Aug 2018 21:33:21 +0000
Bug 1480872 - paymentDetails attributes should default to an empty arrays. r=edenchuang
bf74fe0e7f76709fe091813345aa9d0bb25cf154: Merge autoland to mozilla-central. a=merge
Tiberius Oros <toros@mozilla.com> - Fri, 17 Aug 2018 00:31:31 +0300 - rev 431937
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Merge autoland to mozilla-central. a=merge
2b5fc64beafb876827e00921db1bd4112b13b7f5: Bug 1483527: Change fieldset block-end & inline-axis padding to match other browsers. r=emilio
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 16 Aug 2018 18:26:39 +0000 - rev 431936
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1483527: Change fieldset block-end & inline-axis padding to match other browsers. r=emilio This mirrors the web-platform-tests change at https://github.com/whatwg/html/commit/6058e914c1077c7215a63ab658745fa096b1d35c According to that commit, WebKit/Chromium/EdgeHTML all have the behavior that we're switching to here. Differential Revision: https://phabricator.services.mozilla.com/D3429
f35fa6e7fb463ce848beb3df1550a12089527974: Bug 1480292 - Fix browser_ext_popup_select intermittent failures. r=mixedpuppy
Luca Greco <lgreco@mozilla.com> - Thu, 16 Aug 2018 13:19:03 +0000 - rev 431935
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1480292 - Fix browser_ext_popup_select intermittent failures. r=mixedpuppy From what I saw by reproducing it locally (e.g. I've also been able to trigger it locally pretty often on linux64 by using "./mach mochitest --verify"), the select popup may sometimes be still using part of its previous position while switching between the test case for the browserAction and the test case for the pageAction. On linux64 this test was also (from time to time) sending the mouse event when the select element wasn't yet ready to be clicked in the extension popup. This patch aims to make the behaviors of this test more stable by applying the following changes: - disable the cosmeticAnimations while running these tests - explicitly wait the select element in the popup (using ContentTask.spawn and ContentTaskUtils.waitForCondition) before sending it a mouse event - explicilty close the select popup (and wait the select popup to be hidden) before proceeding to the next test case The following push to try seems to confirm that these changes are helping to make the test more stable: - https://treeherder.mozilla.org/#/jobs?repo=try&revision=086c526724ba409068d679036dd3ef13788535b6&selectedJob=194152144 Differential Revision: https://phabricator.services.mozilla.com/D3438
dbf1387f8b3603fb0f57898724853c35047c63a0: Backed out 1 changesets (bug 1483527) for fieldset reftest failures CLOSED TREE
Ciure Andrei <aciure@mozilla.com> - Thu, 16 Aug 2018 21:04:03 +0300 - rev 431934
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Backed out 1 changesets (bug 1483527) for fieldset reftest failures CLOSED TREE Backed out changeset 3d98e379dc38 (bug 1483527)
8bc5f3cdc25cb9754817ad75d9fa4e158f94042a: Bug 1414084 - Part 17 - Fix setting of private browsing theme state. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 02 Mar 2018 18:01:28 +0100 - rev 431933
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 17 - Fix setting of private browsing theme state. r=Grisha Previously, this wasn't noticeable since adding/removing a PageAction would call refreshPageActionIcons(), which would do the correct thing, but now a newly created PageActionLayout can start with an already pre-populated mPageAction- List, which means that the subsequently arriving call to setPrivateMode() will erroneously activate the private mode tinting for all PageActions that support it. MozReview-Commit-ID: EvNx1Q9vwZ5
f565a28721bf3a0ea5af7ce5ced737d82c7e8803: Bug 1414084 - Part 16 - Add some tests for the handling of PageActions. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 19 Mar 2018 20:27:01 +0100 - rev 431932
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 16 - Add some tests for the handling of PageActions. r=Grisha MozReview-Commit-ID: EUl19vyK3Ra
c2580679282dae363a4ad1ce6f0c477ce00fc212: Bug 1414084 - Part 15 - Correctly remove already resolved PageActions, too. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 03 Mar 2018 18:11:57 +0100 - rev 431931
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 15 - Correctly remove already resolved PageActions, too. r=Grisha When a PageActions:Remove message arrives and we cannot simply forward it, we need to remove not just pending PageActions:Add messages, but also any already present PageActions objects that a former PageActionLayout had handed to us. MozReview-Commit-ID: 3jnGsmMuVfa
e8d7b4fd98387380219b879f8a8b211bb87095c7: Bug 1414084 - Part 14 - Rename isPwaAdded for more clarity. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 20:39:00 +0100 - rev 431930
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 14 - Rename isPwaAdded for more clarity. r=Grisha Despite its name and the original purpose for which it was added, that function generically checks for duplicates among all PageActions, not just the PWA badge. MozReview-Commit-ID: Ae6FsLb9F3S
a40e70bbfe1a544d577c10248251628c134f6b80: Bug 1414084 - Part 13 - Cache PageActions. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 26 Feb 2018 21:50:50 +0100 - rev 431929
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 13 - Cache PageActions. r=Grisha Since converting a PageAction message into an actual PageAction object also en- tails parsing the image data URL into a drawable, we leave that task to the PageActionLayout. This means that the PageAction cache needs to operate slightly differently than the MenuItem cache. First, we store all PageAction BundleEvent messages that arrive while no PageActionLayout is ready and then forward them en masse when one becomes available. Secondly, if the PageActionLayout is going away again, we then also take a list of already parsed PageAction objects for safekeeping. MozReview-Commit-ID: AcPPONXqe46
3dcf1f67d7e476803f0d1daacdf7e1999f7e8724: Bug 1414084 - Part 12 - Add some tests for the processing of Menu messages. r=Grisha
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 19 Mar 2018 20:06:32 +0100 - rev 431928
Push 34455 by toros@mozilla.com at Thu, 16 Aug 2018 21:31:58 +0000
Bug 1414084 - Part 12 - Add some tests for the processing of Menu messages. r=Grisha MozReview-Commit-ID: D8Aujo1PgIk
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip