1427b2fca8d7453a4f46be04981db274dd6abe36: Bug 1423835 - part 1: Add EditorDOMPointBase::SetToEndOf() to initialize the instance at end of container node r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 07 Dec 2017 17:27:20 +0900 - rev 395953
Push 33061 by aciure@mozilla.com at Sun, 10 Dec 2017 09:53:10 +0000
Bug 1423835 - part 1: Add EditorDOMPointBase::SetToEndOf() to initialize the instance at end of container node r=m_kato Editor code sometimes sets a DOM point to end of a node. In this case, we need to write |Set(node, node->Length())|. So, it should have |void SetToEndOf(const nsINode* aContainer)| for making meaning of the code clearer. MozReview-Commit-ID: 91shMCD2d84
ec4df7b61cce17758ac02acc834a4e8c7dbc0767: Bug 1423097 - part 3: Fix new orange caused by an existing bug of EditorBase::DeleteSelectionAndCreateElement() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 07 Dec 2017 13:57:35 +0900 - rev 395952
Push 33061 by aciure@mozilla.com at Sun, 10 Dec 2017 09:53:10 +0000
Bug 1423097 - part 3: Fix new orange caused by an existing bug of EditorBase::DeleteSelectionAndCreateElement() r=m_kato Even after EditorBase::DeleteSelectionAndCreateElement() creates a new element, it tries to collapse selection with |pointToInsert| which is outdated after inserting new element. So, it should recompute the caret position with new DOM tree. MozReview-Commit-ID: DKh2uhItIol
b9b64291ad9491c01df3d2ce6987951cdd226431: Bug 1423097 - part 2: Add overloads of nsRange::SetStart(), nsRange::SetEnd(), nsRange::IsPointInRange() and nsRange::ComparePoint() to use them with RawRangeBoundary r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 05 Dec 2017 17:50:13 +0900 - rev 395951
Push 33061 by aciure@mozilla.com at Sun, 10 Dec 2017 09:53:10 +0000
Bug 1423097 - part 2: Add overloads of nsRange::SetStart(), nsRange::SetEnd(), nsRange::IsPointInRange() and nsRange::ComparePoint() to use them with RawRangeBoundary r=smaug nsRange::SetStart(), nsRange::SetEnd(), nsRange::IsPointInRange() and nsRange::ComparePoint() take a set of container node and offset in it to specifying a DOM point. However, the caller may not have computed the offset but may know the child node at the point. In such case, they can avoid computing the offset with nsINode::IndexOf() if they have overloads which take RawRangeBoundary. Therefore, this patch implements the overloads and changes the callers in editor. MozReview-Commit-ID: E4DLbAgTTCI
2c1ad12ab12bd20e1378f1fa337f89ad62489691: Bug 1423097 - part 1: Implement Selection::AnchorRef() and Selection::FocusRef() r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 05 Dec 2017 16:36:57 +0900 - rev 395950
Push 33061 by aciure@mozilla.com at Sun, 10 Dec 2017 09:53:10 +0000
Bug 1423097 - part 1: Implement Selection::AnchorRef() and Selection::FocusRef() r=smaug Some methods of editor retrieves anchor and focus of selection. However, there are no methods which directly access RangeBoundary of anchor and focus. This patch adds it for making editor code simpler and avoiding unnecessary child offset computation. MozReview-Commit-ID: EvepQpFMi8S
3b2fc3875b516ea82ff90a3c11294538b0aa2555: Bug 1408125 - part 5: Redesign HTMLEditor::NormalizeEOLInsertPosition() with EditorRawDOMPoint r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 05 Dec 2017 15:36:49 +0900 - rev 395949
Push 33061 by aciure@mozilla.com at Sun, 10 Dec 2017 09:53:10 +0000
Bug 1408125 - part 5: Redesign HTMLEditor::NormalizeEOLInsertPosition() with EditorRawDOMPoint r=m_kato HTMLEditor::NormalizeEOLInsertPosition() takes a set of container node and offset in it for specifying insertion point. So, this should be replaced with |const EditorRawDOMPoint&| and it should return |EditorDOMPoint| rather than modifying the argument. Additionally, perhaps, GetBetterInsertionPointFor() is better name for it. MozReview-Commit-ID: IB1FhrkzK2G
a2d28cf0e5acec789b7ba42e456ef2aa2269761d: Bug 1408125 - part 4: Redesign HTMLEditor::InsertNodeAtPoint() with EditorRawDOMPoint r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 28 Nov 2017 22:28:07 +0900 - rev 395948
Push 33061 by aciure@mozilla.com at Sun, 10 Dec 2017 09:53:10 +0000
Bug 1408125 - part 4: Redesign HTMLEditor::InsertNodeAtPoint() with EditorRawDOMPoint r=m_kato HTMLEditor::InsertNodeAtPoint() should take |const EditorRawDOMPoint&| as an argument which specifies point to insert. Additionally, it should take |EditorDOMPoint*| to return the next point of actual insertion point. Additionally, this patch renames it to InsertNodeAtProperAncestor() for explaining what it will do. MozReview-Commit-ID: HYUzSlyPxAd
019dac777e99ec644419c1d13af67f3c752d8f2d: Bug 1408125 - part 3: Redesign nsIEditActionListener::(Will|Did)InsertNode() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 28 Nov 2017 21:26:10 +0900 - rev 395947
Push 33061 by aciure@mozilla.com at Sun, 10 Dec 2017 09:53:10 +0000
Bug 1408125 - part 3: Redesign nsIEditActionListener::(Will|Did)InsertNode() r=m_kato Although nsIEditActionListener::WillInsertNode() nobody implements actually, we should remove it in a follow up bug. nsIEditActionListener::DidInsertNode() is implemented only by HTMLEditRules. So, if we make it not use nsIEditActionListener, we can remove it too. However, keep it for now. On the other hand, they don't need to receive index of the insertion point. WillInsertNode() needs next sibling of the insert point, but DidInsertNode() needs nothing because listener can compute it with new inserted node. MozReview-Commit-ID: GiTKkVyZJlN
7a72eb2626425069bd4ac9fa69804ec3d046d70f: Bug 1408125 - part 2: EditorBase::CreateTxnForInsertNode() and EditorBase::InsertNode() should take |const EditorRawDOMPoint&| as an argument specifying point to insert r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 22 Nov 2017 21:25:05 +0900 - rev 395946
Push 33061 by aciure@mozilla.com at Sun, 10 Dec 2017 09:53:10 +0000
Bug 1408125 - part 2: EditorBase::CreateTxnForInsertNode() and EditorBase::InsertNode() should take |const EditorRawDOMPoint&| as an argument specifying point to insert r=m_kato EditorBase::CreateTxnForInsertNode() and EditorBase::InsertNode() should take |const EditorRawDOMPoint&| as an argument specifying point to insert. MozReview-Commit-ID: KhK19xS7wXb
86e780efd838a27c5eb4ab9d1ca161e37b52d783: Bug 1408125 - part 1: Make InsertNodeTransaction use EditorRawDOMPoint and RangeBoundary instead of pair of container node and offset in it r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 22 Nov 2017 17:29:22 +0900 - rev 395945
Push 33061 by aciure@mozilla.com at Sun, 10 Dec 2017 09:53:10 +0000
Bug 1408125 - part 1: Make InsertNodeTransaction use EditorRawDOMPoint and RangeBoundary instead of pair of container node and offset in it r=m_kato Like CreateNodeTransaction, InsertNodeTransaction should use EditorRawDOMPoint for temporary variable and arguments of its methods and should use RangeBoudary to store it as its member. MozReview-Commit-ID: FCGY8x97egb
0af5308b7c76e503d1bcb6e6f8fda176461e76ae: Bug 1423122 - Use the correct selection object in the getSelectionInfo when an input element is selected r=Felipe
Thom Chiovoloni <tchiovoloni@mozilla.com> - Wed, 06 Dec 2017 15:27:46 -0500 - rev 395944
Push 33061 by aciure@mozilla.com at Sun, 10 Dec 2017 09:53:10 +0000
Bug 1423122 - Use the correct selection object in the getSelectionInfo when an input element is selected r=Felipe MozReview-Commit-ID: L8nANaiYfyc
d1a257223f9039fdb1ea8e5ef63ad60f1574c8ea: servo: Merge #19536 - style: Move the code to parse a list of compound selectors (from emilio:compound-selector-list); r=mbrubeck
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 09 Dec 2017 17:15:14 -0600 - rev 395943
Push 33061 by aciure@mozilla.com at Sun, 10 Dec 2017 09:53:10 +0000
servo: Merge #19536 - style: Move the code to parse a list of compound selectors (from emilio:compound-selector-list); r=mbrubeck I'll need this for ::slotted(). Source-Repo: https://github.com/servo/servo Source-Revision: c6bf85eca90b9cb71ff05d4454a43a7da5fc3ac8
e7cb0e4afac53aa8a24b5e98ac1b429633c72887: servo: Merge #19533 - style: Remove unused SelectorImpl::pseudo_element_cascade_type (from emilio:unused-code-should-die); r=emilio
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 09 Dec 2017 15:27:49 -0600 - rev 395942
Push 33061 by aciure@mozilla.com at Sun, 10 Dec 2017 09:53:10 +0000
servo: Merge #19533 - style: Remove unused SelectorImpl::pseudo_element_cascade_type (from emilio:unused-code-should-die); r=emilio Source-Repo: https://github.com/servo/servo Source-Revision: 95520ca39c4dde7296584227d49d70615dda0bf0
083f444180094f009a9442c59806f9b151c64281: servo: Merge #19538 - Use ? in Option more often (from emilio:questions-questions-questions); r=mbrubeck
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 09 Dec 2017 13:58:25 -0600 - rev 395941
Push 33061 by aciure@mozilla.com at Sun, 10 Dec 2017 09:53:10 +0000
servo: Merge #19538 - Use ? in Option more often (from emilio:questions-questions-questions); r=mbrubeck Source-Repo: https://github.com/servo/servo Source-Revision: 548028fd07d85dbbbd0511386f88ea19825dc258
9d0c1d058307e1cc4e931da7049cbee9d056e310: merge mozilla-central to autoland. r=merge a=merge
Sebastian Hengst <archaeopteryx@coole-files.de> - Sat, 09 Dec 2017 23:09:49 +0200 - rev 395940
Push 33061 by aciure@mozilla.com at Sun, 10 Dec 2017 09:53:10 +0000
merge mozilla-central to autoland. r=merge a=merge
03975fa2422ae2b9ebc0455e47cbdb708611a15f: Merge mozilla-central to autoland. r=merge a=merge on a CLOSED TREE
Andreea Pavel <apavel@mozilla.com> - Sat, 09 Dec 2017 22:26:08 +0200 - rev 395939
Push 33061 by aciure@mozilla.com at Sun, 10 Dec 2017 09:53:10 +0000
Merge mozilla-central to autoland. r=merge a=merge on a CLOSED TREE
ccda2a6f947758e100a26f7226340d08bca4654f: servo: Merge #19537 - style: Use the ? operator for Option (from mbrubeck:try); r=nox
Matt Brubeck <mbrubeck@limpet.net> - Sat, 09 Dec 2017 10:50:55 -0600 - rev 395938
Push 33061 by aciure@mozilla.com at Sun, 10 Dec 2017 09:53:10 +0000
servo: Merge #19537 - style: Use the ? operator for Option (from mbrubeck:try); r=nox This is stable in Rust 1.22 (#19532). --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because it is refactoring only Source-Repo: https://github.com/servo/servo Source-Revision: 5f4f355cea4a24992ac9efa97f4a6e1837008e0b
28a4a342ac597ea12691c5c642be0f78be3c8632: servo: Merge #19534 - style: Simplify naming and signatures of single-colon pseudo stuff (from emilio:naming-is-a-bit-hard-but-not-that-hard); r=nox
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 09 Dec 2017 09:52:27 -0600 - rev 395937
Push 33061 by aciure@mozilla.com at Sun, 10 Dec 2017 09:53:10 +0000
servo: Merge #19534 - style: Simplify naming and signatures of single-colon pseudo stuff (from emilio:naming-is-a-bit-hard-but-not-that-hard); r=nox Also drop a few FIXMEs while at it, since they look bogus. Source-Repo: https://github.com/servo/servo Source-Revision: 051eb6bcb9204ecab1c1481a275a09fd50bf0467
3a33e3beb0cd41e0080a63f153a24e0230033578: Backout revived test file of bug 1423626. r=merge-fix a=merge-fix
Sebastian Hengst <archaeopteryx@coole-files.de> - Sat, 09 Dec 2017 23:08:03 +0200 - rev 395936
Push 33060 by archaeopteryx@coole-files.de at Sat, 09 Dec 2017 21:08:55 +0000
Backout revived test file of bug 1423626. r=merge-fix a=merge-fix
7a79d93a146a7210ad6f61d3f86b57240604ed99: Merge inbound to mozilla-central r=merge a=merge
Andreea Pavel <apavel@mozilla.com> - Sat, 09 Dec 2017 22:21:17 +0200 - rev 395935
Push 33059 by apavel@mozilla.com at Sat, 09 Dec 2017 20:22:52 +0000
Merge inbound to mozilla-central r=merge a=merge
630a91d55d86cc667a653c4b61945fc010a2c9b4: Bug 1423798 - Remove headers included for backwards compat in nsString.h. r=njn on a CLOSED TREE
Eric Rahm <erahm@mozilla.com> - Wed, 06 Dec 2017 19:36:57 -0800 - rev 395934
Push 33059 by apavel@mozilla.com at Sat, 09 Dec 2017 20:22:52 +0000
Bug 1423798 - Remove headers included for backwards compat in nsString.h. r=njn on a CLOSED TREE Remove the headers included for "backwards compatibility" and just include them where required.
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip