1156ef220859015269bff058a3db9f6183bf347f: Bug 1466031 - Add spec links to test files; r=hiro
Brian Birtles <birtles@gmail.com> - Mon, 04 Jun 2018 10:20:58 +0900 - rev 421162
Push 34089 by dluca@mozilla.com at Mon, 04 Jun 2018 18:11:55 +0000
Bug 1466031 - Add spec links to test files; r=hiro
4a4aafa588f86050dadc4ea7644639e4ac547461: Bug 1466031 - Move CSS animations / Web animation integration tests to web-platform-tests; r=hiro
Brian Birtles <birtles@gmail.com> - Mon, 04 Jun 2018 10:20:58 +0900 - rev 421161
Push 34089 by dluca@mozilla.com at Mon, 04 Jun 2018 18:11:55 +0000
Bug 1466031 - Move CSS animations / Web animation integration tests to web-platform-tests; r=hiro
e7fb7955c589cb038713614b3357ecfeb50c70aa: Bug 1466031 - Update test_setting-effect.html; r=hiro
Brian Birtles <birtles@gmail.com> - Mon, 04 Jun 2018 10:20:57 +0900 - rev 421160
Push 34089 by dluca@mozilla.com at Mon, 04 Jun 2018 18:11:55 +0000
Bug 1466031 - Update test_setting-effect.html; r=hiro Apart from whitespace / test description tests this patch also drops an assertion about the animation playState since it seems unrelated to the purpose of that particular test.
31b0c91a0237f593c5911325936eff589d43d204: Bug 1466031 - Update test description in test_pseudoElement-get-animations.html; r=hiro
Brian Birtles <birtles@gmail.com> - Mon, 04 Jun 2018 10:20:57 +0900 - rev 421159
Push 34089 by dluca@mozilla.com at Mon, 04 Jun 2018 18:11:55 +0000
Bug 1466031 - Update test description in test_pseudoElement-get-animations.html; r=hiro
2181d4e46ec87b1700cd4c56620fbe3f9f298b11: Bug 1466031 - Update test_element-get-animations.html; r=hiro
Brian Birtles <birtles@gmail.com> - Mon, 04 Jun 2018 10:20:57 +0900 - rev 421158
Push 34089 by dluca@mozilla.com at Mon, 04 Jun 2018 18:11:55 +0000
Bug 1466031 - Update test_element-get-animations.html; r=hiro As well as addressing a few FIXMEs this patch drops the checking of start times since that seems out of scope for this file and is covered elsewhere (I believe we only added it at first to bootstrap this work).
93a6b929c042e12a351f788f4cff7a7a1fc969d5: Bug 1466031 - Update test_animations-dynamic-changes.html; r=hiro
Brian Birtles <birtles@gmail.com> - Mon, 04 Jun 2018 10:20:57 +0900 - rev 421157
Push 34089 by dluca@mozilla.com at Mon, 04 Jun 2018 18:11:55 +0000
Bug 1466031 - Update test_animations-dynamic-changes.html; r=hiro
bfe96f889a3bf706cba047baadbbd67fdd6a6414: Bug 1466031 - Update test_animation-starttime.html; r=hiro
Brian Birtles <birtles@gmail.com> - Mon, 04 Jun 2018 10:20:57 +0900 - rev 421156
Push 34089 by dluca@mozilla.com at Mon, 04 Jun 2018 18:11:55 +0000
Bug 1466031 - Update test_animation-starttime.html; r=hiro This patch updates the tests in this file as follows: * startTime of a newly created (play-pending) animation is unresolved -> Covered by 'startTime of a play-pending animation is unresolved' in wpt/web-animations/interfaces/Animation/startTime.html However, it would be useful to have a test a new CSS animation is play-pending so I have extended the test in test_animation-playstate.html to cover this. * startTime of a newly created (pause-pending) animation is unresolved -> Covered by 'startTime of a pause-pending animation is unresolved' in wpt/web-animations/interfaces/Animation/startTime.html * startTime is resolved when running -> Covered by 'startTime is resolved when running' in wpt/web-animations/interfaces/Animation/startTime.html * startTime is unresolved when paused -> Moved to wpt/web-animations/timing-model/animations/pausing-an-animation.html * startTime while pause-pending and play-pending -> Moved to wpt/web-animations/timing-model/animations/pausing-an-animation.html * startTime while play-pending from finished state, startTime while play-pending from finished state using finish() -> Merged and moved to wpt/web-animations/timing-model/animations/playing-an-animation.html * Pausing should make the startTime become null -> Simplified and merged into the test for 'startTime is unresolved when paused' / 'Pausing clears the start time' test in wpt/web-animations/timing-model/animations/pausing-an-animation.html * Sanity test to check round-tripping assigning to a new animation's startTime -> Updated and left. * Skipping forward through animation -> This is really testing two things: (a) That you can seek a CSS animation using the start time. For this it makes sense to have a separate test that also checks that the computed style is updated (like we have for current time). (b) That seeking a CSS animation using the start time triggers dispatching events. This patch splits the above into two separate tests. * Skipping backwards through animation, Redundant change, before -> active, then back, Redundant change, before -> after, then back, Redundant change, active -> before, then back, Redundant change, active -> after, then back, Redundant change, after -> before, then back, Redundant change, after -> active, then back -> All these tests are really just exercising event dispatch which is already covered by test_event-dispatch.html. Provided we have a test that checks that events are dispatched when setting the startTime we don't need to test each combination again since we have tests for each of these combinations already when using the currentTime to seek and we can assume UAs are following the same code path at this point. As a result this patch drops these tests. * Setting startTime to null -> Covered by 'Setting an unresolved start time sets the hold time' in wpt/web-animations/timing-model/animations/setting-the-start-time-of-an-animation.html * Animation.startTime after pausing -> Covered by the new 'Pausing clears the start time' test in wpt/web-animations/timing-model/animations/pausing-an-animation.html * Animation.startTime after canceling -> Merged into wpt/web-animations/timing-model/animations/canceling-an-animation.html and made it follow the spec a little more closely (which requires clearing the start time and hold time).
357a5f2a456bd31c83ae54933dec03ae6af0a12d: Bug 1466031 - Move the reversing test to Web Animations web-platform-tests; r=hiro
Brian Birtles <birtles@gmail.com> - Mon, 04 Jun 2018 10:20:56 +0900 - rev 421155
Push 34089 by dluca@mozilla.com at Mon, 04 Jun 2018 18:11:55 +0000
Bug 1466031 - Move the reversing test to Web Animations web-platform-tests; r=hiro
225a32bacfbc737e9934ba301fc447ce58e500c8: Bug 1466031 - Tidy up test_animation-ready.html; r=hiro
Brian Birtles <birtles@gmail.com> - Mon, 04 Jun 2018 10:20:56 +0900 - rev 421154
Push 34089 by dluca@mozilla.com at Mon, 04 Jun 2018 18:11:55 +0000
Bug 1466031 - Tidy up test_animation-ready.html; r=hiro Although many of these tests are similar to tests in the Web Animations web-platform-tests test suite they focus on the interaction with animation-play-state and so are probably worth keeping. There are two exceptions that I felt were worth changing: * The test for the handling of a ready promise on an aborted pause. I could not find a similar test in the Web Animations wpt and the test is not really particular to CSS animations so this patch moves it to Web Animations wpt. * The test for the resolution value of the ready promise for a paused animation is covered by the "A pending ready promise should be resolved and not replaced when the animation is paused" in pausing-an-animation.html in the Web Animations wpt (although peripherally) and that seems like the better place for this test anyway (it is not specific to CSS animations) so I have simply deleted it from this file.
4f526a64e149c4c650f7ad54858714689070e6cf: Bug 1466031 - Tidy up test_animations-playstate.html; r=hiro
Brian Birtles <birtles@gmail.com> - Mon, 04 Jun 2018 10:20:56 +0900 - rev 421153
Push 34089 by dluca@mozilla.com at Mon, 04 Jun 2018 18:11:55 +0000
Bug 1466031 - Tidy up test_animations-playstate.html; r=hiro
43b6a75465244fe6c9e9cddf7aad2c6d6d833181: Bug 1466031 - Tweak whitespace in test_animation-id.html; r=hiro
Brian Birtles <birtles@gmail.com> - Mon, 04 Jun 2018 10:20:55 +0900 - rev 421152
Push 34089 by dluca@mozilla.com at Mon, 04 Jun 2018 18:11:55 +0000
Bug 1466031 - Tweak whitespace in test_animation-id.html; r=hiro This just makes the grouping a little more clear I think.
865062de80fb7f7beb5c74fef93b0412147d090c: Bug 1466031 - Tidy up test_animation-finished.html; r=hiro
Brian Birtles <birtles@gmail.com> - Mon, 04 Jun 2018 10:20:55 +0900 - rev 421151
Push 34089 by dluca@mozilla.com at Mon, 04 Jun 2018 18:11:55 +0000
Bug 1466031 - Tidy up test_animation-finished.html; r=hiro This mostly just involves using promise_rejects to simplify some test code. The change to the test description of the last test might seem like it is giving it the opposite meaning but the original test name was "Test finished promise changes when animationPlayState set to running"[1], and it is about testing that there are NO changes but that got lost when the "Test" part of the description was dropped. [1] https://searchfox.org/mozilla-central/rev/cb846d13d3f9ec5d38ace93a74f749a18e9c67f5/dom/animation/test/css-animations/test_animation-player-finished.html#287
c8dd07176c5c38e69d363c6266febc9b864f5634: Bug 1466031 - Drop test_animation-finish.html; r=hiro
Brian Birtles <birtles@gmail.com> - Mon, 04 Jun 2018 10:20:55 +0900 - rev 421150
Push 34089 by dluca@mozilla.com at Mon, 04 Jun 2018 18:11:55 +0000
Bug 1466031 - Drop test_animation-finish.html; r=hiro These tests are all covered elsewhere: * The "Test exceptions when finishing infinite animation" test is covered by the "Finishing an infinite animation throws" test in finishing-an-animation.html in the Web Animations web-platform-tests. * The "Test finish() while paused" test is covered by the "Finishing a paused animation resolves the start time" test in finishing-an-animation.html in the Web Animations web-platform-tests. * The "Test finish() while pause-pending with positive playbackRate" test is covered by the "Finishing a pause-pending animation resolves the pending task immediately and update the start time" test in finishing-an-animation.html in the Web Animations web-platform-tests. * The 'Test finish() while pause-pending with negative playbackRate" test is covered by the "Finishing a pause-pending animation with negative playback rate resolves the pending task immediately" test in finishing-an-animation.html in the Web Animations web-platform-tests. In fact, it very much looks like these tests were copied to Web Animations' web-platform-tests at some point without deleting the original.
bdf0455bd3ecfc5c79b305cd36db71bff86f099d: Bug 1466031 - Re-arrange tests in test_animations-currenttime.html; r=hiro
Brian Birtles <birtles@gmail.com> - Mon, 04 Jun 2018 10:20:55 +0900 - rev 421149
Push 34089 by dluca@mozilla.com at Mon, 04 Jun 2018 18:11:55 +0000
Bug 1466031 - Re-arrange tests in test_animations-currenttime.html; r=hiro A number of these tests are redundant with other tests or are otherwise unnecessary. Other tests should be moved to a more appropriate file. Some notable examples: * A number of the tests relate to dispatching events in various phases and have been moved to test_event-dispatch.html. * The "Seeking finished -> paused dispatches animationstart" test is covered by the "After -> Active" test in test_event-dispatch.html (which also operates on a paused animation). * The "Animation.currentTime clamping" is really just testing finishing behavior and is covered by the updating-the-finished-state.html tests in the Web Animations web-platform-tests (specifically the "Updating the finished state when playing past end" test). * Likewise for the "Animation.currentTime clamping for reversed animation" test.
89a749ca3580571856d0b339eb486069f8bb27d9: Bug 1466031 - Apply various whitespace tweaks to test_animation-computed-timing.html; r=hiro
Brian Birtles <birtles@gmail.com> - Mon, 04 Jun 2018 10:20:55 +0900 - rev 421148
Push 34089 by dluca@mozilla.com at Mon, 04 Jun 2018 18:11:55 +0000
Bug 1466031 - Apply various whitespace tweaks to test_animation-computed-timing.html; r=hiro
3bba2706455865c58ec1a575539daf1caae147fe: Bug 1466031 - Update the titles of each test file; r=hiro
Brian Birtles <birtles@gmail.com> - Mon, 04 Jun 2018 10:20:55 +0900 - rev 421147
Push 34089 by dluca@mozilla.com at Mon, 04 Jun 2018 18:11:55 +0000
Bug 1466031 - Update the titles of each test file; r=hiro Some of these names will make more sense after the renaming of files towards the end of this patch series. Also a couple of files do not have titles added since they will be subsequently removed.
e4926e77c345206dfc64b2101ca30df7ba76353e: Bug 1466031 - Fix the spelling of canceled/canceling in dom/animation/test/css-animations/; r=hiro
Brian Birtles <birtles@gmail.com> - Mon, 04 Jun 2018 10:20:55 +0900 - rev 421146
Push 34089 by dluca@mozilla.com at Mon, 04 Jun 2018 18:11:55 +0000
Bug 1466031 - Fix the spelling of canceled/canceling in dom/animation/test/css-animations/; r=hiro
2337de0fc6d6aed827feb6495bfa4dbc33140dae: Bug 1466031 - Use for ... of instead of forEach in a few places in dom/animation/test/css-animations/; r=hiro
Brian Birtles <birtles@gmail.com> - Mon, 04 Jun 2018 10:20:54 +0900 - rev 421145
Push 34089 by dluca@mozilla.com at Mon, 04 Jun 2018 18:11:55 +0000
Bug 1466031 - Use for ... of instead of forEach in a few places in dom/animation/test/css-animations/; r=hiro
814a885cf046a3bfb3ac253684b5df1b11b4dc05: Bug 1466031 - Use async/await in dom/animation/test/css-animations/; r=hiro
Brian Birtles <birtles@gmail.com> - Mon, 04 Jun 2018 10:20:54 +0900 - rev 421144
Push 34089 by dluca@mozilla.com at Mon, 04 Jun 2018 18:11:55 +0000
Bug 1466031 - Use async/await in dom/animation/test/css-animations/; r=hiro
34668c9b0d60615e8eab458dfe2a277ec48c03e5: Bug 1466031 - Replace var with const/let in dom/animation/test/css-animations/; r=hiro
Brian Birtles <birtles@gmail.com> - Mon, 04 Jun 2018 10:20:54 +0900 - rev 421143
Push 34089 by dluca@mozilla.com at Mon, 04 Jun 2018 18:11:55 +0000
Bug 1466031 - Replace var with const/let in dom/animation/test/css-animations/; r=hiro
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip