10eb6ec39ef1a34243c212c64047c7097499f8f8: Bug 1416384 - Part 6: Eliminate calls to Assert{Inner,Outer} and As{Inner,Outer} in nsGlobalWindow, r=smaug
Nika Layzell <nika@thelayzells.com> - Wed, 15 Nov 2017 11:34:27 -0500 - rev 392034
Push 32909 by cbrindusan@mozilla.com at Wed, 15 Nov 2017 22:25:14 +0000
Bug 1416384 - Part 6: Eliminate calls to Assert{Inner,Outer} and As{Inner,Outer} in nsGlobalWindow, r=smaug MozReview-Commit-ID: GIiSlDzjgWb
aaed1999291a6622a030f20f5f7469fa59f622e5: Bug 1416384 - Part 5: Eliminate inner window only methods from nsGlobalWindowOuter, r=smaug
Nika Layzell <nika@thelayzells.com> - Wed, 15 Nov 2017 11:34:20 -0500 - rev 392033
Push 32909 by cbrindusan@mozilla.com at Wed, 15 Nov 2017 22:25:14 +0000
Bug 1416384 - Part 5: Eliminate inner window only methods from nsGlobalWindowOuter, r=smaug MozReview-Commit-ID: FzaGKmdDtmy
2d5ba51ff7e36562bb2534ed47e99af3b4e8c98d: Bug 1416384 - Part 4: Eliminate outer window only methods from nsGlobalWindowInner, r=smaug
Nika Layzell <nika@thelayzells.com> - Wed, 15 Nov 2017 11:34:13 -0500 - rev 392032
Push 32909 by cbrindusan@mozilla.com at Wed, 15 Nov 2017 22:25:14 +0000
Bug 1416384 - Part 4: Eliminate outer window only methods from nsGlobalWindowInner, r=smaug MozReview-Commit-ID: CV6rrA0M2ZV
ba47537d18440f8d9df9351d3461d734beb9e867: Bug 1416384 - Part 3: Remove nsPIDOMWindow<nsISupports>, r=smaug
Nika Layzell <nika@thelayzells.com> - Wed, 15 Nov 2017 11:34:04 -0500 - rev 392031
Push 32909 by cbrindusan@mozilla.com at Wed, 15 Nov 2017 22:25:14 +0000
Bug 1416384 - Part 3: Remove nsPIDOMWindow<nsISupports>, r=smaug This was needed before as the base to nsGlobalWindow, but now that nsGlobalWindow doesn't exist, and we only have specific versions, we no longer need this type. MozReview-Commit-ID: 6IJmJtnSkMr
862355bc5c589cc22420526d5bbf10e7f6f7ba78: Bug 1416384 - Part 2e: Eliminate duplicate declarations, and get gecko building again, r=smaug
Nika Layzell <nika@thelayzells.com> - Wed, 15 Nov 2017 11:33:58 -0500 - rev 392030
Push 32909 by cbrindusan@mozilla.com at Wed, 15 Nov 2017 22:25:14 +0000
Bug 1416384 - Part 2e: Eliminate duplicate declarations, and get gecko building again, r=smaug There are many helper methods and structs in nsGlobalWindow.cpp. Many of these are used by only the inner or only the outer window, while some are used by both. In the case of the items used by both, I extracted them into nsGlobalWindow.cpp, which includes nsGlobalWindowInner.cpp and nsGlobalWindowOuter.cpp as the compilation unit entry point. In the case of items used by just one or the other, I removed them from the other file, and deleted the bodies of functions which used them, replacing them, with a MOZ_CRASH. This gets gecko building again, so that we can make further incremental improvements. MozReview-Commit-ID: 8QnJ1PX6TAO
d1fc9865c5574cecc72270dde1822c9344bc137e: Bug 1416384 - Part 2d: Get nsGlobalWindowOuter.cpp building, r=smaug
Nika Layzell <nika@thelayzells.com> - Wed, 15 Nov 2017 11:33:51 -0500 - rev 392029
Push 32909 by cbrindusan@mozilla.com at Wed, 15 Nov 2017 22:25:14 +0000
Bug 1416384 - Part 2d: Get nsGlobalWindowOuter.cpp building, r=smaug MozReview-Commit-ID: 4Yz8hRMZEJC
71a0e504ebd0dd6349a8f16b28f8fac057aa5792: Bug 1416384 - Part 2c: Get nsGlobalWindowInner.cpp building, r=smaug
Nika Layzell <nika@thelayzells.com> - Wed, 15 Nov 2017 11:33:39 -0500 - rev 392028
Push 32909 by cbrindusan@mozilla.com at Wed, 15 Nov 2017 22:25:14 +0000
Bug 1416384 - Part 2c: Get nsGlobalWindowInner.cpp building, r=smaug MozReview-Commit-ID: CmKx5jtvtrT
028e876d02bfabc06e5945d00ee3740fb5af823b: Bug 1416384 - Part 2b: Get split headers building but not linking, r=smaug
Nika Layzell <nika@thelayzells.com> - Wed, 15 Nov 2017 11:33:29 -0500 - rev 392027
Push 32909 by cbrindusan@mozilla.com at Wed, 15 Nov 2017 22:25:14 +0000
Bug 1416384 - Part 2b: Get split headers building but not linking, r=smaug MozReview-Commit-ID: JRvPtQTJqSX
a1b15fe9224ebd2aa5a0e398b31383f3e938ab87: Bug 1416384 - Part 2a: Delete nsGlobalWindow.{h,cpp}, r=smaug
nika@thelayzells.com - Wed, 15 Nov 2017 11:31:37 -0500 - rev 392026
Push 32909 by cbrindusan@mozilla.com at Wed, 15 Nov 2017 22:25:14 +0000
Bug 1416384 - Part 2a: Delete nsGlobalWindow.{h,cpp}, r=smaug
74086caf9463416cbe6630370a2219bb648cf697: Bug 1416384 - Part 1: Copy nsGlobalWindow.{h,cpp} to nsGlobalWindow{Inner,Outer}.{h,cpp}, r=smaug
nika@thelayzells.com - Wed, 15 Nov 2017 11:30:13 -0500 - rev 392025
Push 32909 by cbrindusan@mozilla.com at Wed, 15 Nov 2017 22:25:14 +0000
Bug 1416384 - Part 1: Copy nsGlobalWindow.{h,cpp} to nsGlobalWindow{Inner,Outer}.{h,cpp}, r=smaug
f46e5a93d51054d20f4fd9ce4ec583ce4477cca5: Bug 1415741. Switch to a different env var, not MOZ_DEBUG, for disabling mouse event taps on Mac. r=mstange
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 15 Nov 2017 12:23:58 -0500 - rev 392024
Push 32909 by cbrindusan@mozilla.com at Wed, 15 Nov 2017 22:25:14 +0000
Bug 1415741. Switch to a different env var, not MOZ_DEBUG, for disabling mouse event taps on Mac. r=mstange MozReview-Commit-ID: BgFpmE2Juom
3b3a7055f264a102dbaa41b9e361efe3d1bfe7cc: Bug 691151. Remove Event.getPreventDefault. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 15 Nov 2017 12:23:58 -0500 - rev 392023
Push 32909 by cbrindusan@mozilla.com at Wed, 15 Nov 2017 22:25:14 +0000
Bug 691151. Remove Event.getPreventDefault. r=smaug MozReview-Commit-ID: FQ3LzP7rW6e
5b3b0a38b2d1827f4fc9af6f32e9fb939789d6c8: Bug 1398229 - Save-link-as feature should use the loading principal - part 3 - implementation of nsIContentPolicy.TYPE_SAVE_AS_DOWNLOAD, r=ckerschb
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 15 Nov 2017 18:16:29 +0100 - rev 392022
Push 32909 by cbrindusan@mozilla.com at Wed, 15 Nov 2017 22:25:14 +0000
Bug 1398229 - Save-link-as feature should use the loading principal - part 3 - implementation of nsIContentPolicy.TYPE_SAVE_AS_DOWNLOAD, r=ckerschb
a726fc7506ca26371b0df3a523bd489f4620206a: Bug 1398229 - Save-link-as feature should use the loading principal - part 2 - context menu using nsIContentPolicy.TYPE_SAVE_AS_DOWNLOAD, r=ckerschb
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 15 Nov 2017 18:16:28 +0100 - rev 392021
Push 32909 by cbrindusan@mozilla.com at Wed, 15 Nov 2017 22:25:14 +0000
Bug 1398229 - Save-link-as feature should use the loading principal - part 2 - context menu using nsIContentPolicy.TYPE_SAVE_AS_DOWNLOAD, r=ckerschb
53dae7764e58db6288d1f03e7b8b4909b32a85c8: Bug 1398229 - Save-link-as feature should use the loading principal - part 1 - test, r=ckerschb
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 15 Nov 2017 18:16:28 +0100 - rev 392020
Push 32909 by cbrindusan@mozilla.com at Wed, 15 Nov 2017 22:25:14 +0000
Bug 1398229 - Save-link-as feature should use the loading principal - part 1 - test, r=ckerschb
c56352d90f678c2ad104da657aae116513502153: Bug 1415645 - Part 5: Fix some more consumers of nsGlobalWindow which I missed, r=smaug
Nika Layzell <nika@thelayzells.com> - Thu, 09 Nov 2017 15:44:10 -0500 - rev 392019
Push 32909 by cbrindusan@mozilla.com at Wed, 15 Nov 2017 22:25:14 +0000
Bug 1415645 - Part 5: Fix some more consumers of nsGlobalWindow which I missed, r=smaug MozReview-Commit-ID: DvMH4cVw5NK
55c0344711b64723b7653404ed9c4cd28ca9d6d9: Bug 1415645 - Part 4: Modify some shared runnables to not refer directly to nsGlobalWindow, r=smaug
Nika Layzell <nika@thelayzells.com> - Wed, 08 Nov 2017 13:53:25 -0500 - rev 392018
Push 32909 by cbrindusan@mozilla.com at Wed, 15 Nov 2017 22:25:14 +0000
Bug 1415645 - Part 4: Modify some shared runnables to not refer directly to nsGlobalWindow, r=smaug MozReview-Commit-ID: ANdBkuhZ2xx
9a766cc68671449c2c624816dff943d597a992a6: Bug 1415645 - Part 3: Don't cast to nsGlobalWindow when working with the inner window linked list, r=smaug
Nika Layzell <nika@thelayzells.com> - Wed, 08 Nov 2017 11:19:59 -0500 - rev 392017
Push 32909 by cbrindusan@mozilla.com at Wed, 15 Nov 2017 22:25:14 +0000
Bug 1415645 - Part 3: Don't cast to nsGlobalWindow when working with the inner window linked list, r=smaug After the window split is complete, the inner window linked list won't be homogenously typed anymore, as there will be an nsGlobalWindowOuter member in addition to the nsGlobalWindowInner members. This patch changes the code to perform PRCList* pointer comparisons before casting to nsGlobalWindowInner to avoid this issue. MozReview-Commit-ID: 56q5XodtGe7
4a6c2c5490f454e53d3b962ea0ce9dd29c9da298: Bug 1415645 - Part 2: Make CleanupCachedXBLHandlers a instance method, r=smaug
Nika Layzell <nika@thelayzells.com> - Wed, 08 Nov 2017 11:18:12 -0500 - rev 392016
Push 32909 by cbrindusan@mozilla.com at Wed, 15 Nov 2017 22:25:14 +0000
Bug 1415645 - Part 2: Make CleanupCachedXBLHandlers a instance method, r=smaug This will make the split easier, as this method is used by both nsGlobalWindowInner and nsGlobalWindowOuter. MozReview-Commit-ID: FsjK4y6x7NE
8fdfee217a97f07574a600f2868b06646debaf48: Bug 1415645 - Part 1: Make nsGlobalWindow.cpp use the specific {Inner,Outer} variants in more places internally, r=smaug
Nika Layzell <nika@thelayzells.com> - Wed, 08 Nov 2017 10:37:39 -0500 - rev 392015
Push 32909 by cbrindusan@mozilla.com at Wed, 15 Nov 2017 22:25:14 +0000
Bug 1415645 - Part 1: Make nsGlobalWindow.cpp use the specific {Inner,Outer} variants in more places internally, r=smaug MozReview-Commit-ID: LsgjJTbuH3L
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip