0fce6a40f64c9605d79acac6cc106405ab8b3fd6: Bug 1651021 [wpt PR 24482] - Python 3: port some tests in common and infrastructure, a=testonly
ziransun <zsun@igalia.com> - Thu, 09 Jul 2020 14:16:02 +0000 - rev 539813
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1651021 [wpt PR 24482] - Python 3: port some tests in common and infrastructure, a=testonly Automatic update from web-platform-tests Python 3: port some tests in common and infrastructure (#24482) -- wpt-commits: 924cdb5f242893239b3835a5c78a5a7a8deec240 wpt-pr: 24482
71a9ba84db010f432706c649b7c6495760e1c5d7: Bug 1650924 [wpt PR 24472] - [NativeFS] Stop marking WPT tests as tentative., a=testonly
Marijn Kruisselbrink <mek@chromium.org> - Thu, 09 Jul 2020 14:15:56 +0000 - rev 539812
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1650924 [wpt PR 24472] - [NativeFS] Stop marking WPT tests as tentative., a=testonly Automatic update from web-platform-tests [NativeFS] Stop marking WPT tests as tentative. All these tests test what is in the spec, so these shouldn't be marked as tentative anymore. Bug: none Change-Id: Ib494c57b3c258e9a7e80ac3fd2a4df25abc4783a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283735 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#785593} -- wpt-commits: ff124a192986ad53d0af652f99b277e3019701ad wpt-pr: 24472
939665c53acbd87f85ddf8c994f7bc46107112cf: Bug 1645838 [wpt PR 24151] - Switch WPT to use Taskcluster Checks integration, a=testonly
Stephen McGruer <smcgruer@chromium.org> - Thu, 09 Jul 2020 14:15:51 +0000 - rev 539811
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1645838 [wpt PR 24151] - Switch WPT to use Taskcluster Checks integration, a=testonly Automatic update from web-platform-tests Switch WPT to use Taskcluster Checks integration (#24151) See https://github.com/web-platform-tests/wpt/issues/14846; this should only be landed once wpt.fyi is ready to receive check_suite events. Co-authored-by: Robert Ma <robertma@chromium.org> -- wpt-commits: 972cc74af2d621fb45e5097350f4ee7d3b7c6ef4 wpt-pr: 24151
4edbc1e8e64676dedc7d3e94f5ef280a873e66a0: Bug 1651041 [wpt PR 24484] - Move six import after path is set, a=testonly
jgraham <james@hoppipolla.co.uk> - Thu, 09 Jul 2020 14:15:46 +0000 - rev 539810
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1651041 [wpt PR 24484] - Move six import after path is set, a=testonly Automatic update from web-platform-tests Move six import after path is set (#24484) Co-authored-by: Stephen McGruer <smcgruer@chromium.org> -- wpt-commits: 47821bc96914cfb6a42832490c987e16408e58be wpt-pr: 24484
bd47849c5a9582a3e3300c7b8e634daf620db85b: Bug 1639960 [wpt PR 23733] - Solidify Python 3 support in the manifest code, a=testonly
James Graham <james@hoppipolla.co.uk> - Thu, 09 Jul 2020 14:15:41 +0000 - rev 539809
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1639960 [wpt PR 23733] - Solidify Python 3 support in the manifest code, a=testonly Automatic update from web-platform-tests Move sourcefile construction to the manifest update function Instead of having the tree iterator return either paths or constructed sourcefiles, just have it always return paths, and construct the sourcefiles in the caller. This has the advantage that we can better handle some error conditions that may be caused by having an invalid cache. It is also somewhat clearer since we don't end up with an iterator that can return quite different types depending on whether it thinks the file was updated or not. -- Fix a bunch of Python 3 issues in the manifest code The goal here is to get mypy passing in Python 3; prior to this patch there were a lot of cases where Python 3 behaviour was broken but not picked up by the tests (e.g. because it only happened when updating the manifest or with certain caches or similar). Many of these issues were seen by mypy, but that had been disabled for Py3 specfically to avoid having to fix all the issues at the time the annotations were added. But now we do need that support. The general approach here is to use the same types for Py 2 and Py 3. In particular we use Text where possible (with a couple of exceptions where it was easier not to), rather than bytes. The native str type is avoided wherever possible since this introduces difficult to debug differences between Python versions. The preference for Text includes paths, which means we no longer support running in non-unicode directories (in practice it is likely to be broken if the path isn't UTF-8 compatible on Unix or UTF-16 compatible on Windows). -- Fix passing arguments from wpt to Python 3 -- Update six in docker image -- Run pip3 when installing in Python 3 -- Ensure deps are installed for py3 -- Update vendored six to latest -- Use pip2 rather than just pip Seems like bare pip started defaulting to python 3 -- Ensure that html5lib test build uses Python 2 -- Make canvas tests use python2 for build -- wpt-commits: b923853fec706d8d448010caab33583026ae4749, 6539f1e3433e77e23a33e293007f2da993c96abc, cbe30a2fb78294ae530856d5174a47065b4f1958, 4e07dbd21b1ef0bf749bd38f3b8ea2e954abdf27, 96ea8bb0f93a29a09dfa181a65eebe871d5b6d95, da9f11f0610f1ab52f2d85f40a8b58ecd72571d7, 394d3fb5f647fa2416a95d105fb82f9269f73586, 40a49406d70c9d3bb73f38e2e0576efd301d75a4, 76a0eee0d2b697a4bcc599b4f7ad0522ade4d0e8, 6a531642611c81e83bed58421fdc555e2db1f77a wpt-pr: 23733
f195433e1584a37b06fc0244ae91fcc96d0cda3e: Bug 1650966 [wpt PR 24477] - [css-grid] Check that 'align-self: last baseline' does not interfere with baseline alignment in first row., a=testonly
fantasai <fantasai.bugs@inkedblade.net> - Thu, 09 Jul 2020 14:15:29 +0000 - rev 539808
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1650966 [wpt PR 24477] - [css-grid] Check that 'align-self: last baseline' does not interfere with baseline alignment in first row., a=testonly Automatic update from web-platform-tests [css-grid] Check that 'align-self: last baseline' does not interfere with baseline alignment in first row. https://github.com/w3c/csswg-drafts/issues/5293 -- wpt-commits: e3698c7bb3c309df69134e9bc0a375f00535e226 wpt-pr: 24477
e87dc4e32fd164c3dbb50455c9f3a6d8088dfa85: Bug 1650955 [wpt PR 24475] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Tue, 07 Jul 2020 00:49:10 +0000 - rev 539807
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1650955 [wpt PR 24475] - Update wpt metadata, a=testonly wpt-pr: 24475 wpt-type: metadata
1b22b432401830db808efdd896fd281e26109c17: Bug 1650955 [wpt PR 24475] - [css-grid] Remove now-disallowed variant results., a=testonly
Tab Atkins Jr <jackalmage@gmail.com> - Thu, 09 Jul 2020 14:15:21 +0000 - rev 539806
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1650955 [wpt PR 24475] - [css-grid] Remove now-disallowed variant results., a=testonly Automatic update from web-platform-tests [css-grid] Remove now-disallowed variant results. (#24475) -- wpt-commits: b0c22598269697ea79de50dcac841a49be7340df wpt-pr: 24475
2295f77f50c2265382794a56a2c2853cbe17a25a: Bug 1650935 [wpt PR 24473] - [css-grid] Add testcase for second-row shared alignment baseline., a=testonly
fantasai <fantasai.bugs@inkedblade.net> - Thu, 09 Jul 2020 14:15:12 +0000 - rev 539805
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1650935 [wpt PR 24473] - [css-grid] Add testcase for second-row shared alignment baseline., a=testonly Automatic update from web-platform-tests [css-grid] Add testcase for second-row shared alignment baseline. https://github.com/w3c/csswg-drafts/issues/3645 https://github.com/w3c/csswg-drafts/commit/a74f96f7e29be98ee2b73ecdfedc27b3a789a410 -- wpt-commits: e365e5f52713aab96c38a56d461c86fd68d3e235 wpt-pr: 24473
a74b9b1309078509fa92367a2214c35b95cb0332: Bug 1650175 [wpt PR 24425] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Mon, 06 Jul 2020 23:18:52 +0000 - rev 539804
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1650175 [wpt PR 24425] - Update wpt metadata, a=testonly wpt-pr: 24425 wpt-type: metadata
2f1fb7d4c18e6ffe32eb34210fed3e1f2df67501: Bug 1650175 [wpt PR 24425] - Add secondary HTTPS port to common/get-host-info.sub.js, a=testonly
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> - Thu, 09 Jul 2020 14:14:47 +0000 - rev 539803
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1650175 [wpt PR 24425] - Add secondary HTTPS port to common/get-host-info.sub.js, a=testonly Automatic update from web-platform-tests Add secondary HTTPS port to common/get-host-info.sub.js (#24425) Bug: 1101075 Change-Id: Ife0482e82ea7596bdce61d84f7954f61efe7092c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274547 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#785490} Co-authored-by: Stephen McGruer <smcgruer@chromium.org> -- wpt-commits: 3dc847c5c53bbdb662222a5b4537c9d513fdecdc wpt-pr: 24425
d2c32f3b331f1eb30d528f5cbc455abd817b6195: Bug 1650908 [wpt PR 24471] - Change 'window.load() event' to 'window load event' for correctness, a=testonly
Simon Pieters <zcorpan@gmail.com> - Thu, 09 Jul 2020 14:14:42 +0000 - rev 539802
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1650908 [wpt PR 24471] - Change 'window.load() event' to 'window load event' for correctness, a=testonly Automatic update from web-platform-tests Change 'window.load() event' to 'window load event' for correctness (#24471) -- wpt-commits: 2f4dbfef969fac95baa9459f16e3591d3db5ecc2 wpt-pr: 24471
fc90ccfb35037ea1ef047e63d11bbb9a8aa28c83: Bug 1650905 [wpt PR 24470] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Mon, 06 Jul 2020 22:55:08 +0000 - rev 539801
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1650905 [wpt PR 24470] - Update wpt metadata, a=testonly wpt-pr: 24470 wpt-type: metadata
72cf46059ecaaafda3463d37b7eb8f438bafb106: Bug 1650905 [wpt PR 24470] - [css-grid] Maxmin autorepeat tests, a=testonly
fantasai <fantasai.bugs@inkedblade.net> - Thu, 09 Jul 2020 14:14:34 +0000 - rev 539800
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1650905 [wpt PR 24470] - [css-grid] Maxmin autorepeat tests, a=testonly Automatic update from web-platform-tests [css-grid] Test autorepeat with max,min. https://github.com/w3c/csswg-drafts/issues/4043 -- [css-grid] Use background vs. background-color consistently. (editorial/lint) -- wpt-commits: 9520e0643c5171ff97157469ec342636f0f1cf88, 7f77bdd0d1a3d7ae933026b74342ee0de1afed46 wpt-pr: 24470
5c4f5b2b61a0c3ac8060600fe04dde37a41c3638: Bug 1650902 [wpt PR 24468] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Mon, 06 Jul 2020 22:53:15 +0000 - rev 539799
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1650902 [wpt PR 24468] - Update wpt metadata, a=testonly wpt-pr: 24468 wpt-type: metadata
622efd376654fadec13692bde329d527783d7961: Bug 1650902 [wpt PR 24468] - [css-grid] Fix empty first row baseline test., a=testonly
fantasai <fantasai.bugs@inkedblade.net> - Thu, 09 Jul 2020 14:14:26 +0000 - rev 539798
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1650902 [wpt PR 24468] - [css-grid] Fix empty first row baseline test., a=testonly Automatic update from web-platform-tests [css-grid] Fix empty first row baseline test. https://github.com/w3c/csswg-drafts/issues/3645 -- wpt-commits: 511805a83e4e984092175681e75c24f1239f46e8 wpt-pr: 24468
d1cb5cbe019921a5c64c9ef8d17fe0914cc7c030: Bug 1650873 [wpt PR 24465] - Update interfaces/streams.idl, a=testonly
autofoolip <auto@foolip.org> - Thu, 09 Jul 2020 14:14:21 +0000 - rev 539797
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1650873 [wpt PR 24465] - Update interfaces/streams.idl, a=testonly Automatic update from web-platform-tests Update interfaces/streams.idl (#24465) Source: https://github.com/tidoust/reffy-reports/blob/8c05df2/ed/idl/streams.idl Build: https://travis-ci.org/tidoust/reffy-reports/builds/705513650 -- wpt-commits: e1fc3c037c9142c3a2c49d1f8f832d600abcd4c4 wpt-pr: 24465
acb1b84716ca27902269623e0d1c59aed7cac2d3: Bug 1650877 [wpt PR 24466] - [css-grid] Improve readability/understandability of baseline alignment test., a=testonly
fantasai <fantasai.bugs@inkedblade.net> - Thu, 09 Jul 2020 14:14:16 +0000 - rev 539796
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1650877 [wpt PR 24466] - [css-grid] Improve readability/understandability of baseline alignment test., a=testonly Automatic update from web-platform-tests [css-grid] Improve readability/understandability of baseline alignment test. -- wpt-commits: cbedc38b1da1db3e7032c63c80daf5a1c6a438dd wpt-pr: 24466
11445091ccfa6c3af5c1c571086ae77732b6e1d9: Bug 1647826 [wpt PR 24316] - Update wpt metadata, a=testonly
moz-wptsync-bot <wptsync@mozilla.com> - Mon, 06 Jul 2020 20:11:31 +0000 - rev 539795
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1647826 [wpt PR 24316] - Update wpt metadata, a=testonly wpt-pr: 24316 wpt-type: metadata
d7b17a7c6137c7451bf558487b381e03697f6bfa: Bug 1647826 [wpt PR 24316] - Reland "Don't reset computed 'float' for flex and grid items", a=testonly
Alison Maher <almaher@microsoft.com> - Thu, 09 Jul 2020 14:14:08 +0000 - rev 539794
Push 37586 by ccoroiu@mozilla.com at Fri, 10 Jul 2020 16:06:24 +0000
Bug 1647826 [wpt PR 24316] - Reland "Don't reset computed 'float' for flex and grid items", a=testonly Automatic update from web-platform-tests Reland "Don't reset computed 'float' for flex and grid items" This is a reland of 906abd41e4f6c786a1927f6edd69d6926e20317b Original change : https://chromium-review.googlesource.com/c/chromium/src/+/2157889 Revert of original change : https://chromium-review.googlesource.com/c/chromium/src/+/2256772 ----- The original change was reverted due to a DCHECK being triggered. See the following CRBug for more details: https://bugs.chromium.org/p/chromium/issues/detail?id=1097595 The original change no longer adjusted the ComputedStyle for floats based on whether or not it was a flex/grid item. This adjustment was left for the LayoutBox to handle. However, there was code on the layout side that depended on IsFloating() getting adjusted for the style, as well. This resulted in the DCHEK mentioned above getting hit. To fix this, I updated all cases that used the style's IsFloating() function and either updated it to also take the style's IsFlexOrGridItem() function into account or updated the code to use LayoutObject's IsFloating() function instead. ----- Original change's description: > Don't reset computed 'float' for flex and grid items > > Floated flex and grid items have their 'float' incorrectly computed to > "none". This change fixes this by adjusting IsFloating() for flex and > grid items inside LayoutBox::UpdateFromStyle() instead of inside > StyleAdjuster::AdjustStyleForDisplay(). > > Beyond this, legend elements are not allowed to be rendered legends > if they are floating. However, if legends are flex items, we > adjust IsFloating() to be false. This causes legends to be > used as rendered legends when they are flex items, even if they > were styled as a float. > > This is fixed by checking ComputedStyle::IsFloating() instead > of LayoutObject::IsFloating() when finding the rendered legend in > order to get its non-adjusted floating value. > > Bug: 875235,350505 > Change-Id: Ia1e7f7c244cc0c443cd58be42854866884b7f7e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157889 > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > Commit-Queue: Alison Maher <almaher@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#763988} Bug: 875235, 350505 Change-Id: I915e045db7fda94d99cfdae33911d8b5f6df26de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261412 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#785456} -- wpt-commits: d33bc572d46eab7d3db2f67c24ab7e132344e22f wpt-pr: 24316
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip